[{"id":3688617,"web_url":"http://patchwork.ozlabs.org/comment/3688617/","msgid":"<6015230a-7cae-49ad-a099-ce79ccf477cd@linaro.org>","list_archive_url":null,"date":"2026-05-08T17:13:31","subject":"Re: [PATCH v3 02/32] linux-user/mips: implement\n sysmips(MIPS_ATOMIC_SET)","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 5/8/26 10:12, James Hilliard wrote:\n> Implement the MIPS_ATOMIC_SET sysmips command as an aligned 32-bit atomic\n> exchange in target memory.\n> \n> MIPS reports syscall errors through a separate register, so successful old\n> values can overlap the errno range. Write the return value and error flag\n> directly and return -QEMU_ESIGRETURN so the common syscall path leaves the\n> registers unchanged.\n> \n> Signed-off-by: James Hilliard\n> ---\n> Changes v2 -> v3:\n> - Split MIPS_ATOMIC_SET out of the combined sysmips/MIPS_FIXADE patch.\n> (suggested by Richard Henderson)\n> - Always use the explicit MIPS return-register path for successful\n> atomic_set results. (suggested by Richard Henderson)\n> ---\n> linux-user/mips/target_syscall.h | 1 +\n> linux-user/mips64/target_syscall.h | 1 +\n> linux-user/syscall.c | 31 +++++++++++++++++++++++++++++++\n> 3 files changed, 33 insertions(+)\n\nReviewed-by: Richard Henderson \n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=vPffvDvp;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBwhB1yyRz1yJq\n\tfor ; Sat, 09 May 2026 03:14:02 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wLOlh-0003lD-6x; Fri, 08 May 2026 13:13:41 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wLOld-0003kJ-65\n for qemu-devel@nongnu.org; Fri, 08 May 2026 13:13:38 -0400","from mail-oo1-xc35.google.com ([2607:f8b0:4864:20::c35])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wLOlb-0008Ld-Hq\n for qemu-devel@nongnu.org; Fri, 08 May 2026 13:13:36 -0400","by mail-oo1-xc35.google.com with SMTP id\n 006d021491bc7-6969c864c89so1333148eaf.2\n for ; Fri, 08 May 2026 10:13:35 -0700 (PDT)","from ?IPV6:2600:381:c938:6375:4b0a:aabe:cbe1:bd0c?\n ([2600:381:c938:6375:4b0a:aabe:cbe1:bd0c])\n by smtp.gmail.com with ESMTPSA id\n 006d021491bc7-69b25c1a58asm1435135eaf.1.2026.05.08.10.13.33\n for \n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 08 May 2026 10:13:33 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1778260414; x=1778865214; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id:from\n :to:cc:subject:date:message-id:reply-to;\n bh=n8tmtDohUfpCkCVj+VBAiMIsanhmZ1pbwWJCkcn/qBA=;\n b=vPffvDvp5d+04IgH+4Dc1w85Er25LZeGUNeg3Ao+ZKjrces0G1c5gYYrZbI2bl64x1\n yRyhhKhTqnFttsqnhW47dbqa1idBRWZMTBnfCZk2C3jJKx6hkuBlwIJovPJqtWcNBwxv\n 5K5ps1jfT1UVw95nS2MdqIoi+X29ICX8chbs6Q7v9GBXVobOCldte9EIn/QhsGfJwlnW\n gfglS2kCl1SW5MZ4RlRLLXbH8UtNvRadIhWaaZntehHB0e/4QqV761EHsYrzSZydb7jv\n sfM90k93DuqrXw4Qad4VuTrUIVdoZPJ2WjokW19y3pJfBWioZSl42GDlrysLCuiCAvwN\n UYEw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778260414; x=1778865214;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=n8tmtDohUfpCkCVj+VBAiMIsanhmZ1pbwWJCkcn/qBA=;\n b=bEQWFS3P/MKNw8agM0O9/Hcb+Ocxnr/lcSxDm+lQnAfmTL/PMmSCDYsi3udT87sjCm\n x7AdF8GtDZb/Yom5b158km/ULhkpBas5f9cSeLIoTkKzZZgMUuG4RmY/+NJ51UjXZuUl\n uI1lHk/CrmisOfYqasosLlIV4HQ3rdFuawoKgJzYsk7BYxg4PQJQztgjWc4hVDqrKmy1\n 7pvpWD3AnVD03Q/Zs3Q2qvIloSbOmt3N2ZpXwaqkjgauyrV63RnY7DMmF2JOEtzdgdLp\n 3D2a1NRuK1Mmfh1F40k94VGigWs223J8ngNlxHHbnp4LWfM0NkxxHyoxML8HzoyEj6J6\n weZw==","X-Gm-Message-State":"AOJu0YwJkDFsNOhlBSAd9Am5EkYypz5jDc5fb9rP3zishr+9e+TlW8jK\n Ne9rL4Jks9w/TqzO4lhpuFRxN5rP8qqZhCtpdNutDjMP2YetqGKvldR8rijFYedhPEsIAlx7Jjn\n 5X0wy","X-Gm-Gg":"AeBDievu8R/eF+kSdXOO3p4SoBqtllfEUyqVNQTtmXz47gvRfNwc3hvKiR4Rby8Rflx\n RZRrcca2No8/cudcHnDE5cyATgaMmaX4LZjJH9fuUjY3OFnhGUmKVJZo39X+evkFnokHhDldirr\n FmH7nGPH6xsTPpRMWn8q3fQJ6pQYGkiRNps1swCrLL1dz4iuEMF7lqCX+QcuDSxSof68wKtc7iK\n QX7rzuFWJ6k0oO2SI6cMgEy87jO7Fvj1Sm9XAwKfv6tz5iCC7uuO53tYmuIXznZlpjt/UaCfrRe\n xPH3/mVS47g/pNsea3PUdm8NhaAjbuXfNcUYs9X6lbFf3fMBwWXo50gf4MkI83vnRoBsYnEweJi\n P4bYBgh+euOer3Z5BPKHCQ/WBnMO4VTjNCtkwWzEZDmoO2c8AMsWaYkFn0G7NgxK5Y0A0ChxI9C\n 67O6+F057Dy05laGFc9iRHg2R02gC3IdCDpKf8h7gwNJ03ItBkqEJAdFNck83ULi9m0xg1RUhdJ\n AkvqrrnYLpcIoIXQZ60GjvZFVUiTzw=","X-Received":"by 2002:a05:6820:1521:b0:696:1dbd:9827 with SMTP id\n 006d021491bc7-69998cbaf94mr7708725eaf.12.1778260413914;\n Fri, 08 May 2026 10:13:33 -0700 (PDT)","Message-ID":"<6015230a-7cae-49ad-a099-ce79ccf477cd@linaro.org>","Date":"Fri, 8 May 2026 12:13:31 -0500","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 02/32] linux-user/mips: implement\n sysmips(MIPS_ATOMIC_SET)","To":"qemu-devel@nongnu.org","References":"\n <20260508-mips-octeon-missing-insns-v2-v3-0-bcbec96357d9@gmail.com>\n <20260508-mips-octeon-missing-insns-v2-v3-2-bcbec96357d9@gmail.com>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"\n <20260508-mips-octeon-missing-insns-v2-v3-2-bcbec96357d9@gmail.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::c35;\n envelope-from=richard.henderson@linaro.org; helo=mail-oo1-xc35.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]