[{"id":3688635,"web_url":"http://patchwork.ozlabs.org/comment/3688635/","msgid":"<810e5b86-4885-49ba-960d-f4841214727c@linaro.org>","list_archive_url":null,"date":"2026-05-08T17:30:05","subject":"Re: [PATCH v3 05/32] target/mips: split Octeon SEQ/SNE decode","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 5/8/26 10:12, James Hilliard wrote:\n> Decode the equality and inequality forms as explicit SEQ/SNE and\n> SEQI/SNEI instructions rather than using shared generated SEQNE/SEQNEI\n> entries.\n> \n> The explicit decoder names match the architectural mnemonics, which makes\n> the translator entry points and trace/debug output easier to correlate\n> with the instruction set.\n> \n> Signed-off-by: James Hilliard\n> ---\n> Changes v1 -> v2:\n> - Split the SEQ/SNE decode cleanup out of the Octeon arithmetic\n> instruction patch. (suggested by Philippe Mathieu-Daudé)\n> \n> Changes v2 -> v3:\n> - Remove the decoded ne field now that the instructions are split.\n> - Reuse @r3 for SEQ/SNE and pass the TCG condition into a shared\n> translator helper. (suggested by Richard Henderson)\n> ---\n> target/mips/tcg/octeon.decode | 7 +++--\n> target/mips/tcg/octeon_translate.c | 52 ++++++++++++++++++++------------------\n> 2 files changed, 32 insertions(+), 27 deletions(-)\n\nReviewed-by: Richard Henderson \n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=sHC/EUC0;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBx356qLlz1yKd\n\tfor ; Sat, 09 May 2026 03:30:24 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wLP1j-0001cr-EX; Fri, 08 May 2026 13:30:15 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wLP1g-0001cH-Gb\n for qemu-devel@nongnu.org; Fri, 08 May 2026 13:30:12 -0400","from mail-oo1-xc34.google.com ([2607:f8b0:4864:20::c34])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wLP1d-0005sE-I7\n for qemu-devel@nongnu.org; Fri, 08 May 2026 13:30:12 -0400","by mail-oo1-xc34.google.com with SMTP id\n 006d021491bc7-6948fb494a0so1233270eaf.2\n for ; Fri, 08 May 2026 10:30:08 -0700 (PDT)","from ?IPV6:2600:381:c938:6375:4b0a:aabe:cbe1:bd0c?\n ([2600:381:c938:6375:4b0a:aabe:cbe1:bd0c])\n by smtp.gmail.com with ESMTPSA id\n 006d021491bc7-69b25dbffdbsm1412511eaf.9.2026.05.08.10.30.06\n for \n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 08 May 2026 10:30:07 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1778261407; x=1778866207; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id:from\n :to:cc:subject:date:message-id:reply-to;\n bh=Hb1EH9Xrzx9rxL5gZMbpieqiGBVfWSH4VhI5pKGThkU=;\n b=sHC/EUC0LmToCPcNJopXi6P6PFP/Ut00423EelARjF9nZS8zcNs4znN81JUzShZMxL\n 0ItqLDWHK1y+piA5kz6WNBYAq9OE6O5KiMdwtlG4LfNC51c07FN5lzolCnSVCuFArfxJ\n mJFPOzNVa26IwQ0xUrZxfFyHOyyEK/AZRxhkAqVG+yiVQMRT+lWB43JzEs+whicbygwl\n ouvG6ln0YkYKFGManL//nP4c0UAxB6WdqPd5+WOi7mVm4kMaSov9UNFLVNtBG+oRmkHb\n 2gCTVWACGAXGxoJLsZg7Q0+BNQ2F/YCj/awgyJ6rHfd12F6bB7Dp08G2oFH9NZdHHMCD\n L2pg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778261407; x=1778866207;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=Hb1EH9Xrzx9rxL5gZMbpieqiGBVfWSH4VhI5pKGThkU=;\n b=Hs42Ot14qPy0RqtOrWsJ3AMBPxHISu3Mr37G48JOI1DNXh1VuCbjSV0rn++VLJz7/3\n xtBcYjDRNCmMEsla8Os1xQtdKfRqU9Qpi7IDGaLo972kdUc87pKb4tEIbt+LP7zqx7VT\n rUNplvHEvna7/bP4uAeVftNHg/FixKc31U7k8rNVAuvQgmYlB1c4ZKDvVIIpsSR2MYxZ\n qp50mQFzr9ZwkqRYkfM/WLFvNj9lY1tZGjn4FwWx54YgFrBMoAulHTqHXnJkv+IBrUgB\n +HAnQUXx+AahSwXiBlHwo4D2Pa0df2XDkwfHuAX5cUCZ/uT37QiaXQ8mmJyC+lXUkfmy\n cblw==","X-Gm-Message-State":"AOJu0Yxfp9/DqufFc3cZ2z+l97YA6bZdR1rUxrX379x36tqMnZIXzutz\n LwXEuiXkMyA4L5efWzgiCIQkNYcEzryz2a1xq3KeqdebZzziUlznoU++dv97LG7bqS4GwU83kUw\n 5JMSx","X-Gm-Gg":"AeBDievzS+akhd0uc82dRQlV88D9M3XBg4VAn9hJa0yEpNRwzoTzQY/RQNmBar31AqU\n mpU9UgmezPIaWY/lXWAF8GJny51xdWPzzWBdpoanVix5jWb5Qj6TbHNeQIGiLaJyNPzixtJuQI1\n zRuUMVT46mXLj4dASL/5OMals5ZTaGQ4go9mBQKvxF8EUHNXQovsVoJNgi/p49Z7gl3rfPHlWXv\n lu7brY1kt0cUVE9i44QxfqaO8ZATqCWd+4GIa6WRCXtW2/Pmn0OkJLtZ6rgkcphSp7jpC9cXiDz\n 5tKF4mEWcK9BkrpUmrsLxkXHKhBz5LEBZOrUoBaxZCoo23eGTJdeMdFEmLYzlWO6VEYNPxvcfIx\n KQue4p5z8r4At5wnIx5sJ+tSiRAl/bWYmzpgzVimUxZ2X/mRBCoA7uJfffUnZJz6/6KprO5kCYR\n IG98kfllMbzEKcPrFeW5HMdwJuOTzqZYKkOLyPvQC87ut5bAB4v64bfzxL3tPERZymseWQcAGkd\n 0z1FfPGzQ==","X-Received":"by 2002:a05:6820:1621:b0:696:1a25:fddc with SMTP id\n 006d021491bc7-69998cdf2a7mr7023102eaf.23.1778261407427;\n Fri, 08 May 2026 10:30:07 -0700 (PDT)","Message-ID":"<810e5b86-4885-49ba-960d-f4841214727c@linaro.org>","Date":"Fri, 8 May 2026 12:30:05 -0500","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 05/32] target/mips: split Octeon SEQ/SNE decode","To":"qemu-devel@nongnu.org","References":"\n <20260508-mips-octeon-missing-insns-v2-v3-0-bcbec96357d9@gmail.com>\n <20260508-mips-octeon-missing-insns-v2-v3-5-bcbec96357d9@gmail.com>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"\n <20260508-mips-octeon-missing-insns-v2-v3-5-bcbec96357d9@gmail.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::c34;\n envelope-from=richard.henderson@linaro.org; helo=mail-oo1-xc34.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]