[{"id":3688634,"web_url":"http://patchwork.ozlabs.org/comment/3688634/","msgid":"","list_archive_url":null,"date":"2026-05-08T17:28:17","subject":"Re: [PATCH v3 04/32] target/mips: fix Octeon arithmetic destination\n handling","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 5/8/26 10:12, James Hilliard wrote:\n> BADDU and DMUL write their results to rd, not rt. Route writes through\n> gen_store_gpr() so rd == $zero is handled consistently.\n> \n> Signed-off-by: James Hilliard\n> ---\n> Changes v1 -> v2:\n> - Split the BADDU/DMUL destination handling fix out of the Octeon\n> arithmetic instruction patch. (suggested by Philippe Mathieu-Daudé)\n> \n> Changes v2 -> v3:\n> - Remove the rd == $zero fast paths and let gen_store_gpr() discard\n> writes to $zero. (suggested by Richard Henderson)\n> ---\n> target/mips/tcg/octeon_translate.c | 16 ++++------------\n> 1 file changed, 4 insertions(+), 12 deletions(-)\n\nReviewed-by: Richard Henderson \n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=eRduro3n;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBx105SHwz1yJq\n\tfor ; Sat, 09 May 2026 03:28:36 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wLOzw-00012M-Ql; Fri, 08 May 2026 13:28:24 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wLOzu-00011t-RV\n for qemu-devel@nongnu.org; Fri, 08 May 2026 13:28:22 -0400","from mail-oo1-xc2a.google.com ([2607:f8b0:4864:20::c2a])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wLOzt-0005Dc-9p\n for qemu-devel@nongnu.org; Fri, 08 May 2026 13:28:22 -0400","by mail-oo1-xc2a.google.com with SMTP id\n 006d021491bc7-679f6ee3fb0so1046392eaf.2\n for ; Fri, 08 May 2026 10:28:20 -0700 (PDT)","from ?IPV6:2600:381:c938:6375:4b0a:aabe:cbe1:bd0c?\n ([2600:381:c938:6375:4b0a:aabe:cbe1:bd0c])\n by smtp.gmail.com with ESMTPSA id\n 006d021491bc7-69b25c1ba56sm1406512eaf.3.2026.05.08.10.28.19\n for \n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 08 May 2026 10:28:19 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1778261300; x=1778866100; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id:from\n :to:cc:subject:date:message-id:reply-to;\n bh=zTXnDZQCOJhXXH8fEMl8WEakNQGNw8knKy4t21c3KMU=;\n b=eRduro3nPD2NXzuEe1tQAPh/67wHRhGEy3Sq7CYQJCLrPBQ/tsgSKr5dZEZAlFNPe0\n YBBehc/uWJgJKR/zy79Kh4NbGneFfWS3mq66HgYQoWjCTttUm34ARLmiFUC4C1Lvo+S0\n PhhpYofX8CwjCfV87v0E59iPFy1FQcJPnmj32IUUOXZ2BqDMk/Vz64aaqm71XzfXeL+H\n j0J13Urme4s1raDWksitxjlbGuLbQAOzjC4E2bvMAhDoVCpvGohDAhDUE81MG5I26msn\n U7rd143TkuALBDFL4WVZZaNXJIBHOROqw3WWlgkeDlPcPL8aO73jHjOoyNd7akL2S4ET\n gH3w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778261300; x=1778866100;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=zTXnDZQCOJhXXH8fEMl8WEakNQGNw8knKy4t21c3KMU=;\n b=lhM7mUGGPVy3oLhU1TBtIH32ROC+2LQf0B3Ubn9Dyy4dgANmga/+IXJ8CqLQw/tEGX\n nrkCw5bfBjzoa/TKZhfK5bb0a9/o91UhJMWF2geEaoY5xPNzrFj9Q17Pn5q6oRA8tqOc\n wSzpJRgD5nr3T5BmtoTkbTK+QlwHBQJj5f6hbwmaoien5delX6hfwiWG95s1mDMWTb96\n Wa9Pk1qfJzQAK1LynjoV56zzQPJ48YxaUM1uZBHpH8OaQj05EL81EI4rQMRaHtxQDukx\n GX516+J6esS6ydxigneJrKkeuCzDHpI4eiNhiyJ+EWli5pHvv4FcoRbXwJ8/mr4ltESM\n +CEQ==","X-Gm-Message-State":"AOJu0YySbhIc91C5qY0npjZRm7mLoMoqujWjA+7R1zxzG1fECdDAarXq\n doOg1scSRmHEebzNen6LJPgSY9sBDCEvzOtzK97Ld9Nilnt9CAIRT8XMLE7fuNcJ1IwrwY/CRfl\n avpmw","X-Gm-Gg":"AeBDieug8P3ZUDoCYRbIVgBVLJdhMTPhUoNRgIPNj/dSDFBnJWexrE5D+4Ekqd2q6x2\n ZdPNuSzu0rl8jjTowXRmTRTr8qWTwbYHohCabbAHx8vaJerC3M0kiTya99p98WedpF6cNoeHQaK\n nByumjL4jpysvG+YsTm5vT4ina7RATAILVW1MXALr62BIp2leq+m0q+ShjVOMCgNcTa43WLdFNx\n VAmQSUE/c4dvM2BZOFn/ZDj0BlZ/wp75CQbZG94XY9ToW55wqmrIxMvAsDBmIQRZNAbfXXiAwqN\n +4Gt0CzlWpQwxt87keChZ8LJxdrgrQ0IpCR0HoKFELKfh1LrGH3FC4ia8i9Vlr98HV/R6STdlBH\n 9ln5KdNoW731HO7vi1XCXYl2XGmclShYIxVGTE8XYEpzi7Aq1xJrvPMbF5wP1Z/o6I2YyvQKmdN\n wXHYYsNIuWhsOi1RkD84ZXgyrRNOE2AHJOfnNTP4AMfY0OmjYg2rH7ti+ZEqOtXHf7cDw0Jln+6\n yPpGTSJm5ICNq2SN+nt","X-Received":"by 2002:a05:6820:1c91:b0:67e:42ca:bf0 with SMTP id\n 006d021491bc7-69998d173d6mr7290014eaf.39.1778261299877;\n Fri, 08 May 2026 10:28:19 -0700 (PDT)","Message-ID":"","Date":"Fri, 8 May 2026 12:28:17 -0500","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 04/32] target/mips: fix Octeon arithmetic destination\n handling","To":"qemu-devel@nongnu.org","References":"\n <20260508-mips-octeon-missing-insns-v2-v3-0-bcbec96357d9@gmail.com>\n <20260508-mips-octeon-missing-insns-v2-v3-4-bcbec96357d9@gmail.com>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"\n <20260508-mips-octeon-missing-insns-v2-v3-4-bcbec96357d9@gmail.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::c2a;\n envelope-from=richard.henderson@linaro.org; helo=mail-oo1-xc2a.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]