[{"id":3688636,"web_url":"http://patchwork.ozlabs.org/comment/3688636/","msgid":"","list_archive_url":null,"date":"2026-05-08T17:30:49","subject":"Re: [PATCH v3 06/32] target/mips: drop Octeon zero-register fast\n paths","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 5/8/26 10:12, James Hilliard wrote:\n> EXTS, CINS, and POP route their destination writes through\n> gen_store_gpr(), which already discards writes to $zero. Remove the\n> remaining translator fast paths for destination $zero so these Octeon\n> instructions follow the same shape as BADDU/DMUL and the generic MIPS\n> translator helpers.\n> \n> Signed-off-by: James Hilliard \n> ---\n> Changes v2 -> v3:\n> - Remove the remaining destination $zero fast paths and let\n> gen_store_gpr() discard writes to $zero. (suggested by Richard\n> Henderson)\n> ---\n> target/mips/tcg/octeon_translate.c | 15 ---------------\n> 1 file changed, 15 deletions(-)\n\nReviewed-by: Richard Henderson \n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=SU1mo472;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBx445w6Kz1yKd\n\tfor ; Sat, 09 May 2026 03:31:16 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wLP2O-0002Am-Da; Fri, 08 May 2026 13:30:56 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wLP2M-00029N-CP\n for qemu-devel@nongnu.org; Fri, 08 May 2026 13:30:54 -0400","from mail-oa1-x2d.google.com ([2001:4860:4864:20::2d])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wLP2K-0006KC-V3\n for qemu-devel@nongnu.org; Fri, 08 May 2026 13:30:54 -0400","by mail-oa1-x2d.google.com with SMTP id\n 586e51a60fabf-42fdab683b7so1219352fac.3\n for ; Fri, 08 May 2026 10:30:52 -0700 (PDT)","from ?IPV6:2600:381:c938:6375:4b0a:aabe:cbe1:bd0c?\n ([2600:381:c938:6375:4b0a:aabe:cbe1:bd0c])\n by smtp.gmail.com with ESMTPSA id\n 586e51a60fabf-43557371c56sm2132381fac.9.2026.05.08.10.30.50\n for \n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 08 May 2026 10:30:50 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1778261451; x=1778866251; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id:from\n :to:cc:subject:date:message-id:reply-to;\n bh=PcCGFKSeSDiFKHXeL28dhI/b+093mcZfYC74ymBxegI=;\n b=SU1mo472h5cNFt/5bYom6qnPMTBxQNTKvL+JFjYJ7fwCASyDTQrUTb9W4RzM9KL49D\n 1gwHzzCPANVYxCrzk5Wt0UKWDlxvk5PjRK7CfzGI9VUD5rwsGGlS09o4Vy5BDaM1kTKb\n 6zeF1OfbAl6Id2MZX8CyDrmzXKgxCtTD6b05P3uLzHc+f54Jl5wJ5MM/CaIdcV21txI3\n x6/fToWe238+kmYnYisfw0cKi0WtfTGRSzjc9lNreVqgRtwCKhG1jRv+/MzypFj0l1bP\n cg/fr2wwaQN21W+pwi9WQFVSHmJ5R/HzlUViG1f/eRGUST95iNmgo3S7Qruc6P0Cqchq\n +Y6g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778261451; x=1778866251;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=PcCGFKSeSDiFKHXeL28dhI/b+093mcZfYC74ymBxegI=;\n b=tRFxdmC+uPI0bx7CV5r9QyNchxTqPkhogmQLXtE1JeNAskKYlQL8dr+XrRZ/6lNlBP\n 3r+uEIF1rBTc9vcRmY7IJEPWu0wixTOqRnAU4eod5pd313eNZv5REKC+3mAj/utSDzJF\n v4E1Hicm+uPWzZPO0gTBfErE4ROTxZSDaFmxwZrYGNGNrQcgbJQo5xlFcoThqMlDMM1I\n 7q0Z59Hd2K0rsOO5nEYn/s9bDDCBHQXRJZt/MAyNYP6glQu14fqxHLGPBrkrq9rjQ3AB\n Sft/bnOUX3NG4VX1z9YLDTenC++GIyjDGbzO5SjVP5Zvtkydo70GKSdYMSDNu5IU31bB\n S+7A==","X-Gm-Message-State":"AOJu0YwkzzQ5hnyexUTTtNEPuUVOpzEi+96/f6bvmyZurBLUTXis1gAe\n VWoDztsY1wUras6kjwCFbSToWfhQZabHjhaYaK9e6FdKxzhzTX+E8opFRiKr7mC0BfJGcLS+bfF\n ZnDDc","X-Gm-Gg":"Acq92OHCvLGaU5XiridlvKRAky/JKzcchoeqOVV7+rFPRbdBg8yFB8tcSQ9URHUvdle\n 8Ly/2o71+JgsKxDxEmya1hwdkAH6j6a1LCKyQsHS9wOfAGOk+3LCFjKVa2iIwlTg4WC91zJcmKT\n uRIgxHhyPiUiSMf6ez/rTjdBPEF+PtANMa5n2DnZJvu/oXTUEy2IAntbtFlvAn1zWg3B2TkfDrn\n brwVvIOTTkwyAlMpNKxNhvAKrz7eTjC4VCSMDZTJezjnpmLbfkLgoeoEqMkjnQsrZoeecWbP9WP\n o8wupGACUIiXHddpJunyHn+q+2w7fCKpSphcxejY6Hztx2pJ7M2UY7EUgsefOJyQf2Em7KWsIWL\n S25XnSM076tNN8r9tvcQksJW7qYySEV6qs/7+wRqiefUwZf0tMHjbWfLp58Ja3haPEKsm+825Fo\n oBrypoZPht4tSmdtkOqTXmAOfo0djrizr6xkqtTZbz8WwUMerG3h0+osW33yoof/duSQhCgNYPQ\n pfsDjRayy150gPMtUxD","X-Received":"by 2002:a05:6871:4b10:b0:424:5b7:65e2 with SMTP id\n 586e51a60fabf-434f659b726mr8596770fac.39.1778261450995;\n Fri, 08 May 2026 10:30:50 -0700 (PDT)","Message-ID":"","Date":"Fri, 8 May 2026 12:30:49 -0500","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 06/32] target/mips: drop Octeon zero-register fast\n paths","To":"qemu-devel@nongnu.org","References":"\n <20260508-mips-octeon-missing-insns-v2-v3-0-bcbec96357d9@gmail.com>\n <20260508-mips-octeon-missing-insns-v2-v3-6-bcbec96357d9@gmail.com>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"\n <20260508-mips-octeon-missing-insns-v2-v3-6-bcbec96357d9@gmail.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=2001:4860:4864:20::2d;\n envelope-from=richard.henderson@linaro.org; helo=mail-oa1-x2d.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]