[{"id":3688469,"web_url":"http://patchwork.ozlabs.org/comment/3688469/","msgid":"","list_archive_url":null,"date":"2026-05-08T14:37:21","subject":"Re: [ovs-dev] [PATCH net-next v8 2/2] selftests: openvswitch: add\n pop_vlan test","submitter":{"id":67184,"url":"http://patchwork.ozlabs.org/api/people/67184/","name":"Aaron Conole","email":"aconole@redhat.com"},"content":"Minxi Hou writes:\n\n> Add test_pop_vlan() to verify OVS kernel datapath pop_vlan action\n> correctly strips 802.1Q VLAN tags from frames.\n>\n> Test structure:\n> - Baseline: untagged forwarding validates basic connectivity.\n> - Negative: forward without pop_vlan, tagged frame is invisible\n> to ns2 (no VLAN sub-interface), ping fails.\n> - Positive: pop_vlan strips tag on forward path, push_vlan\n> restores tag on return path, ping succeeds.\n>\n> Use static ARP entries to avoid VLAN-tagged ARP complexity.\n> Rely on ping success/failure for verification -- no tcpdump or\n> pcap files needed.\n>\n> Signed-off-by: Minxi Hou \n> ---\n\nThere is an issue applying to net-next, so this will need to be rebased\non net-next - likely a conflict from 05416ada37aa4 (\"selftests:\nopenvswitch: add tests for tunnel vport refcounting\"). Please wait 24h\nbefore reposting and you can include my review tags in 1/2 and 2/2\n\nReviewed-by: Aaron Conole ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=XMCKaBjb;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp1.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=XMCKaBjb","smtp1.osuosl.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBsCj21QMz1yCg\n\tfor ; Sat, 09 May 2026 00:37:37 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 4358481114;\n\tFri, 8 May 2026 14:37:35 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id E8A4c_-jHKAs; Fri, 8 May 2026 14:37:34 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org\n [IPv6:2605:bc80:3010:104::8cd3:938])\n\tby smtp1.osuosl.org (Postfix) with ESMTPS id 6508B810DA;\n\tFri, 8 May 2026 14:37:34 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id 42290C04EB;\n\tFri, 8 May 2026 14:37:34 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 3169BC04E7\n for ; Fri, 8 May 2026 14:37:33 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 23A3780FDE\n for ; Fri, 8 May 2026 14:37:33 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id YzeODxPVMuHD for ;\n Fri, 8 May 2026 14:37:32 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 20604802E7\n for ; Fri, 8 May 2026 14:37:31 +0000 (UTC)","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-251-jBZh-RDlMV-Cj9rTjJjAVw-1; Fri,\n 08 May 2026 10:37:27 -0400","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id BF8711956094; Fri, 8 May 2026 14:37:25 +0000 (UTC)","from RHTRH0061144 (unknown [10.22.65.142])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with\n ESMTPS\n id 5DB411803A8E; Fri, 8 May 2026 14:37:23 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections -\n client-ip=2605:bc80:3010:104::8cd3:938; helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org 6508B810DA","OpenDKIM Filter v2.11.0 smtp1.osuosl.org 20604802E7"],"Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=aconole@redhat.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org 20604802E7","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1778251050;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=yVkKNgHxig7M46X9NYBxZb338TZpmf1fuqe4XUbcFJw=;\n b=XMCKaBjbH0wjpymbl0+/aPfae7F0nffDbx7t6dXJx/MEV68kN+Vht0omfvzy+pUBHulvVw\n 5Ud2zKILy4eSoGPlYAKO9D/kXJHmhDvb+FYygJPXiILIEpUU81SO+Jy4sjniIDywxCxaQt\n A6ZniPEZThJocMLBY4Bdpq0UkG6qmpA=","X-MC-Unique":"jBZh-RDlMV-Cj9rTjJjAVw-1","X-Mimecast-MFC-AGG-ID":"jBZh-RDlMV-Cj9rTjJjAVw_1778251046","To":"Minxi Hou ","In-Reply-To":"<20260508134308.2857449-3-houminxi@gmail.com> (Minxi Hou's\n message of \"Fri, 8 May 2026 21:43:08 +0800\")","References":"<20260508134308.2857449-1-houminxi@gmail.com>\n <20260508134308.2857449-3-houminxi@gmail.com>","Date":"Fri, 08 May 2026 10:37:21 -0400","Message-ID":"","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","X-Mimecast-MFC-PROC-ID":"Nk114aiyf34uNikimvgfmGCY9zO4nLpiSVRCljyBob0_1778251046","X-Mimecast-Originator":"redhat.com","Subject":"Re: [ovs-dev] [PATCH net-next v8 2/2] selftests: openvswitch: add\n pop_vlan test","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Aaron Conole via dev ","Reply-To":"Aaron Conole ","Cc":"dev@openvswitch.org, linux-kselftest@vger.kernel.org,\n netdev@vger.kernel.org, linux-kernel@vger.kernel.org, i.maximets@ovn.org,\n edumazet@google.com, horms@kernel.org, kuba@kernel.org, pabeni@redhat.com,\n shuah@kernel.org, davem@davemloft.net","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "}}]