[{"id":3688660,"web_url":"http://patchwork.ozlabs.org/comment/3688660/","msgid":"","list_archive_url":null,"date":"2026-05-08T18:03:47","subject":"Re: [PATCH 5/6] board: tq: common: add sysinfo helpers","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Nora,\n\nOn 2026-05-08T08:48:28, Feilke, Alexander\n wrote:\n> board: tq: common: add sysinfo helpers\n>\n> Add a number of helpers based on the tq_eeprom sysinfo driver and\n> related hardware detection features. The helpers set up the U-Boot\n> environment and fixup the OS Device Tree.\n>\n> Signed-off-by: Nora Schiffer \n> Signed-off-by: Alexander Feilke \n>\n> board/tq/common/Kconfig | 27 +++++++++++++++++++++++++++\n> board/tq/common/Makefile | 4 ++++\n> board/tq/common/tq_sysinfo.c | 32 ++++++++++++++++++++++++++++++++\n> board/tq/common/tq_sysinfo.h | 18 ++++++++++++++++++\n> 4 files changed, 81 insertions(+)\n\n> diff --git a/board/tq/common/tq_sysinfo.h b/board/tq/common/tq_sysinfo.h\n> @@ -0,0 +1,18 @@\n> +#ifndef __TQ_SYSINFO_H\n> +\n> +#ifndef CONFIG_XPL_BUILD\n> +\n> +void tq_common_sysinfo_setup(void);\n> +\n> +#endif\n> +\n> +#endif /* __TQ_SYSINFO_H */\n\nThe include guard is missing its '#define __TQ_SYSINFO_H' - please add\nit right after the #ifndef.\n\nAlso, why hide the prototype behind #ifndef CONFIG_XPL_BUILD? It is\ncleaner to leave the declaration unconditional and gate the .o via\nKconfig - a stray SPL caller will then fail at link time rather than\nwith a confusing 'implicit declaration' warning.\n\n> diff --git a/board/tq/common/Kconfig b/board/tq/common/Kconfig\n> @@ -14,3 +14,30 @@ config TQ_COMMON_SDMMC\n> +config TQ_COMMON_SPL_BOARD_SETUP\n> + bool\n> + depends on SPL\n\nIs this option referenced in this series?\n\n> diff --git a/board/tq/common/Makefile b/board/tq/common/Makefile\n> @@ -8,3 +8,7 @@\n> +ifneq ($(CONFIG_XPL_BUILD),y)\n> +obj-$(CONFIG_TQ_COMMON_SYSINFO) += tq_sysinfo.o\n> +endif\n\nCan you use the standard obj-$(CONFIG_$(PHASE_)FOO) pattern here? Then\njust ensure that TQ_COMMON_SYSINFO is not selected in SPL - that is\nthe convention elsewhere and avoids the matching #ifndef\nCONFIG_XPL_BUILD in the header.\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=ITIp3Ouc;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"ITIp3Ouc\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBxny38kVz1yJq\n\tfor ; Sat, 09 May 2026 04:04:06 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 9C87884DC3;\n\tFri, 8 May 2026 20:04:03 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id E029E84DC4; Fri, 8 May 2026 20:04:01 +0200 (CEST)","from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com\n [IPv6:2a00:1450:4864:20::62d])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id E9A9184D1E\n for ; Fri, 8 May 2026 20:03:59 +0200 (CEST)","by mail-ej1-x62d.google.com with SMTP id\n a640c23a62f3a-ba545100a13so397320666b.2\n for ; Fri, 08 May 2026 11:03:59 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1778263439; cv=none;\n d=google.com; s=arc-20240605;\n b=le1HzpCTENnrbv0uRSlcOss6vAZVzmaJjZDtLcIKwYZTzkcUxbjmRsNpPuXZeOh4yD\n 7HYcHt3w8vOThxPTPx2/sym3SvFQNk2rCAoszfOdwFSrih2/xAFyNPgK3PK1yeHdUDVH\n wJL3RHeETVZXZxA+3kZynseLS8IgLagAMa5C4EJnJ3zsGnIub0pKwhRqqgvfY9mgVHoL\n fqUE3BIpuecUNvma8dlVe2TjM6D3ybDToyuCUMdl/YNl4JlHYSw4Oi82MmnEroAKi0tg\n ovB4JGWPnSW95/HyWixvJgSTIQ0/7/XljBJt4U/pngxB8APXatYgnDbJ9LVqUGW8gM9p\n duew==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=KqkVC8d2KrtUjP+YfQ519mfLEOGgY45x4cj85ZAaJos=;\n fh=syKhMRT2ZKudEbKaXzCBO8z7H5J34wK/WOX8AWEo+tM=;\n b=Jf9YqB5D6ar7s06zoE0brCUdeuN8yRndlmi5daj1vh+i3jjr308cfuqdA3Pwn/n6ul\n yafSKzV/HjF0H6ysURN9Pcr65yTTls3J+9tbi2gm8OX//adhaKCOACINhEwYcNw2gwL6\n 6tts+LRR4pTWg4PVDlwpJUETfs5gxdqval8yBAMCiaUooNUKt20NaKgYCZp5sKSjSGuW\n ueaYnsYVm/9mizUbthxlNG3UdrX0pgPKqgDPa+IrdiLew1yAY1FrOGrTDabG8n/WfhMP\n NBdWzgfGC92FCUj94JYgtKKK4ZVSanA0cyHqfchDEwH3YJiTgDM3DvHI1HerSC3WtwJu\n uldg==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1778263439; x=1778868239; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=KqkVC8d2KrtUjP+YfQ519mfLEOGgY45x4cj85ZAaJos=;\n b=ITIp3OucfK/yitkfZkPAMsL/+XUt8yNOw7zUycESMwpzl1+L3AbD4cq/0H75X08AeQ\n snM9jvkvY4CEa6V9KhGwFiTIMklKEsThkblXJSwiwC2od4xd9vfY9uArYzacwQJlTGoM\n rMcYFRDSe8YLUU4PMGICatNoHbZTjcpimF738=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778263439; x=1778868239;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=KqkVC8d2KrtUjP+YfQ519mfLEOGgY45x4cj85ZAaJos=;\n b=ieamwqX7YRZA8G65X+ExYdxPWmfm5DYiE0ZUDNJv/uRW/OgYwb+UJBTSN35IyGEQlN\n 82VJrbWodTaZKuY3C0Ty9hH4j3FG+CMCVoE6bI/eoEyg6IgEjNcuygVmNQjzRtkfa3Wl\n zfQZGaNOcCz7dOY98GnuYVT6+ZwesAZYT7o7suM7jozoEU6gsrwRBRCuZqvhlYzAsV2c\n 5C2OxDcbo2eiSVJxjeWdf11w0+AudBLfAL2o3R8ksiSldm8DQ+i8gg1kywhpy3Czw1J2\n 7pb7GW3XFlBvpTCVRVKb8GFbPm98EUdWXQKwenEoPaAc0rhyBnYOqs2DDdY9Adn0uwGv\n G13A==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/xb2dI/NVXw7y3NbXYgCl36u+K0L+uFhS6/ghzp45wBijn1QKZmDcZnY8mtaTo66uJx0LSdm0=@lists.denx.de","X-Gm-Message-State":"AOJu0YyIYlXuj4ivAB8hiz5Fl4XJNDj+tQXrvxjiDdAMs3zohg4Pz86O\n 68GDvPBBtGjmfFmbKzooswGCGjauFLNp4638fg7zLlxRV5rjzKNQpnsq+DoJVBgKHj6Xx7CFRMl\n dG8cnKBdESM5Bfs0k8o4oeO4ohdqhK4dZZboVdXsi","X-Gm-Gg":"AeBDievZYXvywLO6e7GXff4MmpHAPc0MHeRKVZIGEvRVqhWiOCZ+geM2XCVzzlZgHJ/\n Pe6JT5Xlaa88xWvimDUG8i98LuWx8JM9fg7QcqmxGw/me/fWwO/i6Pz3bsTRme4AZdrlVCb831d\n vMPoysCrwOwsiTxp3QM3M1OixwYXxMltlqfCQpBGqfyujYQlwhNUttzdl2r9GefPMbvyY29w8Rl\n iRMu0ApAAtxhcDsWyokab/6ahzfJdB4f7TlFgz4ZA3Fl57wXnYoAXqLtYCD6VDvrSnJU5EbVhnA\n wyWDGQ==","X-Received":"by 2002:a17:907:3d12:b0:bab:c646:dc7c with SMTP id\n a640c23a62f3a-bc56d51b1fcmr882716766b.34.1778263439339; Fri, 08 May 2026\n 11:03:59 -0700 (PDT)","MIME-Version":"1.0","References":"<20260508084834.45637-1-Alexander.Feilke@ew.tq-group.com>\n <20260508084834.45637-6-Alexander.Feilke@ew.tq-group.com>","In-Reply-To":"<20260508084834.45637-6-Alexander.Feilke@ew.tq-group.com>","From":"Simon Glass ","Date":"Fri, 8 May 2026 12:03:47 -0600","X-Gm-Features":"AVHnY4KGMj87yLQeQcuqx3A-hqFcvxIiIBstekpjuLJ_jhLqtClG7Ql_WQZI9sY","Message-ID":"\n ","Subject":"Re: [PATCH 5/6] board: tq: common: add sysinfo helpers","To":"Alexander.Feilke@ew.tq-group.com","Cc":"\"NXP i.MX U-Boot Team\" , u-boot@ew.tq-group.com,\n u-boot@lists.denx.de, Nora Schiffer ,\n Stefano Babic ,\n Fabio Estevam , Tom Rini ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]