[{"id":3688254,"web_url":"http://patchwork.ozlabs.org/comment/3688254/","msgid":"<3be78585-84d2-4e7f-b6dd-d9d0feb5dbdf@ew.tq-group.com>","list_archive_url":null,"date":"2026-05-08T09:43:10","subject":"Re: [PATCH 2/6] sysinfo: add sysinfo_get_and_detect() helper","submitter":{"id":92142,"url":"http://patchwork.ozlabs.org/api/people/92142/","name":"Feilke, Alexander","email":"Alexander.Feilke@ew.tq-group.com"},"content":"Signed-off-by: Nora Schiffer \nSigned-off-by: Alexander Feilke \n---\n include/sysinfo.h | 28 +++++++++++++++++++++++++++-\n 1 file changed, 27 insertions(+), 1 deletion(-)\nI missed a silly mistake in this patch. This should be the correct version.\nOld CI pipeline run: https://dev.azure.com/u-boot/u-boot/_build/results?buildId=13173\nNew CI pipeline run: https://dev.azure.com/u-boot/u-boot/_build/results?buildId=13175\ndiff --git a/include/sysinfo.h b/include/sysinfo.h\nindex 54eb64a204a..976144fd4fc 100644\n--- a/include/sysinfo.h\n+++ b/include/sysinfo.h\n@@ -373,6 +373,27 @@ int sysinfo_get_data_by_index(struct udevice *dev, int id, int index,\n  */\n int sysinfo_get(struct udevice **devp);\n \n+/**\n+ * sysinfo_get_and_detect() - Return the sysinfo device for the sysinfo in\n+ * question and runs its detect operation.\n+ * @devp: Pointer to structure to receive the sysinfo device.\n+ *\n+ * Since there can only be at most one sysinfo instance, the API can supply a\n+ * function that returns the unique device. This is especially useful for use\n+ * in sysinfo files.\n+ *\n+ * Return: 0 if OK, -ve on error.\n+ */\n+static inline int sysinfo_get_and_detect(struct udevice **devp)\n+{\n+ int ret = sysinfo_get(devp);\n+\n+ if (!ret)\n+   ret = sysinfo_detect(*devp);\n+\n+ return ret;\n+}\n+\n /**\n  * sysinfo_get_fit_loadable - Get the name of an image to load from FIT\n  * This function can be used to provide the image names based on runtime\n@@ -438,6 +459,11 @@ static inline int sysinfo_get(struct udevice **devp)\n  return -ENOSYS;\n }\n \n+static inline int sysinfo_get_and_detect(struct udevice **devp)\n+{\n+ return -ENOSYS;\n+}\n+\n static inline int sysinfo_get_fit_loadable(struct udevice *dev, int index,\n             const char *type, const char **strp)\n {","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=ew.tq-group.com header.i=@ew.tq-group.com\n header.a=rsa-sha256 header.s=default2602 header.b=kMdU/xBT;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=fail (p=quarantine dis=none) header.from=ew.tq-group.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=ew.tq-group.com header.i=@ew.tq-group.com\n header.b=\"kMdU/xBT\";\n\tdkim-atps=neutral","phobos.denx.de; dmarc=pass (p=quarantine dis=none)\n header.from=ew.tq-group.com","phobos.denx.de; spf=pass\n smtp.mailfrom=alexander.feilke@ew.tq-group.com"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBkh64gy8z1yCg\n\tfor ; Fri, 08 May 2026 19:43:18 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id A49EA84AF6;\n\tFri, 8 May 2026 11:43:15 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 538BA84B02; Fri, 8 May 2026 11:43:15 +0200 (CEST)","from www537.your-server.de (www537.your-server.de [188.40.3.216])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 3334D84A63\n for ; Fri, 8 May 2026 11:43:13 +0200 (CEST)","from sslproxy08.your-server.de ([78.47.166.52])\n by www537.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384\n (Exim 4.96.2) (envelope-from )\n id 1wLHjj-000Ily-33; Fri, 08 May 2026 11:43:12 +0200","from localhost ([127.0.0.1])\n by sslproxy08.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384\n (Exim 4.96) (envelope-from )\n id 1wLHjj-0002ZV-20; Fri, 08 May 2026 11:43:11 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS\n autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n d=ew.tq-group.com; s=default2602; h=Content-Transfer-Encoding:Content-Type:\n In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender\n :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:\n Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID;\n bh=tbD8bEEcv9uXBABJ7OAac0VEgDQ7gvxf2x/xcwkLxI4=; b=kMdU/xBTpIqaZ7dkfMoitHprHF\n zzQtuA5cPBAkUH7rxPH3O/zMu+8BWuussfFSN10MDQmm639i7uGZZcyg0wV3uqzCCFQjc7Ys7ZC9Z\n T+LGZw0Xzc+FTbTWIl358QKvVgsK6PkDEgDPkZ0LNdSzvmel0KVDh8Mhb/cLg45wpm30NMk/QEJ0g\n dVK+FSJHV/nXyHfwBu8nD6goTJUPv4/Jf2ImQZpBc8IWnM1uvp4MgCov2zMvK/bEfYm0bnLcZGaTh\n xpYiwE/HahFiFLK4UddwwpuBrfF0k2l+dB1OxXaiE4CIDiHyLUW0EyAKHRU26DAWUoeYjQ5xbBKI3\n D/Np09pA==;","Message-ID":"<3be78585-84d2-4e7f-b6dd-d9d0feb5dbdf@ew.tq-group.com>","Date":"Fri, 8 May 2026 11:43:10 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 2/6] sysinfo: add sysinfo_get_and_detect() helper","To":"\"NXP i.MX U-Boot Team\" , u-boot@ew.tq-group.com,\n u-boot@lists.denx.de","Cc":"Nora Schiffer ,\n Stefano Babic , Fabio Estevam ,\n Tom Rini ","References":"<20260508084834.45637-1-Alexander.Feilke@ew.tq-group.com>\n <20260508084834.45637-3-Alexander.Feilke@ew.tq-group.com>","Content-Language":"en-US","From":"\"Feilke, Alexander\" ","In-Reply-To":"<20260508084834.45637-3-Alexander.Feilke@ew.tq-group.com>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3688655,"web_url":"http://patchwork.ozlabs.org/comment/3688655/","msgid":"","list_archive_url":null,"date":"2026-05-08T17:57:47","subject":"Re: [PATCH 2/6] sysinfo: add sysinfo_get_and_detect() helper","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Nora,\n\nOn 2026-05-08T08:48:28, Feilke, Alexander\n wrote:\n> sysinfo: add sysinfo_get_and_detect() helper\n>\n> sysinfo_detect() is commonly called after sysinfo_get(). Make the API a\n> bit more convenient to use by introducing a helper.\n>\n> Signed-off-by: Nora Schiffer \n> Signed-off-by: Alexander Feilke \n> Signed-off-by: Nora Schiffer \n> Signed-off-by: Alexander Feilke \n>\n> include/sysinfo.h | 21 +++++++++++++++++++++\n> 1 file changed, 21 insertions(+)\n\nReviewed-by: Simon Glass \n\n> commit 4e2201c3294275168ba5ae00b20c9db89879474e\n> Signed-off-by: Nora Schiffer \n> Signed-off-by: Alexander Feilke \n> Signed-off-by: Nora Schiffer \n> Signed-off-by: Alexander Feilke \n\nEach Signed-off-by appears twice - please drop the duplicates.\n\n> diff --git a/include/sysinfo.h b/include/sysinfo.h\n> @@ -446,3 +446,24 @@ static inline int sysinfo_get_fit_loadable(struct udevice *dev, int index,\n> +/**\n> + * sysinfo_get_and_detect() - Return the sysinfo device for the sysinfo in\n> + * question and runs its detect operation.\n> + * @devp: Pointer to structure to receive the sysinfo device.\n> + *\n> + * Since there can only be at most one sysinfo instance, the API can supply a\n> + * function that returns the unique device. This is especially useful for use\n> + * in sysinfo files.\n> + *\n> + * Return: 0 if OK, -ve on error.\n> + */\n\nPlease rewrite to describe what the helper does, e.g. \"Get the sysinfo\ndevice and run its detect operation\" and describe it as a convenience\nwrapper around sysinfo_get() followed by sysinfo_detect()\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=Ef31nY63;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"Ef31nY63\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBxgH4Dmbz1yKd\n\tfor ; Sat, 09 May 2026 03:58:19 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 378DD84DC5;\n\tFri, 8 May 2026 19:58:11 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 0E05984DC8; Fri, 8 May 2026 19:58:10 +0200 (CEST)","from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com\n [IPv6:2607:f8b0:4864:20::52c])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id D8B5884DC4\n for ; Fri, 8 May 2026 19:58:07 +0200 (CEST)","by mail-pg1-x52c.google.com with SMTP id\n 41be03b00d2f7-c82471904fcso1043297a12.2\n for ; Fri, 08 May 2026 10:58:07 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1778263086; cv=none;\n d=google.com; s=arc-20240605;\n b=flGYsHW7bOaqklZnjNcKTL22a1rCgraHcFYa+T2JXdJswY9XUErps7PRAx88RJn741\n oGMM5/7cOpGf7tocCkbLTLXJpdSo25zR2WbBwhZNvNt5dPpxo/VQse4bZ2EC4b4Zfjh1\n ycFi5Am49TeHnxw/gD7tfbz0Kzg83KgoaU8tILw34Wc9Y1STlZjIX+r6x8AgYbfYRZnj\n HtBGfgTcvERNAkEvA0+g/LFZsV+tvh6eoF4V2Fljhpx2j/5etveSeXwQliPDNsDoBW7B\n 8rFiP2uC+Wnki5+1RZKADy7JIrSs15qILan74mvbK+dlcW7FNtoM1Vss1lJ5Ccq4RAEo\n TNeg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=Xds8CXG3O/feVU2+2EDE6fpp7Y2n19vK17t0yieQ5QE=;\n fh=523FaTOBFN1Oloy6VXhCfiDzLq8MJLaBc5ZkYCBBq64=;\n b=B9+Noh9/D5NZA0Bv0+XTLR0KcFRu4nMGcZwXgcrbHDpboy4l3uGbtsM42GHSalxfUh\n jHXTyvibMktBHyiHsru9A2JX+TbVjx3C4+/8Hz6ZjgCASX4c/9H1J6KIv+kWQHFjZJcV\n pdzoEHXes3mZXDsg13f7Age8YHBnwzW0sdaFiyqsoLt7YRoOUpPQHUeVFwVK6V1zBc+V\n wwJYqcVkbukOY3q6fdttbQyU/iRRM7LG+NRk1w53L3JyV7Seo5JawqUpehdvVQ7KfDvh\n bsP0gI2P5eZfO0QESa/NWfZ1BMWR2x5CWQX4x8K5UH0qGgUdNjefX1l6RD4/KZVqSkGX\n SURg==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1778263086; x=1778867886; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=Xds8CXG3O/feVU2+2EDE6fpp7Y2n19vK17t0yieQ5QE=;\n b=Ef31nY63eMWzc4CexZWn2HTdD8tp0akYDRr4dYAcKT37gE6zkjdEtluQ0KDTqnohBh\n E76KZmC1Ah3ngUWsRS5n8M8/7Lg0oM6QMvyn8RbQdE92A5r8re5D+oLwY5QA96TFWzt8\n EdJjQUfG7H4Z6eKIe7n53m1VYbcJhNkeeGJH4=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778263086; x=1778867886;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Xds8CXG3O/feVU2+2EDE6fpp7Y2n19vK17t0yieQ5QE=;\n b=JTqQnns8pDn3OwjomBMCsUgx1vBWolrq7QJnjfdmsUF1gTu+vLO81qqwlwt2hgdqiq\n kGRYKjLUy7tsNZ5+lVQU1A8hZDzBe1s//bVK5NtqD3cz63AyyXeJ6QMCPQw1rRfPkAoD\n dr0eNqj0zFL5pG52URIONkTEFu/fGLrLnHbCMOI+FRmjqHgVz1xUJRv5Y0aCxrkkRnJ1\n 5QKWOslpekX0UWU/i7XLFJvRCzN6MEE7RA3A17juOsI3TBNx1dBoBgxfHYQLtW/dKuDK\n 37FiZQDz/h3WlbE8Qa17KjZaIyog7uwl+VrsYT0MKnS9kQnQzpGztAIXqwWd+I+OmEcD\n LKwQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8tP2EOYwuO93NxXMyQsJTCyKssPwZTvvgjXM5z5220v//urxniq7JuzSPUfSQ1q29pzHS50Y4=@lists.denx.de","X-Gm-Message-State":"AOJu0YzPoWvlyDCvL2RGe/2G2uLjySK0n6VvLhTP2TsvyF+odXe6vXeN\n NOKl3tTvrpisFzmPvuTHJA11XBbEjN3BTQmqwlY24RqH5LihZOhnwtm7mXbPF/tIR7OogvHd5s2\n Jor317k8qqX6LoTd1Cx5RUsFvjilivu3J6Jzqsxrj","X-Gm-Gg":"AeBDiev4ievDTCMub0ZG4gqIKEuivDchv7UCugGzIbySWDg2QLYwIbaz2C3bwcjNEAH\n 2vGUfBBKQ3amNs089/l81T9vllRqzgFPWY5Jjg5irldozc+EKKxsx8JbPALWFUCJ/pqsFLSqxNC\n TZAAkNO122irTlarx2yq73uO/cbaClmtdPEBfoHm+R0Nw1nTf1wPO2C3OZOHqIorQIcYPES+SIX\n 5UqQB6wXL/wO95uK+FXuljpNm8/oCZdxnJGRYF/stMpvHvzvuw0psdMCvvQb7ceeF9CbxoBH2Y1\n HRYerA==","X-Received":"by 2002:a05:6a20:3ca5:b0:39b:f8d1:a603 with SMTP id\n adf61e73a8af0-3aa5a931e3emr15840621637.22.1778263086237; Fri, 08 May 2026\n 10:58:06 -0700 (PDT)","MIME-Version":"1.0","References":"<20260508084834.45637-1-Alexander.Feilke@ew.tq-group.com>\n <20260508084834.45637-3-Alexander.Feilke@ew.tq-group.com>","In-Reply-To":"<20260508084834.45637-3-Alexander.Feilke@ew.tq-group.com>","From":"Simon Glass ","Date":"Fri, 8 May 2026 11:57:47 -0600","X-Gm-Features":"AVHnY4Kstp8PYIS7Rm62b7lkDLfa-wnc1KNaguPAghaMYqmjsuTRUBA-DJGwsuw","Message-ID":"\n ","Subject":"Re: [PATCH 2/6] sysinfo: add sysinfo_get_and_detect() helper","To":"Alexander.Feilke@ew.tq-group.com","Cc":"\"NXP i.MX U-Boot Team\" , u-boot@ew.tq-group.com,\n u-boot@lists.denx.de, Nora Schiffer ,\n Stefano Babic ,\n Fabio Estevam , Tom Rini ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]