[{"id":3688136,"web_url":"http://patchwork.ozlabs.org/comment/3688136/","msgid":"<20260508034543.D9D2FC2BCB0@smtp.kernel.org>","list_archive_url":null,"date":"2026-05-08T03:45:43","subject":"Re: [PATCH 02/18] X.509: Make certificate parser public","submitter":{"id":93311,"url":"http://patchwork.ozlabs.org/api/people/93311/","name":null,"email":"sashiko-bot@kernel.org"},"content":"Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:\n- [Medium] The commit message claims to adjust the `#include ` directive to `#include `, but the patch fails to do so.\n--\n\ncommit b079c32d2fd414877e2d8a8b3e079a1f6c2dc220\nAuthor: Lukas Wunner \n\nX.509: Make certificate parser public\n\nThis commit makes struct x509_certificate and its associated parsing functions\npublic to allow CMA-SPDM access to the Subject Alternative Name. It moves\nthese definitions from the private x509_parser.h to a new public header.\n\n> The private header file x509_parser.h previously included \n> for the definition of time64_t. That definition was since moved to\n> by commit 361a3bf00582 (\"time64: Add time64.h header\n> and define struct timespec64\"), so adjust the #include directive as part\n> of the move to the new public header file .\n\n[ ... ]\n\n> diff --git a/include/keys/x509-parser.h b/include/keys/x509-parser.h\n> new file mode 100644\n> index 0000000000000..8b68e720693a6\n> --- /dev/null\n> +++ b/include/keys/x509-parser.h\n> @@ -0,0 +1,55 @@\n> +/* SPDX-License-Identifier: GPL-2.0-or-later */\n> +/* X.509 certificate parser\n> + *\n> + * Copyright (C) 2012 Red Hat, Inc. All Rights Reserved.\n> + * Written by David Howells (dhowells@redhat.com)\n> + */\n> +\n> +#ifndef _KEYS_X509_PARSER_H\n> +#define _KEYS_X509_PARSER_H\n> +\n> +#include \n> +#include \n\nDoes this include directive match the intention stated in the commit message?\n\nThe commit message mentions adjusting the include to , but it\nappears this still includes .","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=BjOL5F9w;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-54180-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"BjOL5F9w\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBZlb2N3Vz1yK7\n\tfor ; Fri, 08 May 2026 13:45:47 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 55DF43010BB5\n\tfor ; Fri, 8 May 2026 03:45:45 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 807E31DED42;\n\tFri, 8 May 2026 03:45:44 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E1EC8635D\n\tfor ; Fri, 8 May 2026 03:45:44 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id D9D2FC2BCB0;\n\tFri, 8 May 2026 03:45:43 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1778211944; cv=none;\n b=qvB0RDgDnzJ/wstCOEBtTFdW6MBGEMVTSfVpJF6jdOUgXMZ1wWMW9k0Pbsv7FzU5afzx+BNmsdeOHfP+ZNdzu2eHVevtwMADHXhP1R89HV0jPkrrkexhZgdSpmoogjMbX8JfhXOn3GXChbSHT9CCG9FyXcvFkmssTo82jNRSeWs=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1778211944; c=relaxed/simple;\n\tbh=TZvjDkRrsvyYtai6/4fqD71zkwm9S1hQzyg2/Z0clOw=;\n\th=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date:\n\t Message-Id;\n b=jZ6ElC7j2Js1//6aFJ6icubOag3AaMY5bTZKVDtiNTUeBW9mzEgDHwezsU2eWk4PxXyVKnmbGpBo+r1+wIcYZYTyd5S4sTUnLs7pLDrdlWYNE5gzKNo5TsYR9XVWsNqiUTKqudYyCtKJiQt+BCcHwdBhG1vBj4ll5uCPyrSxSPU=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=BjOL5F9w; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1778211944;\n\tbh=TZvjDkRrsvyYtai6/4fqD71zkwm9S1hQzyg2/Z0clOw=;\n\th=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date:From;\n\tb=BjOL5F9wNf168Lrif69MpgcWe0vYnJpcmTVMAeUJ+hLgUxeRzTfDB8bh5WjnBJVzE\n\t 6VBpuJIfPIfTNXj/iyx9dEacuDOpsuMKmwlH7y3a2Wywgt18K/GlCgSAvVyid9E64z\n\t lMcOpUL0EszS4BuYBTs0dqp4UGix2oC4F3+XM9r3tmPUi2KkxBXDAVvlw80j9ggZdz\n\t oRi8l/SYbJvJVJSyoLXCs3jv0n6JVg8KuD/gmOa8lxkTAlLFC+TcW5G5tsUrdufy7s\n\t dQmRYDgWim+/xOdtt6jgikYwjLLYsZBFrUaUyLaCdOv2gOkHLeSwHDC6mSbaEy55rc\n\t PeG9/rb7cJ2JQ==","From":"sashiko-bot@kernel.org","Subject":"Re: [PATCH 02/18] X.509: Make certificate parser public","Reply-To":"sashiko@lists.linux.dev","To":"alistair23@gmail.com","Cc":"ojeda@kernel.org, linux-pci@vger.kernel.org","In-Reply-To":"<20260508031710.514574-3-alistair.francis@wdc.com>","References":"<20260508031710.514574-3-alistair.francis@wdc.com>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","Date":"Fri, 08 May 2026 03:45:43 +0000","Message-Id":"<20260508034543.D9D2FC2BCB0@smtp.kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":""}}]