[{"id":3688114,"web_url":"http://patchwork.ozlabs.org/comment/3688114/","msgid":"<20260508012916.C3067C2BCB2@smtp.kernel.org>","list_archive_url":null,"date":"2026-05-08T01:29:16","subject":"Re: [PATCH 2/2] PCI: qcom: Add support for Hawi","submitter":{"id":93311,"url":"http://patchwork.ozlabs.org/api/people/93311/","name":null,"email":"sashiko-bot@kernel.org"},"content":"Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:\n- [Low] The introduced compatible string `qcom,hawi-pcie` deviates from the established `qcom,pcie-` naming convention.\n--\n\ncommit 190903f616d8f4e9c8306f764cc2fdb2f6027cd6\nAuthor: Matthew Leung \n\nPCI: qcom: Add support for Hawi\n\nThis commit adds support for the Hawi platform. It introduces a new device\ntree match entry for the dual PCIe controllers present on the system.\n\n> diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c\n> index af6bf5cce65be..80a238aa26b68 100644\n> --- a/drivers/pci/controller/dwc/pcie-qcom.c\n> +++ b/drivers/pci/controller/dwc/pcie-qcom.c\n> @@ -2121,6 +2121,7 @@ static int qcom_pcie_resume_noirq(struct device *dev)\n> }\n> \n> static const struct of_device_id qcom_pcie_match[] = {\n> +\t{ .compatible = \"qcom,hawi-pcie\", .data = &cfg_1_9_0 },\n\nThis isn't a bug, but should this compatible string follow the established\nqcom,pcie- prefix format used by the other entries?\n\nIf renamed to qcom,pcie-hawi, would it also make sense to move this entry\nfurther down in the array to maintain alphabetical sorting?\n\n> \t{ .compatible = \"qcom,pcie-apq8064\", .data = &cfg_2_1_0 },\n> \t{ .compatible = \"qcom,pcie-apq8084\", .data = &cfg_1_0_0 },\n> \t{ .compatible = \"qcom,pcie-ipq4019\", .data = &cfg_2_4_0 },","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=dop7sBCN;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-pci+bounces-54148-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"dop7sBCN\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBWkB1kLhz1yJq\n\tfor ; Fri, 08 May 2026 11:29:22 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id C99153029798\n\tfor ; Fri, 8 May 2026 01:29:19 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 7F7F619CCF7;\n\tFri, 8 May 2026 01:29:17 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A97B10F1\n\tfor ; Fri, 8 May 2026 01:29:17 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id C3067C2BCB2;\n\tFri, 8 May 2026 01:29:16 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1778203757; cv=none;\n b=LeQAX/Ndce+EPq4u17aNPh+vQkrhAGgyLoZKKt1zInYzm/9yeFcjHVQAw+iGzKDK3CdFNbWwxMVQjtpO+UehZFScuSAmcS6rHec4ULxF61lw66cRcvNJYWdx5WX/DhuzoSBa2I2nHSk4pk8DItkTLwMnYRIiEoIf73o+ImjK2F8=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1778203757; c=relaxed/simple;\n\tbh=YGuQwSfBTUvGmZMxjieGktWya+bHTKEaMd8XANNHPQQ=;\n\th=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date:\n\t Message-Id;\n b=eBAmKWXzz4qOMj489JJ0rRiY+OFFH9yBd5oEePemgjvWYdmsV4iY/pRajEzP+4ILYDbTVNV31cvja16KE3rPhCi8+oilUMlEVviLH6sGACfPvSG9NA+qt0Sz0NwkKQbTdvunGXjkAZAeHPUhBUjNHM0YX3qhKwp8zx5gH9Gm3ds=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=dop7sBCN; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1778203756;\n\tbh=YGuQwSfBTUvGmZMxjieGktWya+bHTKEaMd8XANNHPQQ=;\n\th=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date:From;\n\tb=dop7sBCNtz+/WwdD1Kq744b5yz1JRWWxnghTmCL9V1Akilx7TqyVXWb8qaqcR3d1s\n\t dgjwVxoHBYJitoa/zYdz1NNzpfIm/kV9/vlqtIM+TG5i633x9VvZsnMWktGi6184HC\n\t Shps0qg7Sn0B8mHW2vUz6T645L/jqL7xxS7HDThmZwKftLNuemCFtUu5fCkHg6LcTR\n\t u/QPAVFvy2a0ououJJdyLiwqnoGE+NpOELe7LlFS3Qc8YWXAP8NO1LpC5DNtzAb9mB\n\t mOAP/UEMKyw3i7mMIG/SQ+roPLq3gJhGORbROIKPzy14gQT8XkcqQa7zH2riVyXsXZ\n\t SBEf3FX2tdNeA==","From":"sashiko-bot@kernel.org","Subject":"Re: [PATCH 2/2] PCI: qcom: Add support for Hawi","Reply-To":"sashiko@lists.linux.dev","To":"\"Matthew Leung\" ","Cc":"linux-pci@vger.kernel.org","In-Reply-To":"<20260508-hawi-pcie-v1-2-0c910906f7e5@oss.qualcomm.com>","References":"<20260508-hawi-pcie-v1-2-0c910906f7e5@oss.qualcomm.com>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","Date":"Fri, 08 May 2026 01:29:16 +0000","Message-Id":"<20260508012916.C3067C2BCB2@smtp.kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":""}}]