[{"id":3687055,"web_url":"http://patchwork.ozlabs.org/comment/3687055/","msgid":"","list_archive_url":null,"date":"2026-05-06T12:51:09","subject":"Re: [PATCH v2 1/3] [PATCH 1/3] gpio: acpi: modernize resource\n management using cleanup.h","submitter":{"id":46495,"url":"http://patchwork.ozlabs.org/api/people/46495/","name":"Andy Shevchenko","email":"andriy.shevchenko@intel.com"},"content":"On Wed, May 06, 2026 at 02:35:34PM +0200, Marco Scardovi wrote:\n\nNo, this is wrong and completely missed the guidelines!\nPlease, spend near hours to study the Submitting Patches and Coding Style\nkernel documentation before preparing and sending a v3.\n\n...\n\n> +#include \n> +#include \n> #include \n> #include \n> #include \n\n...\n\n> +DEFINE_FREE(free_gpio_desc, struct gpio_desc *, {\n> +\tif (_T)\n> +\t\tgpiochip_free_own_desc(_T);\n> +})\n> +\n> +DEFINE_FREE(acpi_free, void *, {\n> +\tif (_T)\n> +\t\tACPI_FREE(_T);\n> +})\n\nAnd yes, these are still subject to comments I gave against v1.","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=EV/cT3yM;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-gpio+bounces-36289-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=\"EV/cT3yM\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=192.198.163.17","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=intel.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=intel.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g9b2L5W3mz1y04\n\tfor ; Wed, 06 May 2026 22:55:06 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id C87DB305EABE\n\tfor ; Wed, 6 May 2026 12:51:16 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 08BD344DB7D;\n\tWed, 6 May 2026 12:51:16 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 1186744E045;\n\tWed, 6 May 2026 12:51:13 +0000 (UTC)","from orviesa001.jf.intel.com ([10.64.159.141])\n by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 06 May 2026 05:51:13 -0700","from abityuts-desk.ger.corp.intel.com (HELO localhost)\n ([10.245.244.183])\n by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 06 May 2026 05:51:11 -0700"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1778071875; cv=none;\n b=tqpZ1wXkShphUWnQ5fZlzIq7YN5VYlDTuytyov3RdzB6ILxGgiYdrI2fjhbU7b3HNRSMTqrsYcOTY33hdf6TGIZDSb6OhHQ2kheigQ6bSO6+oSuRwczFPh/SXh86Zv0vfQpZ6N+AjQY/qtzxqxyKPOWuXCR1CYYIvsB9rrftNy0=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1778071875; c=relaxed/simple;\n\tbh=NL8vqlia/Db1s/BAwE2DZLUGLxpFhvU1atzwhuPFyh4=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=RlYA71lv+tnMj+Rf9allwflOEIR5EmEZQp23mjsXn3vkbnPjuAEfHx4gMjofJwj1iGRSoPT6qnzhqv6+YYYwiAAQqD87geeUBNyq8GRjVau2dZecOCSd5FNL7JSOepMAXU2yHAV0H2L/fe9Ys1fZAlUxKrngMjYorMn4kOTBr/k=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=intel.com;\n spf=pass smtp.mailfrom=intel.com;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=EV/cT3yM; arc=none smtp.client-ip=192.198.163.17","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1778071874; x=1809607874;\n h=date:from:to:cc:subject:message-id:references:\n mime-version:in-reply-to;\n bh=NL8vqlia/Db1s/BAwE2DZLUGLxpFhvU1atzwhuPFyh4=;\n b=EV/cT3yMHvUmMuL+4HjkcXpmXq9UjxkdbTO7mF/vuqVFlASiCJE2etqV\n s1S0EPP8S0MthlAJYi8FaVH2jxfNS09U+mrVpQveJQu9p6aRYVu7VLR5A\n nPfjt1vY9J+1qO1900Vr84Prhn8jX6halOTmU2ZdRy0EN+9935d5/Ti71\n khAa/ci1d9FKch3pl/0vOGwSpffEUramOybYxV4ZqiSkguLh4T0lAdqJs\n D/8R4K7cTJwOLRiWjrDLAi3KU1Vib97MeEOwyF0gYai5fjdb0bAX6BMJ6\n 751PV78hoS2soKKvAE/i7Y80PH8yRC0y948K7DIBrl53XqAyEoAuSO2qo\n w==;","X-CSE-ConnectionGUID":["iJDDaYKAQiyRNFIYSbktIg==","h8g9pckaQ8i8tFx0fMG7tw=="],"X-CSE-MsgGUID":["m6QOddTjQYClMhgsrOLp3w==","9G4w6qJNT6WFpKb9gH4yeg=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11777\"; a=\"78848513\"","E=Sophos;i=\"6.23,219,1770624000\";\n d=\"scan'208\";a=\"78848513\"","E=Sophos;i=\"6.23,219,1770624000\";\n d=\"scan'208\";a=\"274267273\""],"X-ExtLoop1":"1","Date":"Wed, 6 May 2026 15:51:09 +0300","From":"Andy Shevchenko ","To":"Marco Scardovi ","Cc":"mika.westerberg@intel.com, mathias.nyman@intel.com,\n\tlinux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH v2 1/3] [PATCH 1/3] gpio: acpi: modernize resource\n management using cleanup.h","Message-ID":"","References":"<20260506113215.GK6785@://intel.com>\n <20260506123637.1077421-1-mscardovi95@gmail.com>\n <20260506123637.1077421-3-mscardovi95@gmail.com>","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260506123637.1077421-3-mscardovi95@gmail.com>","Organization":"Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6\n krs, Bertel Jungin Aukio 5, 02600 Espoo"}}]