[{"id":3687439,"web_url":"http://patchwork.ozlabs.org/comment/3687439/","msgid":"<20260506161629.5488a643@kernel.org>","date":"2026-05-06T23:16:29","subject":"Re: [PATCH v2 net] net: wan: fsl_ucc_hdlc: free tx_skbuff in\n uhdlc_memclean","submitter":{"id":77159,"url":"http://patchwork.ozlabs.org/api/people/77159/","name":"Jakub Kicinski","email":"kuba@kernel.org"},"content":"On Wed, 6 May 2026 13:15:29 +0200 Holger Brunck wrote:\n> When the device is removed all allocated resources should be freed.\n> In uhdlc_memclean the netdev transmit queue was already stopped. But at\n> this point we may have pending skb in the transmit queue which must be\n> freed. Therefore iterate over the tx_skbuff pointers and free all\n> pending skb. The issue was discovered by sashiko.\n\nAnd you tested this how? \n\nGiven the questionable v1 I'm highly hesitant to accept patches\nfrom you if you can't test them.","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=hw/IU/A2;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20536-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=172.234.252.31","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=hw/IU/A2;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=172.234.252.31; helo=sea.source.kernel.org;\n envelope-from=kuba@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g9rqP4Cd6z1yJq\n\tfor ; Thu, 07 May 2026 09:16:33 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g9rqP1C58z2y8d;\n\tThu, 07 May 2026 09:16:33 +1000 (AEST)","from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g9rqN3DlJz2x9N\n\tfor ; Thu, 07 May 2026 09:16:32 +1000 (AEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby sea.source.kernel.org (Postfix) with ESMTP id B8FB0409E9;\n\tWed, 6 May 2026 23:16:30 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 3EB54C2BCB0;\n\tWed, 6 May 2026 23:16:30 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1778109393;\n\tcv=none;\n b=O/Ll1ySftj4O7hLg9KNgJEz6vkCzjCJ7Pl4j4mqNSfcdWp2ORLun8ITuZ5oNqusSxeWXh5hWDIV1ixDXz4eVS0kJUmt2IxVkzYJeUzcRWUczlBXvCZBCMRnU2SvdrH58iaJLXIcwBox6WNZ+hQaDDtD+P6HJmj/3bYokGJpkcW5z/pNssl+uRpSfnNnRiYSMLqzk68gbtCp/XmDMj/AcZnj65XMQtSMDy7x+ASAVspiEU+rLdNcm8ol/S7RnHFD+PQPh0EhELXWPzgUrlq82mqgwWKjWzokf7AkBAbZ24HXnhmtINAtj+GEnYF8d3BT6Rn81sNgExInEYosnlGkBXQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1778109393; c=relaxed/relaxed;\n\tbh=ctmrICSVUtbQrmuJUyc8W5eGsdbCGEEcppWRe17i5Io=;\n\th=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=HLLAdYRjoCsfm2gMuxmHozc7mxBxIwYEzyPK/0A5cWZsra2WFIPwOtagKvBUKuSkOObFfi+T6bzNvrkLRMAEqWjkZ4NmBXtJZ3IVy6yRBn8aRsehFDcsVl6qhVUCriskf+Twl8H7eA1f0rwjmQgw8x7RVytiCVqVkgmsnkne9ZFcne+nyERXYvOyfNSlYL5DC0tkxPogV27rMiJLU5WWWEAfg6zO/3Zho73ZaZON1jCHqZ2zmUuRLPZzMnmTOpdy99LzDu8psfOihqIoxINlu0cBoSebngMjowWUofW8JK1V8JB3VZ7vEIZnvGEKcw26xeTeC8hSRgivDD5rp2+2bA==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=hw/IU/A2; dkim-atps=neutral;\n spf=pass (client-ip=172.234.252.31; helo=sea.source.kernel.org;\n envelope-from=kuba@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1778109390;\n\tbh=ZeQsG/N9Ska5pWnZzaJsL52vXjyhYhU7cDQ4rObifgM=;\n\th=Date:From:To:Cc:Subject:In-Reply-To:References:From;\n\tb=hw/IU/A2r4V8y7O6kkV3ePUos8hJlaVcXoR/jiizehDw+u3YVqr9YI78M+6ZcRL5F\n\t yA7+iqvXCGAExh1HR+D+I1zzA4cxhIGlYK7KThCpzjSJEw8x2kRcLCF2fUq6ozms5S\n\t t8JWyAeoSf1b+um5lyS7G36tLangQZaApZV2havmHEwmbK8Aju/ZE/A4NSHb+Pj9A8\n\t AtNGL38evyydlQh6hy+J7KJ94JqzY7+7YVv54Yg6ad593d42wWNpkAGsrjR4WF/fxQ\n\t vKXKAmfKPFhkrVwvHyechOoK1IY4EzDaBFN8s16OmoM/5S1pWbB/kUDXtaa4a81i8q\n\t PimvG9DWf+GCA==","Date":"Wed, 6 May 2026 16:16:29 -0700","From":"Jakub Kicinski ","To":"Holger Brunck ","Cc":"netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,\n andrew+netdev@lunn.ch, chleroy@kernel.org, qiang.zhao@nxp.com,\n horms@kernel.org","Subject":"Re: [PATCH v2 net] net: wan: fsl_ucc_hdlc: free tx_skbuff in\n uhdlc_memclean","Message-ID":"<20260506161629.5488a643@kernel.org>","In-Reply-To":"<20260506111529.2919079-1-holger.brunck@hitachienergy.com>","References":"<20260506111529.2919079-1-holger.brunck@hitachienergy.com>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Spam-Status":"No, score=-0.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}},{"id":3687869,"web_url":"http://patchwork.ozlabs.org/comment/3687869/","msgid":"","date":"2026-05-07T15:07:35","subject":"RE: [PATCH v2 net] net: wan: fsl_ucc_hdlc: free tx_skbuff in\n uhdlc_memclean","submitter":{"id":82682,"url":"http://patchwork.ozlabs.org/api/people/82682/","name":"Holger Brunck","email":"holger.brunck@hitachienergy.com"},"content":"> On Wed, 6 May 2026 13:15:29 +0200 Holger Brunck wrote:\n> > When the device is removed all allocated resources should be freed.\n> > In uhdlc_memclean the netdev transmit queue was already stopped. But\n> > at this point we may have pending skb in the transmit queue which must\n> > be freed. Therefore iterate over the tx_skbuff pointers and free all\n> > pending skb. The issue was discovered by sashiko.\n> \n> And you tested this how?\n> \n> Given the questionable v1 I'm highly hesitant to accept patches from you if you\n> can't test them.\n\nI tested the patch on a ls1043a board running HDLC in busmode on kernel 6.12\n\nI was able to queue some packets in the TX part simply in removing the TX clock\nfor my setup. When I then shutdown the interface and remove the module I can\nsee that thel sk_buff pointers stored in the priv->tx_skbuff array, are not freed\n without the patch in question.\nI am currently not able to run my setup on latest master, but the changes in the\ndriver compared to master are minimal.\n \nBest regards\nHolger","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=hitachienergy.com header.i=@hitachienergy.com\n header.a=rsa-sha256 header.s=selector1 header.b=JuCSiuTp;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20571-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=pass smtp.remote-ip=\"2a01:111:f403:c201::6\" arc.chain=microsoft.com","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=hitachienergy.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=hitachienergy.com header.i=@hitachienergy.com\n header.a=rsa-sha256 header.s=selector1 header.b=JuCSiuTp;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=hitachienergy.com\n (client-ip=2a01:111:f403:c201::6;\n helo=am0pr02cu008.outbound.protection.outlook.com;\n envelope-from=holger.brunck@hitachienergy.com; receiver=lists.ozlabs.org)","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=hitachienergy.com;"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBFxS1fQjz1yKd\n\tfor ; Fri, 08 May 2026 01:08:12 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4gBFxK2qVLz2xS3;\n\tFri, 08 May 2026 01:08:05 +1000 (AEST)","from AM0PR02CU008.outbound.protection.outlook.com\n (mail-westeuropeazlp170130006.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c201::6])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange secp256r1 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4gBFxD2nHWz2xLs\n\tfor ; Fri, 08 May 2026 01:07:59 +1000 (AEST)","from AM0PR06MB10396.eurprd06.prod.outlook.com (2603:10a6:20b:6fd::9)\n by PA1PR06MB9379.eurprd06.prod.outlook.com (2603:10a6:102:45f::22) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.15; Thu, 7 May\n 2026 15:07:35 +0000","from AM0PR06MB10396.eurprd06.prod.outlook.com\n ([fe80::f64e:6a20:6d85:183f]) by AM0PR06MB10396.eurprd06.prod.outlook.com\n ([fe80::f64e:6a20:6d85:183f%5]) with mapi id 15.20.9891.016; Thu, 7 May 2026\n 15:07:35 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1778166485;\n\tcv=pass;\n b=JwQ/VCg4evxYp1Tv2w9xHjn+d1LaYB2Q09LK6JBx4Hz6707kVlHe5/XyUqMj3RrIdAxnTJLuk7K+z9sSFLzkQ4ToqWT9wcAj2a/lOvBIk+SyJomp3/XyWoQAy3W2vhFFc7qqoWYZla4zaVAxMo5fg3uPPNljIESK/WkMiqxYjiOXXFHrf+0QK/SBZ6FKPmLOht/JRNMMCVDIb1nR7dDUlsZRUXH0rZs8Sq3OAx8fSevDLGwatEufIjR9fQbultbFOURKSuIcZ6VRfqm66guo5+A1xTA9ZPqCj5u3DnQl5JQHORTxMlW2iEGAY2ty9gAIgfSSLMRd4x3ePl494PJGsg==","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=uwsEYMKxfC027kG9g4CqSyxE491/d05QiWlcL2oGzJlWDo3/PCNxdsIgqflFylcKflRgvi1QkhdweI+VHP2pu7nng/inTSYu8SlZmsFj3EjAet3iTcdao8xUjG5MTkY0aLYueiuCjRdWC1sNnehysQrui9be2QSXJB3VoY9FBH/89y+5/qhEhI2vkbleM7cJ4nzyB/QMa+vbrjSrEEdJHqRYnLgKYpDppw6IRaeFrqu9lH6KV55vW1rEKhZTqfdPn/NQ2M2obffvxbwXq2LlLnrHQg8bVMTX/SN+rmzLY0gq8KyFi8ezSPeukJonZjbCOrta7zIyYpx2VgapQAl9kw=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1778166485; c=relaxed/relaxed;\n\tbh=LswTpcupaSdZPPJOs7QBQX8VSwIFYM0YwdGmT7fjYz8=;\n\th=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To:\n\t Content-Type:MIME-Version;\n b=ViNsZfa0E9vEaNfkBaRD82+I8NoR2ycbZJ8C0/wfM/OUNbOyGVdYSDTnxT/4dX7EfET2BD2QQKSJ1oF7rjvIjaDPXdhHC6VlvQuKT16HDEslFqSssu10mddp/OXizHOUkqLABv08zaDeH3/vw50Qi8xFY1XYKpH3t/kfrdD/3vd4xS4XQlaMub8TfP8UMG1YoMBS7eLdXeqQFUCs3iExwXWdWPMLayMlqKVnddru0WZJwV3PR2hQFX52IS7Qyh++TVwC3HUNr8bVBAQFGsDEaRhJz+YFRxzJMfKvzP6FhT7YFivcKzxopMojZB8JT7K6L5lRqJIoKzeaD17bjsN28g==","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=LswTpcupaSdZPPJOs7QBQX8VSwIFYM0YwdGmT7fjYz8=;\n b=d3H1HhQI6kPsCHnHzF3RZ36qY2idNkG28L2U4x8xbiYOyKVLimpwswzcwkXk99C89bKfPVuPHPkdRSX1FAj6/3bMul3ayQku2YYCWK5Omq8taFRSBWn4wp1UyfQqxneEd/v6DOJIy89jn/EmsW7V7PBFHVWKm0NiWoPLGJB04YFcFpFSnwKZ6IcGmgWypugTU/F6E1jY1WYriIthoudOgZW7HttFMtcUmkXLSVIz4dMElpfmR9wfBWKuoPM++S7LVwwJ72swjjlas10TijHejNXr6a1IQclNny8KGOkUW7CKWchuD+I4hAw3vnXXW8osZQD8cfxbnZyhphxMKDl/8A=="],"ARC-Authentication-Results":["i=2; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=hitachienergy.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=hitachienergy.com header.i=@hitachienergy.com\n header.a=rsa-sha256 header.s=selector1 header.b=JuCSiuTp; dkim-atps=neutral;\n spf=pass (client-ip=2a01:111:f403:c201::6;\n helo=am0pr02cu008.outbound.protection.outlook.com;\n envelope-from=holger.brunck@hitachienergy.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=hitachienergy.com","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=hitachienergy.com; dmarc=pass action=none\n header.from=hitachienergy.com; dkim=pass header.d=hitachienergy.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=hitachienergy.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=LswTpcupaSdZPPJOs7QBQX8VSwIFYM0YwdGmT7fjYz8=;\n b=JuCSiuTpD1xOWykmFSfK1s3qRRIugJGnZDvw85GGAazKDyc58XIXutciywKi6SvOGYp204DxsxH4kfHSnTrjCpgo+FMnhmGVqpubkt07nVlnPClFP7p9i3IgY8e2T0KKy2T0c1s/I7N8DloN/mn99bE0vPhR8k+KnQMYi3nvG32d1SIM5/TXK41VxUF7tH9RTStMXml2DGXFla6HgPiprh7lIAxMqvZdzqSLj1P8UesMcS/GKT6rkTh6qxOkVkWKMM3IMqtzDTbZ2oE/lFxyZ0Yxx/2HAeb13i5VCvme7/GhxH39rEcLs2zbz+xhG/3ugm8SWLCW3aBEDWHYLHDo5A==","From":"Holger Brunck ","To":"Jakub Kicinski ","CC":"\"netdev@vger.kernel.org\" ,\n\t\"linuxppc-dev@lists.ozlabs.org\" ,\n\t\"andrew+netdev@lunn.ch\" , \"chleroy@kernel.org\"\n\t, \"qiang.zhao@nxp.com\" ,\n\t\"horms@kernel.org\" ","Subject":"RE: [PATCH v2 net] net: wan: fsl_ucc_hdlc: free tx_skbuff in\n uhdlc_memclean","Thread-Topic":"[PATCH v2 net] net: wan: fsl_ucc_hdlc: free tx_skbuff in\n uhdlc_memclean","Thread-Index":"AQHc3Umw1+noMo6hfE2oruIw7o3WBrYBoimAgADKE5A=","Date":"Thu, 7 May 2026 15:07:35 +0000","Message-ID":"\n ","References":"<20260506111529.2919079-1-holger.brunck@hitachienergy.com>\n <20260506161629.5488a643@kernel.org>","In-Reply-To":"<20260506161629.5488a643@kernel.org>","Accept-Language":"en-GB, en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=hitachienergy.com header.i=@hitachienergy.com\n header.a=rsa-sha256 header.s=selector1 header.b=JuCSiuTp;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20571-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=pass smtp.remote-ip=\"2a01:111:f403:c201::6\" arc.chain=microsoft.com","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=hitachienergy.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=hitachienergy.com header.i=@hitachienergy.com\n header.a=rsa-sha256 header.s=selector1 header.b=JuCSiuTp;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=hitachienergy.com\n (client-ip=2a01:111:f403:c201::6;\n helo=am0pr02cu008.outbound.protection.outlook.com;\n envelope-from=holger.brunck@hitachienergy.com; receiver=lists.ozlabs.org)","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=hitachienergy.com;"],"x-ms-publictraffictype":"Email","x-ms-traffictypediagnostic":"AM0PR06MB10396:EE_|PA1PR06MB9379:EE_","x-ms-office365-filtering-correlation-id":"c86fc915-47c5-4e24-0481-08deac4a5f18","x-he-o365-outbound":"HEO365Out","x-ms-exchange-senderadcheck":"1","x-ms-exchange-antispam-relay":"0","x-microsoft-antispam":"\n BCL:0;ARA:13230040|366016|1800799024|376014|38070700021|22082099003|56012099003|18002099003;","x-microsoft-antispam-message-info":"\n eSiu0Z4WefdYUlNwMXyAPl+kWe4F1vuzTFcY5zdU0QRLij888EkowoV5gPq3sfl5sYPYDGoA/SAUs6iiOmA1jhGMNwIg0p9zdjl5Sjqt2podtMXXWfeKdxFwY8aizQyk4tB+e5OElLDW2sCG5Sul26eALc/PZVJWZQFkirmiDu2Zk0NAGWlcPkrTy6+RRaOEic9BePJW/QSPQvwJyOtBZfdLTP9TCHsexBYqgs5Qm8IlXi7HYAzDylv5JNuluf++6ul9mqn7OejcqV4+FuUw0qTyYJULNXQOuOvlIqPlh1O6Z/yIngqUyAvIYzzT49cfSj2vGr6k7AZQm7rEiV/esqkAtTEVij2mDAldwfcSIHn+wbzER7jCtfw+SAvqhchaAQ8VLpR2/lOmt591Q5Due8ElgIJ9+gTnBThC4PD3WkIy7zNxQdY2kpvJzkinzO/KeoUnN9IXYsxQeSZLI2GRCH8WoftW9T3k6kpllI/SzQ28kvBPUPlM/hEwxloMal+0u3oJS/E3sCqh8IYTwcJCdQKqJVpOEu5Hfz5UiiN9soQp7iePW/hEo1UgsJSV9JyUVyndLVI/rYskskF4UXlfDtrw7jptU1gTO67mePk5MRWEk7hylacB+Ngo06j1kEqoh4kVW6OHEaQm9DBjV2YZU2ZjpsMQH11kHEjdfX4JrxEOwnyDh8Bv0olA+Kokiu393YSRCqzb1z6FiaVPBWdwBD6cH+ReU2Nj4sgNZRCtx7Zs8WtOHqI/1NZW/Q0plrQg","x-forefront-antispam-report":"\n CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR06MB10396.eurprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(38070700021)(22082099003)(56012099003)(18002099003);DIR:OUT;SFP:1101;","x-ms-exchange-antispam-messagedata-chunkcount":"1","x-ms-exchange-antispam-messagedata-0":"\n 4CyvXtti4zDRaKh/SwgGfftq+b1u+EVoFgYhvJssS2OAFfyQ67wxIJW4pq4DLnPhrGuK6HSfpgUVhHTA94jr5dbikVa7H09cXXOhkLY6O9W7CbaLCr9RogaPHZiDq2n2ftydJ1hOhYd0x78N6KHBF8Li319vq+Ys2B8Dq54i+nebbwkqO7Wi5Q9eqJNafmMyuH0JP5/R912Qe6At9hK9Ffkd3gCioPsYnevrwsoJBpVDfwxPdGZfo3PorF95LaCqrU1MrsVDl3h5RQxX/bZrBlAymbC47u72PMWC6VSbLmozkU5/dqOWHezOLDtcyWGZ3pJ2nJCCpWk16/ujFvjOBRTS6RiRZOM+THv+V5hXJ7BYgKxaUAwxB2J0TZ7xFcf3lnLR1PNW7bu0PrhYOojKn8By3gXsFyj+AHC0IPYecYQVfoR1QIvFkLgi9vTk6aKhQWc1ciSggQ6JxwI5LXkEPg8cXhfFbMGlCcvbyxg5TFl+t5FBo5YZ8cNvdMxFIKDK0UzDl4K2bMcX8RZfWdBXxNyHt5WFj3aRSdaWsnnMI5RYRprhhno6eV1shwky5pHuI8IY5HSw5y50KdNOaDdyK9oACvQCAWM2EDQl2FqkMjet0W0vcLTIbwHzPHSVyl2ywLh4XUDQCkDtAj73gt5Xg9R3zn/YiqN2jLtX4kD+/bSAD6q/+Q8gkuwzoSsUJkJqMzV8m5HGQggZH5OoGWevRb9ky3Y/VYI1uBJMj+SIIcrnhdbt1LFtd9laGBWpCTUbQd1jcxKq5ub1hiQS7+33mzZLQ6ssxf2FrAwyFcPWmzWtYw3t/2aFHHV0Tdd/Ig2wm443LVlFr3mEPW2LsIukY78DLYogpqZEa2qoXq3ZK+bHtfWVmOzcCdxWRZXYq3lH3y7ujyNQ0ZTysQ9KFtPryKjBtHNuY1pCuKdGfy3tMLUY7KZAb6znIAFFcIQ80eSQhN6+NgIb7kOOl3A6NhczoIiAVRifuOQL7wyan5NOkbeDYH5nBzCriI2Gx6sMxf4p92NJTHFNAGS+OCA3Vc7rg0zXwKQ7T9jbU0bR+PmjthaWOFD6wsvPAF1LtmEY2gg2kfRUJ8fwhbHsQGjMmbM2SYFhuVcEtLumTx9fxGXmKsxP8Go8fQnFmAx72YHDXRcpXm+gmwnOBtqKvPglfgWbKfxjbNiUZgk4AXOlTODvEYU7raM1lfAKc6/llwSvf7iphdhDSjtu5g2wqhyCcuXHoAoXDgKq0XMpngiwea0rA/2LqWXO1iwc06IaE2Dm5F9iiCC4cONyRZCLFgTNNWs7gHBY2lJxExk72Y/XuT5RREwg4yhVnHzmnDHqXPNZTciHScCUQlTG/Dftapw7vcJq/KA/12JuDT3aD3ldVn60kxWmWWsn0Ph3hUu0zifSq8Eec1VFW5uos8JZz+xj4OG+nNRFoI//g8tiS9QFHcHlpgxtGihusuPOtrMUbkC5aHiIerohXLchyMp9waqljesfc7AsVj/QJWsVUc3Y8OCg5bXVD++waQf4FTQLrgjdrkaQX9b9nixEOY0q0e1g93DDqyk/GgH3ibXwQqxjLC8PIdLSR4L0mhX9nSnxAEhCRXW2k8bd4W7mBKnMeYyBpaU/8BpbtTqEW3ASHF4ORQ/85MCAos3IQ1g5PmyBNnzs82Mgl8YtixqgJf3fIc7oRr/CutMYFLtgJG+ibpFEp1Nht+BpKykCBgj32gTYLyjQt9ZreBmVrfohwvvXfKaCtMvsAZlomn3xZ7inFqKeRg5oWys=","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"quoted-printable","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","X-OriginatorOrg":"hitachienergy.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"AM0PR06MB10396.eurprd06.prod.outlook.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n c86fc915-47c5-4e24-0481-08deac4a5f18","X-MS-Exchange-CrossTenant-originalarrivaltime":"07 May 2026 15:07:35.5558\n (UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"7831e6d9-dc6c-4cd1-9ec6-1dc2b4133195","X-MS-Exchange-CrossTenant-mailboxtype":"HOSTED","X-MS-Exchange-CrossTenant-userprincipalname":"\n XyiDhN1h8yE0H/5s9aDIUyMjhYVxrKh7zTms34DvVbAsHHSZptz2+Y6JvzbATFOpSnCLmqzCYsTa5hcDhYW50b5+mu1MBAiQO1Em8C0sozQ=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"PA1PR06MB9379","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=disabled\n\tversion=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}},{"id":3687889,"web_url":"http://patchwork.ozlabs.org/comment/3687889/","msgid":"<20260507083508.681108f1@kernel.org>","date":"2026-05-07T15:35:08","subject":"Re: [PATCH v2 net] net: wan: fsl_ucc_hdlc: free tx_skbuff in\n uhdlc_memclean","submitter":{"id":77159,"url":"http://patchwork.ozlabs.org/api/people/77159/","name":"Jakub Kicinski","email":"kuba@kernel.org"},"content":"On Thu, 7 May 2026 15:07:35 +0000 Holger Brunck wrote:\n> > On Wed, 6 May 2026 13:15:29 +0200 Holger Brunck wrote: \n> > > When the device is removed all allocated resources should be freed.\n> > > In uhdlc_memclean the netdev transmit queue was already stopped. But\n> > > at this point we may have pending skb in the transmit queue which must\n> > > be freed. Therefore iterate over the tx_skbuff pointers and free all\n> > > pending skb. The issue was discovered by sashiko. \n> > \n> > And you tested this how?\n> > \n> > Given the questionable v1 I'm highly hesitant to accept patches from you if you\n> > can't test them. \n> \n> I tested the patch on a ls1043a board running HDLC in busmode on kernel 6.12\n\nPlease add this to the commit message, as previously requested.","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=WcWBKvcp;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20573-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=172.234.252.31","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=WcWBKvcp;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=172.234.252.31; helo=sea.source.kernel.org;\n envelope-from=kuba@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBGXf6BNmz1yKd\n\tfor ; Fri, 08 May 2026 01:35:14 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4gBGXf14xGz2xS3;\n\tFri, 08 May 2026 01:35:14 +1000 (AEST)","from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4gBGXd1z8nz2xPb\n\tfor ; Fri, 08 May 2026 01:35:13 +1000 (AEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby sea.source.kernel.org (Postfix) with ESMTP id 64EAD43242;\n\tThu, 7 May 2026 15:35:10 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id E6A07C2BCB2;\n\tThu, 7 May 2026 15:35:09 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1778168113;\n\tcv=none;\n b=dqxiRsOXSgMQB1iuXLC/99C9EdVVEcPZfbwU6DCRrRutHQlfdZogQu0L25z02V/rUuQ8UdHBah/kXjH6kdEm1ETI/RVWU8hsg8GUeGCx2UrNwzTmYWWcwzoLGjmqP/Hmw4UvDs+t1Ji+Z811IChgG+1+u7hqoM9UwvqyCz0Lf9QbGI7L77r9CAPrIBoLILdJcAc7d3Vj2gtVyufI8lMGFTM3wU+Q6X3B9MF/777bz7vVD3woq2uZUkeA04UHyeqTVcHwdep0kkNCJeJhWxo4YMc/dZRmZw4Vvz4okWgj/X1UbGF2NVaR6gUcRUZA9GuY8pIZgwO/EX/mrthy4AVmbQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1778168113; c=relaxed/relaxed;\n\tbh=8CP/y3oVn3N78iCMTniq89jeAR5Rqn/G5wxZXvBJrbg=;\n\th=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=PRJBG+fF2SPnHfWhERVl5TryzAzkjmGaADbkhaMbbJs8Q9bo8Wdym2CoUrUddNXzBnXl0YdynULJFCthxc+v6DmpNMw061HRkbOj7+YauxxFbg2X5wYe8UdE+2Pw38IuDwMUckiYn798yyVU29xz3ynT1YVbdLf7IBYcg23IQzAK6r8ABQHkUx5rOUX8lG3gN8JGp/OgbsZ5zGX9JubjXnF5Ydtzzb0t6Wfxz5TTEuwZOOrAe1SbtxTz/tzAt0HoFPsf6MvkmG+GSyFQ2FHBHDnZ25xUNA2RE0G/a8dMPyqqH5DLVm1F+PVwr4UgMQhawwpxzB5HBLHey29lWf88lw==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=WcWBKvcp; dkim-atps=neutral;\n spf=pass (client-ip=172.234.252.31; helo=sea.source.kernel.org;\n envelope-from=kuba@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1778168110;\n\tbh=rzn+mXwuxuGBqeL9f0zlEdgdDoITVl3qMXqi0a/HbI4=;\n\th=Date:From:To:Cc:Subject:In-Reply-To:References:From;\n\tb=WcWBKvcpSgYbkBNyr6JNT1JrlsNQNjuDcOrxP9Q04JR7iG1SGc53yJH9QuWx5bU6x\n\t V3bLy879FPuVi32guDbf+7BM6eD2rG0QsVrSlIBxJHWhd6nwvx/fOu6yjzWxUC7lsf\n\t ppTsFMDsQK6dNf9+DRUSOd4udu7qMWEQZ7ICQIc9NUqxdGbHEgFSC35l5T9xjZTsNS\n\t l4W6WgDn9gxuCsAeA9SdmMeOdmR8pfwnBXaWyeo3hLoxjnlKlKKRQE58NzxMwvsLRV\n\t OBQl58iKhbpDNK1WmaUAz0L0ER1vrXEEI+o6c88vRJ1twtcyZiK8t6jU3Do5lOnVhB\n\t ZNuiPLuNt/Row==","Date":"Thu, 7 May 2026 08:35:08 -0700","From":"Jakub Kicinski ","To":"Holger Brunck ","Cc":"\"netdev@vger.kernel.org\" ,\n \"linuxppc-dev@lists.ozlabs.org\" ,\n \"andrew+netdev@lunn.ch\" , \"chleroy@kernel.org\"\n , \"qiang.zhao@nxp.com\" ,\n \"horms@kernel.org\" ","Subject":"Re: [PATCH v2 net] net: wan: fsl_ucc_hdlc: free tx_skbuff in\n uhdlc_memclean","Message-ID":"<20260507083508.681108f1@kernel.org>","In-Reply-To":"\n ","References":"<20260506111529.2919079-1-holger.brunck@hitachienergy.com>\n\t<20260506161629.5488a643@kernel.org>\n\t","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Spam-Status":"No, score=-0.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]