[{"id":3687015,"web_url":"http://patchwork.ozlabs.org/comment/3687015/","msgid":"<19498f18-1872-4c3f-aeff-43e906084b36@linaro.org>","list_archive_url":null,"date":"2026-05-06T12:03:17","subject":"Re: [PATCH] stdbit: Fix builtin name used in __glibc_has_builtin\n check for rotate_right","submitter":{"id":66065,"url":"http://patchwork.ozlabs.org/api/people/66065/","name":"Adhemerval Zanella Netto","email":"adhemerval.zanella@linaro.org"},"content":"On 06/05/26 08:03, Uros Bizjak wrote:\n> The __glibc_has_builtin check in include/stdbit.h incorrectly refers to\n> ___builtin_stdc_rotate_right (with three leading underscores) instead of the\n> correct __builtin_stdc_rotate_right (two leading underscores). As a result,\n> the builtin is not detected even when supported by the compiler.\n> \n> Fix the spelling to use __builtin_stdc_rotate_right consistently in both the\n> feature test and the corresponding comment.\n> \n> Fixes: 4adae8550a7a (\"stdlib: Add internal stdc_rotate_right implementation\")\n> Cc: Adhemerval Zanella \n> Signed-off-by: Uros Bizjak \n\nLGTM, thanks.\n\nReviewed-by: Adhemerval Zanella \n\n> ---\n> include/stdbit.h | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/include/stdbit.h b/include/stdbit.h\n> index 5be19b882e..863b0f8383 100644\n> --- a/include/stdbit.h\n> +++ b/include/stdbit.h\n> @@ -5,8 +5,8 @@\n> #ifndef _ISOMAC\n> # include \n> \n> -# if __glibc_has_builtin (___builtin_stdc_rotate_right)\n> -# define stdc_rotate_right(__x, __n) (___builtin_stdc_rotate_right (__x, __n))\n> +# if __glibc_has_builtin (__builtin_stdc_rotate_right)\n> +# define stdc_rotate_right(__x, __n) (__builtin_stdc_rotate_right (__x, __n))\n> # define stdc_rotate_right_uc(__x, __n) (stdc_rotate_right (__x, __n))\n> # define stdc_rotate_right_us(__x, __n) (stdc_rotate_right (__x, __n))\n> # define stdc_rotate_right_ui(__x, __n) (stdc_rotate_right (__x, __n))\n> @@ -62,7 +62,7 @@ __ror64_inline (uint64_t __x, unsigned int __n)\n> # define stdc_rotate_right_ul(__x, __n) (__ror32_inline (__x, __n))\n> # endif\n> # define stdc_rotate_right_ull(__x, __n) (__ror64_inline (__x, __n))\n> -# endif /* __glibc_has_builtin (___builtin_stdc_rotate_right) */\n> +# endif /* __glibc_has_builtin (__builtin_stdc_rotate_right) */\n> \n> # endif /* _ISOMAC */\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","libc-alpha@sourceware.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","libc-alpha@sourceware.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=byN8+i3f;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=byN8+i3f","sourceware.org;\n dmarc=pass (p=none dis=none) header.from=linaro.org","sourceware.org; spf=pass smtp.mailfrom=linaro.org","sourceware.org;\n arc=none smtp.remote-ip=2607:f8b0:4864:20::1329"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g9YvM1VJPz1y04\n\tfor ; Wed, 06 May 2026 22:03:59 +1000 (AEST)","from vm01.sourceware.org (localhost [IPv6:::1])\n\tby sourceware.org (Postfix) with ESMTP id 39BA34BA23EF\n\tfor ; Wed, 6 May 2026 12:03:57 +0000 (GMT)","from mail-dy1-x1329.google.com (mail-dy1-x1329.google.com\n [IPv6:2607:f8b0:4864:20::1329])\n by sourceware.org (Postfix) with ESMTPS id 5EA894BA7981\n for ; Wed, 6 May 2026 12:03:21 +0000 (GMT)","by mail-dy1-x1329.google.com with SMTP id\n 5a478bee46e88-2ee990e8597so6742027eec.1\n for ; Wed, 06 May 2026 05:03:21 -0700 (PDT)","from ?IPV6:2804:1b3:a7c1:364:6de5:1475:1d1e:88c0?\n ([2804:1b3:a7c1:364:6de5:1475:1d1e:88c0])\n by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2f56d8c45acsm3373501eec.13.2026.05.06.05.03.18\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 06 May 2026 05:03:19 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 39BA34BA23EF","OpenDKIM Filter v2.11.0 sourceware.org 5EA894BA7981"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 5EA894BA7981","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 5EA894BA7981","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778069001; cv=none;\n b=QHjulNDdw+u2Qa2dXMxd8ey9eNMRnsH0Zl6YYsvHp4b4Qxo+dwIi6vUJ6iNYzQ0JZ1tug72gaj1wjq9v2KSnKBYa1KNjeODR6rUzar4lcQvagjGmaGyixsuSQ6cuW4yxzW7kSveYYvtaZyB1jJoG8vMCyFejVxeEnNxsPDYwVbo=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1778069001; c=relaxed/simple;\n bh=ovoKKIZYALVSJk0HXP3GRo9fX4UJJUDMsgrLoKYVfXA=;\n h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From;\n b=IkNN7zqSF9SATskSbcGR79qHDqQxTyPRCcBUcVc6EoWIjMhuCPqN0CEM41dPa8x5zRf/LEPFfkKXvPQJ/UGmRUNUyEUbUa7r1c4r4306jydLR0mPqWAKxKHYWb6RJN0pd1WiD3ySVQEIeNzWgpNBHRmheU+7RupIk45+KH6SyB8=","ARC-Authentication-Results":"i=1; sourceware.org;\n dkim=pass (2048-bit key, unprotected)\n header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google\n header.b=byN8+i3f","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1778069000; x=1778673800; darn=sourceware.org;\n h=content-transfer-encoding:in-reply-to:organization:from\n :content-language:references:to:subject:user-agent:mime-version:date\n :message-id:from:to:cc:subject:date:message-id:reply-to;\n bh=EJzTC8vXkXPGybbpbaT34bUdVBjP+huYkyfMYXXIOEU=;\n b=byN8+i3fCh4ed6KJdqNDJ5JM2saJPKkiJls9qE/MHICAyL6GOJgHoODaPp6cIG+4kA\n KsyrQkoSHdc9jA295Zd56Mh1FwJSiA1k8WY0o5o978iA/mG/LG6/VFCqlBjHnXUpzr9m\n 9S17TtL1PW10bnKbhxZCLzkTO/XMFn5WgwkOKYbHXkSmT2CwVU2WC+otZqxlOgvbBTKm\n z3vgPIPK8KUEcpmks6dLf66qFtFR3hDkxgHWR/1zvCiomjQrxqv8Y/kVaNJbZ4gvu1uB\n NGxZ+9fT4iIU+lU9rQRBo8cS3EDo7U0QB0iWuFzG3fCAm8aI+arDTL1WVWMc3WKng5Tt\n F6+g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778069000; x=1778673800;\n h=content-transfer-encoding:in-reply-to:organization:from\n :content-language:references:to:subject:user-agent:mime-version:date\n :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=EJzTC8vXkXPGybbpbaT34bUdVBjP+huYkyfMYXXIOEU=;\n b=CePIjnMkZUm2rrp+yp6NvIAd7gkpjPImfFUsDtRNk9b59jLt8QYgUUkss2XRH1yGYn\n UWJ8eQpjefjyaBCLFB9XIGHwpCI6GQNxW9bFCsgEyhayCro5tcM780dSxovluE9ZkzSl\n 1/mOr0sCYpjrPAk/XjqvGY704H95STpxT8u5cwXPCs9Sqm7JK+RGAHCPINYwCrDdxWZY\n MMxNFwIsNHUPHzsuEch6dnxe8KD+sC7+rImOk/8pdOi4mZfAOotU8wwbf2F/3ivJcw3e\n o3ACjC8qPl5z0QSULILvT4SxIoxFMBjAyXAOyvkAIHQPM5T6w/7hc6yRLGvcuiTBvhTw\n fRYg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/2MW8c8xQG9axE4fJ5XSeE8oU+c6ueAFcIIUmMBZz5qTS+YdK/O2yY3f0jMqIo9zeNvkhrhYbf4Lz2@sourceware.org","X-Gm-Message-State":"AOJu0YyeHUaaG1+kItviusy2DrLr8oYhG79dg1SGFaZNJyUEpgpAC8MS\n uP+CK6+OOqekZozzQxrSmiYAn1nEgbz1ageFFs81FXTUKYEWsyrwp3WdRZgRxxpDRs4=","X-Gm-Gg":"AeBDieta9CmPk9bb3j9IzqzLujg6xKZjkzeirg7zjuMqpPU1j+nY3qF/KYjXQhuFgmQ\n WUD+xcqAEY0PPWcBRBbNXhPv09+mqkKUkwwn8sskDXJi3RfYQsQ64Zi09fLcE5AO4G9m1s9ifPr\n ZQ3KYGyY7Z5mDkCCZUkopxkQZHeoKD9h8cdSVOrmgUV/kFEX4gd7q/D/zryUImAdIwANwOoJ3m9\n sSfWX2l1maLJlJogJ+C0Ttwrnuw85tSQlgC+Dzemke4D97JNY2+T7TX72ym1QYJxWUsr/2sBElD\n 4mefCms2aiAOv8u8EHh4c8YVImoC/cI1pR6D91I0V2BfwUKO8VUYpnP69KtP68EJSgFkETGWDp0\n MXvp4fUbbKNmsv6lYraHkPi6SzTHz7tEwassxfkcB+59UiAvuAM4TkzkiJEEOW/Ql9+fHlgs0fd\n TIh2jzd0tK3MqsLVMq8FUw/l9/S+9BXAZJtMrICZeRmMT3t/35CYa9MRpbWqonOxg2F+7PO4XUc\n HqoD2CRWVCFOfzV33hBpCfmRuj0eIgU6vjdPKPF6A==","X-Received":"by 2002:a05:7300:570d:b0:2f1:fbbb:e321 with SMTP id\n 5a478bee46e88-2f548a99568mr1831862eec.6.1778068999884;\n Wed, 06 May 2026 05:03:19 -0700 (PDT)","Message-ID":"<19498f18-1872-4c3f-aeff-43e906084b36@linaro.org>","Date":"Wed, 6 May 2026 09:03:17 -0300","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] stdbit: Fix builtin name used in __glibc_has_builtin\n check for rotate_right","To":"Uros Bizjak , libc-alpha@sourceware.org","References":"<20260506110309.1599633-1-ubizjak@gmail.com>","Content-Language":"en-US","From":"Adhemerval Zanella Netto ","Organization":"Linaro","In-Reply-To":"<20260506110309.1599633-1-ubizjak@gmail.com>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-BeenThere":"libc-alpha@sourceware.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Libc-alpha mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org"}},{"id":3687076,"web_url":"http://patchwork.ozlabs.org/comment/3687076/","msgid":"","list_archive_url":null,"date":"2026-05-06T13:27:13","subject":"Re: [PATCH] stdbit: Fix builtin name used in __glibc_has_builtin\n check for rotate_right","submitter":{"id":808,"url":"http://patchwork.ozlabs.org/api/people/808/","name":"Uros Bizjak","email":"ubizjak@gmail.com"},"content":"On Wed, May 6, 2026 at 2:03 PM Adhemerval Zanella Netto\n wrote:\n>\n>\n>\n> On 06/05/26 08:03, Uros Bizjak wrote:\n> > The __glibc_has_builtin check in include/stdbit.h incorrectly refers to\n> > ___builtin_stdc_rotate_right (with three leading underscores) instead of the\n> > correct __builtin_stdc_rotate_right (two leading underscores). As a result,\n> > the builtin is not detected even when supported by the compiler.\n> >\n> > Fix the spelling to use __builtin_stdc_rotate_right consistently in both the\n> > feature test and the corresponding comment.\n> >\n> > Fixes: 4adae8550a7a (\"stdlib: Add internal stdc_rotate_right implementation\")\n> > Cc: Adhemerval Zanella \n> > Signed-off-by: Uros Bizjak \n>\n> LGTM, thanks.\n>\n> Reviewed-by: Adhemerval Zanella \n\nSure enough, I somehow missed the fact that _ull version is missing.\nFixed by the following emergency one-liner patch.\n\nUros.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","libc-alpha@sourceware.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","libc-alpha@sourceware.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=kZWRyaLU;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=kZWRyaLU","sourceware.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","sourceware.org; spf=pass smtp.mailfrom=gmail.com","sourceware.org;\n arc=pass smtp.remote-ip=2a00:1450:4864:20::22b"],"Received":["from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g9bm669WCz1yJV\n\tfor ; Wed, 06 May 2026 23:27:50 +1000 (AEST)","from vm01.sourceware.org (localhost [IPv6:::1])\n\tby sourceware.org (Postfix) with ESMTP id CDC7B4BA23E3\n\tfor ; Wed, 6 May 2026 13:27:48 +0000 (GMT)","from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com\n [IPv6:2a00:1450:4864:20::22b])\n by sourceware.org (Postfix) with ESMTPS id C534D4BA2E2F\n for ; Wed, 6 May 2026 13:27:26 +0000 (GMT)","by mail-lj1-x22b.google.com with SMTP id\n 38308e7fff4ca-393a44854d2so25643161fa.3\n for ; Wed, 06 May 2026 06:27:26 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org CDC7B4BA23E3","OpenDKIM Filter v2.11.0 sourceware.org C534D4BA2E2F"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org C534D4BA2E2F","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org C534D4BA2E2F","ARC-Seal":["i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1778074047; cv=pass;\n b=rrKa/Gk/0nXsBZQlWnR9g8LgmClMLTl2lXDjeqa/qTyjOQtXKcULEoXa6AySG1Xlmm8UjD0pOt+GPzJqnz5vm65rv/zKaxEc/kARzHELZOJ6RBj2vJ90uR547Dj2p8h5C0xf2nokN4LQ4jNyEs+lZ/GEKwPBIVURg3z7yVz5q94=","i=1; a=rsa-sha256; t=1778074045; cv=none;\n d=google.com; s=arc-20240605;\n b=bE1JqQCB15SxT3r7zzDPiTujp/2t+VzTmmH3RuJdideOhX+ootfaP1FCjr00kJB+bf\n lskLErHcNLKQ+Hiop7ImmdnesqYmEKQtSXWT+D6jeB6TpmBflgdkDGwXmrXHtqOhskol\n qRO2dxpRjEStXjbkMzsm8NsIVtIJvWtx0lNnx2WyBcNGD9VZI/t0pt2sju9rBG63CeT2\n WmEa+ljogmqt/u7bgEDpsJlueddfRevX8qDCvo9zeJtCXOagGWWKXT/AsXphb5kW6xwp\n T1fXRRrb+1pTUXe4zAE1JHu6asoX243WjEWkM0HWF9C8lrHdyjccmJdkJCsYFWr6fx+x\n m9ng=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=sourceware.org; s=key;\n t=1778074047; c=relaxed/simple;\n bh=DG0UOUhlFeGacXdHKCVwq7aQd0Zx7CwvxvDWpITYCXo=;\n h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To;\n b=YVMCfiBSNVwXM0sNmrbtxNNkcc4tEn/tI2xQcR9UwfRofcaty79NU6uGe/dsw969dRNCVF3iPKzqGN7p9KrFMfdeJdXWqGkFYengSQpm0UDCEbbFU/x91cl3LFchfhPz1bqLJbdAcM2MmE7R1B9d8LyeR9IyTf5U9Y6fEBWtg5I=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=AbETBdK0BM15lxlf8+w8j1XZTmNT8jr6Cr/+hY2znzw=;\n fh=QYbHWo33ns4+oxWOgYFGQevuIRD7qCPyuzgopK9sNuo=;\n b=HrjB1Xfo36sZtVdRpaYarcU2Jm7I05ndAkWpW2C94XC3ui4OrTcmM50PQMePS8Mox5\n DK1dtodin29K/HxNmogJYsSZnAVWKnuLBN9ji3WhmACxQmUfptNobe9PJbeyct8osr7l\n Y9x3jW5LCC2GH3+L/1bBwGiaJ8S4vP7xdfEwb1bWdk4LjkwigEqEXxgPyIUD2TN5bkza\n 86aYGrWZDUBmtT+EX7uBDPJPbxVX+obdhvTzMj5t1eG77GP+p1/pb4VgxUDFp/yFUjBw\n N7HzbI/004Rw+mvilrDQFz/1vVmZb9laNTYCtx+UNq/4G5KFeRQrGYSoj2l/2St2W2S1\n J4YQ==; darn=sourceware.org"],"ARC-Authentication-Results":["i=2; sourceware.org;\n dkim=pass (2048-bit key, unprotected)\n header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104\n header.b=kZWRyaLU","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1778074045; x=1778678845; darn=sourceware.org;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=AbETBdK0BM15lxlf8+w8j1XZTmNT8jr6Cr/+hY2znzw=;\n b=kZWRyaLU+iNP2Kp76uSzjE3oY/P1ONLg4GslSM7xeqVKiXXQZvQkayeFEjoVqx5iFc\n 2ZASuavtLfmmvWBDSB/DR9p2m8JC3pKIHxoMytU1Qp3sSioq84hrDKXQ3ibuQISS0PDL\n XImDjQAa44yPjHoYXmPHY6LmVou8b/599cXnlduqf62WicSdbCd6hw85NZ9HbYVUgXdf\n 0FGlyLuS5KIgfH5ECRaNtWUb5Hjd59ia4zmVZIq1BekqMozuGOvBpTbwVETBa471jQFt\n 7eyMN5s76qDNwunC2SY+X2XpKx8TWDm07nf0pC5g0u+hxd8AYUXD27VGvJj4Wv3523ja\n FV3A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778074045; x=1778678845;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=AbETBdK0BM15lxlf8+w8j1XZTmNT8jr6Cr/+hY2znzw=;\n b=jCGjAg9Dd3qVFnXLq73J85M0wnUFmTgy4BAN9i6Va9NjntiGMZTNx8YtmR1sYq238V\n AzckpKVIlYQBUps4QKBLeqkJHGTZRFC1SdW6eG/WAR4IlzMVHrXjZVZ5hVC9srmS83Lk\n VU7ucoJHTnLhPSJrjdqAfCIhODt9SA2S0x/2KF75zT12WJ3yzVDsJxBZ9vKkpykQ9ZsF\n 7tl57HTUCkXwYHRq/xL706np+4GzJ30X0Rd47yOH8VRs3XJ8L6Yfxd/v9kbYumVVt3BG\n jzvOu/7gAKgz4zbmeqwM1JP0I1JfZsvX4Tc0YDAk4+WN2ePpSQr9knO8xtysJXOvq66h\n 3E7Q==","X-Gm-Message-State":"AOJu0YxwfT8pBJ/MQVZAjK1HM3m/2Gq/gOKAIE09eAuEYXX6KwuMCaZ2\n SXXluu7AB2aMndEb/ha5BZLUuyxntG84iprGRk1qwC8AzatAecO2DiZ5450J0Oxl/dPj2EdH71d\n Pp64qqZZ8Ml2Ee1cEd5WXqTCK3SooCvo=","X-Gm-Gg":"AeBDiesgi82KH63t7n858S+Nlw3jbOWJGfuJjYh8LPzsYabOFuBR6koyPhOpvLxhbw4\n hxteHfneMJJCkBv4VGlmS+jYIpCrcc2Ws2xH+41jro2hDlaxcSgMkgaLbbhgHGMI3bNRaCapIE4\n w8G01qiuO+lxOs8fAYigtLW39qpmFJFJMTfPqhf6je3jFUGFVzvqFj9TwfMMus/SqptLe7H931V\n Ku8IQVPvEt3SHXfKG9oA3S7QU1vIKY2RyrN/+AcIv7P5HiO928U+e5WRxjEiY7uub8oMFGb6CXO\n pTCGnbNfmdchG2l2QQllV19QF3vMl59ScazeZHqK6dgdOWjdwJYlhJLT+cj50kWbYRd0oNMp5th\n BrjoxSoZaZaJCSlpoYKyAMIMJA1OsNgYhpVZVKqGAJ9PAWMyj/9A5HcKc","X-Received":"by 2002:a2e:be14:0:b0:38c:45f1:1eb7 with SMTP id\n 38308e7fff4ca-393c40ff1eemr15427991fa.8.1778074045086; Wed, 06 May 2026\n 06:27:25 -0700 (PDT)","MIME-Version":"1.0","References":"<20260506110309.1599633-1-ubizjak@gmail.com>\n <19498f18-1872-4c3f-aeff-43e906084b36@linaro.org>","In-Reply-To":"<19498f18-1872-4c3f-aeff-43e906084b36@linaro.org>","From":"Uros Bizjak ","Date":"Wed, 6 May 2026 15:27:13 +0200","X-Gm-Features":"AVHnY4Kz4z0c3cUogFD4axh2K5SQQ_ZyphD7yqN7K1sk2gRw_dEIQjKmKA1-zf0","Message-ID":"\n ","Subject":"Re: [PATCH] stdbit: Fix builtin name used in __glibc_has_builtin\n check for rotate_right","To":"Adhemerval Zanella Netto ","Cc":"libc-alpha@sourceware.org","Content-Type":"multipart/mixed; boundary=\"000000000000d7aa7d0651261f94\"","X-BeenThere":"libc-alpha@sourceware.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Libc-alpha mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org"}},{"id":3687079,"web_url":"http://patchwork.ozlabs.org/comment/3687079/","msgid":"","list_archive_url":null,"date":"2026-05-06T13:37:46","subject":"Re: [PATCH] stdbit: Fix builtin name used in __glibc_has_builtin\n check for rotate_right","submitter":{"id":66065,"url":"http://patchwork.ozlabs.org/api/people/66065/","name":"Adhemerval Zanella Netto","email":"adhemerval.zanella@linaro.org"},"content":"On 06/05/26 10:27, Uros Bizjak wrote:\n> On Wed, May 6, 2026 at 2:03 PM Adhemerval Zanella Netto\n> wrote:\n>>\n>>\n>>\n>> On 06/05/26 08:03, Uros Bizjak wrote:\n>>> The __glibc_has_builtin check in include/stdbit.h incorrectly refers to\n>>> ___builtin_stdc_rotate_right (with three leading underscores) instead of the\n>>> correct __builtin_stdc_rotate_right (two leading underscores). As a result,\n>>> the builtin is not detected even when supported by the compiler.\n>>>\n>>> Fix the spelling to use __builtin_stdc_rotate_right consistently in both the\n>>> feature test and the corresponding comment.\n>>>\n>>> Fixes: 4adae8550a7a (\"stdlib: Add internal stdc_rotate_right implementation\")\n>>> Cc: Adhemerval Zanella \n>>> Signed-off-by: Uros Bizjak \n>>\n>> LGTM, thanks.\n>>\n>> Reviewed-by: Adhemerval Zanella \n> \n> Sure enough, I somehow missed the fact that _ull version is missing.\n> Fixed by the following emergency one-liner patch.\n> \n> Uros.\n\nThanks. I should have checked it better with the development gcc version.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","libc-alpha@sourceware.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","libc-alpha@sourceware.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=jX7C41R1;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=jX7C41R1","sourceware.org;\n dmarc=pass (p=none dis=none) header.from=linaro.org","sourceware.org; spf=pass smtp.mailfrom=linaro.org","sourceware.org;\n arc=none smtp.remote-ip=2607:f8b0:4864:20::e2e"],"Received":["from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g9c0557Nkz1yJx\n\tfor ; Wed, 06 May 2026 23:38:13 +1000 (AEST)","from vm01.sourceware.org (localhost [IPv6:::1])\n\tby sourceware.org (Postfix) with ESMTP id 7FB0B4BA23C6\n\tfor ; Wed, 6 May 2026 13:38:11 +0000 (GMT)","from mail-vs1-xe2e.google.com (mail-vs1-xe2e.google.com\n [IPv6:2607:f8b0:4864:20::e2e])\n by sourceware.org (Postfix) with ESMTPS id EFDDF4BA23EB\n for ; Wed, 6 May 2026 13:37:50 +0000 (GMT)","by mail-vs1-xe2e.google.com with SMTP id\n ada2fe7eead31-62e7d2633e9so720158137.0\n for ; Wed, 06 May 2026 06:37:50 -0700 (PDT)","from ?IPV6:2804:1b3:a7c1:364:6de5:1475:1d1e:88c0?\n ([2804:1b3:a7c1:364:6de5:1475:1d1e:88c0])\n by smtp.gmail.com with ESMTPSA id\n a1e0cc1a2514c-95ce0902d6dsm8715200241.6.2026.05.06.06.37.48\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 06 May 2026 06:37:49 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 7FB0B4BA23C6","OpenDKIM Filter v2.11.0 sourceware.org EFDDF4BA23EB"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org EFDDF4BA23EB","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org EFDDF4BA23EB","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778074671; cv=none;\n b=KqLOa1GMuEcHrhxHCwlB0Ne4wsvGHzH7xSa+zkiJaR3AVxs/rpOHouBHpUfcfh13zFrm6tPgBh3z1AP0ogsbBE3ku0V1ECm+zs+BJNCAJ3LL9h/GjE1ebk8FXiJb7sonOpc+wTOQIMhvE2lY/4209qciTAvYcuSUlRaoIoaQpzE=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1778074671; c=relaxed/simple;\n bh=5NBRzDvObC4gakrII6XpGBW/ep0kZvnpOt3mm8XHVtc=;\n h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From;\n b=pYd74NELWQPXDIR9c+joQxfreY31P2cKcPuVl7QJTnvE35xW5hlIrPZ7/OJlkY6Yq2PhpWY9hCOxEcwpANlSzAMSN9tbBcITKLSnC+mjv/UU8PtaNhvrjpyF8iyfZd698Z/T8xpHZ6kjZmbbpFhQ/+yNfQnOU5IvYuHyk5OYNRE=","ARC-Authentication-Results":"i=1; sourceware.org;\n dkim=pass (2048-bit key, unprotected)\n header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google\n header.b=jX7C41R1","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1778074670; x=1778679470; darn=sourceware.org;\n h=content-transfer-encoding:in-reply-to:organization:from\n :content-language:references:cc:to:subject:user-agent:mime-version\n :date:message-id:from:to:cc:subject:date:message-id:reply-to;\n bh=mu2nqhKiaSsLYgKTquNIA3nLFPirIyvHoYXO9qnlIrQ=;\n b=jX7C41R1Yw8+SA2eNdOdgruXc0EDDah0GOoklGZAYfNR/KCxCt9bQw9YlqwnA1Ml3V\n QpISEoyhVRaFn6oeX9YKE8UgKo01h8QxSrKWc0EI0JRwD6iWsgumm5+iBRMo9J4+C82N\n 4CcsPDuwB8VJQi3YtSBjMiRu06MLZbrktGNIhVQHslIOnWmL4r1mlp0OpEzYsy4F2fw9\n 9T0xRflhMRO4HgyrkZxoHP9QIBGOPpSvXdNEtA0103mnPWVf37YFdNwAn8q5rR4hcU6e\n 9Y4BfpoUuJOKX25Gi7beAhcqmuNyjRrp89T3HvWamsyoffF7LKOxAftZ0z128ATxjr/H\n aIMw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778074670; x=1778679470;\n h=content-transfer-encoding:in-reply-to:organization:from\n :content-language:references:cc:to:subject:user-agent:mime-version\n :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=mu2nqhKiaSsLYgKTquNIA3nLFPirIyvHoYXO9qnlIrQ=;\n b=HoVJMVnh+b/yDSiGNUlFWduNds7DEWd0gJRpmDbcT6r2XFhMYGeh0tLCjdfvOAA7IB\n 8tDzXTLkpVoxLq20qW+KznViODc1h8vTuLCZUquDTFxTq7TmYrCvgCwVRQkur24H6WmI\n FOuoeNTDSx+/sGknnILqCw0XUFeJxvSkeZgOqWt4Psp9YemJD+fL5N8EQJJQIRirqRs5\n 4U+sMmp4SUa2EQ0SaVMU0Svtqx4bIIQgsuqOZYCnQooIZ8RzEWmj2VZznJZ6tO4DiPx2\n 5CHwXOjtlz8nrwjAKy01dH7+SmvVy6hXLWJtUF/Eial8LYpgc+LE89xtUlkPrXrDe0HC\n eylg==","X-Gm-Message-State":"AOJu0YwPHQkYmW/XnDZTDCAxyl/0kjjmbg5shnXaqTHgeHbh/DAJCes2\n R6sAStqkys/B1FkWCC/A0GiUlT4dzjYiuDTdFMpruyONjZD6f2v5CE2Gl9mvfQNiEA0pGtCJ8hi\n 6UJwr","X-Gm-Gg":"AeBDieu0nbJKSjFRSbnYUFTMjA5kQHyKo/8kCEzLD4VAqda4Z7UwvZ8/EkkNkC/w+Ew\n eCK+V9R5MmK2zg+K6kR/VJ3tDcp9ZocZ9nbzG9r85fLLFZzcG2b4ttZuUNwGicPf688TyJjO0G1\n VIiRo0ine2gEVnOnFRCxjUOcTkgAObtVWt9C7iTqEcTA0cStHk/k7a9VMhER6xpdClWspZGTxcj\n CZjl8Yn7rLx43GLowv40+7Ul7WGgkTHwpq3FykqOboemb5SUwI6iOM/+VLBjNDPaEi7GxZ2fbRL\n nocKcPF6H/YRMCtsikeqU1kongLcdUVMuKEuiYWED2IbwUhrSL5qcabZmcY3zSz4xWkd5jGse7G\n Pcb40aLdski9QnOmoJU1QmdaIVBiBSfR9WrwUDB2N5NxXs4NpAy2/3SvQD+hTsIydQwEL3zSpSJ\n Osh167Ajc4DUGL7VxGQkNcLMDP9vudKmjuLlzx95Ug4D8tQiE2SwtNoI/2fwEYWkOnyGYYnNBca\n knDyPsVrhZAIlL9nfjBVXRwkQ7UbBQczVKbD5Y+aHwc4uSr9qgF","X-Received":"by 2002:a05:6102:548b:b0:62e:1ae1:cd6f with SMTP id\n ada2fe7eead31-62f557d05bbmr4097663137.3.1778074670342;\n Wed, 06 May 2026 06:37:50 -0700 (PDT)","Message-ID":"","Date":"Wed, 6 May 2026 10:37:46 -0300","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] stdbit: Fix builtin name used in __glibc_has_builtin\n check for rotate_right","To":"Uros Bizjak ","Cc":"libc-alpha@sourceware.org","References":"<20260506110309.1599633-1-ubizjak@gmail.com>\n <19498f18-1872-4c3f-aeff-43e906084b36@linaro.org>\n ","Content-Language":"en-US","From":"Adhemerval Zanella Netto ","Organization":"Linaro","In-Reply-To":"\n ","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libc-alpha@sourceware.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Libc-alpha mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org"}}]