[{"id":3687500,"web_url":"http://patchwork.ozlabs.org/comment/3687500/","msgid":"<177813267025.2413233.2433763734158027693.b4-review@b4>","list_archive_url":null,"date":"2026-05-07T05:44:30","subject":"Re: [PATCH 3/4] qapi/net: Wean SLIRP off QAPI type String to\n improve documentation","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"content":"On Wed, 06 May 2026 12:54:20 +0200, Markus Armbruster wrote:\n> String's doc comment is useless. Replace its use in NetdevUserOptions\n> by identical types with hopefully useful documentation.\n> \n> While there, add a non-doc commment explaining why the port forwarding\n> interface is problematic.\n\ncommment -> comment","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=EObomPis;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gB1S94rjCz1yM5\n\tfor ; Thu, 07 May 2026 15:45:27 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wKrXi-0003vy-4u; Thu, 07 May 2026 01:45:02 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wKrXc-0003ve-4s\n for qemu-devel@nongnu.org; Thu, 07 May 2026 01:44:56 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wKrXa-0008FS-Se\n for qemu-devel@nongnu.org; Thu, 07 May 2026 01:44:55 -0400","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-457-7qBetvLoNzyDeAYAm2UEAQ-1; Thu,\n 07 May 2026 01:44:52 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 6E874195604F; Thu, 7 May 2026 05:44:51 +0000 (UTC)","from localhost (unknown [10.44.24.4])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 352EC3002D2D; Thu, 7 May 2026 05:44:49 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1778132694;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=WUi2XRqgCiQ3PpOP9SpSvaVmiT3Wd1zzgoRsVu7zwCU=;\n b=EObomPiskpUVkKiUIhW4d9L5BJK4az3eURXrzfg/YtFKbQ94OIeQFeB1kP5gIVMKId59Zs\n q8rR7azIfH9R0YAvs2LEsJgKTAuQX/22AzELha1MnRGNbWcQvGvEzd47PWfU8ZRrqzGM+A\n VSLpW3ysYlmvwnOuULIqan9cL4dunHM=","X-MC-Unique":"7qBetvLoNzyDeAYAm2UEAQ-1","X-Mimecast-MFC-AGG-ID":"7qBetvLoNzyDeAYAm2UEAQ_1778132691","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Subject":"Re: [PATCH 3/4] qapi/net: Wean SLIRP off QAPI type String to\n improve documentation","From":"marcandre.lureau@redhat.com","To":"Markus Armbruster ","Cc":"qemu-devel@nongnu.org, jasowang@redhat.com, lvivier@redhat.com,\n sbrivio@redhat.com, samuel.thibault@ens-lyon.org,\n marcandre.lureau@redhat.com","In-Reply-To":"<20260506105421.2461117-4-armbru@redhat.com>","References":"<20260506105421.2461117-1-armbru@redhat.com>\n <20260506105421.2461117-4-armbru@redhat.com>","Date":"Thu, 07 May 2026 09:44:30 +0400","Message-Id":"<177813267025.2413233.2433763734158027693.b4-review@b4>","X-Developer-Signature":"v=1; a=openpgp-sha256; l=402;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=orVFJtM0vPnXWwyONkHErqTdWX5FGPMwQgrVjTEqld4=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp/CbCSGUPR57J/1+urAzYXQbbRhqeDtgqkpPyH\n nGNnQ7fnmmJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafwmwgAKCRDa6OEJdZac\n 5dkzEACsze4iDoWfkA4x1dexSlh8ug/ZjIaFiaOjpmLPCqHx765Mv9nWGKAHthCQo5eLGNVz4um\n wqLOjsyAJUhW7E0M9AuCCLrmBRm+FuARXC+LA3Lsc6eDPSg3fB7fDpeDfF/DQ/ghPHu6XtAwpS+\n ZWxgvGCSJnVPKEF7yAHpanIA6ypxToTNqIzMkj5AqynF2NHvKabowWxH51ovrBFVWdzXeqfaltT\n jXJasbmpizMY7lF1BjTfzwfVtqXQuXh5wLFEe+pwwjJLcTf3v01hNes+5TUkGMlT/JycK9vIFZN\n /ifCnnYZICcfs2WXFlzIUYGFUYZo6oPBD+qlTrMemk6njkr/Xv5Gjsot2O8F9ulYC59yD5nh+AP\n TmRrC3F/VRpGg//fa2B38TyHls5Dfdcn0HjH6s7zsNICecvWfm4ChCI/ESAD6Rk3wpq1UF9rRmt\n 4f2tasCfkD6c9odahq0eovEu5ouVz3xAZLcXYZrOPxV9c6cPsNsn+WLjn3a/QxVlfZGDzcN3U+s\n GTaalvsE4xISvPnQ+5NJt/U6F7oIg7tIwmfQAf3q+TXLGw3rJOhRptcvSxuAVU11ElTrc+jLQFK\n BTfBwsyEIc5lOMEF6nHdf730OeN7UGJ7IRF7yyF7RhH5/VTKxUrudKwW2o1gQOlFvOPJmVbN0/l\n /culR8G+FMzqw2w==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"8","X-Spam_score":"0.8","X-Spam_bar":"/","X-Spam_report":"(0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.443,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]