[{"id":3687026,"web_url":"http://patchwork.ozlabs.org/comment/3687026/","msgid":"","list_archive_url":null,"date":"2026-05-06T12:21:33","subject":"Re: [PATCH v4] ASoC: tegra: Add per-stream Mixer Fade controls","submitter":{"id":24878,"url":"http://patchwork.ozlabs.org/api/people/24878/","name":"Mark Brown","email":"broonie@kernel.org"},"content":"On Wed, May 06, 2026 at 10:20:32AM +0000, Sheetal wrote:\n> Add per-stream fade controls for the Tegra mixer to allow\n> independently configuring target gain and fade duration for each of\n> the 10 input streams (RX1 through RX10).\n\n> +\t\t\telse if (i == DURATION_INV_N3_ID)\n> +\t\t\t\tval = (u32)(BIT_ULL(31 + TEGRA210_MIXER_PRESCALAR) /\n> +\t\t\t\t\t mixer->duration[id]);\n> +\t\t\telse\n\nI'll apply this but there's one small issue which can be addressed\nincrementally: if the duration is very small (32 or less) then we'll\noverflow the u32 and generate nonsense values. Either constraining the\nminimum or doing the maths with a 64 bit value would avoid the issue.","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=WTUibB+y;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-tegra+bounces-14238-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"WTUibB+y\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g9ZHm4m3bz1yJq\n\tfor ; Wed, 06 May 2026 22:21:40 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id B29B23009F15\n\tfor ; Wed, 6 May 2026 12:21:38 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 819F93DC4B3;\n\tWed, 6 May 2026 12:21:37 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 41FC843CEFC;\n\tWed, 6 May 2026 12:21:37 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id B3ACAC2BCB8;\n\tWed, 6 May 2026 12:21:36 +0000 (UTC)","by finisterre.sirena.org.uk (Postfix, from userid 1000)\n\tid 21D9E1AC587D; Wed, 06 May 2026 13:21:34 +0100 (BST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1778070097; cv=none;\n b=lNRtETWDo4Y7+5wP3YfOIhNx0oinM/KaJLt8d3ENnWjoQFsRprlm4rseqzbW8NksKUaRNgBwCSuekLag6La0ecjtWMxwEaU8QER1RGPRFcQ+zxJJkpy6fRSGaulPxii/j3rCmVILA38nerd7Ztofb9dzZFFfDsZrs4569USus7g=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1778070097; c=relaxed/simple;\n\tbh=t3hbP7AubYp2C3nJfkuMIJM/a1DKJTDOt/tBbj3XISQ=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=qJ2j7WibK9XE0kkKedXx7SLJH2+ZamL0ZjCOokjX2XASz/yZVHpQT9yyWJSVQbBM+sDuVNJ24kr6Du6WkJ0XphYQ43BhWJxjy/aZ1UC4HcUQFX4FMQZLVgNjXc7nRXSXGDG3ZAVI0i1zkRQ4QrVDh0spx1TTNgWUbPWifzYPw08=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=WTUibB+y; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1778070096;\n\tbh=t3hbP7AubYp2C3nJfkuMIJM/a1DKJTDOt/tBbj3XISQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=WTUibB+y8GyqoowmuKM8+ovNKS77fRx8/vjuE6rgloJBlMrA8gRRLKFLK4IU939MH\n\t Cu2zMUhNbemjCYlUHyHvTR0u8fUz5nNyFVFXRY7nVTxT9h+MWpv8pUW0Y7qmIgcTdE\n\t FF/0DtbB+awOVVIQ6n4lFrhulvhvWMQa1lZDgbP98g6uGMGBIZQ2fYPLl6PVSHRs8/\n\t nizGoOrmlFu4AHpU9zPdPOh/g19viA8oy36W0W+QDOJ7jpBXRetnYDBeDzgWoKBYOR\n\t q62oroFPZLBrKk/oA4kq96bJJ8yCM+yNS3zZzXE4NUlCtBkFtY1raNaCcw7YvhhjVI\n\t /upQhf1T5NchQ==","Date":"Wed, 6 May 2026 21:21:33 +0900","From":"Mark Brown ","To":"Sheetal ","Cc":"Liam Girdwood , Jaroslav Kysela ,\n\tTakashi Iwai ,\n\tThierry Reding ,\n\tJonathan Hunter ,\n\tSameer Pujar , Mohan Kumar ,\n\tKuninori Morimoto ,\n\tlinux-sound@vger.kernel.org, linux-tegra@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH v4] ASoC: tegra: Add per-stream Mixer Fade controls","Message-ID":"","References":"<20260506102032.1644851-1-sheetal@nvidia.com>","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n\tprotocol=\"application/pgp-signature\"; boundary=\"dy75Tbp2warPCQ8+\"","Content-Disposition":"inline","In-Reply-To":"<20260506102032.1644851-1-sheetal@nvidia.com>","X-Cookie":"Alex Haley was adopted!"}},{"id":3687104,"web_url":"http://patchwork.ozlabs.org/comment/3687104/","msgid":"<177807013262.624351.14072023020143249146.b4-ty@b4>","list_archive_url":null,"date":"2026-05-06T12:22:12","subject":"Re: [PATCH v4] ASoC: tegra: Add per-stream Mixer Fade controls","submitter":{"id":24878,"url":"http://patchwork.ozlabs.org/api/people/24878/","name":"Mark Brown","email":"broonie@kernel.org"},"content":"On Wed, 06 May 2026 10:20:32 +0000, Sheetal wrote:\n> ASoC: tegra: Add per-stream Mixer Fade controls\n\nApplied to\n\n https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.2\n\nThanks!\n\n[1/1] ASoC: tegra: Add per-stream Mixer Fade controls\n https://git.kernel.org/broonie/sound/c/36645381b864\n\nAll being well this means that it will be integrated into the linux-next\ntree (usually sometime in the next 24 hours) and sent to Linus during\nthe next merge window (or sooner if it is a bug fix), however if\nproblems are discovered then the patch may be dropped or reverted.\n\nYou may get further e-mails resulting from automated or manual testing\nand review of the tree, please engage with people reporting problems and\nsend followup patches addressing any issues that are reported if needed.\n\nIf any updates are required or you are submitting further changes they\nshould be sent as incremental updates against current git, existing\npatches will not be replaced.\n\nPlease add any relevant lists and maintainers to the CCs when replying\nto this mail.\n\nThanks,\nMark","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=nHgouN9g;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=104.64.211.4; helo=sin.lore.kernel.org;\n envelope-from=linux-tegra+bounces-14250-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"nHgouN9g\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org [104.64.211.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g9clV2LM9z1yJq\n\tfor ; Thu, 07 May 2026 00:12:22 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id AB774300608A\n\tfor ; Wed, 6 May 2026 14:07:57 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 4C4FC47DD75;\n\tWed, 6 May 2026 14:07:56 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CDD747798B;\n\tWed, 6 May 2026 14:07:55 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 5412AC2BCB0;\n\tWed, 6 May 2026 14:07:53 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1778076476; cv=none;\n b=B5ayhfvOSBcr5R77VpyeCGv4sTEzZXcdrFiteg/y1QpvY/ozuLea69645CT9QJR/3oqmTVZH30mzq3JT9bnwTyOcITf4hXSVWYaRaDo0RDqoJzFuhjC7e60/hjeX+sH+hfp4oxauGhZn1vqPG74K0+MDeLTK/xT1pDT+oC1d4gY=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1778076476; c=relaxed/simple;\n\tbh=cQlnEwAXRpnNanjvzfKUqX/rIx5TBMYTuUgvbOozgHw=;\n\th=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date:\n\t MIME-Version:Content-Type;\n b=tMXoDyC9VrjY+5rX+BWVkKKRxe4CvJ9NvR/40sE9BlLXGAoKKbdXRMh7oicBqjdWzcw4kSo/TKA8dtylF0j5gmUgSFmWCe4Nl61x5tzUioz4InBTjRLJHVclTQNO1mWLcORRon33hj5u6hzgspBU8vq+vih5EwWfMb+cWKn4Kps=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=nHgouN9g; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1778076475;\n\tbh=cQlnEwAXRpnNanjvzfKUqX/rIx5TBMYTuUgvbOozgHw=;\n\th=From:To:Cc:In-Reply-To:References:Subject:Date:From;\n\tb=nHgouN9gINhTwXFiYi2DxwBxXH2sgOZudmJHZbHv8Ev03GlvHmEQdrvrG+uB9WDKN\n\t P0f+CDua+TnwG3Uahh9YVWG4qRa5US2U63Qa9vIEsfrvbTlpTUNHUPaHwMenMpAf9U\n\t JjcktYlbOZksli9U7T9yEA66NRVUyKyFucoBsjRZDoRR8mcke6PBfGMLE8agdDtjMW\n\t HfyQv14z0yg/rMI7aWUuMDTlEI2tMcog8CQfYJzw8lrG1Bh4v/Sev8T+yjlMi8wpM7\n\t 6tri/d5kNS3YDGPltBYKwi7K5ZZIVimYJH359RcXlEnknurcVe0SMcEpcNLPsp+pY3\n\t QiXSKopOEXuiw==","From":"Mark Brown ","To":"Liam Girdwood , Sheetal ","Cc":"Jaroslav Kysela , Takashi Iwai ,\n Thierry Reding ,\n Jonathan Hunter , Sameer Pujar ,\n Mohan Kumar ,\n Kuninori Morimoto ,\n linux-sound@vger.kernel.org, linux-tegra@vger.kernel.org,\n linux-kernel@vger.kernel.org","In-Reply-To":"<20260506102032.1644851-1-sheetal@nvidia.com>","References":"<20260506102032.1644851-1-sheetal@nvidia.com>","Subject":"Re: [PATCH v4] ASoC: tegra: Add per-stream Mixer Fade controls","Message-Id":"<177807013262.624351.14072023020143249146.b4-ty@b4>","Date":"Wed, 06 May 2026 21:22:12 +0900","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","X-Mailer":"b4 0.16-dev","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1107; i=broonie@kernel.org;\n h=from:subject:message-id; bh=cQlnEwAXRpnNanjvzfKUqX/rIx5TBMYTuUgvbOozgHw=;\n b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBp+0s4C2Fkg9GPKPt2URXcGk6sVE2GzKwqUpfZt\n qQmTDYCk7WJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCaftLOAAKCRAk1otyXVSH\n 0HSkB/wP2aiYrccXO6hDWncmKF7jG6ds84OhYrfdLEq/FH2k7rgU+cKvU07I+x425UcDmeZ9axX\n 4fyn+nnSAoYpCrj+SOKoytOuUwxL6z/j0QdDn7th5VUeVP+CpakKAsm3xBCYf5aESf0zDToCmQc\n sMNTm3eG3e53Q7KWeyC1JPBlKcT1h5KkvuBrY1Dq7V7LuxKlcFDqTaeb/j4tjauwz7nCNrWXGBg\n Lj5VdDdr8kSkkE7CIaNsyLUyDTco1lhqLeEBElgNs1oHL2PctCc6mCqVBld8eTn0N4r/q0Hj74q\n tAJLcSiV19fJqPVrESgdV1KjBDvxMwozAx6jLjJLfTLbJ4zR","X-Developer-Key":"i=broonie@kernel.org; a=openpgp;\n fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB"}}]