[{"id":3687818,"web_url":"http://patchwork.ozlabs.org/comment/3687818/","msgid":"<02b09dd2-abb4-4df6-9ad3-74812f34cd60@linux.ibm.com>","date":"2026-05-07T13:36:58","subject":"Re: [PATCH 1/3] powerpc/time: remove preempt_disable/enable from\n arch_irq_work_raise()","submitter":{"id":87866,"url":"http://patchwork.ozlabs.org/api/people/87866/","name":"Shrikanth Hegde","email":"sshegde@linux.ibm.com"},"content":"On 5/6/26 2:36 PM, Sayali Patil wrote:\n> A kernel panic is observed when handling machine check exceptions from\n> real mode.\n> \n> BUG: Unable to handle kernel data access on read at 0xc00000006be21300\n> Oops: Kernel access of bad area, sig: 11 [#1]\n> NIP [c000000000029e40] arch_irq_work_raise+0x10/0x70\n> LR [c00000000003ffc8] machine_check_queue_event+0xa8/0x150\n> Call Trace:\n> [c0000000179d3c70] [c00000000003ff64] machine_check_queue_event+0x44/0x150\n> [c0000000179d3d30] [c0000000000084e0] machine_check_early_common+0x1f0/0x2c0\n> \n> The crash occurs because arch_irq_work_raise() calls preempt_disable()\n> from machine check exception (MCE) handlers running in real mode. In\n> this context, accessing the preempt_count can fault, leading to the panic.\n> \n> The preempt_disable()/preempt_enable() pair in arch_irq_work_raise()\n> was originally added by commit 0fe1ac48bef0 (\"powerpc/perf_event: Fix\n> oops due to perf_event_do_pending call\") to avoid races while raising\n> irq work from exception context.\n> \n> Later, commit 471ba0e686cb (\"irq_work: Do not raise an IPI when\n> queueing work on the local CPU\") added preemption protection in\n> irq_work_queue() path, while commit 20b876918c06 (\"irq_work: Use per\n> cpu atomics instead of regular atomics\") added equivalent\n> protection in irq_work_queue_on() before reaching arch_irq_work_raise():\n> \n> irq_work_queue() / irq_work_queue_on()\n> -> preempt_disable()\n> -> __irq_work_queue_local()\n> -> irq_work_raise()\n> -> arch_irq_work_raise()\n> \n> As a result, callers other than mce_irq_work_raise() already execute\n> with preemption disabled, making the additional\n> preempt_disable()/preempt_enable() pair in arch_irq_work_raise()\n> redundant.\n> \n> Remove it to avoid accessing preempt_count from real mode context.\n\nI assume interrupt is disabled here. So it should be functionally safe\nto remove it.\n\n> \n> Fixes: cc15ff327569 (\"powerpc/mce: Avoid using irq_work_queue() in realmode\")\n> Suggested-by: Mahesh Salgaonkar \n> Signed-off-by: Sayali Patil \n> ---\n> arch/powerpc/kernel/time.c | 2 --\n> 1 file changed, 2 deletions(-)\n> \n> diff --git a/arch/powerpc/kernel/time.c b/arch/powerpc/kernel/time.c\n> index 4bbeb8644d3d..a99eb43f6ce9 100644\n> --- a/arch/powerpc/kernel/time.c\n> +++ b/arch/powerpc/kernel/time.c\n> @@ -471,10 +471,8 @@ void arch_irq_work_raise(void)\n\nCould you please add a comment for the function that it expects to\nbe called with preemption_disabled?\n\n> \t * which could get tangled up if we're messing with the same state\n> \t * here.\n> \t */\n> -\tpreempt_disable();\n> \tset_irq_work_pending_flag();\n> \tset_dec(1);\n> -\tpreempt_enable();\n> }\n> \n> static void set_dec_or_work(u64 val)\n\nAcked-by: Shrikanth Hegde ","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=fk4MmUs1;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20567-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=148.163.156.1","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=fk4MmUs1;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com\n (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n envelope-from=sshegde@linux.ibm.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBCwR41QZz1yCg\n\tfor ; Thu, 07 May 2026 23:37:11 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4gBCwR11GDz2xS3;\n\tThu, 07 May 2026 23:37:11 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n [148.163.156.1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4gBCwQ2xHsz2xPb\n\tfor ; Thu, 07 May 2026 23:37:10 +1000 (AEST)","from pps.filterd (m0356517.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 6476MboM067384;\n\tThu, 7 May 2026 13:37:07 GMT","from ppma12.dal12v.mail.ibm.com\n (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220])\n\tby mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dw9y1prv4-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tThu, 07 May 2026 13:37:06 +0000 (GMT)","from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1])\n\tby ppma12.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id\n 647DOUDJ031725;\n\tThu, 7 May 2026 13:37:06 GMT","from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224])\n\tby ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 4dwukqkybb-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tThu, 07 May 2026 13:37:05 +0000 (GMT)","from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com\n [10.20.54.101])\n\tby smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 647Db2Lk54133080\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n\tThu, 7 May 2026 13:37:02 GMT","from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 3A80A2004B;\n\tThu, 7 May 2026 13:37:02 +0000 (GMT)","from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id D2E8920040;\n\tThu, 7 May 2026 13:36:59 +0000 (GMT)","from [9.39.24.53] (unknown [9.39.24.53])\n\tby smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP;\n\tThu, 7 May 2026 13:36:59 +0000 (GMT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1778161031;\n\tcv=none;\n b=nb6eyQ8fKSvlUBhmF3E8wzfL3VUxGtJfL/ahipT5Prw73JcG1YlmUy6KlIxonudr8uZ+axwEb6apvBBE5t4/V55TMbG0bgZdYH7lbQ9fEg0XQ11/lPgIEnwWIzBnsdU46GMNX/Sbb8C9ZZX2lbgHcELwbT0b+HTVYUh0zNDNsbCWajMBffcOQQQxVw1Lm5S3Nc6iu159kxcy/45M9XMsT3AuJz9549I+Djhim9TZngmGd8pne4opd+EQjDh51jsFdN0jYI4jL5bHay59lb0Vds4lo5vd2o70xf2WP4EBZ2uyGjNYaB+doLMU7zuoUIpftgi8YoT38fTjsssJY0btYA==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1778161031; c=relaxed/relaxed;\n\tbh=+C06N/WhHckgQrTKAWXapMtm05UyaUKmH+Dyb2ixO5o=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=BzwF1H8AAgQbRzwYFwHNQTRdpBqz3pUe159ntnJbu2B5xQeMB6Gvw3/DMg3xZPL/mdVgxFejkZowMgTSj09QZpHo3oVmLUFS2koiQm4H0EZTXISygaP9zOAcvITpWYgECxN/HBeDG+4i+HfV+2NqZ7dn05OCrMWntK7VRNFmytoTSn057oQyW5jJIFzXX6AzTbk+Tm8jidImVzEd41YSDH/H7EGpXO5Mb+/WpoWgf9bwuqBYa4WXAGBOpXAQT8GVmF8w4bSiv83Dss5TfVQnOnBZZfbuwYvCJeUvSFp7hI878NWdwPiFnRzMME1JUs14chdhO5UwiK76IdyEptE09g==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=fk4MmUs1; dkim-atps=neutral;\n spf=pass (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n envelope-from=sshegde@linux.ibm.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n\t:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to; s=pp1; bh=+C06N/\n\tWhHckgQrTKAWXapMtm05UyaUKmH+Dyb2ixO5o=; b=fk4MmUs1XYJsU9P+F4NuJI\n\t5GTdLbLJNLCYSz++N8YryipS7xRwL1p7J3BcRueU1qFJubhMZbxTP2WmJ3X6JL1N\n\txLzY3ibecYAkQ6QJDyDZGstJXDdvvJlSjyFnY8mnwwWwS87MZvvqd3fRUaTsMmNU\n\t/+tToeZ3GXCJzUOHf4/tZOZThSK1vW9bkB5XF4Cvrjvu55wPhrr9WZEtuzjL/E2V\n\taYDIHgEYPtvItMrRpK+cbXtNqrilOfWU+KBRB7Fn4IAZaZE/h1hqDEHs8sJ2h5QL\n\twKGiGzaeU5wR9s/omJRXyMOdDx1/iT1Sp7aALNhjwIuMgbYhK8IFaCi3fO9r1lpg\n\t==","Message-ID":"<02b09dd2-abb4-4df6-9ad3-74812f34cd60@linux.ibm.com>","Date":"Thu, 7 May 2026 19:06:58 +0530","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 1/3] powerpc/time: remove preempt_disable/enable from\n arch_irq_work_raise()","To":"Sayali Patil , linuxppc-dev@lists.ozlabs.org,\n maddy@linux.ibm.com","Cc":"linux-kernel@vger.kernel.org, Ritesh Harjani ,\n Mahesh Salgaonkar , chleroy@kernel.org","References":"\n ","Content-Language":"en-US","From":"Shrikanth Hegde ","In-Reply-To":"\n ","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","X-Proofpoint-Reinject":"loops=2 maxloops=12","X-Proofpoint-ORIG-GUID":"TG00qyLQUiXVkIWy0xz9jHkRL7xrKept","X-Proofpoint-GUID":"No0jCZpB6ba70jvTqSZwhqJQKlkR5BYc","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNTA3MDEzNiBTYWx0ZWRfX0W/gj2+ohC+i\n WNcn0bldzqqsWLAKbqUBubTqFfBCW2Sm7QMNpEJdYglSP2/rkmDRdUuH6WoXaJVtMJ13Al4rKsu\n 27+UatzoiqujRvsPd5p2oCk+tkTuEqNNeCJVJRbX3VJxuFT7Z6AlQyyi2KXvDdvAauP+sTeHuzN\n Aot0hsI/5bg89ttz8zhy/P6I4wrG/AXDLxvql/WBFgG07+MwGdaPO4QuCHBTanngYcmUCaD8Z+W\n /2YSd9wRj+RUAy5inlMKAwS8U1N+cPLphE2KeJK/ZvCojCHRXn0PmpHrR+3iDRLm7Gl8CbMAeYf\n w2/eqxGQjgVXpB4eXL6H23h3UA0fmepv8q+c090pyqnbGsUfRh4e1bcP51BrGbx+cvqJ/oVJphT\n Lo/jS5b0jLuFmv7ZNYQDLwYXhFsNlEh1+uPCNVUI14rKKHbNl4APmBQWqSJdKRgQqWp9LqqUykj\n 40cXXBA/15cMjXqRCqw==","X-Authority-Analysis":"v=2.4 cv=UbFhjqSN c=1 sm=1 tr=0 ts=69fc9583 cx=c_pps\n a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17\n a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=RnoormkPH1_aCDwRdu11:22 a=U7nrCbtTmkRpXpFmAIza:22 a=VnNF1IyMAAAA:8\n a=Mg_wskF81hBiSU2tnFsA:9 a=QEXdDO2ut3YA:10","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-05-07_01,2026-05-06_01,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n clxscore=1015 spamscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0\n adultscore=0 priorityscore=1501 bulkscore=0 phishscore=0 impostorscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070136","X-Spam-Status":"No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,\n\tSPF_PASS autolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}},{"id":3690563,"web_url":"http://patchwork.ozlabs.org/comment/3690563/","msgid":"","date":"2026-05-13T04:30:49","subject":"Re: [PATCH 1/3] powerpc/time: remove preempt_disable/enable from\n arch_irq_work_raise()","submitter":{"id":79126,"url":"http://patchwork.ozlabs.org/api/people/79126/","name":"Ritesh Harjani (IBM)","email":"ritesh.list@gmail.com"},"content":"Sayali Patil writes:\n\n> A kernel panic is observed when handling machine check exceptions from\n> real mode.\n>\n> BUG: Unable to handle kernel data access on read at 0xc00000006be21300\n> Oops: Kernel access of bad area, sig: 11 [#1]\n> NIP [c000000000029e40] arch_irq_work_raise+0x10/0x70\n> LR [c00000000003ffc8] machine_check_queue_event+0xa8/0x150\n\n[14626.841925] MSR: 8000000000001003 CR: 88222248 XER: 00000005\n[14626.841939] CFAR: c00000000003ffc4 DAR: c00000006be21300 DSISR: 40000000 IRQMASK: 0\n\n\nLet's also add the above MSR state along with the call stack showing\nMSR[EE] was 0 when this triggered. This also shows the DAR as 0xc....\nwhile MSR[IR|DR] = 0. \n\n> Call Trace:\n> [c0000000179d3c70] [c00000000003ff64] machine_check_queue_event+0x44/0x150\n> [c0000000179d3d30] [c0000000000084e0] machine_check_early_common+0x1f0/0x2c0\n>\n> The crash occurs because arch_irq_work_raise() calls preempt_disable()\n> from machine check exception (MCE) handlers running in real mode. In\n> this context, accessing the preempt_count can fault, leading to the panic.\n>\n> The preempt_disable()/preempt_enable() pair in arch_irq_work_raise()\n> was originally added by commit 0fe1ac48bef0 (\"powerpc/perf_event: Fix\n> oops due to perf_event_do_pending call\") to avoid races while raising\n> irq work from exception context.\n>\n> Later, commit 471ba0e686cb (\"irq_work: Do not raise an IPI when\n> queueing work on the local CPU\") added preemption protection in\n> irq_work_queue() path, while commit 20b876918c06 (\"irq_work: Use per\n> cpu atomics instead of regular atomics\") added equivalent\n> protection in irq_work_queue_on() before reaching arch_irq_work_raise():\n>\n> irq_work_queue() / irq_work_queue_on()\n> -> preempt_disable()\n> -> __irq_work_queue_local()\n> -> irq_work_raise()\n> -> arch_irq_work_raise()\n>\n> As a result, callers other than mce_irq_work_raise() already execute\n> with preemption disabled, making the additional\n> preempt_disable()/preempt_enable() pair in arch_irq_work_raise()\n> redundant.\n>\n> Remove it to avoid accessing preempt_count from real mode context.\n>\n> Fixes: cc15ff327569 (\"powerpc/mce: Avoid using irq_work_queue() in realmode\")\n\nAgree with the Fixes tag. This patch actually moved mce to use\narch_irq_work_raise(). It was ok until the CONFIG_PREEMPTION was\ndisabled on powerpc since macros like preempt_enable|disable() were\nmostly a no-op. However, after lazy preemption got enabled, access to\npreempt_count while in real mode can cause the issue you described.\n\n\nOne more thing which we should add to the commit msg is:\nThe arch_irq_work_raise() function executes in NMI context when called\nfrom MCE handler, hence we won't be preempted or scheduled out since we\nare in NMI context with MSR[EE]=0, hence it is safe to remove\npreempt_disable|enable() call from here.\n\nAnd let's change the commit subject to:\n powerpc/time: Remove redundant preempt_disable|enable() calls from arch_irq_work_raise()\n\n\nBTW, thanks for adding a nice commit msg with the sequence of events.\nWith the above changes - pease feel free to add:\n\nReviewed-by: Ritesh Harjani (IBM) \n\n\n> Suggested-by: Mahesh Salgaonkar \n> Signed-off-by: Sayali Patil \n> ---\n> arch/powerpc/kernel/time.c | 2 --\n> 1 file changed, 2 deletions(-)\n>\n> diff --git a/arch/powerpc/kernel/time.c b/arch/powerpc/kernel/time.c\n> index 4bbeb8644d3d..a99eb43f6ce9 100644\n> --- a/arch/powerpc/kernel/time.c\n> +++ b/arch/powerpc/kernel/time.c\n> @@ -471,10 +471,8 @@ void arch_irq_work_raise(void)\n> \t * which could get tangled up if we're messing with the same state\n> \t * here.\n> \t */\n> -\tpreempt_disable();\n> \tset_irq_work_pending_flag();\n> \tset_dec(1);\n> -\tpreempt_enable();\n> }\n> \n> static void set_dec_or_work(u64 val)\n> -- \n> 2.52.0","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=C5LUzQXa;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20824-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2607:f8b0:4864:20::1036\"","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=C5LUzQXa;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com\n (client-ip=2607:f8b0:4864:20::1036; helo=mail-pj1-x1036.google.com;\n envelope-from=ritesh.list@gmail.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gFhtB1XWtz1yJ5\n\tfor ; Wed, 13 May 2026 15:32:17 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4gFht83FvVz2xpt;\n\tWed, 13 May 2026 15:32:16 +1000 (AEST)","from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com\n [IPv6:2607:f8b0:4864:20::1036])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4gFht65pQPz2xn3\n\tfor ; Wed, 13 May 2026 15:32:13 +1000 (AEST)","by mail-pj1-x1036.google.com with SMTP id\n 98e67ed59e1d1-36608b2f2dcso4421358a91.2\n for ;\n Tue, 12 May 2026 22:32:13 -0700 (PDT)","from pve-server ([49.205.216.49])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-368ede49dfcsm1614075a91.7.2026.05.12.22.32.07\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 12 May 2026 22:32:09 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1778650336;\n\tcv=none;\n b=PTVHLp48m0R2z7AZY+Tdd3Aep/7dmgPnSW8L27waee1AGT9LMXkKgBG+khTHDx6aMrPL8liZcrDILZRIwZCgM0BhCSOwSrIdRujhvFjiTV51z5exQyBLjc+wYD7jEKPZqVhb4kG4TSy+mQZwj6ZAiZUFNe5V+2zN03c0dqKdiRS5+OsxzuvAMURH2AW0nr6+4UVwRhwSgm69nnBkmjfrbY7PBgWvjetEUfzWf4eoE/Up1w3zY8mlWQLpyO8EBaDZ0sOGO2XzqAryfw9Am+0OHnnarKSoLCVOikQNJhBVga7gp7Ui/8owxR29W7lkjNetfFOvbMSu9IJ8vigOCilv3A==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1778650336; c=relaxed/relaxed;\n\tbh=Odlz6dn4AMU3xpWoO+zOes01KTSuDtmQ6fjIHbN8+tI=;\n\th=From:To:Cc:Subject:In-Reply-To:Date:Message-ID:References;\n b=MT4oYBh+NRFXdK85nOqEww9mytqp2C0nWEe1Cuo+V2DrVeesLn996wajPqbIcrgl8sxctbsQchvyEj3c6ddjaeUYftCuvWgtIfXHspLz0Tjef/ONJKVJ1gCLDvffHMLSLjOt60YMCvZ2pMFgAONgfiDhg2guUX2ayRXhhRj+YbBPRqA3tR+HLMFpSMK1NkaxLsY4go0p2R9oAA+MVWCaYzlTigBU5Rd2m8yDICHk3hP+RhAY5Y8iru/DsmybSu2maI4EfnkrYKyh2belamJn5SQJ74RCFbCQcPBgPUB+491BmXQeebZVauhkgewEMriprick/1B0I/qcwD0/QikCzA==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com; dkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=C5LUzQXa; dkim-atps=neutral;\n spf=pass (client-ip=2607:f8b0:4864:20::1036; helo=mail-pj1-x1036.google.com;\n envelope-from=ritesh.list@gmail.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=gmail.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1778650331; x=1779255131;\n darn=lists.ozlabs.org;\n h=references:message-id:date:in-reply-to:subject:cc:to:from:from:to\n :cc:subject:date:message-id:reply-to;\n bh=Odlz6dn4AMU3xpWoO+zOes01KTSuDtmQ6fjIHbN8+tI=;\n b=C5LUzQXaoXKDJA5aIkhgg51UlwAL4phGMIaEWgXYX2ZnecNlqIeVHLL0HtPbJmmD91\n dj6pu6XxDrUHB7Qj51llNF7xPxe7c9aTj9CsWF0oeJ5Oc67G3konTNXLIfVIyJBIZSm8\n jQhHC8D3eMe49Z96Sl1lJDkm754SieWzvdry/TqLXxjx446ZRQ/1F+2Ik+CK+y6zsLrj\n o+6ujY9ZWykvtPsDcbk12rkN6OBCkqUuziz8aEjIexk2eQcVTsm7g+HlEEZrTeVGoCOq\n 9udmRWwhUtq6kwl6uAc3m6TVKhhG3Ap3Dc1tLdsfto3J92xnyXmND2t+lXB06NNmDLT/\n iNhw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778650331; x=1779255131;\n h=references:message-id:date:in-reply-to:subject:cc:to:from:x-gm-gg\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=Odlz6dn4AMU3xpWoO+zOes01KTSuDtmQ6fjIHbN8+tI=;\n b=Jr8Q8zmWjbtobRxS/HLajXZTYJSZMzMPZvKnVf/LOm6S87uKk2urRDECxazryXh1S3\n I5+AUq56dNpEiOHv1Sw1akK84KCdYFcMctnyg0BIQhyrJ8cu+bAX5O+DeaHWOtW3n/3u\n u8i/p9BHJ/EJl5ErsIqSacVlz+5jDL/Pk7VvL9HNHi1KGSweAYyAm8qz34qXWx2WRXRz\n PplIVP3oPwfk53RG30Wx5cD5q6UH8VolWzKIeWTGopnxzkyYC1jKlJ2RD6BxMhiX4+3H\n FXufVYfdaIdbE0u3dmvu7m7hFbzrCJRtv5LQSYNWXjtiu3UMXg808JF+1Bhg8D1NYrdU\n 79Tg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+7WpjQNyAqB16DwklIk4rixVKlj/OEuPyzEh52mwr0yT2DcDcC5PajCRydskQS/qeDp6uRr2tWEmA/h0M=@lists.ozlabs.org","X-Gm-Message-State":"AOJu0Yw9CLq0md+/5BVoHA0y6eMA1X2MO9fqIgdQmeqPr3q1EeFbKFJx\n\tPdz5xmev+WgchniiZqAVrsOewoMRFrLEVJ72MbRNyObi6CAdPSM1c3te","X-Gm-Gg":"Acq92OGU2hvHVuuaD6XK5Xm165AQCOETJlBvCQbV1CGwFyZe+97Q6sRblCXh9zJAtYQ\n\tABWfjohzfzAEYWg84Jj5peh+JZrw81zdhAaj6H5ARaCKqtkQIGyr9mTTH0pHKITtTwymxN8d7xI\n\t1Iw7I3h7QQMzF+7FcCQ3OKpFqEl2YPlNEB5ipzoPobcbDRFdA3IkkNJLvDoLHXR3uJuhIo4DNPr\n\tRw9e9agj7pPqWOeqU2b+K6NACL0EZgIduk92p6XgN+zAbIvJr8VYWSVMGhjj8BwJ8QtA6VxdqG/\n\tX6ENQwf2b5vWze5/Jd/GTzIfmWOFPOgzBcBBWpmoRr1XCN+eWQeaNut68SCQ0oU52nEIDwu+S0A\n\tS9NvQfV/30YVO6GW+u/pfQFM6Oi/UCt3jbNCytgB2lFw88zZuq5+9elSm3hlGP7ySqwSq/Sw7it\n\t8ceDDohfpc/a+HVDkDg8zvGw==","X-Received":"by 2002:a17:90b:2702:b0:366:4782:139a with SMTP id\n 98e67ed59e1d1-368f79930c2mr1396471a91.17.1778650330660;\n Tue, 12 May 2026 22:32:10 -0700 (PDT)","From":"Ritesh Harjani (IBM) ","To":"Sayali Patil , linuxppc-dev@lists.ozlabs.org,\n maddy@linux.ibm.com","Cc":"linux-kernel@vger.kernel.org, Mahesh Salgaonkar ,\n sshegde@linux.ibm.com, chleroy@kernel.org","Subject":"Re: [PATCH 1/3] powerpc/time: remove preempt_disable/enable from\n arch_irq_work_raise()","In-Reply-To":"\n ","Date":"Wed, 13 May 2026 10:00:49 +0530","Message-ID":"","References":"\n ","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,\n\tSPF_HELO_NONE,SPF_PASS autolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list"}},{"id":3690565,"web_url":"http://patchwork.ozlabs.org/comment/3690565/","msgid":"","date":"2026-05-13T05:35:27","subject":"Re: [PATCH 1/3] powerpc/time: remove preempt_disable/enable from\n arch_irq_work_raise()","submitter":{"id":87866,"url":"http://patchwork.ozlabs.org/api/people/87866/","name":"Shrikanth Hegde","email":"sshegde@linux.ibm.com"},"content":"On 5/13/26 10:00 AM, Ritesh Harjani (IBM) wrote:\n> Sayali Patil writes:\n> \n>> A kernel panic is observed when handling machine check exceptions from\n>> real mode.\n>>\n>> BUG: Unable to handle kernel data access on read at 0xc00000006be21300\n>> Oops: Kernel access of bad area, sig: 11 [#1]\n>> NIP [c000000000029e40] arch_irq_work_raise+0x10/0x70\n>> LR [c00000000003ffc8] machine_check_queue_event+0xa8/0x150\n> \n> [14626.841925] MSR: 8000000000001003 CR: 88222248 XER: 00000005\n> [14626.841939] CFAR: c00000000003ffc4 DAR: c00000006be21300 DSISR: 40000000 IRQMASK: 0\n> \n> \n> Let's also add the above MSR state along with the call stack showing\n> MSR[EE] was 0 when this triggered. This also shows the DAR as 0xc....\n> while MSR[IR|DR] = 0.\n> \n>> Call Trace:\n>> [c0000000179d3c70] [c00000000003ff64] machine_check_queue_event+0x44/0x150\n>> [c0000000179d3d30] [c0000000000084e0] machine_check_early_common+0x1f0/0x2c0\n>>\n>> The crash occurs because arch_irq_work_raise() calls preempt_disable()\n>> from machine check exception (MCE) handlers running in real mode. In\n>> this context, accessing the preempt_count can fault, leading to the panic.\n>>\n>> The preempt_disable()/preempt_enable() pair in arch_irq_work_raise()\n>> was originally added by commit 0fe1ac48bef0 (\"powerpc/perf_event: Fix\n>> oops due to perf_event_do_pending call\") to avoid races while raising\n>> irq work from exception context.\n>>\n>> Later, commit 471ba0e686cb (\"irq_work: Do not raise an IPI when\n>> queueing work on the local CPU\") added preemption protection in\n>> irq_work_queue() path, while commit 20b876918c06 (\"irq_work: Use per\n>> cpu atomics instead of regular atomics\") added equivalent\n>> protection in irq_work_queue_on() before reaching arch_irq_work_raise():\n>>\n>> irq_work_queue() / irq_work_queue_on()\n>> -> preempt_disable()\n>> -> __irq_work_queue_local()\n>> -> irq_work_raise()\n>> -> arch_irq_work_raise()\n>>\n>> As a result, callers other than mce_irq_work_raise() already execute\n>> with preemption disabled, making the additional\n>> preempt_disable()/preempt_enable() pair in arch_irq_work_raise()\n>> redundant.\n>>\n>> Remove it to avoid accessing preempt_count from real mode context.\n>>\n>> Fixes: cc15ff327569 (\"powerpc/mce: Avoid using irq_work_queue() in realmode\")\n> \n> Agree with the Fixes tag. This patch actually moved mce to use\n> arch_irq_work_raise(). It was ok until the CONFIG_PREEMPTION was\n> disabled on powerpc since macros like preempt_enable|disable() were\n> mostly a no-op. However, after lazy preemption got enabled, access to\n\nBoth full/lazy preemption. With upstream now, one can choose full or lazy only.\nLeading to issue being discovered.\n\n> preempt_count while in real mode can cause the issue you described.\n> \n> \n> One more thing which we should add to the commit msg is:\n> The arch_irq_work_raise() function executes in NMI context when called\n> from MCE handler, hence we won't be preempted or scheduled out since we\n> are in NMI context with MSR[EE]=0, hence it is safe to remove\n> preempt_disable|enable() call from here.\n> \n> And let's change the commit subject to:\n> powerpc/time: Remove redundant preempt_disable|enable() calls from arch_irq_work_raise()\n> \n> \n> BTW, thanks for adding a nice commit msg with the sequence of events.\n> With the above changes - pease feel free to add:\n> \n> Reviewed-by: Ritesh Harjani (IBM) \n> \n> \n>> Suggested-by: Mahesh Salgaonkar \n>> Signed-off-by: Sayali Patil \n>> ---\n>> arch/powerpc/kernel/time.c | 2 --\n>> 1 file changed, 2 deletions(-)\n>>\n>> diff --git a/arch/powerpc/kernel/time.c b/arch/powerpc/kernel/time.c\n>> index 4bbeb8644d3d..a99eb43f6ce9 100644\n>> --- a/arch/powerpc/kernel/time.c\n>> +++ b/arch/powerpc/kernel/time.c\n>> @@ -471,10 +471,8 @@ void arch_irq_work_raise(void)\n>> \t * which could get tangled up if we're messing with the same state\n>> \t * here.\n>> \t */\n>> -\tpreempt_disable();\n>> \tset_irq_work_pending_flag();\n>> \tset_dec(1);\n>> -\tpreempt_enable();\n>> }\n>> \n>> static void set_dec_or_work(u64 val)\n>> -- \n>> 2.52.0","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=VndogxBT;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20825-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=148.163.158.5","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=VndogxBT;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com\n (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com;\n envelope-from=sshegde@linux.ibm.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gFhy51N4bz1yKH\n\tfor ; Wed, 13 May 2026 15:35:41 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4gFhy50CSnz2y2B;\n\tWed, 13 May 2026 15:35:41 +1000 (AEST)","from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n [148.163.158.5])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4gFhy36d2Fz2xn3\n\tfor ; Wed, 13 May 2026 15:35:39 +1000 (AEST)","from pps.filterd (m0353725.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 64D23AZc3775682;\n\tWed, 13 May 2026 05:35:35 GMT","from ppma23.wdc07v.mail.ibm.com\n (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93])\n\tby mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4e3nv6nx1b-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tWed, 13 May 2026 05:35:34 +0000 (GMT)","from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1])\n\tby ppma23.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id\n 64D5OR5m031964;\n\tWed, 13 May 2026 05:35:33 GMT","from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227])\n\tby ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4e3nfgpbhn-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tWed, 13 May 2026 05:35:33 +0000 (GMT)","from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com\n [10.20.54.101])\n\tby smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 64D5ZUBc49086728\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n\tWed, 13 May 2026 05:35:30 GMT","from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id E6D1320040;\n\tWed, 13 May 2026 05:35:29 +0000 (GMT)","from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 3C0632004B;\n\tWed, 13 May 2026 05:35:28 +0000 (GMT)","from [9.39.28.2] (unknown [9.39.28.2])\n\tby smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP;\n\tWed, 13 May 2026 05:35:28 +0000 (GMT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1778650540;\n\tcv=none;\n b=n6tC/+OiZXybBjTOc0+3RrSWYqkDsPcOVPWh3ey+Jis6tCi/JjjtQUi2PQnDUPnhUi0Ot7WGiqRf/LXU3rzA+bEiLKMRB0LQHQIMnYR6ZErDXDZzOWndx9wjExKsGm7pw3X5k8YXd2PvC7HSp8nANOYvGZkoPy7dgZZFJRgz+MW64VloSF6bSpbY2Jzq6jE3dv2MMoaLUMTEfF2tnHgCRDcDoIk/a9M3xMw2AdrtdUWa75mMEG0i6op+KJfb9Q/ab0Mqj7DAdTtGpKlBh+XMyFmn+QDIS7Qb6uZGMaQaq6qFhMY7c1W4f6CMZ5T+yry00l3gmUq53K+GFNCOu5YNtA==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1778650540; c=relaxed/relaxed;\n\tbh=zcoiNG9cEyP+nL4uxgFRnI+EezDV+bgUmox8t27Hpfo=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=ZZgij6NRVy0ln9V27ET0s56FUY09HenWWsZO+jF/nGg9/r/pO8bxx20mwsyf2NZJsqbx/A9si5163eWtRJOcLCvhJlSQfpjYA7p41PsRgUPegY9gEjpvsWX6l7jY08pfRpuBAfulCFa+67kf6cPabcXjMoJJi+RsgeUmJzuLULaHnof3++xL6atC8KwKwSZ0EpjJK0CuKYkGoppLEmprYAR42JoqJlKunm9saXe5S0lmmvtfinB6WpVYRUq2b/yXZRT4L8Pv2LMTBHoR8W836uSoVdTcUd9IRgGPnFJ3oT0jwKBpapGhLqQfEJZwp/3mJGChq6wPYJqGPdYNmYd7cg==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=VndogxBT; dkim-atps=neutral;\n spf=pass (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com;\n envelope-from=sshegde@linux.ibm.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n\t:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to; s=pp1; bh=zcoiNG\n\t9cEyP+nL4uxgFRnI+EezDV+bgUmox8t27Hpfo=; b=VndogxBTAo/YRD2Fv12IXU\n\tXwqzVbxsxgro0V20kUk2HEeMNVEmPNjDBSFaCNqXnaTylWBdK8tD64QunZHucKHk\n\tXHb+JNE/EpocfIpLeaGycefZzxK+9Z4EUObO5Odo9QYv+GWlgDEzBaRD9Yth1cZ7\n\tJq/GAtwDB7cTsN1oD3k6OBWc4EcwnjG+9n7vP2J9UTzUxUS4vgWRBG8Pt5pfz6Fg\n\tqeSYCLIhUqKgnuAEhLg7tyKSGBQA58Yc29ssqOIMmLrirgsvQTf+7QdJ95VoD2YW\n\tFIrXaJCaG4wTixXrEHwGd5l9Oa7KZ1L2/se8ky8BTls00OJ1OAC9qc3BQlSqWnZQ\n\t==","Message-ID":"","Date":"Wed, 13 May 2026 11:05:27 +0530","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 1/3] powerpc/time: remove preempt_disable/enable from\n arch_irq_work_raise()","To":"\"Ritesh Harjani (IBM)\" ,\n Sayali Patil , linuxppc-dev@lists.ozlabs.org,\n maddy@linux.ibm.com","Cc":"linux-kernel@vger.kernel.org, Mahesh Salgaonkar ,\n chleroy@kernel.org","References":"\n \n ","From":"Shrikanth Hegde ","Content-Language":"en-US","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","X-Proofpoint-Reinject":"loops=2 maxloops=12","X-Authority-Analysis":"v=2.4 cv=KbvidwYD c=1 sm=1 tr=0 ts=6a040da6 cx=c_pps\n a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17\n a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=RnoormkPH1_aCDwRdu11:22 a=V8glGbnc2Ofi9Qvn3v5h:22 a=VnNF1IyMAAAA:8\n a=pGLkceISAAAA:8 a=v7GjVOmr5oXViBslm-QA:9 a=QEXdDO2ut3YA:10","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNTEzMDA0OSBTYWx0ZWRfX7qlmWm6eKoy5\n GI3SLg/3J/ripKfqpaoZNoGckZ4AThDaO8cJkSypTqFRzqhs1/bXr/o5tN7NY1BAI7iiDMDeKUu\n XQOXRuhLfEyDXcG5GQUHgKzcG+lJOl26/G8Y60yI594BO0YT9dQ9EHH9dj3CezZZUynjAtVfqcR\n 6t3S5aOUDmeGmj9K2FbYN7lRQTRMvEaPRWFEgssURV30qaWcKziB2TAhzy97lnG8uKYMaCK2r2C\n +aSlHSWPuTcEgrKMa2CUzqN0CCf1yBfukLrefpS4G8cVGxsmysjOil7ScIEL7uTXkUhp5wsGT0o\n 7TeS9OnvzYwdsmFL2y7wInUdFU7CehoCOOXNEOtgmURJ+iNtppDO6p/bFUReXVOcoZvXVdvSaKI\n /va++DYSbN54h3N9sDUet1GR5MxzvW+4hAGrLJBffGQEh+dZwU+l8PGDRuTJKKid0atCnGo8Udd\n fKkn6K1XY6rywR66toQ==","X-Proofpoint-GUID":"D_itOF8TvEN-EncmPBTqyJg8dpN8gcKu","X-Proofpoint-ORIG-GUID":"U3lz9non03QtN8HWEx95oSypQv83MXK7","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-05-11_05,2026-05-08_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n priorityscore=1501 bulkscore=0 impostorscore=0 malwarescore=0\n lowpriorityscore=0 phishscore=0 spamscore=0 suspectscore=0 clxscore=1015\n adultscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605050000\n definitions=main-2605130049","X-Spam-Status":"No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,\n\tSPF_PASS autolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]