[{"id":3686907,"web_url":"http://patchwork.ozlabs.org/comment/3686907/","msgid":"<7e37497a-212c-449d-9a12-cba93d7d48e7@linaro.org>","list_archive_url":null,"date":"2026-05-06T09:10:13","subject":"Re: [PATCH v1 1/2] hw/usb/hcd-ehci: Rename migration compatibility\n fetch address fields","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 6/5/26 05:26, Jamin Lin wrote:\n> Rename the 32-bit fetch address migration helper fields to make\n> their purpose clearer.\n> \n> These fields are only used for migration compatibility with older\n> machine types that transfer 32-bit fetch addresses in the migration\n> stream. They are not runtime fetch address state.\n> \n> Also add comments to clarify the relationship between the migration\n> compatibility fields and the runtime 64-bit fetch address fields.\n> \n> No functional change.\n> \n> Signed-off-by: Jamin Lin \n> ---\n> hw/usb/hcd-ehci.h | 17 ++++++++++++++---\n> hw/usb/hcd-ehci.c | 12 ++++++------\n> 2 files changed, 20 insertions(+), 9 deletions(-)\n\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=R/VmTEs3;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g9V3j2cCxz1yJq\n\tfor ; Wed, 06 May 2026 19:10:55 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wKYGq-0003li-UM; Wed, 06 May 2026 05:10:20 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wKYGp-0003lE-10\n for qemu-devel@nongnu.org; Wed, 06 May 2026 05:10:19 -0400","from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wKYGn-0000u5-FG\n for qemu-devel@nongnu.org; Wed, 06 May 2026 05:10:18 -0400","by mail-wm1-x32b.google.com with SMTP id\n 5b1f17b1804b1-4891f625344so7283875e9.0\n for ; Wed, 06 May 2026 02:10:16 -0700 (PDT)","from [192.168.69.210] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-45054b02802sm11036870f8f.17.2026.05.06.02.10.14\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 06 May 2026 02:10:14 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1778058615; x=1778663415; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=snPqNajal7y6qubnA9pyHb7+O7dHOfLjv5cOqMGADZQ=;\n b=R/VmTEs3M+zm2ibvIxYNarHeTaqERoQTpol1xp7SBcJ7pEQoYTdORsE46BTtR2nY6K\n A2n4aBzZ3uhAmfgHx6Dqq+Vc6SAgiAwenRE40RXEaPsob4ag1kEh9pKy0NMzo2nG6HUZ\n 2BzB5h28V1QfuOhEqUo0sGBMLCf/QnudIxR0t7wBNZb/MMZlP9gZT7uiO9lpLLNMuRKX\n 9Fm7wo1gkjLIgTmXH7tJ0Fs3jduMe8VdBzbfyh9i6fMk5oQLlFid//3EDvoi4i8dD/ba\n AxF9VA93i4sLkwq4pN6hkhDrSuNBspn0EZjDbYChmsDX4v7xmjhJyTa4gHNvtYG3Fl5i\n 5reg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778058615; x=1778663415;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=snPqNajal7y6qubnA9pyHb7+O7dHOfLjv5cOqMGADZQ=;\n b=eDGN5FgdJ4i0qyLA+3L1YFFGDtlJT2wp0DcQ4sn6lSbhZhE26/7zV9cVwYeZhUJnqw\n QsgydNnrLVdBg00j6U7SCc0C5MUvL84SBA4/RRvWBiDBMciofysl6JzR/3tGBaRCSSWD\n Ysg1hTZKcBB9mabT/CPsRjDoq4KuOV/rD7ZGl32Q7pxgj8BurFfvH0QCT4ltP9LQ/zX8\n MAnxGKa36WVcNTeHmLV0eifufawtyh5uQ6iWAGojeCTO1Lo3Xoiy3z6oo2u0Mq3Axkhv\n 4AUjSanZ1kv3WqztHoQ1kC1Rv9XgKubc9kWlL/6DVKVeVzxJmH8m5LD8WYEKlaxah3Fx\n xSRQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ93ngaMFY6iYx6ca9LEeWmf6hQjlMFViOTH+QyAvJRFgZSQLoA243vZ0Igd+oNEeghL2tuuFyAByVsU@nongnu.org","X-Gm-Message-State":"AOJu0YxEddkq/2CNM9Vu9CftziCdBOrgiH5PWEanJPCEW3XdDauPgvHB\n 8yRmQrt0uI/3zSCdHoep8gWbKMQzKLaTlJ75+jvEO97s+nN1c90+w1zfpLwvnPa7Dhc=","X-Gm-Gg":"AeBDieu6+qF3gTI7uS7WbpJ5zxD4HMghrqQdvSSBFoll89YfUTd/bJhvK43tE+1rHLQ\n BUOuXiZkeuGu+EQxE9zX8ykKO/tEishV1GyLpf7b3wmdjLAu6eRv3fnlYNjDVH5yQaPaZHJyzEl\n /MkfKa/CpbsJuD7F6tj46n2epx+zF/8OqChEMAGDmVBFRJoaohGfXG6Rj+rDZz/cDD6GuzN6u7q\n xil8MvvzOpX87nV22WMIvw/maXaDSbT42PGPVbH2QG6gZ3ASaG7SzAHEnRxMeKYO/tuJQOZHaZS\n Xp7tGn5nhDIxAaKfJqcNESkojGqrNnNdBqbVY6Q+Fe9fkYYcVobKqION7c9FR/pXCShbiq5DhXr\n DNlqaixsFeFUJj98RV02gJqme2y8bAdjIaVVmQbETAbvqzZrqvaGtrE8VWh54rdXoya1Yg7aI1q\n ecLl4IjXfewq/Sr5CiQMezOZlGPRyRYaUAa/5zFTPjZLmNWFxPjXqUM3R2gylo0tDsUJmpwVoMB\n uNepr5pFJemYKE=","X-Received":"by 2002:a05:600c:5747:b0:488:fbf6:ea59 with SMTP id\n 5b1f17b1804b1-48d142654f9mr89061925e9.12.1778058615263;\n Wed, 06 May 2026 02:10:15 -0700 (PDT)","Message-ID":"<7e37497a-212c-449d-9a12-cba93d7d48e7@linaro.org>","Date":"Wed, 6 May 2026 11:10:13 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1 1/2] hw/usb/hcd-ehci: Rename migration compatibility\n fetch address fields","Content-Language":"en-US","To":"Jamin Lin ,\n \"peterx@redhat.com\" ,\n =?utf-8?q?C=C3=A9dric_Le_Goater?= ,\n Peter Maydell ,\n Steven Lee , Troy Lee ,\n Kane Chen ,\n Andrew Jeffery , Joel Stanley ,\n \"open list:ASPEED BMCs\" ,\n \"open list:All patches CC here\" ","Cc":"Troy Lee , \"farosas@suse.de\" ,\n \"flwu@google.com\" ,\n \"nabihestefan@google.com\" ","References":"<20260506032643.2510575-1-jamin_lin@aspeedtech.com>\n <20260506032643.2510575-2-jamin_lin@aspeedtech.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260506032643.2510575-2-jamin_lin@aspeedtech.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32b;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32b.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]