[{"id":3687452,"web_url":"http://patchwork.ozlabs.org/comment/3687452/","msgid":"<20260507104145.ca21edc6e4597b85e8c8b0cb@kernel.org>","list_archive_url":null,"date":"2026-05-07T01:41:45","subject":"Re: [PATCH] sparc64: uprobes: add missing break","submitter":{"id":69037,"url":"http://patchwork.ozlabs.org/api/people/69037/","name":"Masami Hiramatsu (Google)","email":"mhiramat@kernel.org"},"content":"On Tue, 5 May 2026 20:18:15 -0700\nRosen Penev wrote:\n\n> Missing fallthrough causes failure with newer compilers:\n> \n> arch/sparc/kernel/uprobes.c:284:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]\n> 284 | default:\n> | ^\n> arch/sparc/kernel/uprobes.c:284:2: note: insert 'break;' to avoid fall-through\n> 284 | default:\n> | ^\n> | break;\n> \n> Signed-off-by: Rosen Penev \n\nLooks good to me.\n\nReviewed-by: Masami Hiramatsu (Google) \n\n> ---\n> arch/sparc/kernel/uprobes.c | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/arch/sparc/kernel/uprobes.c b/arch/sparc/kernel/uprobes.c\n> index 305017bec164..c8cac64e9988 100644\n> --- a/arch/sparc/kernel/uprobes.c\n> +++ b/arch/sparc/kernel/uprobes.c\n> @@ -280,6 +280,7 @@ int arch_uprobe_exception_notify(struct notifier_block *self,\n> \tcase DIE_SSTEP:\n> \t\tif (uprobe_post_sstep_notifier(args->regs))\n> \t\t\tret = NOTIFY_STOP;\n> +\t\tbreak;\n> \n> \tdefault:\n> \t\tbreak;\n> -- \n> 2.54.0\n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","sparclinux@vger.kernel.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","patchwork-incoming@ozlabs.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=Bj4XLLe/;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=2404:9400:2221:ea00::3; helo=mail.ozlabs.org;\n envelope-from=srs0=qmuf=de=vger.kernel.org=sparclinux+bounces-6762-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)","gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=\"2600:3c0a:e001:db::12fc:5321\"\n arc.chain=subspace.kernel.org","gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","gandalf.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=Bj4XLLe/;\n\tdkim-atps=neutral","gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=sparclinux+bounces-6762-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"Bj4XLLe/\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g9w3J4b2kz1yCg\n\tfor ; Thu, 07 May 2026 11:42:04 +1000 (AEST)","from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4g9w3J3PZJz4wCP\n\tfor ; Thu, 07 May 2026 11:42:04 +1000 (AEST)","by gandalf.ozlabs.org (Postfix)\n\tid 4g9w3J3J9vz4wCX; Thu, 07 May 2026 11:42:04 +1000 (AEST)","from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4g9w3D6QMSz4wCP\n\tfor ; Thu, 07 May 2026 11:42:00 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 367C63013A82\n\tfor ; Thu, 7 May 2026 01:41:49 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 8C4AA25F99F;\n\tThu, 7 May 2026 01:41:48 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 6715123D283;\n\tThu, 7 May 2026 01:41:48 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id A00BAC2BCB0;\n\tThu, 7 May 2026 01:41:46 +0000 (UTC)"],"ARC-Seal":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1778118124; cv=pass;\n\tb=Cc6qand2MoxvHGfk7rXXcd3fDYSd3QEoRddk9EDzXKh/cUtHprH1/lO3j7NxXnQN5UNtZumjoiecDMSZKWdRlhxQLsPi718SBy82OiD2ucuHYKzsogwXhgkLJG24I7FrobXCie0b+85DzWSMxNPc5Unu8YlVyu90KtrsouuCYxoc6Hvl/JSSONRXgjK6iNC/AtUyNauFUWoUWAJnOrxjBMTpX+PRCyenKsO8hqLB1wZLB/RXh7zd/a7RdZZQFg6J6ck6dq7g/zF0KDS/b/fB4aVyDga/7CUvSDCm+BV3jpvQU8aqP6POIW9dmYfIRjc02GVjMKOEhzQDgxk44lpnug==","i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1778118108; cv=none;\n b=C017uQKxDtmDDw8+jwVn6pw8/ERCP00tOMxhUyjs+54e1rkdZeY6/t/7cYDoUigae61X+Lm4n1h1EjPXzgvv1V/kJ8lGgxZBvRu0uKd/7WNoaZVlL5zp0XOUEdQBTBFZrhbdiYiMCOBIhI5TlL07NPO0jAAud4lU85kvcYQh33s="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1778118124; c=relaxed/relaxed;\n\tbh=8R0cEXX7Rw6HTLg48mPiqx4OjZI8HNJX2lW8RApuIkI=;\n\th=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References:\n\t Mime-Version:Content-Type;\n b=Vbyx8pzpw8iSrkHBIexQqMCjW1HQxdxXl6L+PpeCnpMukwSxjNJJQt18MANVrWYh9Xu2LCj3qrBqzBmehc8R9P8WVm1ZakbFZApxltNebU21d/DsXBZi8UIu2zlvo5VLA/y3kAEO7J9OQkL3qKLOm9qnZZMNSeuNOX9DVKoYf+aa3vuUDl/j6u4k+PuXR2lS2ycKlfQerJGLFcjz75p2c00Ph04yzXdG02POz4pIpn7y7GIlaajVPjgJBegYzYdwjGRzY7k/X6LMuxrMcf30QV08HSI4caGOOy4f2L3pqs/sXSjH2PeifM7wHasnItdz4uEyCkbkvcbP2ZPX8c7nIQ==","i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1778118108; c=relaxed/simple;\n\tbh=I3A5cWscMoEuGYe7noxywM4Tzupe8cCfmFvIgdz/SGA=;\n\th=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References:\n\t Mime-Version:Content-Type;\n b=gwTEoSUYVTzythzZ7z44IZKiV53Tbruq9/DLGCjmFYg6D8NloGm+QwlqkMxEBK++ffthdo+WZdYHUuLc7Kdv2KfzjlJvSu9jBdf4lqjwjNDZGJw+BORJdt/j8qfqdKzfoX1MVRmMdhyqM6WZvNyKpc9DWIWF3AaUFfRVHxrabzc="],"ARC-Authentication-Results":["i=2; gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=Bj4XLLe/; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=sparclinux+bounces-6762-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org","i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=Bj4XLLe/; arc=none smtp.client-ip=10.30.226.201"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1778118107;\n\tbh=I3A5cWscMoEuGYe7noxywM4Tzupe8cCfmFvIgdz/SGA=;\n\th=Date:From:To:Cc:Subject:In-Reply-To:References:From;\n\tb=Bj4XLLe/8mgAZLCzPzFAi3j05BHK9TkFjj4TWH4ZAuS+4GKxkfB/X07hPJ4uLILCC\n\t mRhvEiJneZfZn8SIBmoqph96qZhIQi364+FbzEcGuz99TKvVwD/q8PbPvOBtEn98p7\n\t NFMYRNm6i45+B88ECI0s74jxeXv9Xt2LEXYoKU8cnyn2J8Sd6Cu7g64bSfMuCEitro\n\t +DuK3289GvAMhN7OKJmR6dWQ4PJ/RUn2B6BfJsHGqek6j7Y7PynyMhHuaDMHvipSQ/\n\t pOPNbz6ZT3iOaXsAwTXiZkreVxbm4DD9OjJ10G+fuPLwm4EFiXsn9bgf3wERc+YlVy\n\t QEgfRTYRrBYHA==","Date":"Thu, 7 May 2026 10:41:45 +0900","From":"Masami Hiramatsu (Google) ","To":"Rosen Penev ","Cc":"linux-kernel@vger.kernel.org, Masami Hiramatsu ,\n Oleg Nesterov , Peter Zijlstra ,\n \"David S. Miller\" , Andreas Larsson\n , linux-trace-kernel@vger.kernel.org (open\n list:UPROBES), sparclinux@vger.kernel.org (open list:SPARC + UltraSPARC\n (sparc/sparc64))","Subject":"Re: [PATCH] sparc64: uprobes: add missing break","Message-Id":"<20260507104145.ca21edc6e4597b85e8c8b0cb@kernel.org>","In-Reply-To":"<20260506031815.779909-1-rosenp@gmail.com>","References":"<20260506031815.779909-1-rosenp@gmail.com>","X-Mailer":"Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu)","Precedence":"bulk","X-Mailing-List":"sparclinux@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","Mime-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Spam-Status":"No, score=-3.0 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tMAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org"}}]