[{"id":3688908,"web_url":"http://patchwork.ozlabs.org/comment/3688908/","msgid":"<20260509184144.GB11883@quark>","date":"2026-05-09T18:41:44","subject":"Re: [PATCH v2] lib/crypto: powerpc/md5: Drop powerpc optimized MD5\n code","submitter":{"id":74690,"url":"http://patchwork.ozlabs.org/api/people/74690/","name":"Eric Biggers","email":"ebiggers@kernel.org"},"content":"On Tue, May 05, 2026 at 08:00:05PM -0700, Eric Biggers wrote:\n> MD5 is obsolete, is vulnerable to collision attacks, and is being\n> replaced by SHA-256 in new systems. It doesn't make sense to continue\n> to maintain architecture-optimized implementations of MD5. Effort\n> should be spent on modern algorithms.\n> \n> Indeed, architecture-optimized MD5 code remains only for powerpc. It\n> was already removed from mips and sparc, and it never existed for any\n> other architecture (e.g. x86, arm, or arm64) in the first place.\n> Earlier the decision was made to keep the powerpc MD5 code for a while\n> anyway because of someone using it via AF_ALG via libkcapi-hasher\n> (https://lore.kernel.org/r/f0d771d5-ed70-444c-957a-ad4c16f6c115@csgroup.eu/)\n> \n> However, with AF_ALG itself now being on its way out due to its\n> continuous stream of security vulnerabilities\n> (https://lore.kernel.org/r/20260430011544.31823-1-ebiggers@kernel.org/),\n> it's also time to be a bit more forceful with nudging people towards\n> userspace crypto code. It's always been the better solution anyway, and\n> it's much more efficient if properly optimized code is used.\n> \n> Note that the md5-asm.S file contains no privileged instructions and\n> could be run in userspace just fine.\n> \n> Thus, we now have two factors going against keeping the powerpc MD5\n> code. Different people might weigh these two factors differently, but I\n> think the two of them together make the removal the clear choice.\n> \n> Let's remove it.\n> \n> Acked-by: Christophe Leroy (CS GROUP) \n> Acked-by: Ard Biesheuvel \n> Signed-off-by: Eric Biggers \n> ---\n> \n> This patch is intended to be taken via libcrypto-next\n\nApplied to https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=libcrypto-next\n\n- Eric","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=AyJ5rWZI;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20656-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=172.105.4.254","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=AyJ5rWZI;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=ebiggers@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gCZbD5Rg3z1y1d\n\tfor ; Sun, 10 May 2026 04:41:59 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4gCZb95kb0z2xvH;\n\tSun, 10 May 2026 04:41:57 +1000 (AEST)","from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4gCZb833qpz2x9N\n\tfor ; Sun, 10 May 2026 04:41:56 +1000 (AEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id 2315F6024D;\n\tSat, 9 May 2026 18:41:53 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 626DCC2BCB2;\n\tSat, 9 May 2026 18:41:52 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1778352117;\n\tcv=none;\n b=I5Zze7OnbLeLUz0CPMhSyifkdiSxH8EruhThH7GPVISMsSiMkQDvQgNwn29nudMPfbkOQrJyh8RdHHMxhOraAFRY9Dh7dRenNaGjqXUGKgfNwLDglj+HvVPlfCA/V1Hn21NYrsPSfEq4d87x2OCIhTb58ilPl6cnJDBKeiqkRyc1cTY8FQiPAQ3UBUjzJDWwL1h4rHpNVFSGSFZEo6rkDYTGjCTHJXAyL7DrKTuUkeAo0ZBvjwZhlAb0d9wbf01voHJUl/lcquS85Q6YMdwgUHjYZaa2Hq3R+Sbi+JZChUsLmUmgJ3ac0A3yHkv7wCFzBmVCshURbNHzA2MsigV73Q==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1778352117; c=relaxed/relaxed;\n\tbh=WIJ7DfX2k5CGN/qSIl1neCY6LQqrVaz5gRLgzGYqVZA=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=LYYxZKY5H++pw7GIJvlEpgWM4PBIph++XbqAcDxDfM6M+ZH1COrTPCH2X5jJf0sJ4RPcvRGVRNZgkkIl6rQ0mlDrDwE+HefvwoN/8Ws6BTZKICzOEbuTTeumd9KSsILkI3+gxo8yx2mcn4UaHleLjrylXraC4OvD9EEBXHv8h1A2y9UVyKeZug3AUnIzq6f52pLXp6PFCsLYoR1XD8VQBVtBvCL4ZnAnf3QKyyxg/NtUKqkNKiJ0p9KkFnJvn/gUBxu5RHPMFC94+l/wiTrmFiHrYat3cVUZL1UvZE146tI7auDB6qswlDvlD0vojDYuEKLcJEAZeBkuOhvNXIIpnw==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=AyJ5rWZI; dkim-atps=neutral;\n spf=pass (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=ebiggers@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1778352112;\n\tbh=5x6vMZJIgP2JV5U0sf4/3UHVPYatudGhzTthPLFbE1o=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=AyJ5rWZIJlvuab7tohPZ8gd7mvCmDxDNq/R998ABZKL2siI3NOIG5fVudgG+OtgJY\n\t hNTUVyvIvpVN/IQQdxRB0+xP/TMJRVoi4EUtUA9zmVEOnLlC+vDDBS5mNaY7+I/dwr\n\t hznqQ4FgC5RYcm8MWrDvOtf/Pkv/CkE/xcb+X86Cdtdz9lUKt4BxTT5TVtiwSMORdC\n\t ICxc/QlGkB2kaXTTOyXicZiiO/mwafgH6knNICANk6kNsvg+SIaNU+HmB0pF1Ii/hd\n\t e1njZm9xgEXduDH3ASCwWoCuo+GNQ7ZjjCl57klRJMYkkNb3TMaHVz2azJGCgvPWl9\n\t 6IvHRup/FfYXQ==","Date":"Sat, 9 May 2026 11:41:44 -0700","From":"Eric Biggers ","To":"linux-crypto@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, Ard Biesheuvel ,\n\t\"Jason A . Donenfeld\" ,\n\tHerbert Xu ,\n\tlinuxppc-dev@lists.ozlabs.org,\n\tMichael Ellerman ,\n\tMadhavan Srinivasan ,\n\tNicholas Piggin ,\n\tChristophe Leroy ","Subject":"Re: [PATCH v2] lib/crypto: powerpc/md5: Drop powerpc optimized MD5\n code","Message-ID":"<20260509184144.GB11883@quark>","References":"<20260506030005.9698-1-ebiggers@kernel.org>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260506030005.9698-1-ebiggers@kernel.org>","X-Spam-Status":"No, score=-0.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]