[{"id":3686819,"web_url":"http://patchwork.ozlabs.org/comment/3686819/","msgid":"","list_archive_url":null,"date":"2026-05-05T23:28:31","subject":"Re: [PATCH RFC v3 2/2] gpio: s5p: Disable when using upstream DTS","submitter":{"id":90998,"url":"http://patchwork.ozlabs.org/api/people/90998/","name":"Lukas Timmermann","email":"linux@timmermann.space"},"content":"On Wed, May 06, 2026 at 01:13:30AM +0200, Lukas Timmermann wrote:\n> Prevent the older s5p_gpio driver from probing when using upstream DTs\n> because of incompatibilities. pinctrl_exynos5250 driver should be used\n> instead which binds the s5p_gpio for gpio features but replaces pinctrl.\n> \n> Signed-off-by: Lukas Timmermann \n> ---\n> drivers/gpio/s5p_gpio.c | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/drivers/gpio/s5p_gpio.c b/drivers/gpio/s5p_gpio.c\n> index c072f146514..f32c5f7ae1a 100644\n> --- a/drivers/gpio/s5p_gpio.c\n> +++ b/drivers/gpio/s5p_gpio.c\n> @@ -353,7 +353,9 @@ static const struct udevice_id exynos_gpio_ids[] = {\n> \t{ .compatible = \"samsung,s5pc110-pinctrl\" },\n> \t{ .compatible = \"samsung,exynos4210-pinctrl\" },\n> \t{ .compatible = \"samsung,exynos4x12-pinctrl\" },\n> +#if IS_ENABLED(CONFIG_OF_UPSTREAM)\nI just noticed, that this if should be inverted. Will be fixed in the\nnext patch. Sorry for the noise.\n> \t{ .compatible = \"samsung,exynos5250-pinctrl\" },\n> +#endif\n> \t{ .compatible = \"samsung,exynos5420-pinctrl\" },\n> \t{ .compatible = \"samsung,exynos78x0-gpio\" },\n> \t{ }\n> \n> -- \n> 2.54.0\n> \n\nBest regards\n\nLukas Timmermann","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=timmermann.space","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de; dmarc=none (p=none dis=none)\n header.from=timmermann.space","phobos.denx.de;\n spf=pass smtp.mailfrom=linux@timmermann.space"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g9NKS01V4z1y04\n\tfor ; Wed, 06 May 2026 14:52:27 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 147EC847D9;\n\tWed, 6 May 2026 06:52:24 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id F1FAF849D8; Wed, 6 May 2026 01:28:40 +0200 (CEST)","from mout-p-101.mailbox.org (mout-p-101.mailbox.org [80.241.56.151])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 1D9A984996\n for ; Wed, 6 May 2026 01:28:39 +0200 (CEST)","from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4g9F7p4qd2z9v4m;\n Wed, 6 May 2026 01:28:38 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","Date":"Wed, 6 May 2026 01:28:31 +0200","From":"Lukas Timmermann ","To":"Lukas Timmermann , u-boot@lists.denx.de","Cc":"Tom Rini , Simon Glass ,\n Neil Armstrong , Yao Zi ,\n Kory Maincent ,\n Peng Fan , Kuan-Wei Chiu ,\n Raymond Mao ,\n Quentin Schulz ,\n Stefan Roese ,\n Philip Molloy ,\n Jerome Forissier ,\n Kaustabh Chakraborty ,\n Henrik Grimler , Minkyu Kang ","Subject":"Re: [PATCH RFC v3 2/2] gpio: s5p: Disable when using upstream DTS","Message-ID":"","References":"<20260506-pinctrl-exyno5250-v3-0-11649fe82210@timmermann.space>\n <20260506-pinctrl-exyno5250-v3-2-11649fe82210@timmermann.space>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260506-pinctrl-exyno5250-v3-2-11649fe82210@timmermann.space>","X-Mailman-Approved-At":"Wed, 06 May 2026 06:52:22 +0200","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]