[{"id":3686682,"web_url":"http://patchwork.ozlabs.org/comment/3686682/","msgid":"<a0492f90-cb96-4a79-ab93-680b1cbd7b7d@oss.qualcomm.com>","list_archive_url":null,"date":"2026-05-05T20:17:06","subject":"Re: [PATCH] net: mark struct ip6_header as QEMU_PACKED","submitter":{"id":93152,"url":"http://patchwork.ozlabs.org/api/people/93152/","name":"Pierrick Bouvier","email":"pierrick.bouvier@oss.qualcomm.com"},"content":"On 5/5/2026 1:13 PM, Peter Maydell wrote:\n> The ip6_header is often used by network devices to examine structures in\n> packet data, and it's not guaranteed to be aligned. This manifests as\n> errors from the clang sanitizer like this one:\n> \n> SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../../hw/net/rocker/rocker_of_dpa.c:321:37\n> ../../hw/net/rocker/rocker_of_dpa.c:730:33: runtime error: member access within misaligned address 0x742970fe7ecd for type 'struct ip6_header', which requires 4 byte alignment\n> 0x742970fe7ecd: note: pointer points here\n>  00 00 02 81 00 60 00  00 00 00 38 3a ff fe 80  00 00 00 00 00 00 00 00  00 00 00 00 00 02 ff 02  00\n>              ^\n> \n> Fix this by marking the ip6_header struct as QEMU_PACKED, the way we\n> have done to handle similar problems involving tcp_header, ip_header,\n> etc.\n> \n> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>\n> ---\n> Found this one while I was working on a rocker bug.\n> \n>  include/net/eth.h | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n\nReviewed-by: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=QaXJ5N/j;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=hZRRyzDj;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g98vR57Ttz1yJ0\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 06 May 2026 06:17:39 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wKMCh-0006tH-Hx; Tue, 05 May 2026 16:17:15 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pierrick.bouvier@oss.qualcomm.com>)\n id 1wKMCg-0006sm-3B\n for qemu-devel@nongnu.org; Tue, 05 May 2026 16:17:14 -0400","from mx0a-0031df01.pphosted.com ([205.220.168.131])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pierrick.bouvier@oss.qualcomm.com>)\n id 1wKMCe-00082O-8B\n for qemu-devel@nongnu.org; Tue, 05 May 2026 16:17:13 -0400","from pps.filterd (m0279866.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 645IoCs12187253\n for <qemu-devel@nongnu.org>; Tue, 5 May 2026 20:17:10 GMT","from mail-dy1-f198.google.com (mail-dy1-f198.google.com\n [74.125.82.198])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dygce1ytr-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for <qemu-devel@nongnu.org>; Tue, 05 May 2026 20:17:09 +0000 (GMT)","by mail-dy1-f198.google.com with SMTP id\n 5a478bee46e88-2efc342ef15so4545110eec.1\n for <qemu-devel@nongnu.org>; Tue, 05 May 2026 13:17:09 -0700 (PDT)","from [192.168.1.170] (216-71-219-44.dyn.novuscom.net.\n [216.71.219.44]) by smtp.gmail.com with ESMTPSA id\n a92af1059eb24-131f9679dc4sm344456c88.3.2026.05.05.13.17.07\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Tue, 05 May 2026 13:17:07 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n cc:content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n g62WWP5yLXXyA6PV/IbyWqXiSw02/pxJiAzTHHxXZ4I=; b=QaXJ5N/jFvhRrlEm\n 5nvRI9QgcTLdR++8YCeXbuVimlqMh9egL03cE1i1SDBilKnGUzxcWEhcJl4dVL2U\n ALIO6Ys7et3lTu/3LLh7lt5qAbW8etPWqSHan8GPTlE40ReRW0j+EhYdTOb+17zp\n 5aNarGWfTfT0RyNTreHSdK3G5V0htx3pPqPDPuJz9doz5pgn6rliRVw6ETo3pwUY\n 2biPiqzUO/bBXeoTOwJYfIOj/yfceRZzT1XJ2gPkx2H2+anDjPxqog5/0LSPwxQB\n y8CkBpx3ty88WdJ2GR345BllzYz0nuCjDCoic+eTTtOa3jmkQs2x40gZ2u5iK3wv\n YKZzaA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1778012229; x=1778617029; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=g62WWP5yLXXyA6PV/IbyWqXiSw02/pxJiAzTHHxXZ4I=;\n b=hZRRyzDjnBPBc+5d2j6n5N4DAGYS5l7YelqEq77qZb2aEIXyRoO+BFJZy/pyMYT/Wz\n LBOGFbY42DO43UmhRivOVjuv71G5CEdB4nCR16QJx6qMQJeCXR3XyCzNMF8iUPARm0GM\n 71TrOD7xksImINjj4vDcZa6OETI9BQwO4N6hinNX+3xOw97M6eoHEHSSDZfcSQy1F+5Q\n 45rmhVmNLt3nSThSmNMn6jMUxkEcWb0pGI2oNyRhotnMJArmt1Y067vkdlwed7F8o4xY\n 6blnnCnA5Be5ENLgrGpkS9L4F5YOFPgjeZKvUANeU/lGlZ9PoYGqFC1F6DDf3zUY7f0g\n xZtQ=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778012229; x=1778617029;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=g62WWP5yLXXyA6PV/IbyWqXiSw02/pxJiAzTHHxXZ4I=;\n b=WFg687ky9WB5BdTU2cl/mZPrNADZFah8zuKmc/n3omvI9MkaDNwSYxSOkRrHxsslOZ\n iSeLv19/JoKFkjrw+1joSv8Wg47JOIWU3Ec3IfzZG9uWS/Fw1hg5MgPPCpJdkTBBSqxu\n c2dljcWjljT/ZTro0c7cfRoS7yLWCpa6dOt+wKaENMQv3CmE1qPTafvI1L6eY8TEYJpq\n lAHgnR/FMwZFerziMvX8TdjaT8lce5iaTbnPM3qbQu9ElcZYDr/lFZJbvSCzL8n2lMAb\n 4/lskT8VrCctvNZseTRn19LMKFuExRQS4P/w8MQm1MOeSSdYC0gUXZ68Wq0pJRqT0bc1\n wSag==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+5tCOhG/LgLtnoHMoZdOMraUIOiL+zT8YhErJ164g3pywh8W/I/uUya5SUaTF2weh5dweq7NlpGX1r@nongnu.org","X-Gm-Message-State":"AOJu0Yw0YlSfxeLPa1WUKQUCwDyqeKQcprRXu72mzwphfjUc7mLC1wX8\n 5RtMXP6JCNs6AiwZcrZFBUDBgndDPYbKQGORPj1E1lyeu/O2SYHqPW1WWawXXRxukGON+oZas9R\n lOKbq76I2Cl3jT85nwbkwkSlt5v0JX4iOxsCwXl+Y4LQpgjwksz+VoEAT1w==","X-Gm-Gg":"AeBDieslLX8D1rIBmG5jmY0+HQmYq943cEouypFn1ecLeZrtvz7RfnpqEpMfDZPPIzD\n iKmDiLj850etqNtT1TBYX8CT6uze/sXqmiuT4idYDJ1vTeWke4+TqZtmX7cRnlOQzs795c6qktx\n bVCMRXG07ooIEUzU/Ps4CfnxPY8Gg22F7xsleCs4aUmJn/0eOQImm3Ljlzv59kol13ETrDhgXN3\n 8hEbKgaMTfiy7gWsNJ9w8ksbkbiPl4OqoNi8oTp0E35ZHBBEphn9+G09VKnFHNshMn6VI7VEz/e\n ysWcMzieFfU4z4m41CKRXWtWcRoXPYau/LL0FMnnhtHPV8/koGsQ8yyRj8n46js+/5ozUQTEtP0\n ZhOYMA69Fl5ee9jUxJF4NqYu1lj6SpKesp/pFG4bMIEm0AbdEwu6vW4+CSCHD6S8gM1ZJ+0ALkR\n FV1qGj4JFKnnSMsChnyfGUC61w","X-Received":["by 2002:a05:7022:5f11:b0:12d:c1eb:3bb6 with SMTP id\n a92af1059eb24-131967d7b8fmr197949c88.8.1778012229188;\n Tue, 05 May 2026 13:17:09 -0700 (PDT)","by 2002:a05:7022:5f11:b0:12d:c1eb:3bb6 with SMTP id\n a92af1059eb24-131967d7b8fmr197930c88.8.1778012228435;\n Tue, 05 May 2026 13:17:08 -0700 (PDT)"],"Message-ID":"<a0492f90-cb96-4a79-ab93-680b1cbd7b7d@oss.qualcomm.com>","Date":"Tue, 5 May 2026 13:17:06 -0700","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] net: mark struct ip6_header as QEMU_PACKED","To":"Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org","Cc":"Dmitry Fleytman <dmitry.fleytman@gmail.com>,\n Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>,\n Jason Wang <jasowang@redhat.com>","References":"<20260505201324.932323-1-peter.maydell@linaro.org>","From":"Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>","Content-Language":"en-US","In-Reply-To":"<20260505201324.932323-1-peter.maydell@linaro.org>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNTA1MDE5NyBTYWx0ZWRfX4OCoybyStNhd\n t3zTJXT1MqAQmyyiF9/3XhyXg0ZHcpUoMqRodoAvyFLxA9ZTW2Bp5WqDYmRudcGgt0A8zWg3JTt\n N61euZA7Dzr2mrxuWQsvmyKDy9mjtdv4LOvpSldLYTtp6bek2PG9rUs06P6G9RUc5OVhSKyOaMM\n 2gfBd5MYVJmbvQJY4XYdMAnR71vef/DOCp3KQHgVm3+ylacJVMIV5VSp+ApWEqVsbffhLkAjpm9\n J+ZiUxhjUYhhVSzfJgG3AgqfvUdO61T60/d2GsAKT5IcwDn9DLSZWvW6aJO7IZd0/Oyl4bxlY2k\n ymFzaY4wywYSust3ePkC6u0jCRpCAp3ELGMLweBbY5XhjJ746s+O9yzTIg49QvQpqGndccUYrVg\n GK5pUCcXNX0JY4EA3JsfYVdCjl+hH3T6q//XEx4dt3yd+ljpIFfWqHdt/6x6Bry3Hwa+6UQGZRW\n mQWo1r9m9Mh3qoLf2HA==","X-Proofpoint-GUID":"4cWoUffxukfCbTPO1kik9VB8HET_NA2c","X-Proofpoint-ORIG-GUID":"4cWoUffxukfCbTPO1kik9VB8HET_NA2c","X-Authority-Analysis":"v=2.4 cv=b6KCJNGx c=1 sm=1 tr=0 ts=69fa5045 cx=c_pps\n a=wEP8DlPgTf/vqF+yE6f9lg==:117 a=iLqgmErQAxjCjdq5jj1Aqg==:17\n a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22\n a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=wbSR7ExuzqgWBqXGAcYA:9 a=QEXdDO2ut3YA:10\n a=bBxd6f-gb0O0v-kibOvt:22 a=cvBusfyB2V15izCimMoJ:22","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-05-05_02,2026-04-30_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n bulkscore=0 phishscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0\n priorityscore=1501 suspectscore=0 clxscore=1015 malwarescore=0 spamscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605050197","Received-SPF":"pass client-ip=205.220.168.131;\n envelope-from=pierrick.bouvier@oss.qualcomm.com;\n helo=mx0a-0031df01.pphosted.com","X-Spam_score_int":"-27","X-Spam_score":"-2.8","X-Spam_bar":"--","X-Spam_report":"(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3686876,"web_url":"http://patchwork.ozlabs.org/comment/3686876/","msgid":"<fd8b3cbc-165b-444a-8acb-958b5e04f51e@linaro.org>","list_archive_url":null,"date":"2026-05-06T08:28:52","subject":"Re: [PATCH] net: mark struct ip6_header as QEMU_PACKED","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 5/5/26 22:13, Peter Maydell wrote:\n> The ip6_header is often used by network devices to examine structures in\n> packet data, and it's not guaranteed to be aligned. This manifests as\n> errors from the clang sanitizer like this one:\n> \n> SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../../hw/net/rocker/rocker_of_dpa.c:321:37\n> ../../hw/net/rocker/rocker_of_dpa.c:730:33: runtime error: member access within misaligned address 0x742970fe7ecd for type 'struct ip6_header', which requires 4 byte alignment\n> 0x742970fe7ecd: note: pointer points here\n>   00 00 02 81 00 60 00  00 00 00 38 3a ff fe 80  00 00 00 00 00 00 00 00  00 00 00 00 00 02 ff 02  00\n>               ^\n> \n> Fix this by marking the ip6_header struct as QEMU_PACKED, the way we\n> have done to handle similar problems involving tcp_header, ip_header,\n> etc.\n> \n> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>\n> ---\n> Found this one while I was working on a rocker bug.\n> \n>   include/net/eth.h | 2 +-\n>   1 file changed, 1 insertion(+), 1 deletion(-)\n\nReviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=mZcV+xvr;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g9T7n1BDYz1y04\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 06 May 2026 18:29:25 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wKXcp-0005TE-Uv; Wed, 06 May 2026 04:28:59 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wKXco-0005T1-Dj\n for qemu-devel@nongnu.org; Wed, 06 May 2026 04:28:58 -0400","from mail-wm1-x336.google.com ([2a00:1450:4864:20::336])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wKXcm-0003R2-Ri\n for qemu-devel@nongnu.org; Wed, 06 May 2026 04:28:58 -0400","by mail-wm1-x336.google.com with SMTP id\n 5b1f17b1804b1-488b3f8fa2bso5981195e9.1\n for <qemu-devel@nongnu.org>; Wed, 06 May 2026 01:28:56 -0700 (PDT)","from [192.168.69.210] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48e53826022sm32572575e9.0.2026.05.06.01.28.53\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 06 May 2026 01:28:53 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1778056135; x=1778660935; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=dj/sJn/cCNciG3g6jaqaADtqvlnQaV0hsMfSHiNUHzY=;\n b=mZcV+xvr/7g35kFw+hA/eGuAgCrtMfyCtX5jtgKEYIT3qRpmzJj0rVlwBSb20+82oA\n LLoyQgU2hFsK6h6T7Yh3IfkJJmpaG6ljhIX4M+b50hVJFPJJN41zE6aPBsvCciRSNUFn\n kN0vpFcY4GcmKhuEmZ2o/61n2r2UXBakSDsi95rUhvT5uSgScex7rdwC6c+ERISjfZqH\n meBlibT6F+Trcb5xhVjDmh/Q5akSA+wDNUbRUbrmM5Wfkz4WEiYdMUFVXBwhS49wPuwu\n BT9oT+A0FAXSyY9vaQ8CPQkL3u1twUky6mYKDsUv/8fpnQzBT37u7eTlMLu2THSi+MWD\n lC9Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778056135; x=1778660935;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=dj/sJn/cCNciG3g6jaqaADtqvlnQaV0hsMfSHiNUHzY=;\n b=PIjKvjZNKlxaRPzHkDyXId9yQ6eqjWT+uDx4A98gzPuaY/0VTiRnRw+9B9ShUG9MF7\n AhMdYEcdBoCVOA5GgF20ySm8Jhqcfznv3O0IgjNKAjyAsD1Ek03Q/v9FhCd/DT6UrEck\n MfmR2NQA3hKjkMHkp8WlOTQUDpj1fithAyGJVeJs38zIVvp2GmYJJH97g8SNG4t+OSsr\n CKvXtbYfsFGEXGyEBtdbv8B1Dyut/Kj7b22CsdzSEuq6TISzmEERcWA0bFm4bcKHrWef\n KOARcytRpW6PC+ctQb4HGUnWG6IIX7EK2jmrlUTLS85X8UrPk2UGkSFxQM94HOoAwoKU\n 1/6g==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+aF+EO1ARtzOoxbxSzFB77webbZoRTEOXkMjDnv70/eFLvuxavRS5wIdhwEW4/8WVzoZVGpq2XcHTe@nongnu.org","X-Gm-Message-State":"AOJu0Yyr80fN0y8H9VL8e+BurZ2GWzoJ65/Spmb1Ft3AiS7mzYKzpjR+\n Nn6udI/cil7hFH1bWief3Lx6I4RwdK/QovwmGlbs6LMFABsS63o+dMr235XS1kg6rQw=","X-Gm-Gg":"AeBDieuNB7cm/ppsH9zY1z/FE9HjBniZI6yDAamHUVjVliYzkKFX/QX9dVy2ldG/tPd\n 2slBLv52ZhCPwHMYBIMGRtD8wkbsGzinOS7plV+9+fVUoDAEB+SFsRMA5xobX7CamcAhW4hzkmO\n bWNjoQGxhC4cEiyemELZr+ki7oY3WeNjEAuYmFT0uezCQi2tH1tPMx9AVnGgQoq0qTToFrIbZSp\n SCrxYOIJgSUW/cmC0XvPFB4377IYMQ6FyHMFJ2mBDj/vKXlC8FDVr3sf2FLIluJ7cEuUlxhdj3w\n xVEU7ou9+bFm5vgRwNHY3xysD3dviXiKGTDVYOZ3GIfyH+2a3OH/CM+z93g0w7KeTSJb792WtEm\n GYK+TXFLc/rrZ6kKnyLBzqu4LmIPV4I7qkdStrg+WHmk9fE5NCHHBuLkzqeQX4rE6LoJNLCMZMn\n LcEMHwXx0gYqY0RyUwQys1pENM5QTh5LMK41H8ZgtjzfhnBg6DhwEKVdB3P8UyUwvlmTKkk0YQU\n o/B","X-Received":"by 2002:a05:600c:a10d:b0:48a:534a:eed8 with SMTP id\n 5b1f17b1804b1-48e5226be99mr24157365e9.1.1778056134919;\n Wed, 06 May 2026 01:28:54 -0700 (PDT)","Message-ID":"<fd8b3cbc-165b-444a-8acb-958b5e04f51e@linaro.org>","Date":"Wed, 6 May 2026 10:28:52 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] net: mark struct ip6_header as QEMU_PACKED","Content-Language":"en-US","To":"Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org","Cc":"Dmitry Fleytman <dmitry.fleytman@gmail.com>,\n Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>,\n Jason Wang <jasowang@redhat.com>","References":"<20260505201324.932323-1-peter.maydell@linaro.org>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>","In-Reply-To":"<20260505201324.932323-1-peter.maydell@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::336;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x336.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3687814,"web_url":"http://patchwork.ozlabs.org/comment/3687814/","msgid":"<0794f07a-0f71-4891-a1a3-5a2cabb4e7a5@linaro.org>","list_archive_url":null,"date":"2026-05-07T13:35:30","subject":"Re: [PATCH] net: mark struct ip6_header as QEMU_PACKED","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 5/5/26 22:13, Peter Maydell wrote:\n> The ip6_header is often used by network devices to examine structures in\n> packet data, and it's not guaranteed to be aligned. This manifests as\n> errors from the clang sanitizer like this one:\n> \n> SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../../hw/net/rocker/rocker_of_dpa.c:321:37\n> ../../hw/net/rocker/rocker_of_dpa.c:730:33: runtime error: member access within misaligned address 0x742970fe7ecd for type 'struct ip6_header', which requires 4 byte alignment\n> 0x742970fe7ecd: note: pointer points here\n>   00 00 02 81 00 60 00  00 00 00 38 3a ff fe 80  00 00 00 00 00 00 00 00  00 00 00 00 00 02 ff 02  00\n>               ^\n> \n> Fix this by marking the ip6_header struct as QEMU_PACKED, the way we\n> have done to handle similar problems involving tcp_header, ip_header,\n> etc.\n> \n> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>\n> ---\n\nQueued via hw-misc, thanks.","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=QJfmfp8s;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBCtt1sSYz1yCg\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 07 May 2026 23:35:50 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wKyt7-0004m6-JZ; Thu, 07 May 2026 09:35:37 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wKyt5-0004kq-Sw\n for qemu-devel@nongnu.org; Thu, 07 May 2026 09:35:36 -0400","from mail-wr1-x434.google.com ([2a00:1450:4864:20::434])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wKyt4-0001p1-73\n for qemu-devel@nongnu.org; Thu, 07 May 2026 09:35:35 -0400","by mail-wr1-x434.google.com with SMTP id\n ffacd0b85a97d-448528f4e69so585200f8f.3\n for <qemu-devel@nongnu.org>; Thu, 07 May 2026 06:35:33 -0700 (PDT)","from [192.168.69.200] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-4505558e213sm21543079f8f.25.2026.05.07.06.35.30\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 07 May 2026 06:35:31 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1778160932; x=1778765732; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=XlFCmk+1a9NiMbuSot6Ixj5tJUD0mRJsa4cXyaZiYMo=;\n b=QJfmfp8sCmlRaIOorcTLk3+eAj6pHCARsOFMzOlcZIV2lu6xkxbKE0cKuB5odAwshn\n pWqZA+xt/V6XziX3fx4r+Cx0bkrKx86kZmWVMq/JYGFglW03PzecCjHDOcSVu4o7NlfT\n zHQyRUNC91+d5FYsGb/qIJ0leXRNyjgmb1ov8R30Nd+0ep9rPZbr9QVN+u/9J1v7QkkE\n lg4exPKwaQ+Xm8G4SYYsquhnMKY1Wlt0I1mEheUf5+ht78vlYOO6x1rQC+nyTIP7EEeZ\n oCILZwQQJFycPshC/yZ2Q9h2oecZcaog2FSbXNSEHW1qDIHzR6WdXUeRHFl3hlY7jQEf\n AgfA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778160932; x=1778765732;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=XlFCmk+1a9NiMbuSot6Ixj5tJUD0mRJsa4cXyaZiYMo=;\n b=tI7JRZ6J5k+8rVQZJ9GiEIe6CcVHDU7xJBw/2oi8V4qKERy+4IPayMU2q23JLUcbrf\n oiwmYcehJdaCMf/0ssfPqKTdMbhnM+SD+WZXkl//4tL8l1OFpeaZcAkKf3bVPhZbkMdg\n w2daPMIo0yH3xdXkGfIUVpK2Tw4YFVMJYJB1guhZXOKFbFDekeSssZwFZMyeuyzJ3gQ3\n cRBDRzESxBIx9bUH/9FrTm/2RMho/b9FyvMgxxNuJ+24rvWweZbB+bDEuhHjWmbgd1CL\n pVyR74mI4P7vUtjejOkP9EwMrYd/j07NNrhQQO+rPo++v9ceuEw6i1b7rAo+B1d5/ERt\n MP5g==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/j11TAkFISQfdUllVI6hHPFzapADi6+yPLC78iYiguSbGGqxGSLSkD1PH+Bv1FVezurUVIwiH5HuwX@nongnu.org","X-Gm-Message-State":"AOJu0Yz5RR9JKQBrKpV0HwyeZLOUwBfpCwNbexslTNuSyMD9Libhh5L6\n Z+kQPhLc04ymmpTrykEeRfh5aIJCZDi/nfmxDRykE6f96/RlFeqwwkDSTVB2nXye9mM=","X-Gm-Gg":"AeBDievHaCb3r+kxBiUEns0uDsBtY9ZlME9yaQHtDN0ngZHta06Zi/8zjX+0J5VOCzF\n btzyRoRNZKSpy4hV2wCbjWg8izJm44SSTRvnBHBOH0O5U6qRn3D45DVkAv6Yqqp0FbXiWGeCsVM\n 6Kd0BlYY9gaMZsnsjUYsGITPgOBfxrQ/bclcXkItnDxi9A2MUfKzZiF/KZLCyGlETgJ+03uAy3k\n vZOgQUc6lk2a9OTPnn0FvNiWWhZLMfYK2qyEFUBsk9Dxo3xvaHTDq+t1Z42Kzis/xt3MKxZpCbB\n wOpFiCty3wIEFEM/LaF/arKahlQCOLGdgHOBlz9JVDbUo15hL3DKV4D6vRTUpamhASF9Gar859C\n LKgy0vS9IQ69s1K453JY8E9NOSWxr8PbWc+ytPqP77QtKnQBu35BpZMBTzpGuZD4/TcMagMag2n\n tG9qBVbTYCrX80m1VKWfruWoBU0Qn00lLkSu30Yixs2pjlCh/rfGOpLkOGFVSMe1IPrFfnW+NAU\n geskNdJSLJSQWc=","X-Received":"by 2002:a05:6000:1acd:b0:441:2473:c30a with SMTP id\n ffacd0b85a97d-4515d5c561cmr12917120f8f.31.1778160931758;\n Thu, 07 May 2026 06:35:31 -0700 (PDT)","Message-ID":"<0794f07a-0f71-4891-a1a3-5a2cabb4e7a5@linaro.org>","Date":"Thu, 7 May 2026 15:35:30 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] net: mark struct ip6_header as QEMU_PACKED","Content-Language":"en-US","To":"Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org","Cc":"Dmitry Fleytman <dmitry.fleytman@gmail.com>,\n Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>,\n Jason Wang <jasowang@redhat.com>","References":"<20260505201324.932323-1-peter.maydell@linaro.org>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>","In-Reply-To":"<20260505201324.932323-1-peter.maydell@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::434;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x434.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]