[{"id":3687121,"web_url":"http://patchwork.ozlabs.org/comment/3687121/","msgid":"","list_archive_url":null,"date":"2026-05-06T14:31:59","subject":"Re: [PATCH v2 2/7] accel/mshv: move vcpu arch specific\n initialization after vcpu creation","submitter":{"id":90753,"url":"http://patchwork.ozlabs.org/api/people/90753/","name":"Magnus Kulke","email":"magnuskulke@linux.microsoft.com"},"content":"On Tue, May 05, 2026 at 09:50:23PM +0300, Doru Blânzeanu wrote:\n> Call mshv_arch_init_vcpu after the vcpu is created to ensure a valid\n> vcpu fd.\n> \n> Signed-off-by: Doru Blânzeanu \n> ---\n> accel/mshv/mshv-all.c | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/accel/mshv/mshv-all.c b/accel/mshv/mshv-all.c\n> index 58af674bd9..e3da583f21 100644\n> --- a/accel/mshv/mshv-all.c\n> +++ b/accel/mshv/mshv-all.c\n> @@ -415,13 +415,14 @@ static int mshv_init_vcpu(CPUState *cpu)\n> int ret;\n> \n> cpu->accel = g_new0(AccelCPUState, 1);\n> - mshv_arch_init_vcpu(cpu);\n> \n> ret = mshv_create_vcpu(vm_fd, vp_index, &cpu->accel->cpufd);\n> if (ret < 0) {\n> return -1;\n> }\n> \n> + mshv_arch_init_vcpu(cpu);\n> +\n> cpu->accel->dirty = true;\n> \n> return 0;\n> -- \n> 2.53.0\n\nReviewed-by: Magnus Kulke ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linux.microsoft.com header.i=@linux.microsoft.com\n header.a=rsa-sha256 header.s=default header.b=Vg4q+ZMu;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g9dBj5mbLz1yJq\n\tfor ; Thu, 07 May 2026 00:32:28 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wKdIG-0007MZ-0N; Wed, 06 May 2026 10:32:08 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wKdIE-0007MR-MG\n for qemu-devel@nongnu.org; Wed, 06 May 2026 10:32:06 -0400","from linux.microsoft.com ([13.77.154.182])\n by eggs.gnu.org with esmtp (Exim 4.90_1)\n (envelope-from ) id 1wKdID-000755-7l\n for qemu-devel@nongnu.org; Wed, 06 May 2026 10:32:06 -0400","from example.com (unknown [167.220.208.68])\n by linux.microsoft.com (Postfix) with ESMTPSA id CF18020B7165;\n Wed, 6 May 2026 07:31:59 -0700 (PDT)"],"DKIM-Filter":"OpenDKIM Filter v2.11.0 linux.microsoft.com CF18020B7165","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1778077921;\n bh=fyq/JxdQvoF3z9WV8cI9DpjY5SUAMnRCXMqXKlQIc8Q=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=Vg4q+ZMuI5z2thq7m5VfkOpQ26KjXJIPRntArZn8mEQPDiQ1qcClTExuv3KWLr/VD\n 6fQ7C9YTzegP7E6PpFH70PVuFv6NP4ejaxavI7fpK5/I0r7ts+GEssPgYRncy79sw9\n BVo+XgsstGHv8TeViPbnshCHbKVWN7nZBIoDalig=","Date":"Wed, 6 May 2026 16:31:59 +0200","From":"Magnus Kulke ","To":"Doru =?iso-8859-1?q?Bl=E2nzeanu?= ","Cc":"qemu-devel@nongnu.org, Zhao Liu ,\n Wei Liu , Paolo Bonzini ","Subject":"Re: [PATCH v2 2/7] accel/mshv: move vcpu arch specific\n initialization after vcpu creation","Message-ID":"","References":"<20260505185028.237207-1-dblanzeanu@linux.microsoft.com>\n <20260505185028.237207-3-dblanzeanu@linux.microsoft.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260505185028.237207-3-dblanzeanu@linux.microsoft.com>","Received-SPF":"pass client-ip=13.77.154.182;\n envelope-from=magnuskulke@linux.microsoft.com; helo=linux.microsoft.com","X-Spam_score_int":"-19","X-Spam_score":"-2.0","X-Spam_bar":"--","X-Spam_report":"(-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3687789,"web_url":"http://patchwork.ozlabs.org/comment/3687789/","msgid":"<20260507-tacky-sweet-stoat-cdaa43@anirudhrb>","list_archive_url":null,"date":"2026-05-07T13:12:50","subject":"Re: [PATCH v2 2/7] accel/mshv: move vcpu arch specific\n initialization after vcpu creation","submitter":{"id":78917,"url":"http://patchwork.ozlabs.org/api/people/78917/","name":"Anirudh Rayabharam","email":"anirudh@anirudhrb.com"},"content":"On Tue, May 05, 2026 at 09:50:23PM +0300, Doru Blânzeanu wrote:\n> Call mshv_arch_init_vcpu after the vcpu is created to ensure a valid\n> vcpu fd.\n> \n> Signed-off-by: Doru Blânzeanu \n> ---\n> accel/mshv/mshv-all.c | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/accel/mshv/mshv-all.c b/accel/mshv/mshv-all.c\n> index 58af674bd9..e3da583f21 100644\n> --- a/accel/mshv/mshv-all.c\n> +++ b/accel/mshv/mshv-all.c\n> @@ -415,13 +415,14 @@ static int mshv_init_vcpu(CPUState *cpu)\n> int ret;\n> \n> cpu->accel = g_new0(AccelCPUState, 1);\n> - mshv_arch_init_vcpu(cpu);\n> \n> ret = mshv_create_vcpu(vm_fd, vp_index, &cpu->accel->cpufd);\n> if (ret < 0) {\n> return -1;\n> }\n> \n> + mshv_arch_init_vcpu(cpu);\n> +\n> cpu->accel->dirty = true;\n> \n> return 0;\n> -- \n> 2.53.0\n> \n> \n\nReviewed-by: Anirudh Rayabharam (Microsoft) ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=anirudhrb.com header.i=anirudh@anirudhrb.com\n header.a=rsa-sha256 header.s=zoho header.b=pLZLjB6d;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBCP95RqLz1yKd\n\tfor ; Thu, 07 May 2026 23:13:32 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wKyXM-0005N3-3M; Thu, 07 May 2026 09:13:08 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wKyXL-0005Mj-0k\n for qemu-devel@nongnu.org; Thu, 07 May 2026 09:13:07 -0400","from sender4-of-o54.zoho.com ([136.143.188.54])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wKyXJ-0004Om-Mk\n for qemu-devel@nongnu.org; Thu, 07 May 2026 09:13:06 -0400","by mx.zohomail.com with SMTPS id 1778159575066423.3317597299491;\n Thu, 7 May 2026 06:12:55 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; t=1778159578; cv=none;\n d=zohomail.com; s=zohoarc;\n b=JR8NN6Uo7P3nrfQGZoo3s9bzpv+krRXLIb9eQy2Tye5QTNje9zGtMACwK/NlURWvNXrwdJ5ByYCdqwJKU0661oGRjOt9F3JQljD6MsbnuIjpayl91u7ouGmQoaDXd4jiVFmDDvdOsIGkOk5n1lCtMOAu25uOx2rhInkdnCcwncI=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;\n s=zohoarc; t=1778159578;\n h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;\n bh=S0WSjeIVJ0KX1fuzrXbx8wuMlUjbRumButsjVGNqxCY=;\n b=QBeYDQrswpPA1AO94a3ei1py1UEU1a2To9DCV+xB+FbGceFByqyN4DIl+KUiOFLrZ6ZBbOHXRkZJW1I0mpmBExpuJE4qx4e4j6OyYY3/OdNVCTfRQOP3k8NTEoH8O/nbemGyDo4FxiMJtb5vJnoajvV9V12v+NqDQCZGT0GwIDo=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n dkim=pass header.i=anirudhrb.com;\n spf=pass smtp.mailfrom=anirudh@anirudhrb.com;\n dmarc=pass header.from=","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1778159578;\n s=zoho; d=anirudhrb.com; i=anirudh@anirudhrb.com;\n h=Date:Date:From:From:To:To:Cc:Cc:Subject:Subject:Message-ID:References:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To:Message-Id:Reply-To;\n bh=S0WSjeIVJ0KX1fuzrXbx8wuMlUjbRumButsjVGNqxCY=;\n b=pLZLjB6dw7jla1fVoEnM00956818Ok98xyJUVoBj5YRzwCDyN4MPaU+Pe1rzOx8z\n nATJ/EInBK3dPgD9oTJmnEsQhXgbmRROitUwMVt+aTc2kBlY9nd/lZ+3FTBpe0RS5bi\n ckjrPuHrv2YDm/7sy0VeVioc2V2vctP7UMTO6QUc=","Date":"Thu, 7 May 2026 13:12:50 +0000","From":"Anirudh Rayabharam ","To":"Doru =?iso-8859-1?q?Bl=E2nzeanu?= ","Cc":"qemu-devel@nongnu.org, Magnus Kulke ,\n Zhao Liu , Wei Liu ,\n Paolo Bonzini ","Subject":"Re: [PATCH v2 2/7] accel/mshv: move vcpu arch specific\n initialization after vcpu creation","Message-ID":"<20260507-tacky-sweet-stoat-cdaa43@anirudhrb>","References":"<20260505185028.237207-1-dblanzeanu@linux.microsoft.com>\n <20260505185028.237207-3-dblanzeanu@linux.microsoft.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260505185028.237207-3-dblanzeanu@linux.microsoft.com>","X-ZohoMailClient":"External","Received-SPF":"pass client-ip=136.143.188.54;\n envelope-from=anirudh@anirudhrb.com; helo=sender4-of-o54.zoho.com","X-Spam_score_int":"-16","X-Spam_score":"-1.7","X-Spam_bar":"-","X-Spam_report":"(-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1,\n DKIM_SIGNED=0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]