[{"id":3686955,"web_url":"http://patchwork.ozlabs.org/comment/3686955/","msgid":"","list_archive_url":null,"date":"2026-05-06T10:34:22","subject":"Re: [PATCH v2 1/7] target/i386/mshv: remove duplicate function for\n reading vcpu registers","submitter":{"id":90753,"url":"http://patchwork.ozlabs.org/api/people/90753/","name":"Magnus Kulke","email":"magnuskulke@linux.microsoft.com"},"content":"On Tue, May 05, 2026 at 09:50:22PM +0300, Doru Blânzeanu wrote:\n> Remove function `fetch_guest_state` because it is a duplicate function\n> of `mshv_load_regs` function.\n> \n> Signed-off-by: Doru Blânzeanu \n> ---\n> target/i386/mshv/mshv-cpu.c | 21 +--------------------\n> 1 file changed, 1 insertion(+), 20 deletions(-)\n> \n> diff --git a/target/i386/mshv/mshv-cpu.c b/target/i386/mshv/mshv-cpu.c\n> index 4ed6e7548f..9defd05db6 100644\n> --- a/target/i386/mshv/mshv-cpu.c\n> +++ b/target/i386/mshv/mshv-cpu.c\n> @@ -1291,25 +1291,6 @@ static int handle_pio_non_str(const CPUState *cpu,\n> return 0;\n> }\n> \n> -static int fetch_guest_state(CPUState *cpu)\n> -{\n> - int ret;\n> -\n> - ret = mshv_get_standard_regs(cpu);\n> - if (ret < 0) {\n> - error_report(\"Failed to get standard registers\");\n> - return -1;\n> - }\n> -\n> - ret = mshv_get_special_regs(cpu);\n> - if (ret < 0) {\n> - error_report(\"Failed to get special registers\");\n> - return -1;\n> - }\n> -\n> - return 0;\n> -}\n> -\n> static int read_memory(const CPUState *cpu, uint64_t initial_gva,\n> uint64_t initial_gpa, uint64_t gva, uint8_t *data,\n> size_t len)\n> @@ -1429,7 +1410,7 @@ static int handle_pio_str(CPUState *cpu, hv_x64_io_port_intercept_message *info)\n> X86CPU *x86_cpu = X86_CPU(cpu);\n> CPUX86State *env = &x86_cpu->env;\n> \n> - ret = fetch_guest_state(cpu);\n> + ret = mshv_load_regs(cpu);\n> if (ret < 0) {\n> error_report(\"Failed to fetch guest state\");\n> return -1;\n> -- \n> 2.53.0\n\nReviewed-by: Magnus Kulke ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linux.microsoft.com header.i=@linux.microsoft.com\n header.a=rsa-sha256 header.s=default header.b=BdaTzEkB;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g9Wwd1jPLz1y04\n\tfor ; Wed, 06 May 2026 20:34:55 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wKZaL-0000EC-Es; Wed, 06 May 2026 06:34:33 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wKZaJ-0000DM-Jg\n for qemu-devel@nongnu.org; Wed, 06 May 2026 06:34:31 -0400","from linux.microsoft.com ([13.77.154.182])\n by eggs.gnu.org with esmtp (Exim 4.90_1)\n (envelope-from ) id 1wKZaI-000255-2d\n for qemu-devel@nongnu.org; Wed, 06 May 2026 06:34:31 -0400","from example.com (unknown [167.220.208.68])\n by linux.microsoft.com (Postfix) with ESMTPSA id 56AA520B7168;\n Wed, 6 May 2026 03:34:23 -0700 (PDT)"],"DKIM-Filter":"OpenDKIM Filter v2.11.0 linux.microsoft.com 56AA520B7168","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1778063664;\n bh=ac9PLJVs1L9e7wKi2saZETCjTCdTQF2XJcJ33IO86ow=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=BdaTzEkBrIwphe5lYj0ManoarCY7xAArLH5b352q3w7jwCYvUauZWILi/X72SX9/F\n OgZVl9ks+2zt2m72uzn5ODLwlSRTTcRghw49SO+UoGNnVKGH83eeRp8+bYTQo6IZXL\n hqnS0k1S8xrcEglNPdwMWpy8eXrqCtZ3vKjS++9c=","Date":"Wed, 6 May 2026 12:34:22 +0200","From":"Magnus Kulke ","To":"Doru =?iso-8859-1?q?Bl=E2nzeanu?= ","Cc":"qemu-devel@nongnu.org, Zhao Liu ,\n Wei Liu , Paolo Bonzini ","Subject":"Re: [PATCH v2 1/7] target/i386/mshv: remove duplicate function for\n reading vcpu registers","Message-ID":"","References":"<20260505185028.237207-1-dblanzeanu@linux.microsoft.com>\n <20260505185028.237207-2-dblanzeanu@linux.microsoft.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260505185028.237207-2-dblanzeanu@linux.microsoft.com>","Received-SPF":"pass client-ip=13.77.154.182;\n envelope-from=magnuskulke@linux.microsoft.com; helo=linux.microsoft.com","X-Spam_score_int":"-19","X-Spam_score":"-2.0","X-Spam_bar":"--","X-Spam_report":"(-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3686958,"web_url":"http://patchwork.ozlabs.org/comment/3686958/","msgid":"","list_archive_url":null,"date":"2026-05-06T10:35:06","subject":"Re: [PATCH v2 1/7] target/i386/mshv: remove duplicate function for\n reading vcpu registers","submitter":{"id":90753,"url":"http://patchwork.ozlabs.org/api/people/90753/","name":"Magnus Kulke","email":"magnuskulke@linux.microsoft.com"},"content":"On Tue, May 05, 2026 at 09:50:22PM +0300, Doru Blânzeanu wrote:\n> Remove function `fetch_guest_state` because it is a duplicate function\n> of `mshv_load_regs` function.\n> \n> Signed-off-by: Doru Blânzeanu \n> ---\n> target/i386/mshv/mshv-cpu.c | 21 +--------------------\n> 1 file changed, 1 insertion(+), 20 deletions(-)\n> \n> diff --git a/target/i386/mshv/mshv-cpu.c b/target/i386/mshv/mshv-cpu.c\n> index 4ed6e7548f..9defd05db6 100644\n> --- a/target/i386/mshv/mshv-cpu.c\n> +++ b/target/i386/mshv/mshv-cpu.c\n> @@ -1291,25 +1291,6 @@ static int handle_pio_non_str(const CPUState *cpu,\n> return 0;\n> }\n> \n> -static int fetch_guest_state(CPUState *cpu)\n> -{\n> - int ret;\n> -\n> - ret = mshv_get_standard_regs(cpu);\n> - if (ret < 0) {\n> - error_report(\"Failed to get standard registers\");\n> - return -1;\n> - }\n> -\n> - ret = mshv_get_special_regs(cpu);\n> - if (ret < 0) {\n> - error_report(\"Failed to get special registers\");\n> - return -1;\n> - }\n> -\n> - return 0;\n> -}\n> -\n> static int read_memory(const CPUState *cpu, uint64_t initial_gva,\n> uint64_t initial_gpa, uint64_t gva, uint8_t *data,\n> size_t len)\n> @@ -1429,7 +1410,7 @@ static int handle_pio_str(CPUState *cpu, hv_x64_io_port_intercept_message *info)\n> X86CPU *x86_cpu = X86_CPU(cpu);\n> CPUX86State *env = &x86_cpu->env;\n> \n> - ret = fetch_guest_state(cpu);\n> + ret = mshv_load_regs(cpu);\n> if (ret < 0) {\n> error_report(\"Failed to fetch guest state\");\n> return -1;\n> -- \n> 2.53.0\n\nReviewed-by: Magnus Kulke ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linux.microsoft.com header.i=@linux.microsoft.com\n header.a=rsa-sha256 header.s=default header.b=DprHZoY7;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g9WxJ0gz8z1yJV\n\tfor ; Wed, 06 May 2026 20:35:32 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wKZb2-0000yH-J2; Wed, 06 May 2026 06:35:16 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wKZb0-0000wh-DP\n for qemu-devel@nongnu.org; Wed, 06 May 2026 06:35:14 -0400","from linux.microsoft.com ([13.77.154.182])\n by eggs.gnu.org with esmtp (Exim 4.90_1)\n (envelope-from ) id 1wKZaz-0002RP-0f\n for qemu-devel@nongnu.org; Wed, 06 May 2026 06:35:14 -0400","from example.com (unknown [167.220.208.68])\n by linux.microsoft.com (Postfix) with ESMTPSA id 5420C20B7169;\n Wed, 6 May 2026 03:35:07 -0700 (PDT)"],"DKIM-Filter":"OpenDKIM Filter v2.11.0 linux.microsoft.com 5420C20B7169","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1778063708;\n bh=ac9PLJVs1L9e7wKi2saZETCjTCdTQF2XJcJ33IO86ow=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=DprHZoY7Ox+7lysoBfeHZVUMygvBkQKe1ZFcwTo81PJKZqfKaT3D6lkJIXg6yb15w\n FqkVGMrvu4o1rtCz4LmaZ7UeE5tfviSpDYRz/wWSlrCUzPRonrHAPuuEE1qKM8edIx\n GuUKaUCB4hEUeyZxfhSPiPY8ZMtSXB349CaMfz/w=","Date":"Wed, 6 May 2026 12:35:06 +0200","From":"Magnus Kulke ","To":"Doru =?iso-8859-1?q?Bl=E2nzeanu?= ","Cc":"qemu-devel@nongnu.org, Zhao Liu ,\n Wei Liu , Paolo Bonzini ","Subject":"Re: [PATCH v2 1/7] target/i386/mshv: remove duplicate function for\n reading vcpu registers","Message-ID":"","References":"<20260505185028.237207-1-dblanzeanu@linux.microsoft.com>\n <20260505185028.237207-2-dblanzeanu@linux.microsoft.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260505185028.237207-2-dblanzeanu@linux.microsoft.com>","Received-SPF":"pass client-ip=13.77.154.182;\n envelope-from=magnuskulke@linux.microsoft.com; helo=linux.microsoft.com","X-Spam_score_int":"-19","X-Spam_score":"-2.0","X-Spam_bar":"--","X-Spam_report":"(-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3687788,"web_url":"http://patchwork.ozlabs.org/comment/3687788/","msgid":"<20260507-congenial-condor-of-rain-86bcad@anirudhrb>","list_archive_url":null,"date":"2026-05-07T13:12:02","subject":"Re: [PATCH v2 1/7] target/i386/mshv: remove duplicate function for\n reading vcpu registers","submitter":{"id":78917,"url":"http://patchwork.ozlabs.org/api/people/78917/","name":"Anirudh Rayabharam","email":"anirudh@anirudhrb.com"},"content":"On Tue, May 05, 2026 at 09:50:22PM +0300, Doru Blânzeanu wrote:\n> Remove function `fetch_guest_state` because it is a duplicate function\n> of `mshv_load_regs` function.\n> \n> Signed-off-by: Doru Blânzeanu \n> ---\n> target/i386/mshv/mshv-cpu.c | 21 +--------------------\n> 1 file changed, 1 insertion(+), 20 deletions(-)\n\nReviewed-by: Anirudh Rayabharam (Microsoft) ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=anirudhrb.com header.i=anirudh@anirudhrb.com\n header.a=rsa-sha256 header.s=zoho header.b=HvAAPGvt;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBCP95k4cz1yM5\n\tfor ; Thu, 07 May 2026 23:13:32 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wKyX5-0004zJ-QM; Thu, 07 May 2026 09:12:52 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wKyX0-0004zA-QD\n for qemu-devel@nongnu.org; Thu, 07 May 2026 09:12:48 -0400","from sender4-of-o54.zoho.com ([136.143.188.54])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wKyWx-0004Gh-Ts\n for qemu-devel@nongnu.org; Thu, 07 May 2026 09:12:45 -0400","by mx.zohomail.com with SMTPS id 1778159527944691.7310206783533;\n Thu, 7 May 2026 06:12:07 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; t=1778159531; cv=none;\n d=zohomail.com; s=zohoarc;\n b=Nepwq7Kde5kkbg1oFEGSpVof9NEL4DVS6iZDD0MocZATb03BVOnUxOnNyqXTwGKR74cgUlC923tzmv3EScu6wt27sAJzl62h/dq9WiZKC52thmbNKpxRQ3XKRt5AWn48FxZW7s4TcjUQF14mcVEgmfmvSY2FszvzUw1zUc9V5/w=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;\n s=zohoarc; t=1778159531;\n h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;\n bh=FohxqB2gCghFOmFtcMlK/IYfAgJ2IcjP1KCdo2uGtiQ=;\n b=RS7+4d/LwPrtfQ13YwATIHSUxaeIby5M6gFCNdAM8WDjRSlEeDDXsbHiyF5HYCUPsmbGpCFNYVvRe4rPAV+CKZFhfdC5xTJQYfAN0ehyQtJhJzYAgw+jaSmKqnQgXR7e/7iShjahYToiZBjG/lm7HqyEMWD7Oh3fV+J8Q5hc7nQ=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n dkim=pass header.i=anirudhrb.com;\n spf=pass smtp.mailfrom=anirudh@anirudhrb.com;\n dmarc=pass header.from=","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1778159531;\n s=zoho; d=anirudhrb.com; i=anirudh@anirudhrb.com;\n h=Date:Date:From:From:To:To:Cc:Cc:Subject:Subject:Message-ID:References:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To:Message-Id:Reply-To;\n bh=FohxqB2gCghFOmFtcMlK/IYfAgJ2IcjP1KCdo2uGtiQ=;\n b=HvAAPGvt4fOAASr1jhXnewJgtfp4mSJ63jc05UjJYsYw37ZaUXovxV7KDS2mL9w5\n ozRLXACPf39xhfKJZ5Nc/z874GpvqiaLXMu1Kxh6JIh9aVrEwR0Y1a8Yb51NaWZSHvb\n E+BPte1f4vYK5QXb3XIgeXolc2VUU4PXobo5EFLs=","Date":"Thu, 7 May 2026 13:12:02 +0000","From":"Anirudh Rayabharam ","To":"Doru =?iso-8859-1?q?Bl=E2nzeanu?= ","Cc":"qemu-devel@nongnu.org, Magnus Kulke ,\n Zhao Liu , Wei Liu ,\n Paolo Bonzini ","Subject":"Re: [PATCH v2 1/7] target/i386/mshv: remove duplicate function for\n reading vcpu registers","Message-ID":"<20260507-congenial-condor-of-rain-86bcad@anirudhrb>","References":"<20260505185028.237207-1-dblanzeanu@linux.microsoft.com>\n <20260505185028.237207-2-dblanzeanu@linux.microsoft.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260505185028.237207-2-dblanzeanu@linux.microsoft.com>","X-ZohoMailClient":"External","Received-SPF":"pass client-ip=136.143.188.54;\n envelope-from=anirudh@anirudhrb.com; helo=sender4-of-o54.zoho.com","X-Spam_score_int":"-16","X-Spam_score":"-1.7","X-Spam_bar":"-","X-Spam_report":"(-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1,\n DKIM_SIGNED=0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]