[{"id":3686741,"web_url":"http://patchwork.ozlabs.org/comment/3686741/","msgid":"","list_archive_url":null,"date":"2026-05-05T22:06:42","subject":"Re: [PATCH v17 04/11] cxl: Rename find_cxl_port() to\n find_cxl_port_by_dport()","submitter":{"id":13225,"url":"http://patchwork.ozlabs.org/api/people/13225/","name":"Dave Jiang","email":"dave.jiang@intel.com"},"content":"On 5/5/26 10:30 AM, Terry Bowman wrote:\n> From: Dan Williams \n> \n> find_cxl_port() and find_cxl_port_by_uport() are internal port lookup\n> functions that search the CXL bus by dport and uport respectively, but\n> their names do not make the lookup method clear.\n> \n> Rename find_cxl_port() to find_cxl_port_by_dport() to make the lookup\n> method explicit and consistent with find_cxl_port_by_uport(). Both\n> functions remain static to port.c; the upcoming patch that adds the\n> first cross-file caller will widen their scope.\n> \n> Co-developed-by: Terry Bowman \n> Signed-off-by: Terry Bowman \n> Signed-off-by: Dan Williams \n\nReviewed-by: Dave Jiang \n\n\n> \n> ---\n> \n> Changes in v16->v17:\n> - New commit\n> ---\n> drivers/cxl/core/port.c | 20 ++++++++++++++------\n> 1 file changed, 14 insertions(+), 6 deletions(-)\n> \n> diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c\n> index c5aacd7054f1..b35a9016fc81 100644\n> --- a/drivers/cxl/core/port.c\n> +++ b/drivers/cxl/core/port.c\n> @@ -1377,7 +1377,7 @@ static int match_port_by_dport(struct device *dev, const void *data)\n> \treturn dport != NULL;\n> }\n> \n> -static struct cxl_port *__find_cxl_port(struct cxl_find_port_ctx *ctx)\n> +static struct cxl_port *__find_cxl_port_by_dport(struct cxl_find_port_ctx *ctx)\n> {\n> \tstruct device *dev;\n> \n> @@ -1390,8 +1390,16 @@ static struct cxl_port *__find_cxl_port(struct cxl_find_port_ctx *ctx)\n> \treturn NULL;\n> }\n> \n> -static struct cxl_port *find_cxl_port(struct device *dport_dev,\n> -\t\t\t\t struct cxl_dport **dport)\n> +/**\n> + * find_cxl_port_by_dport - find a cxl_port by one of its targets\n> + * @dport_dev: device representing the dport target\n> + * @dport: optional output of the 'struct cxl_dport' companion of the @dport_dev\n> + *\n> + * Return a 'struct cxl_port' with an elevated reference if found. Use\n> + * __free(put_cxl_port) to release.\n> + */\n> +static struct cxl_port *find_cxl_port_by_dport(struct device *dport_dev,\n> +\t\t\t\t\t struct cxl_dport **dport)\n> {\n> \tstruct cxl_find_port_ctx ctx = {\n> \t\t.dport_dev = dport_dev,\n> @@ -1399,7 +1407,7 @@ static struct cxl_port *find_cxl_port(struct device *dport_dev,\n> \t};\n> \tstruct cxl_port *port;\n> \n> -\tport = __find_cxl_port(&ctx);\n> +\tport = __find_cxl_port_by_dport(&ctx);\n> \treturn port;\n> }\n> \n> @@ -1893,14 +1901,14 @@ EXPORT_SYMBOL_NS_GPL(devm_cxl_enumerate_ports, \"CXL\");\n> struct cxl_port *cxl_pci_find_port(struct pci_dev *pdev,\n> \t\t\t\t struct cxl_dport **dport)\n> {\n> -\treturn find_cxl_port(pdev->dev.parent, dport);\n> +\treturn find_cxl_port_by_dport(pdev->dev.parent, dport);\n> }\n> EXPORT_SYMBOL_NS_GPL(cxl_pci_find_port, \"CXL\");\n> \n> struct cxl_port *cxl_mem_find_port(struct cxl_memdev *cxlmd,\n> \t\t\t\t struct cxl_dport **dport)\n> {\n> -\treturn find_cxl_port(grandparent(&cxlmd->dev), dport);\n> +\treturn find_cxl_port_by_dport(grandparent(&cxlmd->dev), dport);\n> }\n> EXPORT_SYMBOL_NS_GPL(cxl_mem_find_port, \"CXL\");\n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=PlrzOt96;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-53805-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=\"PlrzOt96\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=198.175.65.13","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=intel.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=intel.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g9CKT35cqz1yJV\n\tfor ; Wed, 06 May 2026 08:06:53 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 27CE23051C7D\n\tfor ; Tue, 5 May 2026 22:06:49 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 4337848A2B1;\n\tTue, 5 May 2026 22:06:48 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.13])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id A2A202D781B;\n\tTue, 5 May 2026 22:06:46 +0000 (UTC)","from fmviesa007.fm.intel.com ([10.60.135.147])\n by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 05 May 2026 15:06:47 -0700","from spandruv-mobl5.amr.corp.intel.com (HELO [10.125.110.85])\n ([10.125.110.85])\n by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 05 May 2026 15:06:44 -0700"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1778018808; cv=none;\n b=lrNZX/om+G+R7kJPylqFTmSQoOj5vKeTAs3A0BqsjSKRlP6qU32om/JNDZD3Xc+fGsxtzmFp+mGzhXt+lqeBBFU9bB8R0eAL+Sl9vXiqBcwxs8CPOySLJC9LN5D02MYol+IQeqWUYpLi/WHWkK1lXt+4rKpVPiFgSan8LRu/les=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1778018808; c=relaxed/simple;\n\tbh=p/KdBFrY1pdWdMKYMGNY+10d1KOpGCh8qQK+ZFY12hE=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=saJXoh2UPSoMzRuCcL0D6Ug8YV0JIq+oRNE4dL6IkPgJ1CD8Dh0aAj+l7fMEaBX/swHryN3EXovz9hdo5ARCV7qUo81VeMEKzO/7uanlxmaocU6IffxqVeNR/xSmEcNRRLVMNklXk2mYIlC/YK2PuevodpTCDQiTS2oG+MppURg=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=intel.com;\n spf=pass smtp.mailfrom=intel.com;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=PlrzOt96; arc=none smtp.client-ip=198.175.65.13","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1778018807; x=1809554807;\n h=message-id:date:mime-version:subject:to:cc:references:\n from:in-reply-to:content-transfer-encoding;\n bh=p/KdBFrY1pdWdMKYMGNY+10d1KOpGCh8qQK+ZFY12hE=;\n b=PlrzOt96DwT5lunKwXmPGfCbPyZjBjfAcMK1C02ssAPKLr7ebkuZef2+\n E/yF/J7wUS+TR2Gxm2xJ1//C9rztswP6EdXH+b3zR1NXbX66No0gDJdTl\n d3752CzN5R5+R8SFkuGZC9nnXfMhyJcPnUktRQUGqIVm9w/mt+77esFMp\n g46/SMmUHX81NZoVTNgwJWdkBeb4L7prGiiWb5LlsFMXDGASHQb0TIhSU\n Y3AkMHZgOLwixvtlu23tOEnppXbQF6N5xvmog6zzlq6cpC494Q1wd1I0s\n CHl5AzUxFSvdhlFupz1Y5wGOgZRCrzfW3zxx+Vhdp1K3wDMKaxyW8B+Jo\n g==;","X-CSE-ConnectionGUID":["ZBwl6AktT9uSDbR5NEvGcw==","kj4oskQMTPaWmV6s0QHp/A=="],"X-CSE-MsgGUID":["65saHWbnQLyS7Y6zHTxIVg==","Od9QKWFKQ82l1QAxtSZ7zQ=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11777\"; a=\"90010580\"","E=Sophos;i=\"6.23,218,1770624000\";\n d=\"scan'208\";a=\"90010580\"","E=Sophos;i=\"6.23,218,1770624000\";\n d=\"scan'208\";a=\"232814837\""],"X-ExtLoop1":"1","Message-ID":"","Date":"Tue, 5 May 2026 15:06:42 -0700","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v17 04/11] cxl: Rename find_cxl_port() to\n find_cxl_port_by_dport()","To":"Terry Bowman , dave@stgolabs.net, jic23@kernel.org,\n alison.schofield@intel.com, djbw@kernel.org, bhelgaas@google.com,\n ming.li@zohomail.com, Smita.KoralahalliChannabasappa@amd.com,\n rrichter@amd.com, PradeepVineshReddy.Kodamati@amd.com, lukas@wunner.de,\n Benjamin.Cheatham@amd.com, sathyanarayanan.kuppuswamy@linux.intel.com,\n vishal.l.verma@intel.com, alucerop@amd.com, ira.weiny@intel.com,\n corbet@lwn.net, rafael@kernel.org, xueshuai@linux.alibaba.com,\n linux-cxl@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,\n linux-acpi@vger.kernel.org, linux-doc@vger.kernel.org","References":"<20260505173029.2718246-1-terry.bowman@amd.com>\n <20260505173029.2718246-5-terry.bowman@amd.com>","Content-Language":"en-US","From":"Dave Jiang ","In-Reply-To":"<20260505173029.2718246-5-terry.bowman@amd.com>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit"}},{"id":3687979,"web_url":"http://patchwork.ozlabs.org/comment/3687979/","msgid":"<20260507191107.752b043e@jic23-huawei>","list_archive_url":null,"date":"2026-05-07T18:11:07","subject":"Re: [PATCH v17 04/11] cxl: Rename find_cxl_port() to\n find_cxl_port_by_dport()","submitter":{"id":10151,"url":"http://patchwork.ozlabs.org/api/people/10151/","name":"Jonathan Cameron","email":"jic23@kernel.org"},"content":"On Tue, 5 May 2026 15:06:42 -0700\nDave Jiang wrote:\n\n> On 5/5/26 10:30 AM, Terry Bowman wrote:\n> > From: Dan Williams \n> > \n> > find_cxl_port() and find_cxl_port_by_uport() are internal port lookup\n> > functions that search the CXL bus by dport and uport respectively, but\n> > their names do not make the lookup method clear.\n> > \n> > Rename find_cxl_port() to find_cxl_port_by_dport() to make the lookup\n> > method explicit and consistent with find_cxl_port_by_uport(). Both\n> > functions remain static to port.c; the upcoming patch that adds the\n> > first cross-file caller will widen their scope.\n> > \n> > Co-developed-by: Terry Bowman \n> > Signed-off-by: Terry Bowman \n> > Signed-off-by: Dan Williams \n> \n> Reviewed-by: Dave Jiang \nReviewed-by: Jonathan Cameron \n\nCould pick this one up independently / early given it's useful for\nreadability.","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=tqCydUi4;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.232.135.74; helo=sto.lore.kernel.org;\n envelope-from=linux-pci+bounces-54112-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"tqCydUi4\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org [172.232.135.74])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBL0v3kGYz1yCg\n\tfor ; Fri, 08 May 2026 04:11:27 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id ACE5B300908B\n\tfor ; Thu, 7 May 2026 18:11:24 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 4D49642668F;\n\tThu, 7 May 2026 18:11:21 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 2503537C105;\n\tThu, 7 May 2026 18:11:20 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 3B9E2C2BCB2;\n\tThu, 7 May 2026 18:11:12 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1778177481; cv=none;\n b=qaFiPWdIQOuMFQC//GPVFmGqlqY3Hrd8G5Xly1i4C8SuuodAydoBOL/WriAMBvg/+F013VNuTocqQ54haqsfeVfmyfIGZJEc7hugDHtY3ZtiDtOw2CvHU+HEkxCBKi2XB0V7DMSC33wLp4Xht9srPAgeubz4oOAd+rKVsyJZArc=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1778177481; c=relaxed/simple;\n\tbh=c256iUMzuzb0xFvRcQcErKbiOUKlJ8SaT6kFuGeQXWE=;\n\th=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=TTfHFP89JHYnULjbI0RSpShvKPnkvUGPb0R7crDXV4jcpfInh64R0ouT/Duhw4JTK8U2Iox2+bUWWeZxVgIjyMFUmKtzNm5ryTKBWPa7EoZp82wt/OiZ6SrLNkwOhExIUC5MfkF8Kf5VOoWlqIuCigEdJhfSubpZiyjERtrIMao=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=tqCydUi4; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1778177480;\n\tbh=c256iUMzuzb0xFvRcQcErKbiOUKlJ8SaT6kFuGeQXWE=;\n\th=Date:From:To:Cc:Subject:In-Reply-To:References:From;\n\tb=tqCydUi4EdjOm1rR2FLi81GM5ORzlsT/PtGYn7DMAYMYA+Hw+TxW4lV+MC8hIS+Kw\n\t rNF4ZDeubEQk2JDhUzikhD3tvPp2JaIt4cdYJmcdbXw8D8lo3qK7hVlzFGagINhDz3\n\t nq27y61N0xwdg8iX5FNi1HeOvqYbvaB+QFZQj/Y+dum5mNBJVVdFy9dHCmEFbnmj/L\n\t L6VzUj0x6mxEI8QPBtgoLMSn1dMr6VkITEH48l41Ul5Ht6QkoRxhKg8STQPqDBu7x8\n\t P+JMUngQm/4PzrQMofs62Rg+cc6BmgxcJZMDb5XcyY5luhprL8ByON4W5p2x1BHI/T\n\t j/m3escbXLTew==","Date":"Thu, 7 May 2026 19:11:07 +0100","From":"Jonathan Cameron ","To":"Dave Jiang ","Cc":"Terry Bowman , dave@stgolabs.net,\n alison.schofield@intel.com, djbw@kernel.org, bhelgaas@google.com,\n ming.li@zohomail.com, Smita.KoralahalliChannabasappa@amd.com,\n rrichter@amd.com, PradeepVineshReddy.Kodamati@amd.com, lukas@wunner.de,\n Benjamin.Cheatham@amd.com, sathyanarayanan.kuppuswamy@linux.intel.com,\n vishal.l.verma@intel.com, alucerop@amd.com, ira.weiny@intel.com,\n corbet@lwn.net, rafael@kernel.org, xueshuai@linux.alibaba.com,\n linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org,\n linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org,\n linux-doc@vger.kernel.org","Subject":"Re: [PATCH v17 04/11] cxl: Rename find_cxl_port() to\n find_cxl_port_by_dport()","Message-ID":"<20260507191107.752b043e@jic23-huawei>","In-Reply-To":"","References":"<20260505173029.2718246-1-terry.bowman@amd.com>\n\t<20260505173029.2718246-5-terry.bowman@amd.com>\n\t","X-Mailer":"Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu)","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit"}}]