[{"id":3686874,"web_url":"http://patchwork.ozlabs.org/comment/3686874/","msgid":"<987b8bda-0f6d-4a8c-9e81-a6ffef9a5ccc@linaro.org>","list_archive_url":null,"date":"2026-05-06T08:25:51","subject":"Re: [RFC PATCH 03/10] .agents/skills: add qemu-code-reviewer skill","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 5/5/26 19:00, Alex Bennée wrote:\n> This provides basic instructions for how to download and apply a\n> patch series from the mailing list. It currently doesn't outline any\n> details about how to do the review.\n> \n> Signed-off-by: Alex Bennée \n> ---\n> .agents/skills/qemu-code-explorer/SKILL.md | 3 +-\n> .../qemu-code-explorer/evals/evals.json | 1 +\n> .agents/skills/qemu-code-reviewer/SKILL.md | 74 +++++++++++++++++++\n> 3 files changed, 77 insertions(+), 1 deletion(-)\n> create mode 100644 .agents/skills/qemu-code-reviewer/SKILL.md\n> \n> diff --git a/.agents/skills/qemu-code-explorer/SKILL.md b/.agents/skills/qemu-code-explorer/SKILL.md\n> index d41b21179c1..13cb71dd55c 100644\n> --- a/.agents/skills/qemu-code-explorer/SKILL.md\n> +++ b/.agents/skills/qemu-code-explorer/SKILL.md\n> @@ -1,6 +1,7 @@\n> ---\n> name: qemu-code-explorer\n> description: Comprehensive guide for exploring the QEMU codebase using tagging systems (gtags, ctags, cscope), git grep, and build-directory grep for generated files. Use this skill when the user asks to find where something is defined, how it's used, or wants to understand a specific subsystem.\n> +license: GPL-2.0-or-later\n> ---\n> \n> # QEMU Code Base Explorer\n> @@ -26,7 +27,7 @@ make gtags # or make ctags, make cscope, make TAGS\n> \n> `git grep` is the preferred tool for general text searches within the source tree.\n> \n> -- **Best for**:\n> +- **Best for**:\n> - Searching for local variables within a function.\n> - Searching for string literals or comments.\n> - Finding occurrences of symbols defined in system headers (e.g., `optarg`).\n> diff --git a/.agents/skills/qemu-code-explorer/evals/evals.json b/.agents/skills/qemu-code-explorer/evals/evals.json\n> index dff7afa52fa..131cf46e1cc 100644\n> --- a/.agents/skills/qemu-code-explorer/evals/evals.json\n> +++ b/.agents/skills/qemu-code-explorer/evals/evals.json\n> @@ -1,3 +1,4 @@\n> +# SPDX-License-Identifier: GPL-2.0-or-later\n> {\n> \"skill_name\": \"qemu-code-explorer\",\n> \"evals\": [\n\nSquash these to previous patch?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=HYB3Z8yR;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g9T4F5dN5z1y04\n\tfor ; Wed, 06 May 2026 18:26:20 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wKXa1-0004oG-TZ; Wed, 06 May 2026 04:26:05 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wKXZv-0004o0-AE\n for qemu-devel@nongnu.org; Wed, 06 May 2026 04:25:59 -0400","from mail-wr1-x434.google.com ([2a00:1450:4864:20::434])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wKXZt-0001lp-O6\n for qemu-devel@nongnu.org; Wed, 06 May 2026 04:25:59 -0400","by mail-wr1-x434.google.com with SMTP id\n ffacd0b85a97d-452169ae568so110887f8f.3\n for ; Wed, 06 May 2026 01:25:56 -0700 (PDT)","from [192.168.69.210] ([88.187.86.199])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-45055960902sm11886375f8f.28.2026.05.06.01.25.54\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 06 May 2026 01:25:54 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1778055955; x=1778660755; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id:from\n :to:cc:subject:date:message-id:reply-to;\n bh=pxJsbed4vDVoDnW6zsS1RwiJwyMi+ON6WElcbf3aGrE=;\n b=HYB3Z8yRUb/Y8BT3UYCBfH2/Vm1ziHq0J85aEP4KPP1Sqfp7rwH02egxQ2hM0xSWiP\n yrU1KF0TAMofgzMdce/5R58KRjH5KZZkGJs8+ldGeksvzi5S6Sw/zNPhzqIXTPa3jT/+\n W0AalpZA/1hCs1uw/OMtt4TfJB5Hg5Jd7iguN1IysdEPKE9CH31/HDr/YhbLv6rHalLF\n JAM/jxaim++pFprIT/NGGgL1oCcTKNsU7F8C5X6YZBEmMoFvcYP0MqTOEsS3YY8NTYhp\n 3sK+5wxVFKOCvIeF7KINKyspo5IXfkUITL8XljGTKaGLqgbU3O+RuDr9XlYeChUiLj/1\n 2zxQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778055955; x=1778660755;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=pxJsbed4vDVoDnW6zsS1RwiJwyMi+ON6WElcbf3aGrE=;\n b=OyINoC/lcKvoDTYT7gqQ2wk4RNoa4Glivzpcmab8juAdzYAI1EV3CD62vGoViZ6CTb\n kTxT283LtwZUDoiN7E2LIDT1KZxTVCUo/33GmmpDONAdvcx10rRBg5gT73titw1kIGn2\n 9kPAEgVpbKHyKnRYWdZtTndkob1Agm5Wg4bGAo60yobo6NhmkWANRr6fEquoyvSommpe\n 5wjo3tDTTA8IrLpQFwYNjR7HSfl/c4ga5vpbldfkVvXGbn2BW9eBXyzPQn+1ICwGNIWp\n bfEKDPuvI70FuIfvO+bdV8yVI/Jxwjl3Z6bm4QqqHB3uVjfiGLifrE6wupw0WFtvEhRr\n yP3A==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8GjmYP8DcJmZ/OJjaXJV76KZiYI5yQmumUssVo6dnVo6Z5eE6Xhj6EpCk/BJrEAcQ7W+A2WbACMlkc@nongnu.org","X-Gm-Message-State":"AOJu0YwZZqghvTJ1pVUV3eKv27ROvoIJRKgF1c4U9Ed72ILpZ0m3mrwD\n hOtFMh2nJxLred2blrfJLhAQZeeG3irhOfnklaRZCafKzMaYwHPghsPvHNeY+FlWO8s=","X-Gm-Gg":"AeBDies4zIt1GICYG1cHFBzpGQM7GWjZqfrZnsBBhKpWbXBvY6toI0mUMIttY3ZHLyl\n CVRfo+uJIrMzD/+ylyODCg8WLzuX5kVBcgWrl81iQKqHv2Aplqn+uIvQZz/x52DU2FtCrNg4m2k\n akPoeJ4LLEElhkH8bwwzYATPVHrnlkAkjfMSvHGafMAhhbrpHlh3ssmcdj5SuyAK00dtjFn9wpx\n 9kosLG+8BVS+8UQLcVfJX1kqITy/NQI+nAvfY3vdkw23sgzRhJR3J/wWnrcYv4lOAgnUZDesJw/\n Z17QB2J2TzrN9fn3CtTyW7XKgCEufiAlgd0TXNUZwskDNyPa7yypvTERccn2z4cOHcRJ0fhQbIf\n dxiaLD5ZH7ClhkoAXQK9VPTUpH2Ne/LnrZAtNCUoty8rryL+LJ4ytRhbmsMmCXXtMXrpGIPMldq\n +fL2ymepmscqboXnHfQMtcQlpc7wZu1JhC1nUQgVmny+mAIQ==","X-Received":"by 2002:a05:6000:22c6:b0:437:711c:8754 with SMTP id\n ffacd0b85a97d-4515b056c9bmr4002826f8f.7.1778055955084;\n Wed, 06 May 2026 01:25:55 -0700 (PDT)","Message-ID":"<987b8bda-0f6d-4a8c-9e81-a6ffef9a5ccc@linaro.org>","Date":"Wed, 6 May 2026 10:25:51 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [RFC PATCH 03/10] .agents/skills: add qemu-code-reviewer skill","To":"=?utf-8?q?Alex_Benn=C3=A9e?= ,\n qemu-devel@nongnu.org","References":"<20260505170105.228162-1-alex.bennee@linaro.org>\n <20260505170105.228162-4-alex.bennee@linaro.org>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Content-Language":"en-US","In-Reply-To":"<20260505170105.228162-4-alex.bennee@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::434;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x434.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]