[{"id":3686602,"web_url":"http://patchwork.ozlabs.org/comment/3686602/","msgid":"<20260505163206.GS1614990@bill-the-cat>","list_archive_url":null,"date":"2026-05-05T16:32:06","subject":"Re: [PATCH v6 1/6] config.mk: support vendor generic includes","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Tue, May 05, 2026 at 05:48:41PM +0200, Casey Connolly wrote:\n\n> Currently only board/vendor/$(BOARD)/config.mk is supported, add the\n> additional usecase of having a vendor generic config.mk which will be\n> used to add a Qualcomm specific make target.\n> \n> Additionally, fix the ifdef to correctly check for $(BOARDDIR) rather\n> than $(BOARD) since that's what is actually used in the fragment path.\n> \n> Signed-off-by: Casey Connolly \n> ---\n> config.mk | 6 +++++-\n> 1 file changed, 5 insertions(+), 1 deletion(-)\n\nA common pattern is to have board/VENDOR/common and I think qualcomm\nwould benefit from that, and it would make this easier to use elsewhere.\n\n> \n> diff --git a/config.mk b/config.mk\n> index abed9cb65c6f..28a4228b8fa5 100644\n> --- a/config.mk\n> +++ b/config.mk\n> @@ -53,10 +53,14 @@ ENVDIR=${vendor}/env\n> else\n> BOARDDIR = $(BOARD)\n> ENVDIR=${board}/env\n> endif\n> +else\n> +ifdef VENDOR\n> +BOARDDIR = $(VENDOR)\n> endif\n> -ifdef\tBOARD\n> +endif\n> +ifdef\tBOARDDIR\n> sinclude $(srctree)/board/$(BOARDDIR)/config.mk\t# include board specific rules\n> endif\n> \n> ifdef FTRACE\n\nBut BOARDDIR is used in some other places, so might this become a\nproblem overloading it this way? Does this end up working because\nthere's no \"board/\" code being used on these platforms?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=konsulko.com header.i=@konsulko.com header.a=rsa-sha256\n header.s=google header.b=G8QTUEbs;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=konsulko.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=konsulko.com header.i=@konsulko.com\n header.b=\"G8QTUEbs\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=konsulko.com","phobos.denx.de;\n spf=pass smtp.mailfrom=trini@konsulko.com"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g93vR6k0xz1yJ0\n\tfor ; Wed, 06 May 2026 02:32:19 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id D92C68497A;\n\tTue, 5 May 2026 18:32:14 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 763BF84986; Tue, 5 May 2026 18:32:13 +0200 (CEST)","from mail-ot1-x344.google.com (mail-ot1-x344.google.com\n [IPv6:2607:f8b0:4864:20::344])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 4E88784974\n for ; Tue, 5 May 2026 18:32:11 +0200 (CEST)","by mail-ot1-x344.google.com with SMTP id\n 46e09a7af769-7dea20cf21aso5084469a34.1\n for ; Tue, 05 May 2026 09:32:11 -0700 (PDT)","from bill-the-cat (fixed-189-203-106-235.totalplay.net.\n [189.203.106.235]) by smtp.gmail.com with ESMTPSA id\n 46e09a7af769-7deca7a5e75sm10262357a34.2.2026.05.05.09.32.08\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 05 May 2026 09:32:09 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=konsulko.com; s=google; t=1777998730; x=1778603530; darn=lists.denx.de;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=+oJZlqj6DADU50ig/zCM9gQpx65632XKo27agRAki/c=;\n b=G8QTUEbsEAOztQdknZgYHE+lOi4l46k5jZ70wqankchLyE21dscNZK0f5XYj0GoUQV\n n0mxj0h8AANm5lrxYnUdU4QJWIAKh6wVe9SuTxz7ngxeDyLQCI896iaKZuSSjHDU4Bis\n 4RiRO9qQZc26CafL2wQaq8lSv6/7a2rEMC7MM=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777998730; x=1778603530;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=+oJZlqj6DADU50ig/zCM9gQpx65632XKo27agRAki/c=;\n b=Zxe+mzLmhseBKZsOLzUW+x72V+oqi1Wm0CopDpTG1a9ElpTSEvm9p7ZnK90bE33Mwv\n GvJ4qcwZfnIu4Db4xApD0vff4tSima3UcBIWbvpSPUrXBTXT2r+EPPbEwaPnCnAeCjtU\n gZcN1qTcUftetF0sK4Ka4dmEs4tnhGuREYVBjwDIqvQxGfd3FkpL2gqfZJO0LHQxEGFu\n SfQWoV2J8Zy2RKD7Nylw8V2h2O/5YLyVPAT/XJeUorwJKorp4+L616qTAdtTLwxh3Spx\n L7GP/OPI/MY+I0zKnqSMLMGek3OfnQ8NyhOcYKe5drplEJdwNTGWIjXxGMHNQcj5B7s8\n oatA==","X-Gm-Message-State":"AOJu0YzThzLF+WC50cx9HBAg8bVmUPQLG6ynfYpf54WV/x11ZE+MHpsv\n 5CbtMuOoL3gICGKKJVQHqkFIyoDqHeQzj3YgWIV32P65OI7wlzbxqqbluFiLtnqtNZI=","X-Gm-Gg":"AeBDieumHnYn9oeEduksIUf5dz0co7sys3SkpQZebbnkKeBDS+iBZqiCmk45vglUe6g\n C8p6jdeGYuCP6Npe41nqkfnJGn0c5+VIUcS55rPJqNjArSKr/R0VYQzByx2jdSX/ZDTpvMfTHPm\n m7KrNDn1GSURM53c0x7B37QckBPiWYb09dArk/oJ7jg0c5ynppAubPMObKgF8k7LBCOn5JQRiP0\n UpQapJPYksWllInbkyvn48aDEVlDovBgKSHpWkYZ1GEQp9hHlj6OPdfO4v3oWmrKIV+csSSHczD\n 0TJ6wwo8g5cH+VkMlMmfoOi6EYtSTuHIZT31iqYSLhEg3DTTrlzOPISCp3subJWidhCZRkEpSac\n INIPjEoYnT6LNLZQXjZrW6DBXk0bNkx7TCvzmf0xM6H6UC/SvGD5wQhfgZE50/6orWfSEoQ3ePy\n sW8jqP7YlcEVlWcVCQa98P5mSEmw9NbzKTFRbejPoHmywQ78+f3LAVEoDfnWVFauLdrPZZt9PQw\n KjtBeebfp6LJBcm2/yJboTAOmWDBiz7Az4kX2GFFhVIODBpqyJm1aVfOEK3KGsUcTr5ySYg","X-Received":"by 2002:a05:6830:8289:b0:7d7:4002:1f21 with SMTP id\n 46e09a7af769-7e17df16a0dmr2127128a34.20.1777998729853;\n Tue, 05 May 2026 09:32:09 -0700 (PDT)","Date":"Tue, 5 May 2026 10:32:06 -0600","From":"Tom Rini ","To":"Casey Connolly ","Cc":"u-boot@lists.denx.de, Sumit Garg ,\n u-boot-qcom@groups.io, Neil Armstrong ,\n Balaji Selvanathan ,\n Varadarajan Narayanan ,\n Quentin Schulz ,\n Heinrich Schuchardt ,\n Marek Vasut ,\n Peng Fan , Jaehoon Chung ,\n Aswin Murugan ,\n Ilias Apalodimas ,\n Michal Simek , David Lechner ","Subject":"Re: [PATCH v6 1/6] config.mk: support vendor generic includes","Message-ID":"<20260505163206.GS1614990@bill-the-cat>","References":"\n <20260505-b4-qcom-tooling-improvements-v6-0-a5fb673f4af6@linaro.org>\n <20260505-b4-qcom-tooling-improvements-v6-1-a5fb673f4af6@linaro.org>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n protocol=\"application/pgp-signature\"; boundary=\"JPwOHapoKThE27qe\"","Content-Disposition":"inline","In-Reply-To":"\n <20260505-b4-qcom-tooling-improvements-v6-1-a5fb673f4af6@linaro.org>","X-Clacks-Overhead":"GNU Terry Pratchett","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3686870,"web_url":"http://patchwork.ozlabs.org/comment/3686870/","msgid":"","list_archive_url":null,"date":"2026-05-06T08:15:55","subject":"Re: [PATCH v6 1/6] config.mk: support vendor generic includes","submitter":{"id":90679,"url":"http://patchwork.ozlabs.org/api/people/90679/","name":"Casey Connolly","email":"casey.connolly@linaro.org"},"content":"On 05/05/2026 18:32, Tom Rini wrote:\n> On Tue, May 05, 2026 at 05:48:41PM +0200, Casey Connolly wrote:\n> \n>> Currently only board/vendor/$(BOARD)/config.mk is supported, add the\n>> additional usecase of having a vendor generic config.mk which will be\n>> used to add a Qualcomm specific make target.\n>>\n>> Additionally, fix the ifdef to correctly check for $(BOARDDIR) rather\n>> than $(BOARD) since that's what is actually used in the fragment path.\n>>\n>> Signed-off-by: Casey Connolly \n>> ---\n>> config.mk | 6 +++++-\n>> 1 file changed, 5 insertions(+), 1 deletion(-)\n> \n> A common pattern is to have board/VENDOR/common and I think qualcomm\n> would benefit from that, and it would make this easier to use elsewhere.\n\nahh that would make sense\n\n> \n>>\n>> diff --git a/config.mk b/config.mk\n>> index abed9cb65c6f..28a4228b8fa5 100644\n>> --- a/config.mk\n>> +++ b/config.mk\n>> @@ -53,10 +53,14 @@ ENVDIR=${vendor}/env\n>> else\n>> BOARDDIR = $(BOARD)\n>> ENVDIR=${board}/env\n>> endif\n>> +else\n>> +ifdef VENDOR\n>> +BOARDDIR = $(VENDOR)\n>> endif\n>> -ifdef\tBOARD\n>> +endif\n>> +ifdef\tBOARDDIR\n>> sinclude $(srctree)/board/$(BOARDDIR)/config.mk\t# include board specific rules\n>> endif\n>> \n>> ifdef FTRACE\n> \n> But BOARDDIR is used in some other places, so might this become a\n> problem overloading it this way? Does this end up working because\n> there's no \"board/\" code being used on these platforms?\n\nhmm, good point, it works in that case but would break if\nCONFIG_SYS_BOARD was set.\n\nI'll fix this up for the next version.\n\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=fVgOzJsI;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.b=\"fVgOzJsI\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org","phobos.denx.de;\n spf=pass smtp.mailfrom=casey.connolly@linaro.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g9SrQ5V2vz1y04\n\tfor ; Wed, 06 May 2026 18:16:06 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id E7FB98483F;\n\tWed, 6 May 2026 10:16:02 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 52A9C846F4; Wed, 6 May 2026 10:16:01 +0200 (CEST)","from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com\n [IPv6:2a00:1450:4864:20::32c])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 161BD846F4\n for ; Wed, 6 May 2026 10:15:57 +0200 (CEST)","by mail-wm1-x32c.google.com with SMTP id\n 5b1f17b1804b1-48e56c1bf5dso519475e9.3\n for ; Wed, 06 May 2026 01:15:57 -0700 (PDT)","from [192.168.1.36] (p4fc3dd86.dip0.t-ipconnect.de.\n [79.195.221.134])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48e538aca14sm28412215e9.7.2026.05.06.01.15.55\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 06 May 2026 01:15:56 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1778055357; x=1778660157; darn=lists.denx.de;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=VmLaG4x+55AhXrMp9EhEFgpDjUykPyEdExoAX3OHqUk=;\n b=fVgOzJsIxGKSQNqRorxz7OcZ8/0lNFqWpYXHPUMsehmt+ItyR40Jft6THDcPsRQhYA\n 3xHXomQgamjOSANZwt/clu7YyVGfh5SvHOwjAM+DPKyB21D14QxAI22SKPzjwS19oz61\n BHeqjxD6r0ViNo1nYaD6RUo3Ga179AuQKK7LxtIbnUHjivnUd54hlO3qicRSWoCa8VUe\n KcKhuR9UiSCeS09LFgbRrkWkxrMEwIYhvftko97mSUSgRLkp+qZora46qwdFK37ADNaG\n YYknrWVygwW7v1mYq2/5kDesE+ZII3XyxQqwiXYiUsGuEQTbQwgnjQArvpFPQ2hLdoGd\n q6BQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778055357; x=1778660157;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=VmLaG4x+55AhXrMp9EhEFgpDjUykPyEdExoAX3OHqUk=;\n b=VychhwGt5PUyyukDq/6TEOmeFOt+kYWxynJNBSVl7dVa2stVhIstmZkgB4bDlHkrxe\n bTagehlkQF/BZcdT4j5+41oZmTuhLcITbtXaGtQ3skWymR0+2ApgfkGz7x9q7IcU+i0L\n aXyBIOUhRDNjFEyGkUDtrHr55AShS6vw+JexnUgOfH7G9fqmnDG7psjG6969pmj3iFX9\n dy37dDcMuwzWMmnvsooSY3VjGIej7kjdxi3ZRH9eVXSvKTF6iMea3MgvtrWHBqlL3Y5H\n b1rnbOXm9jQ55dnPj8+oJcPdfpAhmABiVF//C1vsZjVPgKQaOkWnR+O9UbiY3wXY9sAh\n PTmQ==","X-Gm-Message-State":"AOJu0YwjIELE0gpnXj3FA3J0UbdVA9+oiz3L+4I+9TraVXVC4Eq8r7TR\n d4RvmvaCx3wmENsSSRk1gcYuEWs8JXHnZPWxlK/HExEPeLpjrCsHv1I6XLDb0lX12+Q=","X-Gm-Gg":"AeBDieuAscsnYcLFnvHfuZ4y4ObZr5V1VUjcEAq2snuAtzjl7gixOeuqZ0B7vhFddHV\n bDq6MKuxOxfN8dsGzjxqL+FFjwrk+Ljp44uM/YD/TSjY1bJxLSW92DsTRbDDQZcDZu3nMancvGf\n XS+pdhohQBXpi18FTl/rbxRcQ1FtpfMYNifnA2mcVyigZg8uEjI41PDVfSlO9Fgd+H/BpxlQ7bN\n 3ytux/S0D4ZshnaVwRRCWD9vtJvI/mEDRlJnjS/dfeil/1NiOpRL10KzFIG1tDJn6V9nnKpvoaF\n Lzm3KVpk0SXN2AwtCMBhbRgOcdKJea9QO1DYS5jDqgoRmcYNO5Nc8boMmQGv6HFDvfQ0WVm7gIK\n jGTS6Ye2fhDGEF26FF0kZdomY3Kh7d7q2/mWAOmHAhcaCQdcWwa3aJyomL2ovg5M405WiZry/yB\n vNE5eEDYcUG1g6PNP2VBVwtQQWt7VmIbd276PIz/fuRNTwgUMgQCKHwmPEY1/uugHTN4KpFc18V\n RUR","X-Received":"by 2002:a05:600d:8451:b0:487:219e:42d with SMTP id\n 5b1f17b1804b1-48e53f33f08mr13817845e9.11.1778055357251;\n Wed, 06 May 2026 01:15:57 -0700 (PDT)","Message-ID":"","Date":"Wed, 6 May 2026 10:15:55 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v6 1/6] config.mk: support vendor generic includes","Content-Language":"en-US","To":"Tom Rini ","Cc":"u-boot@lists.denx.de, Sumit Garg ,\n u-boot-qcom@groups.io, Neil Armstrong ,\n Balaji Selvanathan ,\n Varadarajan Narayanan ,\n Quentin Schulz ,\n Heinrich Schuchardt ,\n Marek Vasut , Peng Fan ,\n Jaehoon Chung ,\n Aswin Murugan ,\n Ilias Apalodimas ,\n Michal Simek , David Lechner ","References":"\n <20260505-b4-qcom-tooling-improvements-v6-0-a5fb673f4af6@linaro.org>\n <20260505-b4-qcom-tooling-improvements-v6-1-a5fb673f4af6@linaro.org>\n <20260505163206.GS1614990@bill-the-cat>","From":"Casey Connolly ","In-Reply-To":"<20260505163206.GS1614990@bill-the-cat>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]