[{"id":3688422,"web_url":"http://patchwork.ozlabs.org/comment/3688422/","msgid":"<20260508132827.1183079-3-horms@kernel.org>","list_archive_url":null,"date":"2026-05-08T13:28:29","subject":"Re: [Intel-wired-lan] [PATCH iwl-next v5 3/5] ice: migrate to\n netdev ops lock","submitter":{"id":82748,"url":"http://patchwork.ozlabs.org/api/people/82748/","name":"Simon Horman","email":"horms@kernel.org"},"content":"From: 'Simon Horman' \n\nThis is an AI-generated review of your patch. The human sending this\nemail has considered the AI review valid, or at least plausible.\nFull review at: https://sashiko.dev\n---\n ice: migrate to netdev ops lock\n\nThis commit migrates queue management operations to use netdev locking.\nIt updates several NAPI and VSI configuration functions to use their\n_locked variants to avoid deadlocks, taking the lock manually where needed.\n\n> diff --git a/drivers/net/ethernet/intel/ice/ice_dcb_lib.c b/drivers/net/ethernet/intel/ice/ice_dcb_lib.c\n> index 16aa255351523..7d89c0acc5d8d 100644\n> --- a/drivers/net/ethernet/intel/ice/ice_dcb_lib.c\n> +++ b/drivers/net/ethernet/intel/ice/ice_dcb_lib.c\n[ ... ]\n> @@ -1107,7 +1106,7 @@ ice_dcb_process_lldp_set_mib_change(struct ice_pf *pf,\n> \n> \trtnl_lock();\n> \t/* disable VSIs affected by DCB changes */\n> -\tice_dcb_ena_dis_vsi(pf, false, true);\n> +\tice_dcb_ena_dis_vsi(pf, false);\n> \n> \tret = ice_query_port_ets(pi, &buf, sizeof(buf), NULL);\n> \tif (ret) {\n> @@ -1119,7 +1118,7 @@ ice_dcb_process_lldp_set_mib_change(struct ice_pf *pf,\n> \tice_pf_dcb_recfg(pf, false);\n> \n> \t/* enable previously downed VSIs */\n> -\tice_dcb_ena_dis_vsi(pf, true, true);\n> +\tice_dcb_ena_dis_vsi(pf, true);\n> unlock_rtnl:\n> \trtnl_unlock();\n> out:\n\nThis wasn't introduced by this patch, but does this error path leave VSIs\npermanently disabled?\n\nIf ice_query_port_ets() fails, the code jumps to unlock_rtnl, bypassing the\ncall to ice_dcb_ena_dis_vsi(pf, true). This seems to leave the affected VSIs\n(including the main PF interface) in a disabled state (ICE_VSI_DOWN) with\nICE_VSI_NEEDS_RESTART set, which could result in a denial of service.\n\n> diff --git a/drivers/net/ethernet/intel/ice/ice_eswitch.c b/drivers/net/ethernet/intel/ice/ice_eswitch.c\n> index 2e4f0969035f7..af0cc77fbf718 100644\n> --- a/drivers/net/ethernet/intel/ice/ice_eswitch.c\n> +++ b/drivers/net/ethernet/intel/ice/ice_eswitch.c\n> @@ -23,10 +23,16 @@ static int ice_eswitch_setup_env(struct ice_pf *pf)\n> \tstruct net_device *netdev = uplink_vsi->netdev;\n> \tbool if_running = netif_running(netdev);\n> \tstruct ice_vsi_vlan_ops *vlan_ops;\n> +\tint ret;\n> +\n> +\tif (if_running && !test_and_set_bit(ICE_VSI_DOWN, uplink_vsi->state)) {\n> +\t\tnetdev_lock(netdev);\n> +\t\tret = ice_down(uplink_vsi);\n> +\t\tnetdev_unlock(netdev);\n> \n> -\tif (if_running && !test_and_set_bit(ICE_VSI_DOWN, uplink_vsi->state))\n> -\t\tif (ice_down(uplink_vsi))\n> +\t\tif (ret)\n> \t\t\treturn -ENODEV;\n> +\t}\n\nSimon says: It seems that the topic of locks in this patch has come up\n again ¯\\_(ツ)_/¯\n\nDoes manipulating the state bit outside of netdev_lock create a race\ncondition with interface teardown?\n\nIf the interface is concurrently brought down, ndo_stop (which holds\nnetdev_lock) would call ice_vsi_close(). Because ICE_VSI_DOWN is already\nset by the test_and_set_bit() call above, ice_vsi_close() would skip calling\nice_down() and immediately proceed to free the Tx/Rx rings.\n\nThis would leave the hardware queues active and performing DMA operations into\nfreed memory, potentially causing a use-after-free.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=ZkZGAkbr;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBqln4hk8z1yJq\n\tfor ; Fri, 08 May 2026 23:31:47 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 76109613A2;\n\tFri, 8 May 2026 13:31:45 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id exX1BNVN-FCC; Fri, 8 May 2026 13:31:44 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id B25FB615DA;\n\tFri, 8 May 2026 13:31:44 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id 5CAD0272\n for ; Fri, 8 May 2026 13:31:43 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 42E7A41774\n for ; Fri, 8 May 2026 13:31:43 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id xwDDK07bRODU for ;\n Fri, 8 May 2026 13:31:42 +0000 (UTC)","from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 6A7BA4176E\n for ; Fri, 8 May 2026 13:31:42 +0000 (UTC)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n by tor.source.kernel.org (Postfix) with ESMTP id 3626B6024D;\n Fri, 8 May 2026 13:31:41 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 02E98C2BCB0;\n Fri, 8 May 2026 13:31:37 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org B25FB615DA","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 6A7BA4176E"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1778247104;\n\tbh=y8ibHP3Nov5Ykqxq9GpDd5L2rGCuKhmKCrkowaXfG5A=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=ZkZGAkbrfJJioEwbb4ooRz8enWG7hhQnwCdyk02LLJAoQ7Z6MqV6TELwyBT9OBnl8\n\t FUOGj6OHq1PD5sdqLNn8abofAgJMik+Z7NK6+XoyWhIEQXkAl/tyuNbPYXIZ37hm8V\n\t NPmRth8q1fEjSWVigyhxMV8NX6nV9+EVH6ukTBv1+AEeJJSeK8BYzagjyIe1C5NoAx\n\t M3zXCO1JJ/XMyOQrNIL0T0HI8WR86hcbcztdmjcs/vdTqNbI6blU9RfqHsAYHeXy3j\n\t uCDOGo8rz0Y2CRhBhW0A9UXs7phZa/rZlwR5UbsyeN9z0d6CJAF57YfXKk+XxKwnC8\n\t L5+XqU9yE1HSg==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=172.105.4.254;\n helo=tor.source.kernel.org; envelope-from=horms@kernel.org;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 6A7BA4176E","From":"Simon Horman ","To":"aleksander.lobakin@intel.com","Cc":"'Simon Horman' , intel-wired-lan@lists.osuosl.org,\n anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,\n andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,\n kuba@kernel.org, pabeni@redhat.com, kohei@enjuk.jp,\n jacob.e.keller@intel.com, aleksandr.loktionov@intel.com,\n nxne.cnse.osdt.itp.upstreaming@intel.com, netdev@vger.kernel.org,\n linux-kernel@vger.kernel.org","Date":"Fri, 8 May 2026 14:28:29 +0100","Message-ID":"<20260508132827.1183079-3-horms@kernel.org>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260505152923.1040589-4-aleksander.lobakin@intel.com>","References":"<20260505152923.1040589-4-aleksander.lobakin@intel.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=kernel.org; s=k20201202; t=1778247100;\n bh=JxypbuWnNL/2mPFJRS9B0fB7VeJz/jcNnlNcUQF/xfE=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=R2ja3fyrqJNqOj50SGTmCp06oLbtZHfnCUor/bUag/UUq45Nu0NzhDTaVd5mhMZAd\n S5DDU/B2LsLmDIYVf50FR16Tf/DCB2tO/DQq5ik51526R1Ba69lCXmneZpQPMvYlhw\n 8Na9yXfKXyq/50mkMUzz8Q5ze+FbAoaYzxLRMx7borZck3uYCbX97Oo1MUUToJO7pM\n XgZgKPVITOvNCeQpw7vyv/BJcROF2VUUIQNJ16azFV8I2hB/lowbfRmUbcsr75RLje\n 7LMq/hmWBtCW1NHT2w0grZq7D6+iTxM6FPTLvoKDh8VHmoM0ufiyvnEjovhvudHqX2\n ZXC8ElFqa4WEw==","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=kernel.org","smtp4.osuosl.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.a=rsa-sha256 header.s=k20201202 header.b=R2ja3fyr"],"Subject":"Re: [Intel-wired-lan] [PATCH iwl-next v5 3/5] ice: migrate to\n netdev ops lock","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3688446,"web_url":"http://patchwork.ozlabs.org/comment/3688446/","msgid":"<5eab9525-6fbd-46ae-8464-12ca9472bea1@intel.com>","list_archive_url":null,"date":"2026-05-08T13:57:25","subject":"Re: [Intel-wired-lan] [PATCH iwl-next v5 3/5] ice: migrate to\n netdev ops lock","submitter":{"id":85827,"url":"http://patchwork.ozlabs.org/api/people/85827/","name":"Alexander Lobakin","email":"aleksander.lobakin@intel.com"},"content":"From: Simon Horman \nDate: Fri, 8 May 2026 14:28:29 +0100\n\n> From: 'Simon Horman' \n> \n> This is an AI-generated review of your patch. The human sending this\n> email has considered the AI review valid, or at least plausible.\n> Full review at: https://sashiko.dev\n> ---\n> ice: migrate to netdev ops lock\n> \n> This commit migrates queue management operations to use netdev locking.\n> It updates several NAPI and VSI configuration functions to use their\n> _locked variants to avoid deadlocks, taking the lock manually where needed.\n> \n>> diff --git a/drivers/net/ethernet/intel/ice/ice_dcb_lib.c b/drivers/net/ethernet/intel/ice/ice_dcb_lib.c\n>> index 16aa255351523..7d89c0acc5d8d 100644\n>> --- a/drivers/net/ethernet/intel/ice/ice_dcb_lib.c\n>> +++ b/drivers/net/ethernet/intel/ice/ice_dcb_lib.c\n> [ ... ]\n>> @@ -1107,7 +1106,7 @@ ice_dcb_process_lldp_set_mib_change(struct ice_pf *pf,\n>> \n>> \trtnl_lock();\n>> \t/* disable VSIs affected by DCB changes */\n>> -\tice_dcb_ena_dis_vsi(pf, false, true);\n>> +\tice_dcb_ena_dis_vsi(pf, false);\n>> \n>> \tret = ice_query_port_ets(pi, &buf, sizeof(buf), NULL);\n>> \tif (ret) {\n>> @@ -1119,7 +1118,7 @@ ice_dcb_process_lldp_set_mib_change(struct ice_pf *pf,\n>> \tice_pf_dcb_recfg(pf, false);\n>> \n>> \t/* enable previously downed VSIs */\n>> -\tice_dcb_ena_dis_vsi(pf, true, true);\n>> +\tice_dcb_ena_dis_vsi(pf, true);\n>> unlock_rtnl:\n>> \trtnl_unlock();\n>> out:\n> \n> This wasn't introduced by this patch, but does this error path leave VSIs\n> permanently disabled?\n> \n> If ice_query_port_ets() fails, the code jumps to unlock_rtnl, bypassing the\n> call to ice_dcb_ena_dis_vsi(pf, true). This seems to leave the affected VSIs\n> (including the main PF interface) in a disabled state (ICE_VSI_DOWN) with\n> ICE_VSI_NEEDS_RESTART set, which could result in a denial of service.\n> \n>> diff --git a/drivers/net/ethernet/intel/ice/ice_eswitch.c b/drivers/net/ethernet/intel/ice/ice_eswitch.c\n>> index 2e4f0969035f7..af0cc77fbf718 100644\n>> --- a/drivers/net/ethernet/intel/ice/ice_eswitch.c\n>> +++ b/drivers/net/ethernet/intel/ice/ice_eswitch.c\n>> @@ -23,10 +23,16 @@ static int ice_eswitch_setup_env(struct ice_pf *pf)\n>> \tstruct net_device *netdev = uplink_vsi->netdev;\n>> \tbool if_running = netif_running(netdev);\n>> \tstruct ice_vsi_vlan_ops *vlan_ops;\n>> +\tint ret;\n>> +\n>> +\tif (if_running && !test_and_set_bit(ICE_VSI_DOWN, uplink_vsi->state)) {\n>> +\t\tnetdev_lock(netdev);\n>> +\t\tret = ice_down(uplink_vsi);\n>> +\t\tnetdev_unlock(netdev);\n>> \n>> -\tif (if_running && !test_and_set_bit(ICE_VSI_DOWN, uplink_vsi->state))\n>> -\t\tif (ice_down(uplink_vsi))\n>> +\t\tif (ret)\n>> \t\t\treturn -ENODEV;\n>> +\t}\n> \n> Simon says: It seems that the topic of locks in this patch has come up\n> again ¯\\_(ツ)_/¯\n> \n> Does manipulating the state bit outside of netdev_lock create a race\n> condition with interface teardown?\n> \n> If the interface is concurrently brought down, ndo_stop (which holds\n> netdev_lock) would call ice_vsi_close(). Because ICE_VSI_DOWN is already\n> set by the test_and_set_bit() call above, ice_vsi_close() would skip calling\n> ice_down() and immediately proceed to free the Tx/Rx rings.\n> \n> This would leave the hardware queues active and performing DMA operations into\n> freed memory, potentially causing a use-after-free.\n\nI ran Sashiko internally a couple times and it hasn't found these =\\\n\nAnyway, now that I anyway need to adjust the series after\n.ndo_set_rx_mode_asyn() landed, I'll take a look at this, too.\n\n(I hate this series already. I feel like if Sashiko was alive when other\n vendors were switching to the netdev lock, they'd have the same drama)\n\n(I was planning to add devmem/io_uring support to idpf after this lands,\n but given that idpf is way more confusing and inconsistent in locking,\n I'm not sure I'll have enough patience :D)\n\nThanks,\nOlek","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=wlpXGNPm;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBrMJ6rcwz1yKd\n\tfor ; Fri, 08 May 2026 23:59:08 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 0FF7661597;\n\tFri, 8 May 2026 13:59:07 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 4wsFc1AGWFqa; Fri, 8 May 2026 13:59:06 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 298DD61601;\n\tFri, 8 May 2026 13:59:06 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n by lists1.osuosl.org (Postfix) with ESMTP id 3B5E8272\n for ; Fri, 8 May 2026 13:59:04 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 1EAD1842CE\n for ; Fri, 8 May 2026 13:59:04 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 9_n_nhGNz846 for ;\n Fri, 8 May 2026 13:59:03 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.19])\n by smtp1.osuosl.org (Postfix) with ESMTPS id E53F3842DE\n for ; Fri, 8 May 2026 13:59:02 +0000 (UTC)","from fmviesa010.fm.intel.com ([10.60.135.150])\n by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 08 May 2026 06:59:02 -0700","from orsmsx903.amr.corp.intel.com ([10.22.229.25])\n by fmviesa010.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 08 May 2026 06:59:02 -0700","from ORSMSX901.amr.corp.intel.com (10.22.229.23) by\n ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Fri, 8 May 2026 06:59:01 -0700","from ORSEDG902.ED.cps.intel.com (10.7.248.12) by\n ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37 via Frontend Transport; Fri, 8 May 2026 06:59:01 -0700","from PH7PR06CU001.outbound.protection.outlook.com (52.101.201.69) by\n edgegateway.intel.com (134.134.137.112) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Fri, 8 May 2026 06:59:01 -0700","from DS0PR11MB8718.namprd11.prod.outlook.com (2603:10b6:8:1b9::20)\n by DS0PR11MB7531.namprd11.prod.outlook.com (2603:10b6:8:14a::20) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.17; Fri, 8 May\n 2026 13:58:55 +0000","from DS0PR11MB8718.namprd11.prod.outlook.com\n ([fe80::6aa:411d:4bfa:619c]) by DS0PR11MB8718.namprd11.prod.outlook.com\n ([fe80::6aa:411d:4bfa:619c%5]) with mapi id 15.20.9891.019; Fri, 8 May 2026\n 13:58:55 +0000"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org 298DD61601","OpenDKIM Filter v2.11.0 smtp1.osuosl.org E53F3842DE"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1778248746;\n\tbh=RCd3pZLX65r9ISI7BSKDqnX3EhbefH0nOEOomUPNhdc=;\n\th=Date:To:CC:References:From:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=wlpXGNPmIuai3hlXJ4vkSFaUz1ZZr1FqPhhVmh5rHYkQQUxIKX2TRWrRnU1cSfsL5\n\t uqON+kBFw4I9n5RaYRcsSbN2+hMLEr6vrvkRfElabB9T+vrSsKd3+FhJEZzgzgEu7L\n\t GIx2T+xguSYxvgo2+VAxXEPNgkx5ygZLzp1DU5i7zEt3QcDYugkymgTVHXoStlZFge\n\t 1RgGNcU5IQPXByGX6IPlJt00MzaPzXhFoE3k2RBTBB7sVU7gbLF8gKECpXhKwIcVS1\n\t +n57NGjsCLsvnhitEcytv7PjyLXUhJ3bUew2U/W9tYfcDwLeXeRXwDDG6BCUT+C9tY\n\t Ii4DGUNdvzGyQ==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.19;\n helo=mgamail.intel.com; envelope-from=aleksander.lobakin@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org E53F3842DE","X-CSE-ConnectionGUID":["VcjRb+XTS3KexvNxGQ5FKQ==","dOZ5jrGRSnKLdSXp7mS2HQ=="],"X-CSE-MsgGUID":["Vr+Uu8LrTOuh2XRh9KBq0A==","bMM7cKS6TYS24YeKeSKudg=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11780\"; a=\"78235957\"","E=Sophos;i=\"6.23,223,1770624000\"; d=\"scan'208\";a=\"78235957\"","E=Sophos;i=\"6.23,223,1770624000\"; d=\"scan'208\";a=\"232433307\""],"X-ExtLoop1":"1","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=K3rqF0mRAbgjNivGTQDtN1kqAtKBe8DsiqKshJfpsXFdukNACXeXqdC4BRO1JBLYGBWGTg6ttNWu0h5uCAvJO0C9WIvD8gBhFFuuC5VZsRQ0mSSaMcHD3tL/TbDfbjq0ir6hf7KQjq4zkTSEKDGQuQN+2PjJozDyOsmIT5ZmmAe4DH4WHkyv0JLnXdRAktWeYdifeRAV86qvhms2CFz4/Kil/yp1QBNJbltS51Th90sWqOhDVK4x64EqBjWnHKSdL6NKdHrrvEDdH2VjEIhyfmEfUFAkQsFshc1oyAxxj+EdFOij62gvZtyPOh0Wu13wXfmqgcrm8ECuypPGRgQQ9A==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=RCd3pZLX65r9ISI7BSKDqnX3EhbefH0nOEOomUPNhdc=;\n b=gaL2mxkL4wxPAZe4s3p2TYRM00zQ5NT+OLTMspp9IxIp9XVmtrOFoDFd8la9YkIuP0vWZV8lUwGT/miEy3NtfPPxiD1pKPBUPxJ4x8CZlJHI2vMQScAxo9BYVSsTgGSRHMwLwrq1zSSMau5WxV3oOjX3Ep1VYyQlIPhlF7TZmV0ArxDLu277OXe6zc2N3/bR8Hu44UnIUYZYhoTWSQk1qrGGXfCegFgEdAKpYZ/TtpmgjCDgkvKbctjdUFgejGbbpLNH4gb9QxF/6ioaQjiGA+56PlIhNCTEUcDPaRCrQyLXubJ++Ac1vV09fNxIsKLDACgpm93FVKoC3BXRbn5STw==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none","Message-ID":"<5eab9525-6fbd-46ae-8464-12ca9472bea1@intel.com>","Date":"Fri, 8 May 2026 15:57:25 +0200","User-Agent":"Mozilla Thunderbird","To":"Simon Horman ","CC":", ,\n , ,\n , , ,\n , , ,\n , ,\n , ","References":"<20260505152923.1040589-4-aleksander.lobakin@intel.com>\n <20260508132827.1183079-3-horms@kernel.org>","Content-Language":"en-US","From":"Alexander Lobakin ","In-Reply-To":"<20260508132827.1183079-3-horms@kernel.org>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"8bit","X-ClientProxiedBy":"TL2P290CA0014.ISRP290.PROD.OUTLOOK.COM\n (2603:1096:950:2::17) To DS0PR11MB8718.namprd11.prod.outlook.com\n (2603:10b6:8:1b9::20)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"DS0PR11MB8718:EE_|DS0PR11MB7531:EE_","X-MS-Office365-Filtering-Correlation-Id":"3b24704b-39cc-4c4f-974a-08dead09f14e","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|7416014|366016|376014|1800799024|18002099003|22082099003|56012099003;","X-Microsoft-Antispam-Message-Info":"\n iQx2Ja/AHRd2rEQ7dC77v5hTqCKqOvtLdNWUH4pmwachOYRM8u54iBfkG1IOpKU1UeKGprX+hVpkIKFztIPlSTWkJus4SyyqxlR02EUMoE/ZUJ+ZH2qT9j0W4+S1m8ZtgNkzCqrN7FZm53UpItb2eCjzHOUkKj3Gu5nyeYRn9D+kBBmmrieu2UstKU7+ROTcLsfhNo5ymC3o5gcRh/0p0Fh5+WAo2mvdNO/qc5f9OavriUTA3V6jW9Z3OtIzO6rH93DWUz9W5DDya6ZrN21rFAapu4hTFZoWGD7N52dYkNmbIfQSCHAFpFPUVh8bAE3VBd1mbcZSWXwsHHStcz4JR3XRp03S7QvUUf4yyLkqJnaO/M8EmnC+g70TBGQlW1tzU7pl40jJGJhqCgPAQJOLi5ZXRB3IEVKJ1w6Bx6UkkKvxYuN4oed9lIjQaSCn4pzlW3Zfgj02RjrmvJP/5KTg8Iu7Tc6Q9Xyiz2bfKQkO2hTtLQvC532I76YNKGZq4z9HHit1yf8/Aq09ThnmlFRTIa0JTr6hfgtQtYoyfKxOy6Q2S+gfHbkJt4er5rX/94sjEQxJfo1/iQFwxki11fp0Tkh2EpOtq+PsROxC08thCOve9zZzA2POTxhnRzr09zUws78YLLYuOiOrne/W0WyQSg==","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:DS0PR11MB8718.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(7416014)(366016)(376014)(1800799024)(18002099003)(22082099003)(56012099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?x4OKsBE9NblT0um9gbq8T33X3Hh8?=\n\t=?utf-8?q?EqjXOZ5W9EnDXFaZUn/S7HWZ/74v6QNM1bsyQkpiu0VCD4zUWIQPydipFc/ijwn6b?=\n\t=?utf-8?q?FITdk217OrWlhEyRoFon/XDDNIkLY3jM2/FnQpTQsN2kV/Dmijd42aPWx+eiYuXB7?=\n\t=?utf-8?q?fXpEzOYtOv7LkSETZ72hvORzSANhKxUwqaMHW9nAd0cdL392y6fIhj4muTJN7BUSw?=\n\t=?utf-8?q?Fb6erbWhbaTjWD3h7xyifONKB03y45jb1gqh9fgPaxbceipoEk0wKWYX0yDE7XTiw?=\n\t=?utf-8?q?Vt5Tzez8F3AdUZkKkthezepCY2sApfri/9HUaL9HUugMEyxh/B+ZEnImWy/3jmYq0?=\n\t=?utf-8?q?Yz5Bg5fKgviVm4eTzzh4ZHVAYHoe81iKKaYcg1Wfg9d5xc3Es8ni2n7mT6AsLbbwQ?=\n\t=?utf-8?q?N6puD4TagcSdyiXoSgXiy56gK/t7uxQz5HLi0e/sk5baz6kYejEY6LE1dmBMuAzc5?=\n\t=?utf-8?q?QGA36070mcZTaemrQdlfErQn33/nX4yi4ceGVyKsqpHw1vtiYFDgNxv++fLbLFeSO?=\n\t=?utf-8?q?Q6Rh2y1+kj/JVat7R//htGivlL7a+AkmeUOS4H3ov3Adr3bX5Awyr9BImRrt77i74?=\n\t=?utf-8?q?/zncTXQsawo4D2/06kcrNmqJYaNXW6dKw9ptPRAwMgdm7Z+qMd7qdKwk04OdSfDP7?=\n\t=?utf-8?q?5h4zWW0xkT1WgT0ZcF0RvfH46Ekzc7BK8Z8VxWl1OMhJyibtxjQTcMH7cv9EBwOpa?=\n\t=?utf-8?q?7uWu+P/lnJnwG5bAGJV3ZkzSMOPIx0aaDalKIiKOy9zWIefwLCs4vygw8EFqRHvEg?=\n\t=?utf-8?q?USSRZDBN7P9ZZsLFx6Iw9s2bAJwYDNtlKRu75gaSixc8wHAenQPtYDOp3lR5fPWSm?=\n\t=?utf-8?q?TSO7X0faldSPx5GE2Xmm6HYmopHjPAWI7XbwqB6VqV9c8rVAyt43Uyxex4g5hHGaI?=\n\t=?utf-8?q?1GckxRu9Hnf7FiTLFGq5/1i4M6tfnjo2xlcrzVTNyCUDU86JhHKRNriJt7LGZzWZW?=\n\t=?utf-8?q?SgKE0HtQaHo0NMdj+dxlltWx/SmUCkAtxk29py4CEKKTK/B6+P+wgF/ps0faqsycd?=\n\t=?utf-8?q?9uBdJjTculDHg4trrPvnQj/AjH+MI2eraSFPHf749coZHsSzsPj7xYccqFLTDPLj7?=\n\t=?utf-8?q?RoJJcN4ajCbicQ/595zkPsdvjOkdT/s8bdbfIVlL3qPcdcFRX38pnPI7UGhY7xXdZ?=\n\t=?utf-8?q?Yl9Ux7u6fPWkojm5VStTzFki3L6/x1XKiNwhoX4ZG60L9yVXubIQ2AIAdcnQnpU7h?=\n\t=?utf-8?q?ZPrxpgYe4Hw13y8zjrg+wvQoWcdQdWkZ51CAyYZ+y9MU+/NvP0QiDiVw0SHAzwWsX?=\n\t=?utf-8?q?O3lEJ3oafUY1CnDt7DDfm3EaUvigi/wNwN2LHabYdfZoHSLPFHCcIY/d4/Seu7Rsw?=\n\t=?utf-8?q?bC7st/H6Tm3bTOYYO7XZOA9Y4auHaD8+Dt5jW4EOhNLjGkUD8kSTIJo+zkiPc/YAJ?=\n\t=?utf-8?q?PSsBDY5VNkFCdF9SWh+9eMKFLYwEkOEJ94R2TMesIGQNgS4AfwiNCSqFwZZZlRi/6?=\n\t=?utf-8?q?5ncrx3QF9SH0ip9fILTi4SBU/WRppqUb3mrVyUs5rMTuYtqhVmvPLm1Vr+xMpEVR0?=\n\t=?utf-8?q?Ae667fFLNMu+hfokfIANKb0N0CN65ewOEOcsZb+xQsE2ZrIpvhhaH1SWjMVIQl1W4?=\n\t=?utf-8?q?N8LC4FL/3UX+W4HeqG0YNB19UN4vdpJq0o4/17CAGPE885NounJlPSf211oQoAd6E?=\n\t=?utf-8?q?2y8X6uHvDUSw6mH3ooui49W5Yzq0mgoBDhV2ZVZEwtnDbgTsszeIY=3D?=","X-Exchange-RoutingPolicyChecked":"\n kecn4s4RQ0kKu8Oa+9oDf4ep7Ptj2vOU41ZnxsK72rJ5prPmjkNdALWuY4kiLEOB3Fu1F/upcHqPB3Q9hUTYNetAWFgc+E0xv8d1C5bWet3v2fJMUxbAKo9QiA+fFsWrN5saC2qT71HIH2hB/bVlYvJgk1kYxBlAr8mkxxnbF8H4y1hzBs3C1O2tPvkIwMDuWSdFl33bMfH0w/NeMEciV4LsF6/xy1rL6WBmTXV9fMTMPbZzUQ9W0zre/XkKvLwvLkyX2+9aGLT7gZTAXxpWeWL+MQeX6ElRP7LsJaVEoeGPWxNETXi2CdCRfv5EVLxl3zjTGVl+Fpv17vcwBZpuOw==","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 3b24704b-39cc-4c4f-974a-08dead09f14e","X-MS-Exchange-CrossTenant-AuthSource":"DS0PR11MB8718.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"08 May 2026 13:58:55.1234 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n sUw/Bj9zIJbS8hnS33PSYKzDx7zHYAcxriRV5RewIeN1PcgMh4MfzlH8V9IUmP8qHSyQqumiN/O9yyELd9Hv3QRXiEeMO9m+E+SOWQJqA0A=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DS0PR11MB7531","X-OriginatorOrg":"intel.com","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1778248743; x=1809784743;\n h=message-id:date:subject:to:cc:references:from:\n in-reply-to:content-transfer-encoding:mime-version;\n bh=ZCol0vQS8fCFXSYrgeFEY/j2G6qiGou2ieYC6O33k6M=;\n b=etnxFTpYFGDmJAlMOtNyX24rvBaBa5U37Lcb7vRO8Y1QnUNLgMcvSUX8\n qMUK4qVahtb/dBTtrdeLMnBgjIosajLRsOyxZCP5OT2buW3cEukt2uR0M\n +85Es6OkS26zuXej8/FPnTPS2d2Gl476rpUF+SOYCc4fuAcvH7rmxG64C\n FVdpfJxnrehpnXKt3ML6OINU0l6F03DYAHUvmVe0+cOy6vyOlVVsB78p2\n uINyiANdgfLobb7tRESIsTLyiHV1nQ239RobtuAbVZLuXu0MMVPFK6Ndh\n ExBMGsKnOrz53oz2d2L/cXaSXOOwzjSGxKJnKjxkp05lWgStav1Y/tvmK\n Q==;","X-Mailman-Original-Authentication-Results":["smtp1.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp1.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=etnxFTpY","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"Subject":"Re: [Intel-wired-lan] [PATCH iwl-next v5 3/5] ice: migrate to\n netdev ops lock","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]