[{"id":3687188,"web_url":"http://patchwork.ozlabs.org/comment/3687188/","msgid":"","list_archive_url":null,"date":"2026-05-06T15:36:00","subject":"Re: [ovs-dev] [PATCH net-next v5 2/2] selftests: openvswitch: add\n pop_vlan test","submitter":{"id":67184,"url":"http://patchwork.ozlabs.org/api/people/67184/","name":"Aaron Conole","email":"aconole@redhat.com"},"content":"Minxi Hou writes:\n\n> Add test_pop_vlan() to verify OVS kernel datapath pop_vlan action\n> correctly strips 802.1Q VLAN tags from frames.\n>\n> Test structure:\n> - Baseline: untagged forwarding validates basic connectivity.\n> - Negative: forward without pop_vlan, tagged frame is invisible\n> to ns2 (no VLAN sub-interface), ping fails.\n> - Positive: pop_vlan strips tag on forward path, push_vlan\n> restores tag on return path, ping succeeds.\n>\n> Use static ARP entries to avoid VLAN-tagged ARP complexity.\n> Rely on ping success/failure for verification — no tcpdump or\n> pcap files needed.\n>\n> Signed-off-by: Minxi Hou \n> ---\n\nThanks for adding this. I'm still a little unclear about the explicit\nmodprobe for 8021q. Is it really needed? I thought the request to add\na vlan tagged interface should auto-load that module (unless it is\nblacklisted or something). I guess this is an attempt to short-circuit\nthe skip, but maybe it would be better to configure an interface and if\nthat fails, then either fail the test or skip the test.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=dxkGciZB;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::133; helo=smtp2.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp2.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=dxkGciZB","smtp3.osuosl.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","smtp3.osuosl.org;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.a=rsa-sha256 header.s=mimecast20190719 header.b=dxkGciZB"],"Received":["from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g9fcJ75h5z1yJV\n\tfor ; Thu, 07 May 2026 01:36:16 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp2.osuosl.org (Postfix) with ESMTP id 1879140608;\n\tWed, 6 May 2026 15:36:15 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id MI_vFHJUYou1; Wed, 6 May 2026 15:36:14 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org\n [IPv6:2605:bc80:3010:104::8cd3:938])\n\tby smtp2.osuosl.org (Postfix) with ESMTPS id 3609E403F8;\n\tWed, 6 May 2026 15:36:14 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id 1BEBAC04EB;\n\tWed, 6 May 2026 15:36:14 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by lists.linuxfoundation.org (Postfix) with ESMTP id C29BDC04E7\n for ; Wed, 6 May 2026 15:36:12 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id A90DC60E60\n for ; Wed, 6 May 2026 15:36:12 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id e0x2aJ12lf0G for ;\n Wed, 6 May 2026 15:36:11 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 9FE23608B7\n for ; Wed, 6 May 2026 15:36:11 +0000 (UTC)","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-179-Oj-mcXI6Mm21pizt2v4p5w-1; Wed,\n 06 May 2026 11:36:06 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id C3E9419560B4; Wed, 6 May 2026 15:36:04 +0000 (UTC)","from RHTRH0061144 (unknown [10.22.65.142])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with\n ESMTPS\n id 32CC318001CE; Wed, 6 May 2026 15:36:02 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections -\n client-ip=2605:bc80:3010:104::8cd3:938; helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp2.osuosl.org 3609E403F8","OpenDKIM Filter v2.11.0 smtp3.osuosl.org 9FE23608B7"],"Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=aconole@redhat.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org 9FE23608B7","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1778081770;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=P0UoDCQban7BwMooeGuUu7b8/86Tvw53i5NmMB+ICeI=;\n b=dxkGciZBFOLkdoYszCtG7/yCO2sznZrtI8x9u4P2AVeZSaPAlSyWiBzlh3NjTNcmr46WgR\n FL8Av7hF8jLSBMsUjVRXv6pWKTF0jkgZT2cTt/0SSEmK8LjfcX8FqVkkLhDgMTJOzPta0u\n Hp5TbO1suAbwll8fVyxsTgNeGdoUHh0=","X-MC-Unique":"Oj-mcXI6Mm21pizt2v4p5w-1","X-Mimecast-MFC-AGG-ID":"Oj-mcXI6Mm21pizt2v4p5w_1778081765","To":"Minxi Hou ","In-Reply-To":"<20260505124957.1239812-3-houminxi@gmail.com> (Minxi Hou's\n message of \"Tue, 5 May 2026 20:49:57 +0800\")","References":"<20260505124957.1239812-1-houminxi@gmail.com>\n <20260505124957.1239812-3-houminxi@gmail.com>","Date":"Wed, 06 May 2026 11:36:00 -0400","Message-ID":"","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","X-Mimecast-MFC-PROC-ID":"6teEZwjhW7ss0EvAL4p1hIAJQZ7mFzwZA0MIzo88zYg_1778081765","X-Mimecast-Originator":"redhat.com","Subject":"Re: [ovs-dev] [PATCH net-next v5 2/2] selftests: openvswitch: add\n pop_vlan test","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Aaron Conole via dev ","Reply-To":"Aaron Conole ","Cc":"dev@openvswitch.org, linux-kselftest@vger.kernel.org,\n netdev@vger.kernel.org, linux-kernel@vger.kernel.org, i.maximets@ovn.org,\n edumazet@google.com, horms@kernel.org, kuba@kernel.org, pabeni@redhat.com,\n shuah@kernel.org, davem@davemloft.net","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "}}]