[{"id":3688056,"web_url":"http://patchwork.ozlabs.org/comment/3688056/","msgid":"","list_archive_url":null,"date":"2026-05-07T21:11:28","subject":"Re: [PATCH v2 2/4] reset: Add sandbox tests for reset_reset() and\n reset_reset_bulk()","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Michal,\n\nOn 2026-05-05T12:30:28, Michal Simek wrote:\n> reset: Add sandbox tests for reset_reset() and reset_reset_bulk()\n>\n> Add DM test coverage for the new reset_reset() and reset_reset_bulk()\n> API functions. The tests exercise the assert + deassert fallback path\n> since the sandbox reset driver does not implement the rst_reset op.\n>\n> Signed-off-by: Michal Simek \n>\n> arch/sandbox/include/asm/reset.h | 3 ++\n> drivers/reset/sandbox-reset-test.c | 14 ++++++++\n> drivers/reset/sandbox-reset.c | 31 ++++++++++++++++++\n> test/dm/reset.c | 67 ++++++++++++++++++++++++++++++++++++++\n> 4 files changed, 115 insertions(+)\n\n> diff --git a/drivers/reset/sandbox-reset.c b/drivers/reset/sandbox-reset.c\n> @@ -66,6 +69,21 @@ static int sandbox_reset_deassert(struct reset_ctl *reset_ctl)\n> return 0;\n> }\n>\n> +static int sandbox_reset_reset(struct reset_ctl *reset_ctl, ulong delay_us)\n> +{\n> + struct sandbox_reset *sbr = dev_get_priv(reset_ctl->dev);\n> +\n> + debug(\"%s(reset_ctl=%p, delay_us=%lu)\\n\", __func__, reset_ctl,\n> + delay_us);\n> +\n> + sbr->signals[reset_ctl->id].asserted = true;\n> + udelay(delay_us);\n> + sbr->signals[reset_ctl->id].asserted = false;\n> + sbr->signals[reset_ctl->id].reset_count++;\n> +\n> + return 0;\n> +}\n\nReviewed-by: Simon Glass \n\nSome optional nits / thoughts below.\n\nThe commit message says the tests exercise the fallback path since the\nsandbox reset driver doesn't have rst_reset op, this patch adds that\nmethod below - so the commit message could use an update.\n\nIf you want coverage for the fallback you could add a second\nsandbox-reset driver without rst_reset, or hack the rest to clear and\nrestart ops->rst_reset,\n\n> diff --git a/drivers/reset/sandbox-reset-test.c b/drivers/reset/sandbox-reset-test.c\n> @@ -96,6 +96,20 @@ int sandbox_reset_test_deassert_bulk(struct udevice *dev)\n> +int sandbox_reset_test_reset(struct udevice *dev)\n> +{\n> + struct sandbox_reset_test *sbrt = dev_get_priv(dev);\n> +\n> + return reset_reset(sbrt->ctlp, 0);\n> +}\n> +\n> +int sandbox_reset_test_reset_bulk(struct udevice *dev)\n> +{\n> + struct sandbox_reset_test *sbrt = dev_get_priv(dev);\n> +\n> + return reset_reset_bulk(sbrt->bulkp, 0);\n> +}\n\nYou could pass a non-zero value here if you want to test the delay.\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=fU598CWL;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"fU598CWL\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBQ0z6mhVz1yJq\n\tfor ; Fri, 08 May 2026 07:11:47 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id E2BB184C01;\n\tThu, 7 May 2026 23:11:45 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 085C184C06; Thu, 7 May 2026 23:11:45 +0200 (CEST)","from mail-ej1-x629.google.com (mail-ej1-x629.google.com\n [IPv6:2a00:1450:4864:20::629])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 7AF9C84C00\n for ; Thu, 7 May 2026 23:11:42 +0200 (CEST)","by mail-ej1-x629.google.com with SMTP id\n a640c23a62f3a-b93698bb57aso241561566b.0\n for ; Thu, 07 May 2026 14:11:42 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1778188302; cv=none;\n d=google.com; s=arc-20240605;\n b=hh37UCKZ7y2GuVVza12LiWbnR55dWe7PZEoifBCN/B9FmaYChEvhX4I+fVeHD8sIxT\n 3kITr26ppihOaUIwD3vkOlmGCpcVIFLRqIrmSDAQCDBSOxcF7kemNzOpblN4DUdePWO7\n i6g8SZfqKBxSdCIwgI/Syy06gvpr7Lhk+FOA00VORayNlaBvN15wD8DvU/drT1lusda+\n bq7wZpLGBXfaaQDbsKvOD8Vh4cwENPHU+ogwIu0E209AEDPJe+5fFrA3gszZ2wccOXeJ\n /Xn/u5sil64AJJoXt5rm4wv/NsgTySaREmUgXYQT3wPXs/YZsFZfBrGavLKeNiuzAzwA\n /a4w==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=bK/0D/p5+4zoQFJqaRHmQRuhxmVLHc59YXdX9p0j6ms=;\n fh=qmb99AbYrxQTqbU8c3YoikZ37BstHm/br0rQHEGk45c=;\n b=bC/VtUUeuatwVbl67/7uHXTyQpyAmRJGDwrzYPiG5Ypmy3pXFj8IKBtrSyVwqSA6rA\n avf6ganMeSB6SzsPIgD9AH1BKuxEa7iCRRfGIhzkk5X+2UZgCg5T7PnUmWiYTXwOo9Fn\n umbckAhNRV/ebZoTB/Llyb2m5zfNK7Ip2/CIBYUC5dYsiqWi9HoG1LQ+r4qC73PdWwR0\n H/Nj5UUYKmTf4WXk1mz9+UMlpoc/V0IDMrqowegsp4OKBtC/jvkZiOy6W6qHl3MhsB+u\n VnHuz7+1uYW6SLa/NvB78behTeGJ6PRqMXP7NRKy2DX+RBJvrKaJqMeNtyogzqsNGYSR\n faqQ==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1778188302; x=1778793102; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=bK/0D/p5+4zoQFJqaRHmQRuhxmVLHc59YXdX9p0j6ms=;\n b=fU598CWLo+kB4nq+8ux3Y0DjfSCQtKyq6EMwvaViOeSVytD0p/OeDo6N2VUr36GBWa\n ujcsb2UmKsejaEcPp5Tu+3p3OdAGOtv78YvcfgAT9+ZF0T77vCS6W9ak0gFyygjPE+eQ\n WH34lQ5xFDCIkNILY9a6Cffe88G3PYcavZkDU=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778188302; x=1778793102;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=bK/0D/p5+4zoQFJqaRHmQRuhxmVLHc59YXdX9p0j6ms=;\n b=CcOWECCYJrQ2Mqa10AnByQ4l0TxfeHBYEyQg0Lff0WNnQteiStE2RbS7OK0eEOfJRM\n 4vgNdRBrIXbtUD8yXD+RX8qvv0xm2jGh8GpCC0SUPunJtGOImE+T8usUfI5cIpHb888o\n iGORIFlHPScLZLCXT9bW796XR4s4A13GR7YgrjgqiDno2HEjOVaeNNg8qiTpd3wmrMdM\n GhPokOlilbJxfrAdD9r6ZIm2ac3lvmV5MiePyTLCeFYyca8/JpvZcyQSThTF98P6CWLm\n fly8cz1MDh3xJPodFQ5sirYE6wp/5In00uA0rrC4QbPm0IqFlVifxT0hldrGYBbLcTCm\n C74w==","X-Gm-Message-State":"AOJu0YxvQYT2zbS9yuneT1MGy6viRaEy/I09rT2RfwesC3wSCmUs4eoV\n VCNuxvygfArD2GVWOdaPl3syHquYsDlrDDr2cWUhVv480i8kJlxPBFZJpA/C6P+Kv6UlpdN6etB\n tYFtbGg+SzyykLGTmVulOLXMAPBaKnYoCmzIzA+xr","X-Gm-Gg":"AeBDiesxqzBylV0urJ5YvDQ96OPr22s3SV0v1wBQyhxxY+Np1R8nRv5xC2gC9O0nuds\n 4IpmlWejw/VLEPkFsf7FtnYz00PRTjm1ThqFBnypSv83vWGy4ukQfC82e05xtwCAPzifENvLZPj\n K57e4KYCcMj/Q6LqlX1BQaOMLdo3mFgCsRYV7dFqE4Ws1ZwW9m4IBoxd6a/T6KEdIiECLN5nQSK\n 3DrOr7ut7umhbSjYwsXWo+XcckNDHfYFOVn+0xIFElvTMhKiVGnoPjyWGvbRdaH4YBbv+7dNUA5\n ifjJ5w==","X-Received":"by 2002:a17:907:3f8e:b0:b9c:5d3c:11e4 with SMTP id\n a640c23a62f3a-bc85c88dd5bmr238076266b.16.1778188301776; Thu, 07 May 2026\n 14:11:41 -0700 (PDT)","MIME-Version":"1.0","References":"\n <21c23cc7403153b45a81c958118b8d9f85f73140.1777984225.git.michal.simek@amd.com>","In-Reply-To":"\n <21c23cc7403153b45a81c958118b8d9f85f73140.1777984225.git.michal.simek@amd.com>","From":"Simon Glass ","Date":"Thu, 7 May 2026 15:11:28 -0600","X-Gm-Features":"AVHnY4LWWI9E4hgJUuITa1rxLxxCUxiZdVQ-SzWRZwW2ATG_auFHh-wxg9aojXk","Message-ID":"\n ","Subject":"Re: [PATCH v2 2/4] reset: Add sandbox tests for reset_reset() and\n reset_reset_bulk()","To":"michal.simek@amd.com","Cc":"u-boot@lists.denx.de, git@amd.com, Simon Glass ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]