[{"id":3687575,"web_url":"http://patchwork.ozlabs.org/comment/3687575/","msgid":"<20260507080010.3E3ADC2BCB8@smtp.kernel.org>","list_archive_url":null,"date":"2026-05-07T08:00:09","subject":"Re: [PATCH v8 phy-next 30/31] phy: remove temporary provider\n compatibility from consumer header","submitter":{"id":93311,"url":"http://patchwork.ozlabs.org/api/people/93311/","name":null,"email":"sashiko-bot@kernel.org"},"content":"Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:\n- [Low] include/linux/phy/phy.h becomes non-self-contained due to missing inclusion.\n--\n\ncommit 84b3f602007ce4ccbcbb1ef2bc28094bd50acb5c\nAuthor: Vladimir Oltean \n\nphy: remove temporary provider compatibility from consumer header\n\nThis commit hides the definition of struct phy from public view by removing\nthe inclusion of phy-provider.h from the consumer header phy.h.\n\n> diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h\n> index e65865b4acfe5..ccf7e83f103ae 100644\n> --- a/include/linux/phy/phy.h\n> +++ b/include/linux/phy/phy.h\n> @@ -12,8 +12,6 @@\n> \n> #include \n> \n> -#include \"../../../drivers/phy/phy-provider.h\"\n\nDoes removing this inclusion also remove the implicit inclusion of\nlinux/err.h?\n\nThe fallback inline functions in phy.h (used when CONFIG_GENERIC_PHY is\ndisabled) rely on ERR_PTR, -ENOSYS, and -ENODEV. Without an explicit\ninclusion of linux/err.h, this header may no longer be self-contained for\nconsumers when CONFIG_GENERIC_PHY is disabled.\n\n> -\n> struct device;\n> struct device_node;\n> struct phy;","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=q1iFUoPx;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-pci+bounces-54059-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"q1iFUoPx\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gB4Rv4Sl3z1yCg\n\tfor ; Thu, 07 May 2026 18:00:27 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 38F4D300BBA7\n\tfor ; Thu, 7 May 2026 08:00:25 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id BA72A36F437;\n\tThu, 7 May 2026 08:00:12 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 44F79371CF1\n\tfor ; Thu, 7 May 2026 08:00:10 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 3E3ADC2BCB8;\n\tThu, 7 May 2026 08:00:10 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1778140811; cv=none;\n b=tj0Y3c4cHwJm/D0PfWPxh+xbnfL6nPQSXfAbIeYXZAgqrMjpTscDaJ4ahfvGYuLY/Rl0TfIZWkxVBXGoUhE7ncws/3+0E2ZAbF0hskqkwYGlZDqJtEf5QI0fCm5p8cKfkbAFdnYtQjnb/8kguw+deuxfPU/x01loahxZpCMAriE=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1778140811; c=relaxed/simple;\n\tbh=hjnJXMERz2ZGC+zhl+PjUMkgbnKfSvTESDI2udLpX6Y=;\n\th=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date:\n\t Message-Id;\n b=G+g1RVjCuxPfGwe06mHBEb/3NWWGhXV5azsDiDoisEYMqpJVjSG31yKpWdFBGfUy8lyv5+XvgV3GeGnEYruwzOIh7kSkj0tSq0mgJi58dBCt+z6EBmXWDOCrZ/y/jUr58DZ5E00+Z4OddyNvWklb1mwlcELbfDU3qZNxBuLIEMI=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=q1iFUoPx; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1778140810;\n\tbh=hjnJXMERz2ZGC+zhl+PjUMkgbnKfSvTESDI2udLpX6Y=;\n\th=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date:From;\n\tb=q1iFUoPxkiFtx8oMy3U72d2tHi3Z0xW+PVL1XSiTF4eAiZGQ+Ii7m+38z+NYZPxic\n\t FGzaGMLeVI2UWVOAD9nU3Xv/WFKdxULJFvH17AV20doUhgfLGPj+qulNh4iWkuyi01\n\t Cx/loD+kqu7zQlXu8k4mbtq8U6WjSR3Tne0Lo0BMXqh4tXI6bhL0vxPl7NrQlfc59+\n\t Sxt2NrOHsSyQVVYJMZWDifmq8OCreYfNrZDy6EmStDQobZdOYS1vM4yjBi8fZjByCd\n\t 1ImODjPBay4cFFQ6SR83I0xU2GV2LxmzVdMwYh1Tq1W0Ir9c57aHRwbieeQhF5/aJA\n\t mwOObCiNdRhXA==","From":"sashiko-bot@kernel.org","Subject":"Re: [PATCH v8 phy-next 30/31] phy: remove temporary provider\n compatibility from consumer header","Reply-To":"sashiko@lists.linux.dev","To":"\"Vladimir Oltean\" ","Cc":"linux-pci@vger.kernel.org, wsa+renesas@sang-engineering.com","In-Reply-To":"<20260505100523.1922388-31-vladimir.oltean@nxp.com>","References":"<20260505100523.1922388-31-vladimir.oltean@nxp.com>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","Date":"Thu, 07 May 2026 08:00:09 +0000","Message-Id":"<20260507080010.3E3ADC2BCB8@smtp.kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":""}}]