[{"id":3687578,"web_url":"http://patchwork.ozlabs.org/comment/3687578/","msgid":"<20260507080006.21207C2BCC7@smtp.kernel.org>","list_archive_url":null,"date":"2026-05-07T08:00:05","subject":"Re: [PATCH v8 phy-next 21/31] drm/rockchip: dsi: include PHY\n provider header","submitter":{"id":93311,"url":"http://patchwork.ozlabs.org/api/people/93311/","name":null,"email":"sashiko-bot@kernel.org"},"content":"Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:\n- [Low] The patch includes a private header from another subsystem using a relative path (`../../../phy/phy-provider.h`), breaking subsystem isolation boundaries.\n--\n\ncommit 82e5f2c2c18bd726ffe8bde8959c86cab426ad1e\nAuthor: Vladimir Oltean \n\ndrm/rockchip: dsi: include PHY provider header\n\nThis commit updates the Rockchip DSI controller driver to include the PHY\nprovider header using a relative path. The driver acts as both a PHY consumer\nand provider, which requires access to the provider APIs.\n\n> diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c\n> index 3547d91b25d31..c0aaa51e02375 100644\n> --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c\n> +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c\n> @@ -27,6 +27,7 @@\n> #include \n> #include \n> \n> +#include \"../../../phy/phy-provider.h\" /* FIXME */\n\nThis isn't a bug, but does including a private header from another subsystem\nusing a deep relative path create brittle coupling across the source tree?\n\nWhile the commit message notes this is discouraged but difficult to address\nwithout moving the driver, bypassing the generic PHY framework's isolation\nboundaries this way could cause compilation issues if the phy directory\nstructure changes in the future.\n\n> #include \"rockchip_drm_drv.h\"\n> \n> #define DSI_PHY_RSTZ\t\t\t0xa0","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=sclFAZLM;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-54058-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"sclFAZLM\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gB4S11rN2z1yKd\n\tfor ; Thu, 07 May 2026 18:00:33 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 778553028813\n\tfor ; Thu, 7 May 2026 08:00:21 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id E1AD93806B3;\n\tThu, 7 May 2026 08:00:09 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FD8737FF75\n\tfor ; Thu, 7 May 2026 08:00:08 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 21207C2BCC7;\n\tThu, 7 May 2026 08:00:06 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1778140808; cv=none;\n b=f8dvWvQzABpZV3oJ/QyK2WLGDUj8Lw8d9omIaXxC082d7pka1L9QfDJdsaiisD5AqXcKsIyDlqsrPM9J+IR6lD8QJunRHN5yl4Wa4MxD8pw4yC3CbxyJ2rIv8bBxZELhRMAzwXPUShaYl1nDml5Ad5YLj/31x91t2JJfFgr6by0=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1778140808; c=relaxed/simple;\n\tbh=SR+fxGIHJLXN0ZRLCE64I6D0TckINCeme4AEx6Z9tQc=;\n\th=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date:\n\t Message-Id;\n b=N+FeRG/SQNwZ1bDG+FBSZteHItoMU7umLeQsGRLCnIf+YkVrn3vWAb3RiXN0/yXhnUNo8Vv7ecDbNgNFe3jzVdPd0SnjtygoYwyCwrJ2L4uLb0eTLZtwNNNiOQFwgaYK1zJHLuHSgVtNMTJZyHjvFvvWf+aF8wfgcwJuf4+SaZg=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=sclFAZLM; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1778140806;\n\tbh=SR+fxGIHJLXN0ZRLCE64I6D0TckINCeme4AEx6Z9tQc=;\n\th=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date:From;\n\tb=sclFAZLMdJmPn0r0LOflXrf/g9poZTebU80JibCfkSebrdPhZWjPHIMix58+ju+Ex\n\t 3lDdNRsKOjN9EhiezbGVer05iTquiiMI5QUQM1AO+h23AiRW5V791vo7YEVm1bEahp\n\t PuvV/hyllyRjmLkpfQNSR37qyDGKLpnLTrKoEoMRxIbsz7SM7bpemUS8Nc/0GXthfj\n\t sBxRGPyC+5/PM5M2iRv8p5hx3mX7S+gYujP4SEQz/IpcOYPk+LFccmApivJ0H8YdPY\n\t LWQBmBSgq2vnbsO6mcldP/lch4pKM4OF5J/vnCsZiC0hg23DvvDncSqO+WvN3OAUPV\n\t xL2pUsuZHRSCA==","From":"sashiko-bot@kernel.org","Subject":"Re: [PATCH v8 phy-next 21/31] drm/rockchip: dsi: include PHY\n provider header","Reply-To":"sashiko@lists.linux.dev","To":"\"Vladimir Oltean\" ","Cc":"linux-pci@vger.kernel.org, wsa+renesas@sang-engineering.com","In-Reply-To":"<20260505100523.1922388-22-vladimir.oltean@nxp.com>","References":"<20260505100523.1922388-22-vladimir.oltean@nxp.com>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","Date":"Thu, 07 May 2026 08:00:05 +0000","Message-Id":"<20260507080006.21207C2BCC7@smtp.kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":""}}]