[{"id":3687571,"web_url":"http://patchwork.ozlabs.org/comment/3687571/","msgid":"<20260507080001.508B8C2BCB8@smtp.kernel.org>","list_archive_url":null,"date":"2026-05-07T08:00:00","subject":"Re: [PATCH v8 phy-next 11/31] scsi: ufs: qcom: call phy_init()\n before phy_power_on()","submitter":{"id":93311,"url":"http://patchwork.ozlabs.org/api/people/93311/","name":null,"email":"sashiko-bot@kernel.org"},"content":"Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:\n- [Low] The patch introduces a compilation error by removing a label but leaving a `goto` statement referencing it.\n--\n\ncommit a9b6eda8b500b1bd6c9826051626a38b21091a29\nAuthor: Vladimir Oltean \n\nscsi: ufs: qcom: call phy_init() before phy_power_on()\n\nThis commit changes the order of PHY API calls in the Qualcomm UFS driver to\ncomply with the Generic PHY API expectations. It moves phy_init() to\nufs_qcom_init() and removes the vestigial initialization from\nufs_qcom_power_up_sequence().\n\n> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c\n> index bc037db46624a..9039b087bf214 100644\n> --- a/drivers/ufs/host/ufs-qcom.c\n> +++ b/drivers/ufs/host/ufs-qcom.c\n[ ... ]\n> @@ -513,13 +513,6 @@ static int ufs_qcom_power_up_sequence(struct ufs_hba *hba)\n> \n> \n> \t/* phy initialization - calibrate the phy */\n> -\tret = phy_init(phy);\n> -\tif (ret) {\n> -\t\tdev_err(hba->dev, \"%s: phy init failed, ret = %d\\n\",\n> -\t\t\t__func__, ret);\n> -\t\treturn ret;\n> -\t}\n> -\n> \tret = phy_set_mode_ext(phy, mode, host->phy_gear);\n> \tif (ret)\n> \t\tgoto out_disable_phy;\n\nDoes this cause a compilation error? The goto statement jumps to the\nout_disable_phy label, but the label is removed by this patch at the end of\nthe function.\n\n[ ... ]\n> @@ -529,23 +522,18 @@ static int ufs_qcom_power_up_sequence(struct ufs_hba *hba)\n[ ... ]\n> \tufs_qcom_select_unipro_mode(host);\n> \n> \treturn 0;\n> -\n> -out_disable_phy:\n> -\tphy_exit(phy);\n> -\n> -\treturn ret;\n> }","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=oeoc+MLZ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-pci+bounces-54051-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"oeoc+MLZ\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gB4Rh2GRpz1yCg\n\tfor ; Thu, 07 May 2026 18:00:16 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id C02BB30143DC\n\tfor ; Thu, 7 May 2026 08:00:11 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id D3CE237E2E7;\n\tThu, 7 May 2026 08:00:04 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 73D6D37C936\n\tfor ; Thu, 7 May 2026 08:00:02 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 508B8C2BCB8;\n\tThu, 7 May 2026 08:00:01 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1778140802; cv=none;\n b=c9g+wKubgjHvi6ZAml456u3SCIh04afSS4A+wCFu67hCVH8mRZJqVaOYSZYVSlhPCgdVuPujT14l6Qrks3f6OsGv/i82k56o1+VizZlv0jbVity0SR5z+ywkdyTajEkuFnpd51NkUUQuEUGlZCi179OqKhycm9nHySNJ5XVGCk8=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1778140802; c=relaxed/simple;\n\tbh=vJ62qumG08PeknTr7gYBqsK6MRDSnl9se9nS77auLw4=;\n\th=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date:\n\t Message-Id;\n b=CjavMXKPN94DByBme2uoiCb9dou8GsUEhH2o0IefRQBR4ySnopfx9vzsIt+33PCA1opdZHhSFCybOfrigq9m6pqxxbLqdp95dwfEAnJIyRMqlXEPXMPJAeipCCbdnVzHkWeN8dbopAXOFZerRktNyWIdyGBC31sjDGxZlKRUEb0=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=oeoc+MLZ; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1778140801;\n\tbh=vJ62qumG08PeknTr7gYBqsK6MRDSnl9se9nS77auLw4=;\n\th=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date:From;\n\tb=oeoc+MLZVH9BidiXnNVxuXVvU7yD2Dztiln2lxQh5xVTtT4mK0u7eOorcIsOOL/wI\n\t zNatHLihMjUQDpVBATmijDHg/gzr8PzcwUwJLWNoWpxIjs+eoZmOiJXPCRlAXAaW9u\n\t 4+MWJBppe7rPBjiiR69DKBohAcSVnhRItlXyw48W2vZh+gqgMA88KgDeSTOQCOcE28\n\t OlIj292Ay+1Koem3KUvcegP1giuCbEnMCT8b4Q/2ZYaxBKvN2fZu81ZyYrrmM9FL+S\n\t g5iJ43uleyWhbMJC4CJeUluyXAfdlNuUnOOs8yU/R+5UlXNXCT+QzdwVtrsIBNlO02\n\t wP+fVM1XnDfRg==","From":"sashiko-bot@kernel.org","Subject":"Re: [PATCH v8 phy-next 11/31] scsi: ufs: qcom: call phy_init()\n before phy_power_on()","Reply-To":"sashiko@lists.linux.dev","To":"\"Vladimir Oltean\" ","Cc":"linux-pci@vger.kernel.org, wsa+renesas@sang-engineering.com","In-Reply-To":"<20260505100523.1922388-12-vladimir.oltean@nxp.com>","References":"<20260505100523.1922388-12-vladimir.oltean@nxp.com>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","Date":"Thu, 07 May 2026 08:00:00 +0000","Message-Id":"<20260507080001.508B8C2BCB8@smtp.kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":""}}]