[{"id":3686599,"web_url":"http://patchwork.ozlabs.org/comment/3686599/","msgid":"<20260505162629.GA734488@bhelgaas>","list_archive_url":null,"date":"2026-05-05T16:26:29","subject":"Re: [PATCH v8 phy-next 01/31] PCI: cadence: Preserve all error codes\n in cdns_plat_pcie_probe()","submitter":{"id":67298,"url":"http://patchwork.ozlabs.org/api/people/67298/","name":"Bjorn Helgaas","email":"helgaas@kernel.org"},"content":"[+cc Tom, author of bd22885aa188 in case there's something subtle here]\n\nOn Tue, May 05, 2026 at 01:04:53PM +0300, Vladimir Oltean wrote:\n> The blamed commit functionally changed the error path of\n> cdns_pcie_host_probe(), now cdns_plat_pcie_probe().\n> \n> When the old code path executed \"goto err_get_sync\", the PCIe controller\n> probe function propagated the pm_runtime_get_sync() error code. The new\n> code doesn't, and returns 0.\n> \n> Similarly for the \"goto err_init\" previously triggered by\n> cdns_pcie_host_init() errors, and now triggered by\n> cdns_pcie_host_setup() and cdns_pcie_ep_setup() errors. These are not\n> propagated and will result in probing success, which is incorrect.\n> \n> Fixes: bd22885aa188 (\"PCI: cadence: Refactor driver to use as a core library\")\n> Signed-off-by: Vladimir Oltean \n> ---\n> Cc: Bjorn Helgaas \n> Cc: \"Krzysztof Wilczyński\" \n> Cc: Lorenzo Pieralisi \n> Cc: Manikandan K Pillai \n> Cc: Manivannan Sadhasivam \n> Cc: Rob Herring \n\nI guess this driver is orphaned.\n\nAcked-by: Bjorn Helgaas \n\n> v7->v8: patch is new, issue was flagged by Sashiko\n> https://sashiko.dev/#/patchset/20260430110652.558622-1-vladimir.oltean@nxp.com\n> ---\n> drivers/pci/controller/cadence/pcie-cadence-plat.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/drivers/pci/controller/cadence/pcie-cadence-plat.c b/drivers/pci/controller/cadence/pcie-cadence-plat.c\n> index b067a3296dd3..8b12a46b5601 100644\n> --- a/drivers/pci/controller/cadence/pcie-cadence-plat.c\n> +++ b/drivers/pci/controller/cadence/pcie-cadence-plat.c\n> @@ -126,7 +126,7 @@ static int cdns_plat_pcie_probe(struct platform_device *pdev)\n> \twhile (phy_count--)\n> \t\tdevice_link_del(cdns_plat_pcie->pcie->link[phy_count]);\n> \n> -\treturn 0;\n> +\treturn ret;\n\nThis affects cases where pm_runtime_get_sync(),\ncdns_pcie_host_setup(), or cdns_pcie_ep_setup() return failure.\n\nSeems right to me to fail the probe when these fail.\n\nNot all users of pm_runtime_get_sync() check for failure, but I think\nall the other controller drivers that do check return failures from\nthe .probe().\n\n> }\n> \n> static void cdns_plat_pcie_shutdown(struct platform_device *pdev)\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ide@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=P3c57A43;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-ide+bounces-5668-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"P3c57A43\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g93rh2KWkz1yJV\n\tfor ; Wed, 06 May 2026 02:29:56 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id E220830C14AD\n\tfor ; Tue, 5 May 2026 16:26:32 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id CBF1048AE25;\n\tTue, 5 May 2026 16:26:31 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id A3B0F3EE1C4;\n\tTue, 5 May 2026 16:26:31 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 0D7D5C2BCB4;\n\tTue, 5 May 2026 16:26:31 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777998391; cv=none;\n b=b2XqrhMSx9cgqNL5aIJy/EEMCa4y7XwGuepE7hurErLXRA/YP+qllxrFRA6frgYh6ik4XxdbRKMG3XxjzkJ5CpIYcU/98fjbb+v02TWZrWiYpLGc2cW3qHOoHeERPPSI7gFQjYbtQab9wwxkU+/yVJgo2bijO+gucVg7GiOaj/g=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777998391; c=relaxed/simple;\n\tbh=d9oRhAaRGwydDiDuK7BhCRvRWDp8pOBlU9+d0qcoLXY=;\n\th=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type:\n\t Content-Disposition:In-Reply-To;\n b=YjO8IVpMtSzCXGDC2g79qdmSNbTcXozg1SPKqgVjg/MPfo+j/eJYcAoIiSrMv0yC2XUaaLSE6CFwkfpe0i40Hb0Ukrk+jajW6M67+pxCmfcbur3xRzWfG3w1C/EKjxUMVnc8yjw1nBI3bv2L42x3uN9ljDkWbOiEsxuHHHZEPM0=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=P3c57A43; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1777998391;\n\tbh=d9oRhAaRGwydDiDuK7BhCRvRWDp8pOBlU9+d0qcoLXY=;\n\th=Date:From:To:Cc:Subject:In-Reply-To:From;\n\tb=P3c57A43Ly9U95oakv1tzSfsBDMAQvbGX3L5fDur0PPxN8g/BkGWOrF0IQ1vnb8kn\n\t q5FpFULXXt5CFm8Sy/qdB+pGfZ+595OPQ/+H2h/dpiAmaAvc14vlTx4Z7a774smhAG\n\t mRi8mWrUgi+n3TQ7klBwMiCHYz3eCKtTXeoo5Vugwd9W8wFUQWC/qxp4tUJmAVvLgS\n\t jHSgvFYD9WkXPVvCXJZvfwe/RjozMVbFHi4OoCu3mLeSQZDLHCSt79QQSlDeG2UmtL\n\t GPSyoqLckepvJjFkRnrQa3yfyKh+iIz18B0bEQzeLYkJERNnopW8hE0+mQWVZV5SLC\n\t bwYA1sJR8mQqw==","Date":"Tue, 5 May 2026 11:26:29 -0500","From":"Bjorn Helgaas ","To":"Vladimir Oltean ","Cc":"linux-phy@lists.infradead.org, Vinod Koul ,\n Neil Armstrong , dri-devel@lists.freedesktop.org,\n freedreno@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org,\n linux-arm-msm@vger.kernel.org, linux-can@vger.kernel.org,\n linux-gpio@vger.kernel.org, linux-ide@vger.kernel.org,\n linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,\n linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org,\n linux-riscv@lists.infradead.org, linux-rockchip@lists.infradead.org,\n linux-samsung-soc@vger.kernel.org, linux-scsi@vger.kernel.org,\n linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org,\n linux-usb@vger.kernel.org, netdev@vger.kernel.org, spacemit@lists.linux.dev,\n UNGLinuxDriver@microchip.com, Bjorn Helgaas , Krzysztof\n\t=?utf-8?q?Wilczy=C5=84ski?= ,\n Lorenzo Pieralisi ,\n Manikandan K Pillai ,\n Manivannan Sadhasivam , Rob Herring ,\n Tom Joseph ","Subject":"Re: [PATCH v8 phy-next 01/31] PCI: cadence: Preserve all error codes\n in cdns_plat_pcie_probe()","Message-ID":"<20260505162629.GA734488@bhelgaas>","Precedence":"bulk","X-Mailing-List":"linux-ide@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260505100523.1922388-2-vladimir.oltean@nxp.com>"}}]