[{"id":3686486,"web_url":"http://patchwork.ozlabs.org/comment/3686486/","msgid":"","list_archive_url":null,"date":"2026-05-05T13:58:42","subject":"Re: [PATCH v3 2/2] cmd: ufetch: only show comma separator if there\n was a previous feature","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 2026-05-05T09:14:31, Quentin Schulz wrote:\n> cmd: ufetch: only show comma separator if there was a previous feature\n>\n> Currently, if NET is disabled, the next feature to be printed will start\n> with a comma and a space which is not pretty. Add the comma and\n> whitespace only when a previous feature has already been shown.\n>\n> Signed-off-by: Quentin Schulz \n>\n> cmd/ufetch.c | 29 ++++++++++++++++++++---------\n> 1 file changed, 20 insertions(+), 9 deletions(-)\n\nReviewed-by: Simon Glass ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=ecEV1mXK;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"ecEV1mXK\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g90Vb1sgYz1yJ0\n\tfor ; Tue, 05 May 2026 23:59:03 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 2685684948;\n\tTue, 5 May 2026 15:59:00 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id A147E84949; Tue, 5 May 2026 15:58:58 +0200 (CEST)","from mail-ej1-x636.google.com (mail-ej1-x636.google.com\n [IPv6:2a00:1450:4864:20::636])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 5DEFE848FC\n for ; Tue, 5 May 2026 15:58:56 +0200 (CEST)","by mail-ej1-x636.google.com with SMTP id\n a640c23a62f3a-bc4edbedb4aso26593366b.1\n for ; Tue, 05 May 2026 06:58:56 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1777989536; cv=none;\n d=google.com; s=arc-20240605;\n b=Xa+xC1FZYUrOGikU0Lu9s/iDdVRQ2CvChTd+v0xwOUWvOZIKEeL/omfkRIvyS8S6Y9\n OjglJiRWOsWQaDl+dWvZ8nQTibkvFg7n0gtuaE5n3QYBEKrUFmihTAbLiq6J+BQoePaa\n J2k+NE6CpEhxFPyKfyCKC9uQUSJY/EUO2KWiqkJhH0I6Q2vk+xUxdzcmxoHFU8pCSHkj\n xz6uYi4/dSvIA5pmyh48zfVzC8ao2xja/ZIcP4cmapmD15tJ9KiO/NKda8k5LnkN2CqZ\n oveXVFgit3l3Mm2drm1cT8aYM8EMtZWKn4z7eGsZfT1BtHtPGQf1xo9n66sJBB5zYybH\n 2N6w==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=RY71QjM3iOWtYfCkUKp5LSYXi8tdeq5bW4y5rrpCObU=;\n fh=6sX/JMBB1a9uFLN+GawcERyIrfwFtjkiJ6nSJPOXXGg=;\n b=CoP1khPTUTr0XF6eUKbwIrwV+jxONAppma/NeSsbKsPsKg+sXjUtRaqU0Z4D6FSo21\n 4zQjDX4jfWxcEwt0GPY9ssThWRrQ1lFJUh04AQc9dQZq2JxQFTgqa6BiScMVcNAsNBWs\n o23iFD+tzrYVlux90DuafCs94qJlOXlI7y8ELpl5RFKgfjoOVxHDrUWRxjGZwT5QA6F9\n oZ+2ZtUAVN9G2XwvzIhxAf4Aj58tQpf38MbwoRxHzuv76i5e8pmWfDHoXa/DrvsFNsvD\n AwatMwdkJjJdbjEJTEfXoa0tQA1KQaXjfQwqwgeRGtneL/SHKE4Kib003+ZusPiwoqpe\n PmwA==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1777989536; x=1778594336; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=RY71QjM3iOWtYfCkUKp5LSYXi8tdeq5bW4y5rrpCObU=;\n b=ecEV1mXKzDE3GVq55JaDXOBqAPndcBk6ArDQAy4MxS3YadrFLcX9JJVo7a/CtRwSnG\n BeOdhm9PFM4lZ4hZKYE/fVXC+Zg+bu72m9rw2SzuSMu6psUjPElYtp3uwC4yFnAlMx0v\n QAEigjqFwgBc3tEG22/XCmJiW4VX73loKMxIw=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777989536; x=1778594336;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=RY71QjM3iOWtYfCkUKp5LSYXi8tdeq5bW4y5rrpCObU=;\n b=IEKYyESO4LvjXOLwDWuQVq4uoeaWVhsdLpaXPBMU0dwMpRPXE1dKzx6m4FAPtzgg2o\n uO9BFiWHh9BV3xA003ekKahfPRaykVe5uumCtJH/DvRV3v6OwNtXC88b+LzpZruYsKvb\n KdqiS0sTuQzhTQ3nVsb2wnyojQ8gBvG+whGhx13wWRZfLTTNwu6HTZW8k1Y7P/CUHvDq\n oJ3RuVvy2DSZxZZSaE/0Hcp89nRAVh7YO2aqLVHyTuMmuoUJlWWMpvLa1qK4dUD2Mh04\n zJH2atNVLneqXwyb6WvgYuGi0beCPQ0yuWD2ksIZ/ABY75pjyPBocvG25VVGODz+rag4\n VWig==","X-Gm-Message-State":"AOJu0YzZtFL36vsu26P11y56tUk9ljZUhgBSxPZarwhHswhkwpgArs8N\n aeaFnS6Mmu6jp/4EnloT/d9QxbFGrfHnuBRU9W4tg5joHUzRb3KVMeeSJXdPGge8jLOC3C0lzLs\n vr/E9DtzMH1gPy0oUG2Q2Mf8t0WsqBUUmav3rdmVC","X-Gm-Gg":"AeBDiev/6M7kpwhZa+9IzTKbIaMG53Wl6gMd2ARyN9jmzjTIWOidc6KPy+J/12WPo/k\n I2NIJjo/NfHyA0Vu97QgpRrUJ+hfuAwCQTgRBy9MogggT4COYkibDDWce3vLjkMSa1yWSCWPreC\n sV+XVbnFjM2x2Ir2KZpo3/te/X++6g90bkH/6zj5OisAfqOc0upmtIoeLwa6jI9WaChkgt3fYDd\n 4UcHo0/mHXnC1975NVdWZ3R507C9hKSeMIR7XXywWef5BlIhVlP9Pe3m2YF+jJJ1MBv9jfQL0XJ\n wvgelKKwy5MKqND1","X-Received":"by 2002:a17:906:fe03:b0:ba6:4e0f:e396 with SMTP id\n a640c23a62f3a-bbffad38563mr799157166b.12.1777989535770; Tue, 05 May 2026\n 06:58:55 -0700 (PDT)","MIME-Version":"1.0","References":"<20260505-ufetch-net-v3-0-eee5eb9ca5ce@cherry.de>\n <20260505-ufetch-net-v3-2-eee5eb9ca5ce@cherry.de>","In-Reply-To":"<20260505-ufetch-net-v3-2-eee5eb9ca5ce@cherry.de>","From":"Simon Glass ","Date":"Tue, 5 May 2026 07:58:42 -0600","X-Gm-Features":"AVHnY4JagoXdSz75zn0ROlxoHc-uPM9gY1ZnrO60L7KktpYQz0jo5l7SuZUz1Y4","Message-ID":"\n ","Subject":"Re: [PATCH v3 2/2] cmd: ufetch: only show comma separator if there\n was a previous feature","To":"foss+uboot@0leil.net","Cc":"u-boot@lists.denx.de, Casey Connolly ,\n Tom Rini ,\n Ilias Apalodimas ,\n Andrew Goodbody ,\n Peter Robinson ,\n Heinrich Schuchardt , Simon Glass ,\n Quentin Schulz ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]