[{"id":3686141,"web_url":"http://patchwork.ozlabs.org/comment/3686141/","msgid":"<3e1a653b-81bc-4008-8f84-77c823aeef49@kernel.org>","date":"2026-05-05T05:37:05","subject":"Re: [PATCH net] net: wan: fsl_ucc_hdlc: free tx_skbuff in\n uhdlc_memclean","submitter":{"id":92089,"url":"http://patchwork.ozlabs.org/api/people/92089/","name":"Christophe Leroy (CS GROUP)","email":"chleroy@kernel.org"},"content":"Le 04/05/2026 à 18:11, Holger Brunck a écrit :\n> When cleaning up the resources we need to iterate over the\n> tx_skbuf array to free pending TX messages.\n> \n> Fixes: c19b6d246a35 (\"drivers/net: support hdlc function for QE-UCC\")\n> Signed-off-by: Holger Brunck <holger.brunck@hitachienergy.com>\n> ---\n>   drivers/net/wan/fsl_ucc_hdlc.c | 7 +++++++\n>   1 file changed, 7 insertions(+)\n> \n> diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c\n> index adf3863463f5..68f78aeabdc3 100644\n> --- a/drivers/net/wan/fsl_ucc_hdlc.c\n> +++ b/drivers/net/wan/fsl_ucc_hdlc.c\n> @@ -739,6 +739,8 @@ static int uhdlc_open(struct net_device *dev)\n>   \n>   static void uhdlc_memclean(struct ucc_hdlc_private *priv)\n>   {\n> +\tint i;\n> +\n>   \tqe_muram_free(ioread16be(&priv->ucc_pram->riptr));\n>   \tqe_muram_free(ioread16be(&priv->ucc_pram->tiptr));\n>   \n> @@ -769,6 +771,11 @@ static void uhdlc_memclean(struct ucc_hdlc_private *priv)\n>   \tkfree(priv->rx_skbuff);\n>   \tpriv->rx_skbuff = NULL;\n>   \n> +\tfor (i = 0; i < TX_BD_RING_LEN) {\n> +\t\tkfree(priv->tx_skbuff[i]);\n\nI don't think you can just kfree() an skb like this.\n\nI think you have to call dev_kfree_skb_any() instead.\n\nChristophe\n\n\n> +\t\tpriv->tx_skbuff[i] = NULL;\n> +\t}\n> +\n>   \tkfree(priv->tx_skbuff);\n>   \tpriv->tx_skbuff = NULL;\n>","headers":{"Return-Path":"\n <linuxppc-dev+bounces-20439-incoming=patchwork.ozlabs.org@lists.ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=TMKGNkLX;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20439-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2600:3c0a:e001:78e:0:1991:8:25\"","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=TMKGNkLX;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org;\n envelope-from=chleroy@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8nMY0Lj1z1yJ0\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 05 May 2026 15:37:12 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g8nMX005cz2xmV;\n\tTue, 05 May 2026 15:37:11 +1000 (AEST)","from sea.source.kernel.org (sea.source.kernel.org\n [IPv6:2600:3c0a:e001:78e:0:1991:8:25])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g8nMV6n6dz2xMV\n\tfor <linuxppc-dev@lists.ozlabs.org>; Tue, 05 May 2026 15:37:10 +1000 (AEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby sea.source.kernel.org (Postfix) with ESMTP id 4F3A243FD6;\n\tTue,  5 May 2026 05:37:08 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 00FD9C2BCB4;\n\tTue,  5 May 2026 05:37:06 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1777959431;\n\tcv=none;\n b=YikM2NlRkwEaLsH1bARMF7o/iLdN0TGjA+8r1Vv/BofUD+hAwbZGgOTAAno83sqlzI/Kecv3fOs5v3hL9tW2niuSxRF8Gjo2HAm3gAtbB5Q7HFbEU3/FW7tQMVL4QVE6ftoa/BLrZSSmBn3p665It9fib4uOSQoMXPfg4dCo97viO6q6XZMp/w0L3C76wGKoUQ99SKWz+JmJpan3/7EB++muuLfGRWV56JVu1aHz5zoQ6t1i1mI9XBOUaIz7L93Oxmh97TWLKfpWlgD2gXs5ATe7/utA7aVauAYrKaow5a1NU8snO8TSSiCLugjo3yjXHvvg1btkm6qB/JeJYr2XCg==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1777959431; c=relaxed/relaxed;\n\tbh=j7tnTrh+pj6vQz8i6B38njsfVGgBXG6wpBp9OTw2xKg=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=jwnCNBAgazLErcT4qQfzwszNAhAHv6muj8n2AovagLz3rqnAabSc9MakArJZBDr6c9XJI7tVmEABXCb0aNB5gbsrd0Mnm35muZJ5FMMPOcjLLa1hw2xfae18phM9ZvKQJiqDBODc50CnZ4BXhQ9+4q5w9HngraIpghHKdJSck32wvaWPKvfTy+vhcg+474Gli1PaNQCYqsNA/KfsdAhNDHxD7diHJ09888JowYmTr9ZvxesrxXBq9HVmIK8wPqp7lkAin7lQSyEB0jGWzG7aM16WD2hP2BFSRiEvqRalQQDO/+6NLfsb4HvLxY+rjB+oTzBi3gk8APhzDv/JRNn3Xw==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=TMKGNkLX; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c0a:e001:78e:0:1991:8:25;\n helo=sea.source.kernel.org; envelope-from=chleroy@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1777959428;\n\tbh=w7dQK57+pO4cmDbX9FAl4uLfSMH4ddaq1KgiB3tb0+k=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=TMKGNkLXRidii1NpLdfVStwvVqd/ZEqEf3zEbyy9/gCaeZpf82yg5OHn/QSY29kHs\n\t xr+NHdYVwj0ta4m77b5TxFMz+oTW64lkR9nMbWOCDfjBCgXBIDRxI+jnR0PmawokC7\n\t bOvvd67+J8RL/9l6paZBow5hb0dRGk8BEMP7fBSG+gf7aRTWdGztYSHJJSPya7OTtb\n\t OofBCWpkhWsCa/MjGufIYmme2DMcD3nRV/Yq9OBEltGzRik7aKHaxvBRQuKneg2ikY\n\t +A8NURQHyKqYHx+bAg1NIU5EVEmBrF+Bw51trnz1XE0ZQdCvfVJcLPKgO9yHV+c8st\n\t 270lBMnEIu4vQ==","Message-ID":"<3e1a653b-81bc-4008-8f84-77c823aeef49@kernel.org>","Date":"Tue, 5 May 2026 07:37:05 +0200","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"<linuxppc-dev.lists.ozlabs.org>","List-Help":"<mailto:linuxppc-dev+help@lists.ozlabs.org>","List-Owner":"<mailto:linuxppc-dev+owner@lists.ozlabs.org>","List-Post":"<mailto:linuxppc-dev@lists.ozlabs.org>","List-Archive":"<https://lore.kernel.org/linuxppc-dev/>,\n  <https://lists.ozlabs.org/pipermail/linuxppc-dev/>","List-Subscribe":"<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n  <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n  <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>","List-Unsubscribe":"<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>","Precedence":"list","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH net] net: wan: fsl_ucc_hdlc: free tx_skbuff in\n uhdlc_memclean","To":"Holger Brunck <holger.brunck@hitachienergy.com>, netdev@vger.kernel.org","Cc":"linuxppc-dev@lists.ozlabs.org, andrew+netdev@lunn.ch, qiang.zhao@nxp.com,\n horms@kernel.org","References":"<20260504161145.2217950-1-holger.brunck@hitachienergy.com>","Content-Language":"fr-FR","From":"\"Christophe Leroy (CS GROUP)\" <chleroy@kernel.org>","In-Reply-To":"<20260504161145.2217950-1-holger.brunck@hitachienergy.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-0.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}},{"id":3686224,"web_url":"http://patchwork.ozlabs.org/comment/3686224/","msgid":"<AM0PR06MB103966EF99B706158C49CB3EAF73E2@AM0PR06MB10396.eurprd06.prod.outlook.com>","date":"2026-05-05T08:33:34","subject":"RE: [PATCH net] net: wan: fsl_ucc_hdlc: free tx_skbuff in\n uhdlc_memclean","submitter":{"id":82682,"url":"http://patchwork.ozlabs.org/api/people/82682/","name":"Holger Brunck","email":"holger.brunck@hitachienergy.com"},"content":"> \n> Le 04/05/2026 à 18:11, Holger Brunck a écrit :\n> > When cleaning up the resources we need to iterate over the tx_skbuf\n> > array to free pending TX messages.\n> >\n> > Fixes: c19b6d246a35 (\"drivers/net: support hdlc function for QE-UCC\")\n> > Signed-off-by: Holger Brunck <holger.brunck@hitachienergy.com>\n> > ---\n> >   drivers/net/wan/fsl_ucc_hdlc.c | 7 +++++++\n> >   1 file changed, 7 insertions(+)\n> >\n> > diff --git a/drivers/net/wan/fsl_ucc_hdlc.c\n> > b/drivers/net/wan/fsl_ucc_hdlc.c index adf3863463f5..68f78aeabdc3\n> > 100644\n> > --- a/drivers/net/wan/fsl_ucc_hdlc.c\n> > +++ b/drivers/net/wan/fsl_ucc_hdlc.c\n> > @@ -739,6 +739,8 @@ static int uhdlc_open(struct net_device *dev)\n> >\n> >   static void uhdlc_memclean(struct ucc_hdlc_private *priv)\n> >   {\n> > +     int i;\n> > +\n> >       qe_muram_free(ioread16be(&priv->ucc_pram->riptr));\n> >       qe_muram_free(ioread16be(&priv->ucc_pram->tiptr));\n> >\n> > @@ -769,6 +771,11 @@ static void uhdlc_memclean(struct ucc_hdlc_private\n> *priv)\n> >       kfree(priv->rx_skbuff);\n> >       priv->rx_skbuff = NULL;\n> >\n> > +     for (i = 0; i < TX_BD_RING_LEN) {\n> > +             kfree(priv->tx_skbuff[i]);\n> \n> I don't think you can just kfree() an skb like this.\n> \n> I think you have to call dev_kfree_skb_any() instead.\n> \n\nyes you are right or at least dev_kfree_skb() as the error handling code in\nucc_hdlc_tx does.\n\nThanks\nHolger","headers":{"Return-Path":"\n <linuxppc-dev+bounces-20444-incoming=patchwork.ozlabs.org@lists.ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=hitachienergy.com header.i=@hitachienergy.com\n header.a=rsa-sha256 header.s=selector1 header.b=aJmZDI/R;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20444-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=pass smtp.remote-ip=\"2a01:111:f403:c200::5\" arc.chain=microsoft.com","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=hitachienergy.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=hitachienergy.com header.i=@hitachienergy.com\n header.a=rsa-sha256 header.s=selector1 header.b=aJmZDI/R;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=hitachienergy.com\n (client-ip=2a01:111:f403:c200::5;\n helo=duzpr83cu001.outbound.protection.outlook.com;\n envelope-from=holger.brunck@hitachienergy.com; receiver=lists.ozlabs.org)","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=hitachienergy.com;"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8sHd5SFxz1yJ0\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 05 May 2026 18:34:05 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g8sHd490Nz2xSF;\n\tTue, 05 May 2026 18:34:05 +1000 (AEST)","from DUZPR83CU001.outbound.protection.outlook.com\n (mail-northeuropeazlp170120005.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c200::5])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange secp256r1 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g8sHX5xX2z2xGc\n\tfor <linuxppc-dev@lists.ozlabs.org>; Tue, 05 May 2026 18:34:00 +1000 (AEST)","from AM0PR06MB10396.eurprd06.prod.outlook.com (2603:10a6:20b:6fd::9)\n by AM9PR06MB7330.eurprd06.prod.outlook.com (2603:10a6:20b:2d0::22) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.25; Tue, 5 May\n 2026 08:33:34 +0000","from AM0PR06MB10396.eurprd06.prod.outlook.com\n ([fe80::f64e:6a20:6d85:183f]) by AM0PR06MB10396.eurprd06.prod.outlook.com\n ([fe80::f64e:6a20:6d85:183f%5]) with mapi id 15.20.9870.023; Tue, 5 May 2026\n 08:33:34 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1777970045;\n\tcv=pass;\n b=TJLb7doaxbyqUHkpf3FuNd+0wUwiG3O/U3PxbG4dCkgNkcC7T6/mRt0nN2f9e917CnEwEKK/3U2YOO7lPELG1sgEoIYhYc2LcDvNTDMzCWDY4r3Arwoar/orriAvDLk69mdEw1Rzm8JMscbswbz2VmdHXnTsdqKokeoLeGRw6eKPT/msQ82c3CgaJlKg3nS60UgYqhSnIGCzqxtEG9B20o56e9/f5qJJ3Ws5PTUAEBbQ0SD+PaDtSRuYNxlZwul7veHpXJBQENmQzjbQi6FhEkDVMwX3RpahSke9xv3UqLsGSo6drkRusn4OgUTgflKO/J1qJKw5NCd37+DGgXniEQ==","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=xFhdnMyGr2fe6RYG2PqmfgjLgAw5UxY4geib/dvSCmcwO47a/ZFyxzZALj3pHeIXGyk4POSsTidIsLe064hKehk/+UfzJ4MClvyR1ZiVR8gxSpQhLgUHWbLHLO9kLeO+GnazBcZ7e88vZGNo1GvlLy86fzwb/GI/wZ0Y7i9Pz3tlNlagqTe1NPYq3rjcROmXJutibBW0JGpdm8SG8DEn2ybOgEz65gove77sMq7ZkmgGMj5xV0+fb6aVBPR0rlbw7q3o135KxK2QczN85bIRXwLwo9C4GtO2jN2/Thzbu30pdxEIqzWEGpYiFkNmB+HG6780Afv72fpcfaGtQsQ7Tw=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1777970045; c=relaxed/relaxed;\n\tbh=a9nKivciaRUziGk20N7Bd6TmSicGqlJiKzVSJ033QBg=;\n\th=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To:\n\t Content-Type:MIME-Version;\n b=An5+DSrhMAHpZzSu+WZx4RLI2o31Cv6UdXEnBIDDT+Yb2mshtloiedoDIsF3w4d3G1DqJpSh/R8sVlsM0EBhZWrNx20sxcxT06BjFKLzbQdfNdaiTTM3QHeLJGkawkpz92MUlxJHWUWFL+p3hVAYQIany8FMcyoKYXYK2ooB6+W+5UI3j+XSj01Nci8jw+T+uw4+f10WyAI2mr7d98KxV3Ngi84un1L3z0i5HyvCJz9N748/jBgkXKUFUKvc6uGuu5mhdcaYVBD3ywZsQ7tvMavT7EI7pNp6sUHZnIa+yyzujn/QAQ41BCgJs72MjawrPNfWgFYwBMFCcYj3Winz+A==","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=a9nKivciaRUziGk20N7Bd6TmSicGqlJiKzVSJ033QBg=;\n b=U/4ulPKjNgrS+Tkui8B28vDMDbAeN5VJnPAtygNjumue4kyCHiuy/hzmsVV9wID8ASrKMaBnxggUukIsmdOs+4xaC2kb4SeZdd8//lLF/FDEFL5255vYB2M0ZRzQEaf5gVHXwCN31hWjmwSBzAUyYLVNSe1Pv/Ez1PDUOt1KhvV88xYVSLIZYcVzbGQqBE14s5CMNNib//83V8SYuXctB4IKyN6DRri10gzwO76IGs4LZiaaRD7AmvVnUdrqjHxqilmXFjxJLr/YTvPdGBanjPE9a5HfudW6+H/5l9iEpSx0DMhI+ZVYrwx1EL9WYd/ScyHLIgUtjwiEgFt7XBa3RQ=="],"ARC-Authentication-Results":["i=2; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=hitachienergy.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=hitachienergy.com header.i=@hitachienergy.com\n header.a=rsa-sha256 header.s=selector1 header.b=aJmZDI/R; dkim-atps=neutral;\n spf=pass (client-ip=2a01:111:f403:c200::5;\n helo=duzpr83cu001.outbound.protection.outlook.com;\n envelope-from=holger.brunck@hitachienergy.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=hitachienergy.com","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=hitachienergy.com; dmarc=pass action=none\n header.from=hitachienergy.com; dkim=pass header.d=hitachienergy.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=hitachienergy.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=a9nKivciaRUziGk20N7Bd6TmSicGqlJiKzVSJ033QBg=;\n b=aJmZDI/RVmUihYCAl8/If1viHdVfognqG2m31swUlp9A+wrNG0s5Lg/T6NwLf/Va+gQd0ufdUvSPgb2db06ifhdBHMjhxFpdDvfyD9RBP1dI9TCUJ4Vs+uAzBGCQo4YXCY469xC75VSfGX5mBAeG3eQzrJESSLP3KBE0f8stbXUOTQ0usfjTw7gvo7DIKvhbacLUZT1moFjtppwNZgmogDRw3cZED02ypJ4pOmVN+yo24cszNGxH5NHIClRoUjim/5zU8bguX+I2Hi5Bhwncrcte21UAtD2D88DkbNM89/gzYhaPihFiZoqw4takxYBiOe+VCx2BGa6On9ZgAVdu4g==","From":"Holger Brunck <holger.brunck@hitachienergy.com>","To":"\"Christophe Leroy (CS GROUP)\" <chleroy@kernel.org>,\n\t\"netdev@vger.kernel.org\" <netdev@vger.kernel.org>","CC":"\"linuxppc-dev@lists.ozlabs.org\" <linuxppc-dev@lists.ozlabs.org>,\n\t\"andrew+netdev@lunn.ch\" <andrew+netdev@lunn.ch>, \"qiang.zhao@nxp.com\"\n\t<qiang.zhao@nxp.com>, \"horms@kernel.org\" <horms@kernel.org>","Subject":"RE: [PATCH net] net: wan: fsl_ucc_hdlc: free tx_skbuff in\n uhdlc_memclean","Thread-Topic":"[PATCH net] net: wan: fsl_ucc_hdlc: free tx_skbuff in\n uhdlc_memclean","Thread-Index":"AQHc2+C9zkursVznM0ykjVaFtNrz0rX+6qiAgAAws/A=","Date":"Tue, 5 May 2026 08:33:34 +0000","Message-ID":"\n <AM0PR06MB103966EF99B706158C49CB3EAF73E2@AM0PR06MB10396.eurprd06.prod.outlook.com>","References":"<20260504161145.2217950-1-holger.brunck@hitachienergy.com>\n <3e1a653b-81bc-4008-8f84-77c823aeef49@kernel.org>","In-Reply-To":"<3e1a653b-81bc-4008-8f84-77c823aeef49@kernel.org>","Accept-Language":"en-GB, en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=hitachienergy.com header.i=@hitachienergy.com\n header.a=rsa-sha256 header.s=selector1 header.b=aJmZDI/R;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20444-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=pass smtp.remote-ip=\"2a01:111:f403:c200::5\" arc.chain=microsoft.com","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=hitachienergy.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=hitachienergy.com header.i=@hitachienergy.com\n header.a=rsa-sha256 header.s=selector1 header.b=aJmZDI/R;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=hitachienergy.com\n (client-ip=2a01:111:f403:c200::5;\n helo=duzpr83cu001.outbound.protection.outlook.com;\n envelope-from=holger.brunck@hitachienergy.com; receiver=lists.ozlabs.org)","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=hitachienergy.com;"],"x-ms-publictraffictype":"Email","x-ms-traffictypediagnostic":"AM0PR06MB10396:EE_|AM9PR06MB7330:EE_","x-ms-office365-filtering-correlation-id":"bbc9aa4f-1310-4adf-7ab1-08deaa80ff17","x-he-o365-outbound":"HEO365Out","x-ms-exchange-senderadcheck":"1","x-ms-exchange-antispam-relay":"0","x-microsoft-antispam":"\n BCL:0;ARA:13230040|366016|1800799024|376014|38070700021|56012099003|18002099003|22082099003;","x-microsoft-antispam-message-info":"\n QLCnHEBj2zJqQsITzzjy47Wm2Wxi4r9NzEx9y9XiAZsCjNjyEeUqY4S9GiBzP1Xo/2LCcMUTJ7d5zbXxxXlOdgbN0U6oBlZTDJNq1A3G8EyMHW105++3GUx4NcIe16vNk+/BWFhwnDlRBlfeF07qucUJWH4Qq7TN7VZs5O2vy2GIaJ3shBtWSMcio6VGzs8mB/973Sx9Phr8lSRucCEKEIHDUWW6eN2LvcvIWmPbNrWGDyZf3mpGMkY/gY6sME5a83gGFoTC/Y7WLYTZhTLLwXG3+b+I4KkqHYt5PFaINZO7GMRKChEZALNSOmCzlX5IOhtzluR1YJ5Q+2kdbsxdJCP7uOMx29sMSHDAq9o4tFifNRHqWIPJqTeMWhT+AhDSqugL0kNI9f+T47bWNGg5Tq++t8epwMuPxNlVIp5VPPSYGCrbernG7wla3wOWdLv7+S2/+iaEGsaR5OURDknsc/43VJ/GXXYs+oanod0YPFlDvjVZjMrcezPR2BwZ1XrOUNPAH2TmWS8RzvrkwyBAACnFr/vcME+JXldmtOoTSpmhh21LICSGI3/w7/g67B7JCR6MpTgk0RavcMEBkSXHo79GvdKo0RFwGs1iNZibZO0HrO4bNjTLGIM6FqG9Vug0AjXxzmTSOwbNzvnwrSdrZEaW9mc7Cx19LY/UDLVnavF0UHuRQ4/9/LmpdW9G7m4Q0XM3IKGGoiWDbGxqN6dbx9D7h30purGgHaxmIUZWsrpaSd3kK26c0FTzVrShrU4g","x-forefront-antispam-report":"\n CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR06MB10396.eurprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(38070700021)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101;","x-ms-exchange-antispam-messagedata-chunkcount":"1","x-ms-exchange-antispam-messagedata-0":"=?iso-8859-1?q?dyubrUH/WZcCHjraKJ+Ja18?=\n\t=?iso-8859-1?q?ojDUeXAU8EekDVEjpY/lM8EAelHcscvU1y+ijPowqH5WQwPBDA6edEw5y+3B?=\n\t=?iso-8859-1?q?a4TppuqrUkRpYTLFwdZ6UFAD0x9gqZieCH1yG5uzkWgWSj6eq9p7qtaoiCC2?=\n\t=?iso-8859-1?q?iPIM7dsTea2vQAf4cUQLPU8aux+5oaZUvNhqUpGAXqa6M4pdpSenESMDpmqn?=\n\t=?iso-8859-1?q?ZQ//OrZ59YlRETg4s06tLDMcnxzJrdrb/PZ4qlAS9KyB2bJ/f772+jIBuNQe?=\n\t=?iso-8859-1?q?pjP/8/duBjmsJo4DRx6GYIEJhlKYBvwgWVuJ6LDXByDLURkjL76CO2vZHCYE?=\n\t=?iso-8859-1?q?IJGcl7WfFbp+SbxgCihFf8XEYF185uIbVWsM82F/Z4DX0Nz+r1hBRbYGv45z?=\n\t=?iso-8859-1?q?STO1e4g1bcYkRD6Yvp5vP9ly3YOO54zrgGyx8y5z4TgN/KhQB/0lCgSoLTQi?=\n\t=?iso-8859-1?q?RVtSSkgHp5sasBAEzu8+9ieNtUgJs1jjoyX1J1XDuDaqIwBKhANTMuExczbZ?=\n\t=?iso-8859-1?q?4BK2TysK8ou2XLY6QYSpcXfft8DrqEn/LpZdLsd15TdBysvqe2J/+/meJBmO?=\n\t=?iso-8859-1?q?BEb+u9mKqH1yrK47xR1w6NJ58IkGC0Cjxq9osRIAG6V2+49bRVqlDvvGWegg?=\n\t=?iso-8859-1?q?iVFiH8iwXwE9KlXCvW8kbLnNx5K1BQ+T0cKWUyjV6vRhwkl8DguiVN2xUlfY?=\n\t=?iso-8859-1?q?tSH1SoKPrSlLJgOuF0x5rIicHOd713MIcSO/FqYRK9XZ1Frf5zz58UpQaHuY?=\n\t=?iso-8859-1?q?AVdM5RF9pvuZ0tDCBaoQRMr86goQ68ITE28/G/FWUn82I1xRMrmavruw6Owo?=\n\t=?iso-8859-1?q?4QLYbMEE6nIIJZLt21yGnOed9SM2NpXDdtxCDQTbbCv/mudFEdVGNlfT2d7K?=\n\t=?iso-8859-1?q?fpTtI/jvF0ESevhmdzozrVKUdzoJ9qKVJhdwhGhksMYbxmRt/ucaxMVekqSm?=\n\t=?iso-8859-1?q?zRab/vTIJw7T3I6j2q6WKUjEMlMpabeUjmBpmz6wUvDrakMml5I7wIKgpLoL?=\n\t=?iso-8859-1?q?eDRV4bRTJwJxrMMCFWD9CFjVWM5kgHGQS5gY0oYcILyxNbUH6FcZ6yzyH8Lj?=\n\t=?iso-8859-1?q?/k2G/+Uhc4Pclg/ic+HoCSruSH/nDPU/MNYVhbXpbBiAtNU/u1AoRPvgqswd?=\n\t=?iso-8859-1?q?FbWKpMph2LxebFl7DmrWPkfCii4ITA7t/S96G9Xw8WQnTSkRH6Z67pjYJZ2t?=\n\t=?iso-8859-1?q?jLLvZGdQb9aP2VenVMvVoKUxBdt2068vH1f5eBRJC8YS/eQRJjHCKLGpv11T?=\n\t=?iso-8859-1?q?uqom+habJhVNwRsKYUmcAE+7pbDC/EweG5fAQ0De45CgvcT1Nx665cl7+cR+?=\n\t=?iso-8859-1?q?dk7qNj9kvNTKHZ1dW0Z6BJl5VnM/pxMy09ZN49UzuktcLQMGrlVvFewlZw/R?=\n\t=?iso-8859-1?q?X3KKFujZoqWYiSwQ1zMzzdPRjQQyJmSffzbKPp6bdY2KQpBLPDjBVED4mkQU?=\n\t=?iso-8859-1?q?XIRpX/qPIMHgiwqSE9NfOObMKZLcjVsL/fmSfvgLcTNcjgoWckCKe7R/mrNP?=\n\t=?iso-8859-1?q?rJx368xK8VjbJ/uttdaElsFAud/Ipz7SqzOdBkuX/OL56XV4q90tjXdZx7S+?=\n\t=?iso-8859-1?q?zSRcO3F76nSKPhS+OrWnv02gCDYoebUitxtI60bnA0ECDrcHlLNIpy6BVQ61?=\n\t=?iso-8859-1?q?YApZiQWS0B7Tg2wg+mrDAvH+ZQqck8HJSBUSW7AsqJAKifHBKz+yGuZNFhGN?=\n\t=?iso-8859-1?q?Cbu5hAc3e7aL2Y5sUMsiQG9VYveiZ+fsBD1DRd6yTZxEwgz0KTIFGVm7i4ZZ?=\n\t=?iso-8859-1?q?NnIYX/Igkkjj+cXsK14wQ4WEc8hE/9QqAu1PCJ0sM19V8cUI+BWVGU0HzH/u?=\n\t=?iso-8859-1?q?iacfA9vY=3D?=","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"<linuxppc-dev.lists.ozlabs.org>","List-Help":"<mailto:linuxppc-dev+help@lists.ozlabs.org>","List-Owner":"<mailto:linuxppc-dev+owner@lists.ozlabs.org>","List-Post":"<mailto:linuxppc-dev@lists.ozlabs.org>","List-Archive":"<https://lore.kernel.org/linuxppc-dev/>,\n  <https://lists.ozlabs.org/pipermail/linuxppc-dev/>","List-Subscribe":"<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n  <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n  <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>","List-Unsubscribe":"<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>","Precedence":"list","MIME-Version":"1.0","X-OriginatorOrg":"hitachienergy.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"AM0PR06MB10396.eurprd06.prod.outlook.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n bbc9aa4f-1310-4adf-7ab1-08deaa80ff17","X-MS-Exchange-CrossTenant-originalarrivaltime":"05 May 2026 08:33:34.4960\n (UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"7831e6d9-dc6c-4cd1-9ec6-1dc2b4133195","X-MS-Exchange-CrossTenant-mailboxtype":"HOSTED","X-MS-Exchange-CrossTenant-userprincipalname":"\n /ZiMmhLNGh8y+Ag9wugV7lqUMrjdQUmUCLSp5GkHzsikZnjZ6WMPi5TPhEdJL5G2YX0+FalzsXBXmxtRQtBvWRCMTema/u9zyMjsOGjoeCA=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"AM9PR06MB7330","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=disabled\n\tversion=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}},{"id":3686773,"web_url":"http://patchwork.ozlabs.org/comment/3686773/","msgid":"<20260505164736.26d203a8@kernel.org>","date":"2026-05-05T23:47:36","subject":"Re: [PATCH net] net: wan: fsl_ucc_hdlc: free tx_skbuff in\n uhdlc_memclean","submitter":{"id":77159,"url":"http://patchwork.ozlabs.org/api/people/77159/","name":"Jakub Kicinski","email":"kuba@kernel.org"},"content":"On Tue, 5 May 2026 08:33:34 +0000 Holger Brunck wrote:\n> > I don't think you can just kfree() an skb like this.\n> > \n> > I think you have to call dev_kfree_skb_any() instead.\n> \n> yes you are right or at least dev_kfree_skb() as the error handling code in\n> ucc_hdlc_tx does.\n\nPlease make it clear in the commit message how you discovered\nthe issue and how you tested your patches.","headers":{"Return-Path":"\n <linuxppc-dev+bounces-20492-incoming=patchwork.ozlabs.org@lists.ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=mSZqag/N;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20492-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=172.105.4.254","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=mSZqag/N;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=kuba@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g9FYn4rBNz1yJq\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 06 May 2026 09:47:41 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g9FYm2hd8z2xsW;\n\tWed, 06 May 2026 09:47:40 +1000 (AEST)","from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g9FYl4F0gz2xdR\n\tfor <linuxppc-dev@lists.ozlabs.org>; Wed, 06 May 2026 09:47:39 +1000 (AEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id 85BA36132B;\n\tTue,  5 May 2026 23:47:37 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id D4839C2BCB4;\n\tTue,  5 May 2026 23:47:36 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1778024860;\n\tcv=none;\n b=ceqhc73LQWb5vZHbUfKvi8ca55qZgIdVdvviyQYpoed7FM3+o1TCbP6RkXcjBQdYQ1+0SDgUhEWQZUJ9+dt66XkynRBxcBSefiqnGw6QDvRt6VLabXYIFKcospahTV3G3XRbvnJirE0oDqz3xItYPCwPRejDLGRFzLVz+lYoC+0aybS/KT3unA0TEr3K2O5wszwtlfRJ46kSIW297d8NjyefWydohZBLYnyHI7NKwH5fvAw5rImFKo2APEln9bpLhBL+0oWjRh83ojivuNj/90ghRqu02woHbgWcuoCHxrDdDfh/u3xVePVrWLewNTpSsv1v+qyOBcHhrHkEDBchUw==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1778024860; c=relaxed/relaxed;\n\tbh=2iuMIIuaxy+LxY6r3I3UWO/Kp0tjbJC+0BF4bNilSQA=;\n\th=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=lvzwixJN/txH1ffPGuMY8rCbOoHt7P06D04gMd+WywD5J8IyGScB1TwCU76yRRsw5CeEukd+u6F7tO+0tRPsJpeD5Is09DY+50dx52MP5VUZIi2y+ALFKip+hUxwVhm4noOsgpHbaHVGUQ9+D2Pz2HVs3FEfo+BvzJgYYVAXuhR/cHA6P6c8vzAHVQ2Lwm1iIk4wFEk2VU0C3vkGydely3XAlau1RIfSSgiVjHOix8iWEpoZ6nQpg/h5qQpBQkaCYIadCwMI62uiVx8rQBUTCCqrhWA7d2h+yU98htctKamPSKfu/WTyh5keAl1OiR5JsKrQRCPVUCkHIAKQC72bIg==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=mSZqag/N; dkim-atps=neutral;\n spf=pass (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=kuba@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1778024857;\n\tbh=3r0ZNyX7X5IFV2nmj70h8MMAibad4YbMGo46z2KFL3k=;\n\th=Date:From:To:Cc:Subject:In-Reply-To:References:From;\n\tb=mSZqag/N7r8AJmkmWKSMWc2XDHcFWL0l2IRahDmpTvkdMKpw0q5vX/uyu1YxkwexJ\n\t OJEYOiGJiXJx/edjOD5FZ0SnOBHB5aBpjgoiy+OGXUW2gOYQAclwhnUE/wheB9K7kU\n\t J+V0ow0Mf25DcPNpw5YCZgeF4/zaFAJ2eWlpOxdqKgBpnSPCRIVih0Li0BIYc3nIzv\n\t Wxxm3XLwajFtHA2Iti3ZedeI3UGVgY9ZmDOHBKpMuYxsthWO5Je2ARt4n6OyPkb+lg\n\t 8xHsqfmznJ9lUUK8MiY2Tp1COk/s+/rIXhmTZ+nWHY7yY2v9bulRxbchQfXwSEOPp7\n\t Ie/iBEug+i0kw==","Date":"Tue, 5 May 2026 16:47:36 -0700","From":"Jakub Kicinski <kuba@kernel.org>","To":"Holger Brunck <holger.brunck@hitachienergy.com>","Cc":"\"Christophe Leroy (CS GROUP)\" <chleroy@kernel.org>,\n \"netdev@vger.kernel.org\" <netdev@vger.kernel.org>,\n \"linuxppc-dev@lists.ozlabs.org\" <linuxppc-dev@lists.ozlabs.org>,\n \"andrew+netdev@lunn.ch\" <andrew+netdev@lunn.ch>, \"qiang.zhao@nxp.com\"\n <qiang.zhao@nxp.com>, \"horms@kernel.org\" <horms@kernel.org>","Subject":"Re: [PATCH net] net: wan: fsl_ucc_hdlc: free tx_skbuff in\n uhdlc_memclean","Message-ID":"<20260505164736.26d203a8@kernel.org>","In-Reply-To":"\n <AM0PR06MB103966EF99B706158C49CB3EAF73E2@AM0PR06MB10396.eurprd06.prod.outlook.com>","References":"<20260504161145.2217950-1-holger.brunck@hitachienergy.com>\n\t<3e1a653b-81bc-4008-8f84-77c823aeef49@kernel.org>\n\t<AM0PR06MB103966EF99B706158C49CB3EAF73E2@AM0PR06MB10396.eurprd06.prod.outlook.com>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"<linuxppc-dev.lists.ozlabs.org>","List-Help":"<mailto:linuxppc-dev+help@lists.ozlabs.org>","List-Owner":"<mailto:linuxppc-dev+owner@lists.ozlabs.org>","List-Post":"<mailto:linuxppc-dev@lists.ozlabs.org>","List-Archive":"<https://lore.kernel.org/linuxppc-dev/>,\n  <https://lists.ozlabs.org/pipermail/linuxppc-dev/>","List-Subscribe":"<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n  <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n  <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>","List-Unsubscribe":"<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Spam-Status":"No, score=-0.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}},{"id":3686875,"web_url":"http://patchwork.ozlabs.org/comment/3686875/","msgid":"<AM0PR06MB10396510359D3108860402A16F73F2@AM0PR06MB10396.eurprd06.prod.outlook.com>","date":"2026-05-06T08:27:40","subject":"RE: [PATCH net] net: wan: fsl_ucc_hdlc: free tx_skbuff in\n uhdlc_memclean","submitter":{"id":82682,"url":"http://patchwork.ozlabs.org/api/people/82682/","name":"Holger Brunck","email":"holger.brunck@hitachienergy.com"},"content":"> On Tue, 5 May 2026 08:33:34 +0000 Holger Brunck wrote:\n> > > I don't think you can just kfree() an skb like this.\n> > >\n> > > I think you have to call dev_kfree_skb_any() instead.\n> >\n> > yes you are right or at least dev_kfree_skb() as the error handling\n> > code in ucc_hdlc_tx does.\n> \n> Please make it clear in the commit message how you discovered the issue and\n> how you tested your patches.\n\ncurrently the driver is broken if you compile it as a module and try to reload it.\nThe issue was discovered by a sashiko review for a previous patch of me:\n https://sashiko.dev/#/patchset/20260429114208.941011-1-holger.brunck%40hitachienergy.com\n\nStill there are further issues remaining in the driver. I will update the patch and\nthe commit message.\n\nBest regards\nHolger","headers":{"Return-Path":"\n <linuxppc-dev+bounces-20508-incoming=patchwork.ozlabs.org@lists.ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=hitachienergy.com header.i=@hitachienergy.com\n header.a=rsa-sha256 header.s=selector1 header.b=XTJdgneD;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20508-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=pass smtp.remote-ip=\"2a01:111:f403:c201::6\" arc.chain=microsoft.com","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=hitachienergy.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=hitachienergy.com header.i=@hitachienergy.com\n header.a=rsa-sha256 header.s=selector1 header.b=XTJdgneD;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=hitachienergy.com\n (client-ip=2a01:111:f403:c201::6;\n helo=am0pr02cu008.outbound.protection.outlook.com;\n envelope-from=holger.brunck@hitachienergy.com; receiver=lists.ozlabs.org)","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=hitachienergy.com;"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g9T6J51Lzz1y04\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 06 May 2026 18:28:08 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g9T6H4C65z2xpp;\n\tWed, 06 May 2026 18:28:07 +1000 (AEST)","from AM0PR02CU008.outbound.protection.outlook.com\n (mail-westeuropeazlp170130006.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c201::6])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange secp256r1 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g9T6F5nn6z2xdL\n\tfor <linuxppc-dev@lists.ozlabs.org>; Wed, 06 May 2026 18:28:05 +1000 (AEST)","from AM0PR06MB10396.eurprd06.prod.outlook.com (2603:10a6:20b:6fd::9)\n by VI1PR06MB6735.eurprd06.prod.outlook.com (2603:10a6:800:183::11) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.15; Wed, 6 May\n 2026 08:27:40 +0000","from AM0PR06MB10396.eurprd06.prod.outlook.com\n ([fe80::f64e:6a20:6d85:183f]) by AM0PR06MB10396.eurprd06.prod.outlook.com\n ([fe80::f64e:6a20:6d85:183f%5]) with mapi id 15.20.9870.023; Wed, 6 May 2026\n 08:27:40 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1778056087;\n\tcv=pass;\n b=emJ9QS2CWBgGB77Ezb98hIh/kfbIyHAVMpZKIci8GnV5el9X8UKecKUgrf30srgiZ548Xt1nUBOXH3yxNOKAv73BcDaT94Zas9QEysWDcqzu0vfteiAfvHCSr9Ot4dRf+SylRs02SpXInF/dRWACHz7uhDuZ0Nm7dX+oLNI8o1cw8OusDFMnh0v9HsUY2BIUFgN4O2ZOXt9uqCgXI64ORyJmHLNFa8rSSCMcJTjJEmQMcfuuls7k3ePNI+KlMofXBGVDzqZMIh0p0qCGk1D1rCvgOqQlKkUoFEtBrPXpR6VzihkGcSt7lx4hE3lH4ZlR0U4skKapvmmTZ5WmfWhNvw==","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=L5mlJon9QcToTttmbn5qFLzx5Y7r0xWSm9JnawdEM2s8+HWD5D1onuC1O7UdF+nqwq6UeW4+jeASyF+u3ZAYDbBa+kukJPIlD/BNd0Q5WXV7iEsGZaJPbj3MuQvmZ4Kt7Yl8SzErTIs5O9YqU2f78/JMvinS5kyIT6oHmkSau+Be3c6z8PzqrwE4Cux0Nf9bvWlZWFuCn6UPNZMM1b6lL9DV5Hq5iJKtoS2bbM1MRbTvnk94bnXJKVFX8p/DY1xrok/5IDp6avMelAkdx7uIUIOGnWa/DXoPQ88LBfzY8pHlcPaVp00iaquApedLcX4hrZ0WDDx8goK3nJXam8g1ig=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1778056087; c=relaxed/relaxed;\n\tbh=lOMP63VHRv6ZXzoIXW/OiUDw8YNfv9JOn3IVHrNuTBE=;\n\th=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To:\n\t Content-Type:MIME-Version;\n b=bg4vLDDg0k4C+2rqWXffMKC7GGJ0zKB7iuFDGnKzdyq4OlhQRUS2Qk1yz1ZtPeJ+N3x58mKrEs0TmNX/dKqN7/dYVxtAdzah/pl0gonAdSRuy1GdDMVO/gF1+svZ9arIQpreYyU7oywCVnZTROFebxDDJMm1ax1PLPMBo5TqAR/nrW8wjrEgUjc6ILwzoJm4FlHqaoG7HYJg8ohMepPfSjv6afdBt0NbJgtoSSl6iVfbS5hk1Or9C5qlxCaSIJSntLXO0LCjSZlL8CcgGY/JRse38ZfWcVs8S15hT1EXaMjGhJYORvabsugc0LC+dtY8oZWq8995kSF01i1aeG+XDw==","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=lOMP63VHRv6ZXzoIXW/OiUDw8YNfv9JOn3IVHrNuTBE=;\n b=e1OBZ7RjuJAHkJaSVWn5xDyAekY90oZCoLMJN6VrYjuZp12JAu7qao7eLTwrUA4cpf3T0CkDtegcNGAFN9VYFuV2y3RMCL4carLAAD8lVF8EabnYNJPoR0ACJmaeKc061l/C2A83DxfkqEqvFO+l8R29JrZtHgdZ+WN2tyLb/902mgJYLJIxFstozxwVnebTI/FM98EgJ83NqUzRzKXPSDeGW/724mG/P7kAaiHbw1ovhZy82wJj5igqpbpxCU5O+QQteSUEoSMVygMM7yP019u5iugM2LCFac0+OPWDat7YGSujQE3JYsOwd5HJxf9/XlyzUvxLDopKe3IU3OXR+w=="],"ARC-Authentication-Results":["i=2; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=hitachienergy.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=hitachienergy.com header.i=@hitachienergy.com\n header.a=rsa-sha256 header.s=selector1 header.b=XTJdgneD; dkim-atps=neutral;\n spf=pass (client-ip=2a01:111:f403:c201::6;\n helo=am0pr02cu008.outbound.protection.outlook.com;\n envelope-from=holger.brunck@hitachienergy.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=hitachienergy.com","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=hitachienergy.com; dmarc=pass action=none\n header.from=hitachienergy.com; dkim=pass header.d=hitachienergy.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=hitachienergy.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=lOMP63VHRv6ZXzoIXW/OiUDw8YNfv9JOn3IVHrNuTBE=;\n b=XTJdgneDSvNZYLDsIhp1wzCBZm0kgFSYsjK92jNyBQu8W89ekabBEUpeqqpZidvTK2qBk9KJHFuvjX8YUrEiign9pOlVvOL/22Y8vafo6dtrM4BbE2Eoouc0sJJ1pKxu6xlSg7dEkZxBr+t7FS4X4m8jaynwQw2JUbj2dnovQS/H0k6ZwVjl2JTBWFZsja5QX0cdPUuhusVWc+ko8HO+eM/DZVXPc6x2Yr+BQmlytzTJAlwSXm7/WBnFS8mhiyPQMalybVLIjFkaJGpqEAHVp3FcQ/dFDp1eMyMQ/JN5JW/MSu1bw2jOd+rS/UpG+qnXpxRVqhjokyYuUu1Rtg5+Bg==","From":"Holger Brunck <holger.brunck@hitachienergy.com>","To":"Jakub Kicinski <kuba@kernel.org>","CC":"\"Christophe Leroy (CS GROUP)\" <chleroy@kernel.org>,\n\t\"netdev@vger.kernel.org\" <netdev@vger.kernel.org>,\n\t\"linuxppc-dev@lists.ozlabs.org\" <linuxppc-dev@lists.ozlabs.org>,\n\t\"andrew+netdev@lunn.ch\" <andrew+netdev@lunn.ch>, \"qiang.zhao@nxp.com\"\n\t<qiang.zhao@nxp.com>, \"horms@kernel.org\" <horms@kernel.org>","Subject":"RE: [PATCH net] net: wan: fsl_ucc_hdlc: free tx_skbuff in\n uhdlc_memclean","Thread-Topic":"[PATCH net] net: wan: fsl_ucc_hdlc: free tx_skbuff in\n uhdlc_memclean","Thread-Index":"AQHc2+C9zkursVznM0ykjVaFtNrz0rX+6qiAgAAws/CAAP/8AIAAijmQ","Date":"Wed, 6 May 2026 08:27:40 +0000","Message-ID":"\n <AM0PR06MB10396510359D3108860402A16F73F2@AM0PR06MB10396.eurprd06.prod.outlook.com>","References":"<20260504161145.2217950-1-holger.brunck@hitachienergy.com>\n\t<3e1a653b-81bc-4008-8f84-77c823aeef49@kernel.org>\n\t<AM0PR06MB103966EF99B706158C49CB3EAF73E2@AM0PR06MB10396.eurprd06.prod.outlook.com>\n <20260505164736.26d203a8@kernel.org>","In-Reply-To":"<20260505164736.26d203a8@kernel.org>","Accept-Language":"en-GB, en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=hitachienergy.com header.i=@hitachienergy.com\n header.a=rsa-sha256 header.s=selector1 header.b=XTJdgneD;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20508-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=pass smtp.remote-ip=\"2a01:111:f403:c201::6\" arc.chain=microsoft.com","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=hitachienergy.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=hitachienergy.com header.i=@hitachienergy.com\n header.a=rsa-sha256 header.s=selector1 header.b=XTJdgneD;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=hitachienergy.com\n (client-ip=2a01:111:f403:c201::6;\n helo=am0pr02cu008.outbound.protection.outlook.com;\n envelope-from=holger.brunck@hitachienergy.com; receiver=lists.ozlabs.org)","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=hitachienergy.com;"],"x-ms-publictraffictype":"Email","x-ms-traffictypediagnostic":"AM0PR06MB10396:EE_|VI1PR06MB6735:EE_","x-ms-office365-filtering-correlation-id":"e0f42130-d0f2-4352-c6e2-08deab49567f","x-he-o365-outbound":"HEO365Out","x-ms-exchange-senderadcheck":"1","x-ms-exchange-antispam-relay":"0","x-microsoft-antispam":"\n BCL:0;ARA:13230040|376014|366016|1800799024|38070700021|22082099003|56012099003|18002099003;","x-microsoft-antispam-message-info":"\n lDdgyjOg3n0ChfwsByuPstA+vo0K6wmLPTRnkcvJHlBQFssglxWEyFT0SHRQL55Ld3EPPN3Dxs9r0E59vSI25g5QyJepSSfU4UPVd7fj137GvS9Ai5cBFaEgxZJWvrJczaZYgljntld7xhEo4WxAbUQWW/oqx+/s2xWGNA9Jc5XcxUlUFpP26hVHbnTcrYHoPuPlaJM5msLaSEOLWikZGIZJdv9r0dPJFvgOanGuW2puLJParXAxVr2pEdab1G1d7XG9zx7zKtoAOwltaCL+cx2ubupUsCs1ydgptxPrT5QfLp+TOqlH3CxNqhevYcLRJXq5iFIOyHlOe2ng7qbgQbd79tMShXZJtpQaMmkfwpU+5CGn2xxpJKN1KGGuZaZbOgqj0IvKo+brmbHMQ+XvUwCdb9WMij5szlRaMd2UE6wMeQuK30njbOj4guhsA27LRzNjxiAkbfNlTU1nqh/4eZ1SMySyUjQu2O78Rf3hNcBT47stLfkc/gcDUTKB4LotBVF8W51+W/gCSJIQUwut3H2V69QllwxEu78VmPWcFDWXZOMz6j4vrBd2Q2MIHjQCDbfbygc7FSohSQ34hCPCP3rOejYLwMpnn0pixbQ7+7go/oP072nFSXSX1NZ5epocMzm5OAllZDd72+8UpnA30HN++LuG4olneM+oNXZATqTZ2a5wG82aZ2stORtixk60","x-forefront-antispam-report":"\n CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR06MB10396.eurprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(38070700021)(22082099003)(56012099003)(18002099003);DIR:OUT;SFP:1101;","x-ms-exchange-antispam-messagedata-chunkcount":"1","x-ms-exchange-antispam-messagedata-0":"\n 23EQ0hqEJX6zAgcJBJonWNQwVZtBQlhZeH66/SooRU39VEOXC+lUVtgnWog+hQb2p5JsL3KXZOa4/6TdSL+KEpD52itCiDUNPm1bjhsmBu3lD6x1SNxQUvM0+g+cMRAPpOm1TTZY0HI84I+i8qNwITsVe7sOHnA3ftSStMBy6ICImKp44hWvk857gNfh25xDqFZr903Xv+LNdECgOc6ZZJCMYSnLZ8M1uxyVFez1QM7Ul3tFWEzV9yBlMQONO3kbhYdbvq7pKT/WT7jG7BgpSSegiZ8XUUA3ocLwgMgMSTHb9svHA+HN15ncluQHX6cC/FiR0jecwP6+jLZO6ofuf1pNHcKTpKkj2NvMsX70e9sCAh5pi/JG0/0xvZTmKutBR8bMkLXUbLj2MJOpe6H0mfHVbSVqzpqNfB8Z2yLjCv1thoae3uPGX/hWuWz30xmwt1JwQsMPcizTXtwN117a5MAPGHi6YdPtZPfs8S+kz4ZLV3Ga/+IMSUPNabhn2E7rK8b+SMLyZYrs71jYGKylJPjs4HtLEk3hWxt0Lr0tb2WbEPnruCHO0xUyAPlZTobwJ9P07gXJKTxPbfk4dUhkbKQCf6gU7sQnrSONhiNfXe5Z5PEOxUuiJIX/BEqO29U4KA75ShrXidpMYQreiGcI/g+QLeiZKxhLaMnNK0ikVYbD+ISH4HbkRreIPFAkyahJx0rEgLzQDmAvbGlNIdsIMR8dTlmHc5mUzZrkJwjszcm+Sn0TK7Il4tJevTYSN9ARsQp6nvhg1ViKx9jyMDfvaDNO1ptlUfW0KYQqiMKKb7Y5q9S+W5dRWLLmOCxfJ/fYN/zQDtcF7kPUY/cRIm6EPnZgc2zilrAj7hqbJt3BlIgXlhdn8IQXZX5YXsKmoN53z3oWMbskWUs4ILPOUgSgcsLq1IeFTbzhJaeReeeYt/s6KPKfCypFtrTRUR0t/QJihBzUx107XkUS2nthWMT2yDRh/g9FIJRBNmru5ZIhOwYBJRkR/RNoMXf5+IOpiqYkcRoq1xJk29bbgU4y4tbqzuja2Mkile4eoY2ZEP3bhUoavhJbpsr7ErwBPugxnLNQJhNIzOO82kmrUvcpIexe2QeRMA/jiK/V3LFNXqmWYecovZFDllWAZTprWmh12xSACCjnbyUYElHdL1yy6Mz1NtSplbAqM6ZfYRsN/FZfb+cfGN5jxrM6IqeHW9otTJBD2VGIjAUnDhdQy1mYLbXly0AlCd19NzF4PnDLj1pa1eBsXaYmLUjfYUioYTVbGO5yjfju5IcY2x4geT3swz7qu16EuKREEJhR8KVu+H7Fy43hcQ8sE8RC6/k7DkTzWvzJbr8I7H/ylW5/1iKu0q8B2M/oMlVClCobSAEGtd3YhP/MKRgRIsD28RG87g3fo8slMcjO15sfJ0pU32hqgszKqItyVc8d55YODzhF2L6D/ju5bVL3DkimqDXPuHQiIvBJOJCHON2Pyufg8eTWabaSJGeOZeiwlBEUKd7JqJZ4WuofpEJ9Mvewj9Yv594xI3gosG/w5WnIFe3J1tPavABRjJIV+tQWBUqTlhnUw4i/8gOfYUuNdfcJ3Of7ypZdD2ydUq8hG7j6JuKbhjJsxz7P93fJ79SciFz4gctUm8xQiKQfNqQnNCDjS+XEAVnEDYQXJ+4s9Y1enRqxv68+KLSjJV7oyT+Zox+iWTKlMi+00F5PtUz7wR8zvFqGVS5O4T3WNlGq4K6X8zFqTrd+cXuH+Mh7FC/sfDwRVv2XoTc5Z8E=","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"quoted-printable","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"<linuxppc-dev.lists.ozlabs.org>","List-Help":"<mailto:linuxppc-dev+help@lists.ozlabs.org>","List-Owner":"<mailto:linuxppc-dev+owner@lists.ozlabs.org>","List-Post":"<mailto:linuxppc-dev@lists.ozlabs.org>","List-Archive":"<https://lore.kernel.org/linuxppc-dev/>,\n  <https://lists.ozlabs.org/pipermail/linuxppc-dev/>","List-Subscribe":"<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n  <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n  <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>","List-Unsubscribe":"<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>","Precedence":"list","MIME-Version":"1.0","X-OriginatorOrg":"hitachienergy.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"AM0PR06MB10396.eurprd06.prod.outlook.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n e0f42130-d0f2-4352-c6e2-08deab49567f","X-MS-Exchange-CrossTenant-originalarrivaltime":"06 May 2026 08:27:40.5107\n (UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"7831e6d9-dc6c-4cd1-9ec6-1dc2b4133195","X-MS-Exchange-CrossTenant-mailboxtype":"HOSTED","X-MS-Exchange-CrossTenant-userprincipalname":"\n KQ5+Wq15JuxFkpezuPln3HYQPplHSrku84yssKpQ1XuPcEYQxdxMNd9CKer+Zh7rhSmlvDs7TcVz3ikikbbKLE7Q7ZxUzZkR8PYmK6hH6WA=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"VI1PR06MB6735","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=disabled\n\tversion=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]