[{"id":3687082,"web_url":"http://patchwork.ozlabs.org/comment/3687082/","msgid":"<31bac9a2-e91c-49bc-ac99-0ba88f83e6ed@linaro.org>","list_archive_url":null,"date":"2026-05-06T13:39:47","subject":"Re: [PATCH v5 05/15] target/arm: emit tag check when MTX without TBI","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 5/4/26 10:50, Gabriel Brookman wrote:\n> Previously, the TBI bit was used to mediate whether tag checks happened.\n> With MTE4, if the MTX bits are enabled, then tag checking happens even\n> if TBI is disabled. See AccessIsTagChecked.\n> \n> Signed-off-by: Gabriel Brookman\n> ---\n> target/arm/helper.c | 10 ++++++++++\n> target/arm/internals.h | 13 ++++++++-----\n> target/arm/tcg/helper-a64.c | 7 ++++---\n> target/arm/tcg/hflags.c | 9 +++++----\n> target/arm/tcg/mte_helper.c | 9 ++++++---\n> target/arm/tcg/sme_helper.c | 4 ++--\n> target/arm/tcg/sve_helper.c | 6 +++---\n> 7 files changed, 38 in\n\nReviewed-by: Richard Henderson \n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=sjgalF2O;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g9c2g2Xzgz1yJV\n\tfor ; Wed, 06 May 2026 23:40:27 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wKcTt-0000OR-47; Wed, 06 May 2026 09:40:05 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wKcTj-0000Ff-FF\n for qemu-devel@nongnu.org; Wed, 06 May 2026 09:39:57 -0400","from mail-yw1-x1131.google.com ([2607:f8b0:4864:20::1131])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wKcTh-0006zK-CB\n for qemu-devel@nongnu.org; Wed, 06 May 2026 09:39:54 -0400","by mail-yw1-x1131.google.com with SMTP id\n 00721157ae682-797ab169454so64727237b3.3\n for ; Wed, 06 May 2026 06:39:52 -0700 (PDT)","from ?IPV6:2600:381:c938:6375:5307:cd92:1ec8:e891?\n ([2600:381:c938:6375:5307:cd92:1ec8:e891])\n by smtp.gmail.com with ESMTPSA id\n 00721157ae682-7bd66527421sm77820107b3.2.2026.05.06.06.39.49\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 06 May 2026 06:39:50 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1778074791; x=1778679591; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=WKVgFAzVfqzQY9IEe4RfflolbrKsfqDi1J4nmML3MUA=;\n b=sjgalF2OhjxmjJVzhIWd79kKuLmtLyxfD5aNlJ/V2BDxKoVQbjTWW3HlqwWNtNf924\n 2mlQ4kMHt29BmKZw74fx2+p2CyjXJBrCQ/sChewQEXkQXZdx5vkt7dhNCT/VwSoEVAr1\n rkiGC0LPlxE7+lShDpIpTzDYD7Fd+9zE/XLSOlaoEG2mAcIHgKjDoICAo8cDPAmCaxlC\n XYeaemKFQrd6wSfLvGiYRrDLaKxDRyfOJ5dcV76CnK/8fWeOLxlZbH/qgfKUDiWyU1CB\n yjKsQYVVBpCela56fwUhKeW0SlofCOPczB1AIALDqPeaHyIjpG7LeweB3JuF6oetxV1Y\n ILRw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778074791; x=1778679591;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=WKVgFAzVfqzQY9IEe4RfflolbrKsfqDi1J4nmML3MUA=;\n b=RVU4OQA6x2xM12m56F/6UqPTsROZGArtYXNf9RDLsz61t66l9bC9I14/Nafe1pGXQH\n zTv+0TNLaEhwR8BsloMbHixWd6lKn8GUpjT9/zKBS95vINoKM4E4QXq05cyZNRDLpV7r\n BN6OfYSYVLKQJLOU4xN2DVCUPeIGd1SRl8LEA4WS/Uid20C9dko+cBh0A2PrGwzHgn6C\n IlMxclfEhZdp28iYIhr007QAqSUmdmWXTh5/VFXYn+SVjoxacSWq3JLiWdQY6/gV8ILw\n RliY8M4QYDvn+n/cITKI5pww+BxlHInSFursqg/fFs4ZTw+FKJkQr5Cqv+1NH1P9iYkz\n z2IA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8RF3/q1v9l2QpW7diFJ0SG3Ldjw3Y3MUaKQITolio3YtWqSvF6k86xpuFjZXD1V5QyK2On9amcvTjF@nongnu.org","X-Gm-Message-State":"AOJu0YwizWS6oyF7/+Hw1T6N1QkK6HBq2pwjbMoE2we/abneWxzjL3GN\n tJ1oAOxKHp/9ch8xgqnKm+72FbMvVVMApw3zzcahYg3cvZDHWZ+b+H4SlURQiWckBqA=","X-Gm-Gg":"AeBDievN1U+rdaQmQHZrTKMm/odf17zx4p+DqhVwwCvGbBetzt5wmdBqFNQLMy1W8T3\n GlsFnAXHxzGVtif5GmcrtX3e6KD7KnhsQ4Mdh0/M7eaGqi1GAqcbh4AXMgt8necMDOmzXENQvmf\n hXuvqMI0+gKtddZoZXerEHjXBVK35Wz7D0gLJYcLc/8JH44mDoyZSa/5mFoiLMxlI4NTGpZTXNP\n dFwnTAeKQb0gnnwkqNVPSKmFQLvD6H6jEXna9FrR692lEoHvcocCpgJ56T5JSToCTgyH4GiNCtA\n aid21KSj4BvjltEE4iOl8aATpuaztVv+aLp9BZd6NIzjThs86CwAdGfmUEAsHoBidgrj9lwIbo/\n WLvTwJ8j9OPlUtFZBXWXQRB4XqbAymGw4sBJA3zIO+nuuE5JlWFM6MKDA9QW7CqtdPaH2Wg6/LN\n 1D69jg8/+23Y3OI0RxF/f7j531VopUNJas0Q/JilkwKR6FA4utTX+D3twfXuUTzU18C60e6Cc6d\n r+gaEtC1NwUDyittNp2","X-Received":"by 2002:a05:690c:ed6:b0:7bd:5d03:dc1a with SMTP id\n 00721157ae682-7bdf5d7f3a4mr42062777b3.1.1778074791164;\n Wed, 06 May 2026 06:39:51 -0700 (PDT)","Message-ID":"<31bac9a2-e91c-49bc-ac99-0ba88f83e6ed@linaro.org>","Date":"Wed, 6 May 2026 08:39:47 -0500","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v5 05/15] target/arm: emit tag check when MTX without TBI","To":"Gabriel Brookman , qemu-devel@nongnu.org","Cc":"Peter Maydell ,\n Gustavo Romero , qemu-arm@nongnu.org,\n Laurent Vivier , Helge Deller ,\n Pierrick Bouvier ","References":"<20260504-feat-mte4-v5-0-232a648e63c6@gmail.com>\n <20260504-feat-mte4-v5-5-232a648e63c6@gmail.com>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260504-feat-mte4-v5-5-232a648e63c6@gmail.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::1131;\n envelope-from=richard.henderson@linaro.org; helo=mail-yw1-x1131.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]