[{"id":3687512,"web_url":"http://patchwork.ozlabs.org/comment/3687512/","msgid":"","date":"2026-05-07T06:13:43","subject":"Re: [PATCH V5 1/2] powerpc tools perf: Initialize error code in\n auxtrace_record_init function","submitter":{"id":20789,"url":"http://patchwork.ozlabs.org/api/people/20789/","name":"Namhyung Kim","email":"namhyung@kernel.org"},"content":"On Mon, May 04, 2026 at 08:43:20PM +0530, Athira Rajeev wrote:\n> perf trace record fails some cases in powerpc\n> \n> # ./perf test \"perf trace record and replay\"\n> 128: perf trace record and replay : FAILED!\n> \n> # ./perf trace record sleep 1\n> # echo $?\n> 32\n> \n> This is happening because of non-zero err value from\n> auxtrace_record__init() function.\n> \n> static int record__auxtrace_init(struct record *rec)\n> {\n> int err;\n> \n> if ((rec->opts.auxtrace_snapshot_opts || rec->opts.auxtrace_sample_opts)\n> && record__threads_enabled(rec)) {\n> pr_err(\"AUX area tracing options are not available in parallel streaming mode.\\n\");\n> return -EINVAL;\n> }\n> \n> if (!rec->itr) {\n> rec->itr = auxtrace_record__init(rec->evlist, &err);\n> if (err)\n> return err;\n> }\n> \n> Here \"int err\" is not initialised. The code expects \"err\" to be set\n> from auxtrace_record__init() function.\n> \n> Update auxtrace_record__init() in arch/powerpc/util/auxtrace.c to clear\n> err value in the beginning.\n> \n> - Clear err value in beginning of function. Any fail later will\n> set appropriate return code to err.\n> - Even if we haven't found any event for auxtrace, perf record\n> should continue for other events. NULL return\n> will indicate that there is no auxtrace record initialized.\n> - Not having \"err\" set here will affect monitoring of other events\n> also because perf record will fail seeing random value in err.\n> \n> Set err to -EINVAL before invoking auxtrace_record__init() in\n> builtin-record.c\n> \n> With the fix,\n> \n> # ./perf trace record sleep 1\n> [ perf record: Woken up 2 times to write data ]\n> [ perf record: Captured and wrote 0.033 MB perf.data (228 samples) ]\n> \n> Fixes: 1dbfaf94cf66 (\"perf powerpc: Add basic CONFIG_AUXTRACE support for VPA pmu on powerpc\")\n> Reviewed-by: Adrian Hunter \n> Signed-off-by: Athira Rajeev \n\nFor both patches,\n\nAcked-by: Namhyung Kim \n\nThanks,\nNamhyung\n\n> ---\n> Changelog:\n> v4:\n> Added Reviewed-by from Adrian\n> \n> v1 -> v2\n> Addressed review comment from Adrian:\n> - Set err to -EINVAL before invoking auxtrace_record__init() in\n> builtin-record.c\n> - Added kernel-doc to auxtrace_record__init() in tools/perf/util/auxtrace.c\n> Addressed review comment from Namhyung:\n> - Added fixes tag\n> \n> tools/perf/arch/powerpc/util/auxtrace.c | 6 ++++++\n> tools/perf/builtin-record.c | 1 +\n> 2 files changed, 7 insertions(+)\n> \n> diff --git a/tools/perf/arch/powerpc/util/auxtrace.c b/tools/perf/arch/powerpc/util/auxtrace.c\n> index e39deff6c857..4600a1661b4f 100644\n> --- a/tools/perf/arch/powerpc/util/auxtrace.c\n> +++ b/tools/perf/arch/powerpc/util/auxtrace.c\n> @@ -71,6 +71,12 @@ struct auxtrace_record *auxtrace_record__init(struct evlist *evlist,\n> \tstruct evsel *pos;\n> \tint found = 0;\n> \n> +\t/*\n> +\t * Set err value to zero here. Any fail later\n> +\t * will set appropriate return code to err.\n> +\t */\n> +\t*err = 0;\n> +\n> \tevlist__for_each_entry(evlist, pos) {\n> \t\tif (strstarts(pos->name, \"vpa_dtl\")) {\n> \t\t\tfound = 1;\n> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c\n> index 4a5eba498c02..708825747af5 100644\n> --- a/tools/perf/builtin-record.c\n> +++ b/tools/perf/builtin-record.c\n> @@ -865,6 +865,7 @@ static int record__auxtrace_init(struct record *rec)\n> \t}\n> \n> \tif (!rec->itr) {\n> +\t\terr = -EINVAL;\n> \t\trec->itr = auxtrace_record__init(rec->evlist, &err);\n> \t\tif (err)\n> \t\t\treturn err;\n> -- \n> 2.47.3\n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=O1SL7zhc;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20557-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2600:3c0a:e001:78e:0:1991:8:25\"","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=O1SL7zhc;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org;\n envelope-from=namhyung@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gB24w2WgDz1yJq\n\tfor ; Thu, 07 May 2026 16:13:51 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4gB24t4ppyz30BC;\n\tThu, 07 May 2026 16:13:50 +1000 (AEST)","from sea.source.kernel.org (sea.source.kernel.org\n [IPv6:2600:3c0a:e001:78e:0:1991:8:25])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4gB24s4FJgz2xlm\n\tfor ; Thu, 07 May 2026 16:13:49 +1000 (AEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby sea.source.kernel.org (Postfix) with ESMTP id 9325743C96;\n\tThu, 7 May 2026 06:13:45 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id DC05FC2BCB8;\n\tThu, 7 May 2026 06:13:44 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1778134430;\n\tcv=none;\n b=ENeO4HH1ZXVseX/oC6up3pLKiep/nOYu9554qk/5uZzNsdh6ZfxpyS2lp/XE2wHSif8ruLsbfe4SQCzZgj4ekuFrl46C7//bp0P4H2GBADPjOE40TzlOrVgNYap4VFJEtes41HGc80f81q9zn+SAl3WPWFOTzfZ5iEv9/XwAXgeMQ775Xw3kOaq42BngmyVr/FaU536GUXH3YlDrvRa9pPqprYwnx9R/yAK4gBByjjpasYDPT7a4dDLszMLUJ3oqRbYpLvJPAqVYUSY+6N2xYamjpCPXKMKLzM9M/3aEGsLm22YA2/4T96JwO3s8IbJFTResSJfNxGsZqtp+vnaPmA==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1778134430; c=relaxed/relaxed;\n\tbh=lYGBqr8XFBQ09CkUVdZZNfV9QX8hnb8GjkvbvaHriVw=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=kfzAT1r0kAwKMVLQhVU/touNAOvh4UZzVEvEENYXzQHlA8NoxGvO5ljvEU+p7QfS8575Oj1SIuFP22zmrTTe+Sh38kPOA7EOAAY32U6gECHNe7q9IufcrXbjsg5TxoEvqS6gOmHGqpNeWZse5cC82+fd1xRseJ4+3/Ixirx4B5b/+uF9o9GB2XGYZJYkDXxqT/G5JvWVvQHAcYazxTmHRtXFIIjoBaN9hrJ+QsvjRx9S2tLk7CHSMs+NF31Wzb/1IgZjqc8n5EvTyf7A4jmIRTZOnKhk2idFrr/JqcFUGWDsDmHtQMNHJ6cIDkfylU7rE+1LDAeIPfqabetwsn2V4Q==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=O1SL7zhc; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c0a:e001:78e:0:1991:8:25;\n helo=sea.source.kernel.org; envelope-from=namhyung@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1778134425;\n\tbh=/fOGlmO82MYiNksLou9+DYkXXjNNOJOZwge6qWlpEOk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=O1SL7zhcohHCqXKMWZaPdXcpgQgH1z7X+h9hV9UYekMxS+z1I7N0h0S6dNL17ETII\n\t pU1/MD4NxjxqlqdmtcDQYIWp2Uxj1ppSZpVZzwJIsPEZDVzheL42ggqSC3q/MOg9Fr\n\t 2t4ghNTIksaiIb1OG4X/x7EzvYDPRZWg2xOl5YfYGdmK8BPbnrcVdcFazrHsLGIExv\n\t hZeWhlVnqv87dqwf+ycQ71pa0zI5yaerTfmMoteWPpm+u6z9Nf/XSn0mUC5fKo5hsF\n\t 9hgbLhVGUspGMJjz4KNalpYCB4+SL7yUGnHYrLwr82EaugvtGv48TGeZ4C9EvB1AJh\n\t 7BjDjivXaZJbA==","Date":"Wed, 6 May 2026 23:13:43 -0700","From":"Namhyung Kim ","To":"Athira Rajeev ","Cc":"acme@kernel.org, jolsa@kernel.org, adrian.hunter@intel.com,\n\tmpetlan@redhat.com, tmricht@linux.ibm.com, maddy@linux.ibm.com,\n\tirogers@google.com, linux-perf-users@vger.kernel.org,\n\tlinuxppc-dev@lists.ozlabs.org, hbathini@linux.vnet.ibm.com,\n\tTejas.Manhas1@ibm.com, Tanushree.Shah@ibm.com,\n\tshivani@linux.ibm.com","Subject":"Re: [PATCH V5 1/2] powerpc tools perf: Initialize error code in\n auxtrace_record_init function","Message-ID":"","References":"<20260504151321.12346-1-atrajeev@linux.ibm.com>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260504151321.12346-1-atrajeev@linux.ibm.com>","X-Spam-Status":"No, score=-0.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]