[{"id":3686036,"web_url":"http://patchwork.ozlabs.org/comment/3686036/","msgid":"","list_archive_url":null,"date":"2026-05-04T20:39:45","subject":"Re: [PATCH v2 2/2] cmd: ufetch: only show comma separator if there\n was a previous feature","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Quentin,\n\nOn 2026-05-04T14:48:27, Quentin Schulz wrote:\n> cmd: ufetch: only show comma separator if there was a previous feature\n>\n> Currently, if NET is disabled, the next feature to be printed will start\n> with a comma and a space which is not pretty. Add the comma and\n> whitespace only when a previous feature has already been shown.\n>\n> Signed-off-by: Quentin Schulz \n>\n> cmd/ufetch.c | 29 ++++++++++++++++++++---------\n> 1 file changed, 20 insertions(+), 9 deletions(-)\n\n> diff --git a/cmd/ufetch.c b/cmd/ufetch.c\n> @@ -157,26 +157,37 @@ static int do_ufetch(struct cmd_tbl *cmdtp, int flag, int argc,\n> - case FEATURES:\n> + case FEATURES: {\n> + bool sep = false;\n> +\n> printf('Features:' RESET \" \");\n> - if (IS_ENABLED(CONFIG_NET))\n> - printf('Net');\n> - if (IS_ENABLED(CONFIG_EFI_LOADER))\n> - printf(\", EFI\");\n> - if (IS_ENABLED(CONFIG_CMD_CAT))\n> - printf(\", cat :3\");\n> + if (IS_ENABLED(CONFIG_NET)) {\n> + printf('%sNet', sep ? \", \" : \"\");\n> + sep = true;\n> + }\n> + if (IS_ENABLED(CONFIG_EFI_LOADER)) {\n> + printf('%sEFI', sep ? \", \" : \"\");\n> + sep = true;\n> + }\n> + if (IS_ENABLED(CONFIG_CMD_CAT)) {\n> + printf(\"%scat :3\", sep ? \", \" : \"\");\n> + sep = true;\n> + }\n\nSorry, one more thought: you couldkeep the separator as a string that\nstarts empty and becomes \", \" after the first print:\n\n const char *sep = \"\";\n\n if (IS_ENABLED(CONFIG_NET)) {\n printf('%sNet', sep);\n sep = \", \";\n }\n\n> diff --git a/cmd/ufetch.c b/cmd/ufetch.c\n> @@ -157,26 +157,37 @@ static int do_ufetch(struct cmd_tbl *cmdtp, int flag, int argc,\n> #ifdef CONFIG_ARM64\n> switch (current_el()) {\n> case 2:\n> - printf(\", VMs\");\n> + printf('%sVMs', sep ? \", \" : \"\");\n> + sep = true;\n> break;\n> case 3:\n> - printf(\", full control!\");\n> + printf(\"%sfull control!\", sep ? \", \" : \"\");\n> + sep = true;\n> break;\n> }\n> #endif\n\nnit: the sep = true is dead since nothing follows the switch.\n\nReviewed-by: Simon Glass \n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=A7EqkBgM;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"A7EqkBgM\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8YRl10zMz1yJx\n\tfor ; Tue, 05 May 2026 06:40:03 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 8830784836;\n\tMon, 4 May 2026 22:40:00 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id BDDFC8483F; Mon, 4 May 2026 22:39:59 +0200 (CEST)","from mail-ej1-x633.google.com (mail-ej1-x633.google.com\n [IPv6:2a00:1450:4864:20::633])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id ACD8184706\n for ; Mon, 4 May 2026 22:39:57 +0200 (CEST)","by mail-ej1-x633.google.com with SMTP id\n a640c23a62f3a-b9358dd7f79so710905166b.1\n for ; Mon, 04 May 2026 13:39:57 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1777927197; cv=none;\n d=google.com; s=arc-20240605;\n b=Ghq9oxDHXS6frPf9BFOFziYFQQu/urLl8BZ3xi2y3JooU+OZMVTAP3xbGCF2qhEodT\n 9vgeTUgI3Np8bRa0oH1P/SurlGToQlpE7Scm32focOpDeif5/UgOssEFj5R1P4NFdI38\n 11jhytDmqzbdKs5GDOtzGhc7lkr/bZw3h8ChWnxoeMssM9HPIjzyedBdYhCjTPekAw96\n 4bC+K5uxhXpifsf1LP0AYkUu4znsOKTUy1BD85wC5BTYSTm26sgTB10jJaND50bKPMkd\n r3WSGgTmTqIncnixQnfSZJaL2mERoSQt2yqo/fpqHSxC6hjtCjCJBgX6E/F/f8pTkyD9\n Pivg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=lHldQmdd9PLvjqnzwA2HjnQme3MB9O4w+mhnBooenKQ=;\n fh=6sX/JMBB1a9uFLN+GawcERyIrfwFtjkiJ6nSJPOXXGg=;\n b=AO5eVuCxWLvalAac3VfAmm8+eIoHgHLLykX2RqrJdjzrC/cbf0uvfkpRyCSg8l0p9P\n zCgR4JiWwJpVhhY/wUe9k3QH4N9yyBgsNqx50pJN8PsNooRg91gwaHbXER0O66ofTBi4\n rRgZTx+Ltaa50tIhoEv+FtMCMmurPhHgg9nNZx3PfQ5EroFkWNLuqaX4QWNwwb1CntPS\n Asmu8W0pTBJQHVEfZYS4D/QCHtpkfikEqXVUZ4FEQ4pfufUNauI+4V4j+fmL6TkSxE/V\n EhZqA4UgNTaYo0OshnleUDLGtG+UJ/wRwNH4SdCEXbsz4WGL41xmRNh1ud1jtJy7jlZ+\n XhbA==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1777927197; x=1778531997; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=lHldQmdd9PLvjqnzwA2HjnQme3MB9O4w+mhnBooenKQ=;\n b=A7EqkBgM93gzuaiPuGxSpXxXCNt/9mqVP+tBNqWhrntcqN47Xk1xkR28UuuhysAZ5o\n vnJ9gHW2lr4y5vHtbyfGbzqBBGzOoh7frXVWccLpM5j3N1rZYs4sX2riPAy7xp124rcm\n HgiiIIVgqim5tA8fjnsL7JxrNmu6QJ+adLKjk=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777927197; x=1778531997;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=lHldQmdd9PLvjqnzwA2HjnQme3MB9O4w+mhnBooenKQ=;\n b=SfZRIBDd4/8nwqHCAQ28wd3SZjtTbbASFMYVLWLC3oHg3D27BxK1Taun1Y1BER/BK+\n gsYc6ELpVWE5NNCDhgOP9yuEXZ/eVK29ESHOO07emuKC3vo2lY5FdWq+4NJitztIK9EM\n Y8VigayBmcvbmQt0VdQq+uu0jOBef6WYka2kd5PzfQvWaf72x/xBITtMBKueiC3pJwgQ\n tlBsNupzoFDx/Qn7KcqKmNAWJOAFQQwJ/1TrR7VfsJJmaCkxkzcSHP6neZ2WyIj9B/1r\n UyHgqKbeiaPrh5USmWGJqws+sFWieVEBSO8tzbKYd+bYZ9uBd8E7dt9odXYuNg2/hjyJ\n b+4Q==","X-Gm-Message-State":"AOJu0YwLUUUxVWzcQRVu8e2vPmWW9qwdjtvfhP1JKag3D8w6veGmYGND\n sA8XI8mKJ83mc2IGBPonmzu+TvstkD3lxjzLa0obAjkaorXWtGpobM5dwan7UBHu49naBIgqoME\n b4qskX9SVMWlKl8f02RbJuESII72U6Ea2thsUeMwOinC4l4dKwhuphg==","X-Gm-Gg":"AeBDievXjmdPRgCDoe2EXThYy+Limucdp4ggNRoIgDJ93KaKFYPTSl5sPwz0wQzhOgs\n KN/mSc0UwYM0zLhq0qXqioYVEuVUvrDVuDYrlUFW45Njh55BR1uVcvSMnxEjBhsDNWBPDHdnoze\n +p0cpBIyq94YBc8vTbvbeigQP9zuhZTgBd+JX/jHGAOqtsMDK1KvPX/hzg1mBEDrilbako+tFaB\n EdDbwq4rrLCjipMFwn2rSy41qoakfW+FBWeubkuMTqhHXla4OVsaxTfwGBW5yo3V0WbxMYVoQAi\n gR283mceX1GUGlCI","X-Received":"by 2002:a17:907:944f:b0:b9d:2fce:308b with SMTP id\n a640c23a62f3a-bc41173a689mr5975566b.30.1777927197131; Mon, 04 May 2026\n 13:39:57 -0700 (PDT)","MIME-Version":"1.0","References":"<20260504-ufetch-net-v2-0-01bec4ca7169@cherry.de>\n <20260504-ufetch-net-v2-2-01bec4ca7169@cherry.de>","In-Reply-To":"<20260504-ufetch-net-v2-2-01bec4ca7169@cherry.de>","From":"Simon Glass ","Date":"Mon, 4 May 2026 14:39:45 -0600","X-Gm-Features":"AVHnY4LZzMH2G6GhnsLYxepBn6Pmb6BZRkJSBBg5j40Spjr3M9_eBy4miOkIIWA","Message-ID":"\n ","Subject":"Re: [PATCH v2 2/2] cmd: ufetch: only show comma separator if there\n was a previous feature","To":"foss+uboot@0leil.net","Cc":"u-boot@lists.denx.de, Casey Connolly ,\n Tom Rini ,\n Ilias Apalodimas ,\n Andrew Goodbody ,\n Peter Robinson ,\n Heinrich Schuchardt , Simon Glass ,\n Quentin Schulz ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]