[{"id":3685669,"web_url":"http://patchwork.ozlabs.org/comment/3685669/","msgid":"<CAMxuvax9D6EfQpiHX9BWs-1nH9npaFVSmPbP9cMUST0k31z7HQ@mail.gmail.com>","list_archive_url":null,"date":"2026-05-04T11:53:43","subject":"Re: [PATCH v2 42/46] target/riscv: fix general_user_opts hash table\n leak","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"content":"Hi\n\nOn Mon, May 4, 2026 at 3:39 PM Marc-André Lureau\n<marcandre.lureau@redhat.com> wrote:\n>\n> The global general_user_opts hash table is recreated on every\n> riscv_cpu_init() call, leaking the previous one.\n>\n> Furthermore, the CPU settings should be associated with their instance\n> and not global.\n>\n> Add a finalize() to free associated instances.\n>\n> Fixes: d167a2247ede (\"target/riscv: move 'pmu-mask' and 'pmu-num' to riscv_cpu_properties[]\")\n> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n> ---\n>  target/riscv/cpu.h         |  3 ++-\n>  target/riscv/cpu.c         | 51 +++++++++++++++++++++++++++-------------------\n>  target/riscv/kvm/kvm-cpu.c |  6 +++---\n>  3 files changed, 35 insertions(+), 25 deletions(-)\n>\n> diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h\n> index 81c41e34296..55a26aeb5be 100644\n> --- a/target/riscv/cpu.h\n> +++ b/target/riscv/cpu.h\n> @@ -546,6 +546,7 @@ struct ArchCPU {\n>      uint32_t pmu_avail_ctrs;\n>      /* Mapping of events to counters */\n>      GHashTable *pmu_event_ctr_map;\n> +    GHashTable *user_options;\n>      const GPtrArray *decoders;\n>  };\n>\n> @@ -619,7 +620,7 @@ bool riscv_cpu_tlb_fill(CPUState *cs, vaddr address, int size,\n>                          bool probe, uintptr_t retaddr);\n>  char *riscv_isa_string(RISCVCPU *cpu);\n>  int riscv_cpu_max_xlen(RISCVCPUClass *mcc);\n> -bool riscv_cpu_option_set(const char *optname);\n> +bool riscv_cpu_option_set(RISCVCPU *cpu, const char *optname);\n>\n>  #ifndef CONFIG_USER_ONLY\n>  void riscv_cpu_do_interrupt(CPUState *cpu);\n> diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c\n> index ce15a17c37d..be9a3ac13e7 100644\n> --- a/target/riscv/cpu.c\n> +++ b/target/riscv/cpu.c\n> @@ -27,6 +27,7 @@\n>  #include \"qapi/error.h\"\n>  #include \"qapi/visitor.h\"\n>  #include \"qemu/error-report.h\"\n> +#include \"qemu/timer.h\"\n>  #include \"hw/core/qdev-properties.h\"\n>  #include \"hw/core/qdev-prop-internal.h\"\n>  #include \"migration/vmstate.h\"\n> @@ -59,18 +60,16 @@ bool riscv_cpu_is_32bit(RISCVCPU *cpu)\n>      return riscv_cpu_mxl(&cpu->env) == MXL_RV32;\n>  }\n>\n> -/* Hash that stores general user set numeric options */\n> -static GHashTable *general_user_opts;\n> -\n> -static void cpu_option_add_user_setting(const char *optname, uint32_t value)\n> +static void cpu_option_add_user_setting(RISCVCPU *cpu, const char *optname,\n> +                                        uint32_t value)\n>  {\n> -    g_hash_table_insert(general_user_opts, (gpointer)optname,\n> +    g_hash_table_insert(cpu->user_options, (gpointer)optname,\n>                          GUINT_TO_POINTER(value));\n>  }\n>\n> -bool riscv_cpu_option_set(const char *optname)\n> +bool riscv_cpu_option_set(RISCVCPU *cpu, const char *optname)\n>  {\n> -    return g_hash_table_contains(general_user_opts, optname);\n> +    return g_hash_table_contains(cpu->user_options, optname);\n>  }\n>\n>  #ifndef CONFIG_USER_ONLY\n> @@ -1103,7 +1102,7 @@ static void riscv_cpu_init(Object *obj)\n>                              \"riscv.cpu.rnmi\", RNMI_MAX);\n>  #endif /* CONFIG_USER_ONLY */\n>\n> -    general_user_opts = g_hash_table_new(g_str_hash, g_str_equal);\n> +    cpu->user_options = g_hash_table_new(g_str_hash, g_str_equal);\n>\n>      /*\n>       * The timer and performance counters extensions were supported\n> @@ -1453,7 +1452,7 @@ static void prop_pmu_num_set(Object *obj, Visitor *v, const char *name,\n>\n>      warn_report(\"\\\"pmu-num\\\" property is deprecated; use \\\"pmu-mask\\\"\");\n>      cpu->cfg.pmu_mask = pmu_mask;\n> -    cpu_option_add_user_setting(\"pmu-mask\", pmu_mask);\n> +    cpu_option_add_user_setting(cpu, \"pmu-mask\", pmu_mask);\n>  }\n>\n>  static void prop_pmu_num_get(Object *obj, Visitor *v, const char *name,\n> @@ -1495,7 +1494,7 @@ static void prop_pmu_mask_set(Object *obj, Visitor *v, const char *name,\n>          return;\n>      }\n>\n> -    cpu_option_add_user_setting(name, value);\n> +    cpu_option_add_user_setting(cpu, name, value);\n>      cpu->cfg.pmu_mask = value;\n>  }\n>\n> @@ -1527,7 +1526,7 @@ static void prop_mmu_set(Object *obj, Visitor *v, const char *name,\n>          return;\n>      }\n>\n> -    cpu_option_add_user_setting(name, value);\n> +    cpu_option_add_user_setting(cpu, name, value);\n>      cpu->cfg.mmu = value;\n>  }\n>\n> @@ -1559,7 +1558,7 @@ static void prop_pmp_set(Object *obj, Visitor *v, const char *name,\n>          return;\n>      }\n>\n> -    cpu_option_add_user_setting(name, value);\n> +    cpu_option_add_user_setting(cpu, name, value);\n>      cpu->cfg.pmp = value;\n>  }\n>\n> @@ -1599,7 +1598,7 @@ static void prop_num_pmp_regions_set(Object *obj, Visitor *v, const char *name,\n>          return;\n>      }\n>\n> -    cpu_option_add_user_setting(name, value);\n> +    cpu_option_add_user_setting(cpu, name, value);\n>      cpu->cfg.pmp_regions = value;\n>  }\n>\n> @@ -1637,7 +1636,7 @@ static void prop_pmp_granularity_set(Object *obj, Visitor *v, const char *name,\n>          return;\n>      }\n>\n> -    cpu_option_add_user_setting(name, value);\n> +    cpu_option_add_user_setting(cpu, name, value);\n>      cpu->cfg.pmp_granularity = value;\n>  }\n>\n> @@ -1710,7 +1709,7 @@ static void prop_priv_spec_set(Object *obj, Visitor *v, const char *name,\n>          return;\n>      }\n>\n> -    cpu_option_add_user_setting(name, priv_version);\n> +    cpu_option_add_user_setting(cpu, name, priv_version);\n>      cpu->env.priv_ver = priv_version;\n>  }\n>\n> @@ -1744,7 +1743,7 @@ static void prop_vext_spec_set(Object *obj, Visitor *v, const char *name,\n>          return;\n>      }\n>\n> -    cpu_option_add_user_setting(name, VEXT_VERSION_1_00_0);\n> +    cpu_option_add_user_setting(cpu, name, VEXT_VERSION_1_00_0);\n>      cpu->env.vext_ver = VEXT_VERSION_1_00_0;\n>  }\n>\n> @@ -1787,7 +1786,7 @@ static void prop_vlen_set(Object *obj, Visitor *v, const char *name,\n>          return;\n>      }\n>\n> -    cpu_option_add_user_setting(name, value);\n> +    cpu_option_add_user_setting(cpu, name, value);\n>      cpu->cfg.vlenb = value >> 3;\n>  }\n>\n> @@ -1828,7 +1827,7 @@ static void prop_elen_set(Object *obj, Visitor *v, const char *name,\n>          return;\n>      }\n>\n> -    cpu_option_add_user_setting(name, value);\n> +    cpu_option_add_user_setting(cpu, name, value);\n>      cpu->cfg.elen = value;\n>  }\n>\n> @@ -1864,7 +1863,7 @@ static void prop_cbom_blksize_set(Object *obj, Visitor *v, const char *name,\n>          return;\n>      }\n>\n> -    cpu_option_add_user_setting(name, value);\n> +    cpu_option_add_user_setting(cpu, name, value);\n>      cpu->cfg.cbom_blocksize = value;\n>  }\n>\n> @@ -1900,7 +1899,7 @@ static void prop_cbop_blksize_set(Object *obj, Visitor *v, const char *name,\n>          return;\n>      }\n>\n> -    cpu_option_add_user_setting(name, value);\n> +    cpu_option_add_user_setting(cpu, name, value);\n>      cpu->cfg.cbop_blocksize = value;\n>  }\n>\n> @@ -1936,7 +1935,7 @@ static void prop_cboz_blksize_set(Object *obj, Visitor *v, const char *name,\n>          return;\n>      }\n>\n> -    cpu_option_add_user_setting(name, value);\n> +    cpu_option_add_user_setting(cpu, name, value);\n>      cpu->cfg.cboz_blocksize = value;\n>  }\n>\n> @@ -2974,6 +2973,15 @@ void riscv_isa_write_fdt(RISCVCPU *cpu, void *fdt, char *nodename)\n>      DEFINE_RISCV_CPU(type_name, parent_type_name,             \\\n>          .profile = &(profile_))\n>\n> +static void riscv_cpu_instance_finalize(Object *obj)\n> +{\n> +    RISCVCPU *cpu = RISCV_CPU(obj);\n> +\n> +    g_clear_pointer(&cpu->pmu_timer, timer_free);\n> +    g_clear_pointer(&cpu->pmu_event_ctr_map, g_hash_table_destroy);\n\nThose 2 should be guarded with\n#ifndef CONFIG_USER_ONLY\n\nfixed\n\n> +    g_clear_pointer(&cpu->user_options, g_hash_table_destroy);\n> +}\n> +\n>  static const TypeInfo riscv_cpu_type_infos[] = {\n>      {\n>          .name = TYPE_RISCV_CPU,\n> @@ -2981,6 +2989,7 @@ static const TypeInfo riscv_cpu_type_infos[] = {\n>          .instance_size = sizeof(RISCVCPU),\n>          .instance_align = __alignof(RISCVCPU),\n>          .instance_init = riscv_cpu_init,\n> +        .instance_finalize = riscv_cpu_instance_finalize,\n>          .abstract = true,\n>          .class_size = sizeof(RISCVCPUClass),\n>          .class_init = riscv_cpu_common_class_init,\n> diff --git a/target/riscv/kvm/kvm-cpu.c b/target/riscv/kvm/kvm-cpu.c\n> index b047ffa9c0c..e0241870ada 100644\n> --- a/target/riscv/kvm/kvm-cpu.c\n> +++ b/target/riscv/kvm/kvm-cpu.c\n> @@ -2025,7 +2025,7 @@ void riscv_kvm_cpu_finalize_features(RISCVCPU *cpu, Error **errp)\n>      }\n>\n>      if (cpu->cfg.ext_zicbom &&\n> -        riscv_cpu_option_set(kvm_cbom_blocksize.name)) {\n> +        riscv_cpu_option_set(cpu, kvm_cbom_blocksize.name)) {\n>\n>          reg.id = KVM_RISCV_REG_ID_ULONG(KVM_REG_RISCV_CONFIG,\n>                                          kvm_cbom_blocksize.kvm_reg_id);\n> @@ -2044,7 +2044,7 @@ void riscv_kvm_cpu_finalize_features(RISCVCPU *cpu, Error **errp)\n>      }\n>\n>      if (cpu->cfg.ext_zicboz &&\n> -        riscv_cpu_option_set(kvm_cboz_blocksize.name)) {\n> +        riscv_cpu_option_set(cpu, kvm_cboz_blocksize.name)) {\n>\n>          reg.id = KVM_RISCV_REG_ID_ULONG(KVM_REG_RISCV_CONFIG,\n>                                          kvm_cboz_blocksize.kvm_reg_id);\n> @@ -2063,7 +2063,7 @@ void riscv_kvm_cpu_finalize_features(RISCVCPU *cpu, Error **errp)\n>      }\n>\n>      /* Users are setting vlen, not vlenb */\n> -    if (riscv_has_ext(env, RVV) && riscv_cpu_option_set(\"vlen\")) {\n> +    if (riscv_has_ext(env, RVV) && riscv_cpu_option_set(cpu, \"vlen\")) {\n>          if (!kvm_v_vlenb.supported) {\n>              error_setg(errp, \"Unable to set 'vlenb': register not supported\");\n>              return;\n>\n> --\n> 2.54.0\n>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=QRZ526D4;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=ZdSK0PxA;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8Knc67Jkz1yJ9\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 04 May 2026 21:54:43 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wJrsJ-0001ik-Sx; Mon, 04 May 2026 07:54:13 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mlureau@redhat.com>)\n id 1wJrsC-0001g1-0I\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:54:05 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mlureau@redhat.com>)\n id 1wJrs9-00065U-0j\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:54:03 -0400","from mail-pg1-f197.google.com (mail-pg1-f197.google.com\n [209.85.215.197]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-16-n08ihjKUOdCSSs1PQADJXg-1; Mon, 04 May 2026 07:53:57 -0400","by mail-pg1-f197.google.com with SMTP id\n 41be03b00d2f7-c70ea91bfe1so1619479a12.1\n for <qemu-devel@nongnu.org>; Mon, 04 May 2026 04:53:57 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777895638;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=19HXGqSox2hwZB7/J65WnaWVZDUxRzJIIwGFz2bh+58=;\n b=QRZ526D4HmF5sANOv/i+UWOKcMhMjtk3YJqpxw2ghmST+nf5YafZGvgG2wcej389xU9MwP\n NxlRiV+bHppo4NshUUsFRRhskL9T2g+LiZQc/9lDRsUYxycJCWEilLR+Od9VbIJCG5XHe9\n GbSBLOMXavLpTKzDaxZ8OBxEskwM3YE=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1777895635; x=1778500435; darn=nongnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=19HXGqSox2hwZB7/J65WnaWVZDUxRzJIIwGFz2bh+58=;\n b=ZdSK0PxAaJDds/pCx7gFORXy3gWF501WoFv7T8657iM1iwFeaxCeal7XjW7UTqLpcW\n 3Dkk+bohM5FsjUMadPV/HDGWohYru56LN8ZXU31Umr6yJ6RYodstzTGYNCP6qEdUAujp\n hzXjHOAANfdvh4lBGjDeVY/0BNbrFWWTjpsr2Z2kEUWct3dGXi0wgMKkizAQgJ9mhVka\n +XF0yX3AoufcXkYqBXekjQdn+fwj0iAqk9IRPuL45+a8/xiEwAjfRSL4OOCy3qGEbH/h\n SDf0jlZRcssbICLXyScWAPjMMSQQcn37/+NyPTlojB0kKTKeJ8Oa56Z9SberL4Qm/n1+\n OsGQ=="],"X-MC-Unique":"n08ihjKUOdCSSs1PQADJXg-1","X-Mimecast-MFC-AGG-ID":"n08ihjKUOdCSSs1PQADJXg_1777895636","ARC-Seal":"i=1; a=rsa-sha256; t=1777895635; cv=none;\n d=google.com; s=arc-20240605;\n b=EMYfxweOpZz+WqvFs0ni/EQU1b//VWgJND+z97bb3wbTsDCfteG0cpBpC4QEiRfhqa\n 0mNjxZ5sZY0WuzBy9FraOgzneG842yTtmQVBU5IiqeAxtZUKj39zLn6ea+rU3ktBAAnA\n h0wHxXACqhGhD+8otV4MsO1xuKX9cX0nGWS3qXCCspmJepqppwqWYw0rj4VwFTwf44Za\n 9KKztrrZ6/OBD7EEx9vanqB+aWJMAIU1MHp7Xqf5PcBsv9Tnx3/8tUZjU/0Wazjnwxpx\n NJ13n9omkcCeeRPN3331cEI5tp1+hT9Fi/MmGisGxUHb9k4bwznQx+0QQRroc7sUF4c7\n JLRw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=19HXGqSox2hwZB7/J65WnaWVZDUxRzJIIwGFz2bh+58=;\n fh=iExg1+WOn1OQKO7evmLFhUuLbnagnvx+Q/4+PBaFS1Y=;\n b=OLQnIcR7cj8YUtSWsxpbBowCgZDFMitriSSB0GOEehRQkppHPxaJF4yRCoRpof9vaU\n wcAzA0V80mKZvp4STcf2IRZync7h4BJSw6OegN9VZr3er+baTC0TTIUWV2Vb/avvO3zd\n yDkOu8zh7eQoKoZuKOn/KR09SP52bv5/w0bSY8fivdImJ0qf9Gq6kxHNpTo7Mmx8Q+qb\n 1PYLSv0SYIZfmgoR8Ap1DrimuEOLm/Ecsjt2ZHqUPkB8ud1KibAC0FRGu70kfOLSjjd0\n v8WUCw3EOgcWZYy4Sq+1T6ekdvs84/59hXDuubD130Sm7ArhgBUnSIMU+mE7g1haojyH\n KKBg==; darn=nongnu.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777895635; x=1778500435;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=19HXGqSox2hwZB7/J65WnaWVZDUxRzJIIwGFz2bh+58=;\n b=A4lM2nJQBZO3VaXf9/iKXZnnYo1A6v0R0QlHaKReZI9azoqfqaKMcxSBI8BbT++z9c\n KA9tf15anuwaMHnwnvlzdAXzXWOSWoilN9kQv4/bICSlLEEDvrRVIuNiusWhA+pGMFNl\n N89tbomEkD1xljScQh4gd5sr5YKuJTrkA0OqicvUPlMWw6z6JY8L2uDtRxqGFSMQjak9\n NnnJslRf+QFVRcQOupqkKHNCx8lWU20ORySyZDOLtjiNDcaEC/GF6DdCUVBeirclCh3p\n 9x3O79Ej1/ZA8AWFBOLTPVMLzzjxEvPurz2Gxr9BKuz9C39qLnl6+W4iiK2bk46I5w3i\n +aFw==","X-Gm-Message-State":"AOJu0YzInSup6mR2/kOr+OwKg7Leom0DXylS41hePKXnuEwccgyDzcau\n gHFESPMne0lPut7CiuldOyRRenRnckb/lpSHuaGT+qK31Bhtnd8fiZod0XgAeEgYCDf6/JTZP0z\n zwj0cPU2LkXDksx9g0kzKnWzuKQeMogeamLv27CX6ya52khf/a6AVaZtZj/FjGRL6vF7DpC3REu\n qgqF5KqbrvNA5EUv75MMuRgoxAO0yn/8CSq5F6/0V3/g==","X-Gm-Gg":"AeBDieuoPavkYmYiAwoHqNxEPEDDD3SCRR7Jvo81p1bC/ebO4bPynSprhOkUGmoMoE7\n uwW8GujEkv7hyS+unVg1n0t2I653zpYG6OK5T3mKOFu9xEy4u3FTcaO+2PhNuVqvz7Kgca3Z4Cy\n IFc4WgPkaUEqm2wL+hYV0Pufgz5kH+yf0sKdn98P1kPRxYK9kU5bvLMN7+fQp3h+N15BLjmDZ1D\n hH04+YpFrV6UK3ukz37OQ55gL26HW27ONSyM7rS+uCOJdrnO7JEt+NnhqbFTA2t6jOM+PVlQG/6\n qbSi0R74WiuzUQ/mCWSzgOe8RrFQc7k/Ha8=","X-Received":["by 2002:a05:6a20:938e:b0:39c:787:f196 with SMTP id\n adf61e73a8af0-3a7f1a8c3f6mr9050954637.16.1777895635189;\n Mon, 04 May 2026 04:53:55 -0700 (PDT)","by 2002:a05:6a20:938e:b0:39c:787:f196 with SMTP id\n adf61e73a8af0-3a7f1a8c3f6mr9050920637.16.1777895634585; Mon, 04 May 2026\n 04:53:54 -0700 (PDT)"],"MIME-Version":"1.0","References":"<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>\n <20260504-qom-tests-v2-42-ef7e3dc94f7a@redhat.com>","In-Reply-To":"<20260504-qom-tests-v2-42-ef7e3dc94f7a@redhat.com>","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>","Date":"Mon, 4 May 2026 15:53:43 +0400","X-Gm-Features":"AVHnY4KvPjcViPnxdKEXBtwEfZaA7zkZegpaMnChRJCsSrh-rd1QNr0x_FCWIzE","Message-ID":"\n <CAMxuvax9D6EfQpiHX9BWs-1nH9npaFVSmPbP9cMUST0k31z7HQ@mail.gmail.com>","Subject":"Re: [PATCH v2 42/46] target/riscv: fix general_user_opts hash table\n leak","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=mlureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-24","X-Spam_score":"-2.5","X-Spam_bar":"--","X-Spam_report":"(-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]