[{"id":3685741,"web_url":"http://patchwork.ozlabs.org/comment/3685741/","msgid":"<619bc62d-49c4-4c86-bb12-7412cad1ff65@redhat.com>","list_archive_url":null,"date":"2026-05-04T12:41:56","subject":"Re: [PATCH v2 34/46] hw/fsi: move OPBus qbus_init() to instance_init","submitter":{"id":85406,"url":"http://patchwork.ozlabs.org/api/people/85406/","name":"Cédric Le Goater","email":"clg@redhat.com"},"content":"On 5/4/26 13:35, Marc-André Lureau wrote:\n> Remove the TODO comment that documented the workaround, as it is\n> no longer needed.\n> \n> Suggested-by: Cédric Le Goater \n> Signed-off-by: Marc-André Lureau \n> ---\n> hw/fsi/aspeed_apb2opb.c | 13 +------------\n> 1 file changed, 1 insertion(+), 12 deletions(-)\n> \n> diff --git a/hw/fsi/aspeed_apb2opb.c b/hw/fsi/aspeed_apb2opb.c\n> index 36092468391..058abc86452 100644\n> --- a/hw/fsi/aspeed_apb2opb.c\n> +++ b/hw/fsi/aspeed_apb2opb.c\n> @@ -273,6 +273,7 @@ static void fsi_aspeed_apb2opb_init(Object *o)\n> for (i = 0; i < ASPEED_FSI_NUM; i++) {\n> object_initialize_child(o, \"fsi-master[*]\", &s->fsi[i],\n> TYPE_FSI_MASTER);\n> + qbus_init(&s->opb[i], sizeof(s->opb[i]), TYPE_OP_BUS, DEVICE(s), NULL);\n\nnice !\n\n> }\n> }\n> \n> @@ -282,18 +283,6 @@ static void fsi_aspeed_apb2opb_realize(DeviceState *dev, Error **errp)\n> AspeedAPB2OPBState *s = ASPEED_APB2OPB(dev);\n> int i;\n> \n> - /*\n> - * TODO: The OPBus model initializes the OPB address space in\n> - * the .instance_init handler and this is problematic for test\n> - * device-introspect-test. To avoid a memory corruption and a QEMU\n> - * crash, qbus_init() should be called from realize(). Something to\n> - * improve. Possibly, OPBus could also be removed.\n> - */\n> - for (i = 0; i < ASPEED_FSI_NUM; i++) {\n> - qbus_init(&s->opb[i], sizeof(s->opb[i]), TYPE_OP_BUS, DEVICE(s),\n> - NULL);\n> - }\n> -\n> sysbus_init_irq(sbd, &s->irq);\n> \n> memory_region_init_io(&s->iomem, OBJECT(s), &aspeed_apb2opb_ops, s,\n> \n\nReviewed-by: Cédric Le Goater \n\nThanks,\n\nC.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Fa8bTl8p;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=fAXLBG/P;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8LsK0bv7z1yJ0\n\tfor ; Mon, 04 May 2026 22:42:59 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wJscf-00011b-Ta; Mon, 04 May 2026 08:42:05 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wJsce-000117-5r\n for qemu-devel@nongnu.org; Mon, 04 May 2026 08:42:04 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wJscc-0001zb-F6\n for qemu-devel@nongnu.org; Mon, 04 May 2026 08:42:03 -0400","from mail-wr1-f70.google.com (mail-wr1-f70.google.com\n [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-486-LrCuM6WfMbChSvBUlmH0Eg-1; Mon, 04 May 2026 08:41:59 -0400","by mail-wr1-f70.google.com with SMTP id\n ffacd0b85a97d-4411a36715dso2859850f8f.2\n for ; Mon, 04 May 2026 05:41:59 -0700 (PDT)","from ?IPV6:2a01:e0a:280:24f0:9db0:474c:ff43:9f5c?\n ([2a01:e0a:280:24f0:9db0:474c:ff43:9f5c])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a8fe3cae3sm111879025e9.0.2026.05.04.05.41.57\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Mon, 04 May 2026 05:41:57 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777898521;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references:autocrypt:autocrypt;\n bh=K9QBWp5H+ydDasr/z4vN8DMthPHp9zsLZhsnXeEOO6s=;\n b=Fa8bTl8pglbt+W+2k5Uw9y65XfnZCjAnsAC5EJGv7PqiR3KcyXAB8ZM6g8AS39QsW/PkQi\n 2ZFZMocpWC7JHVXdLQKTEifgkr/lx3BbduxdsAK08yAeJ6YSQzjI+Taw+Kga+dJUm/WVdE\n dsCrt2ff5RfjAyPMhEOMu8qZ7+jiRBc=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1777898518; x=1778503318; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:autocrypt:from\n :content-language:references:cc:to:subject:user-agent:mime-version\n :date:message-id:from:to:cc:subject:date:message-id:reply-to;\n bh=K9QBWp5H+ydDasr/z4vN8DMthPHp9zsLZhsnXeEOO6s=;\n b=fAXLBG/PsGFVDfQRMHYL4gegZT+SZhRiUr0YNc+lm0brdUbqLUW7f6Y5C0gMDPU8Rv\n AeDf6HLa8sE9fYGKwSZdFU9r8LgMJKK7q4QyIhZ2rAuAeJrrMY7NJkIKMWyKSkmpiY8H\n AdYY2ImGnBwvSymmFpIgqh+AwzQ8o/PAYsJrxXTcK/kTi7PwX5sZJx5qL/NlMuscu96/\n cowpw27AeckhWhEN9VzHpfZe2LLb7lC2uPo9rJRpV3WJOAXT+xAA0BK61Wyz8Jyu38bo\n ob88kiqi3Fx1/eYE1Wyg4pLmqIXOqHtQ6MfdG3JCYadV4mlVtDfOjJRbuFRKt0fFNWkS\n 956Q=="],"X-MC-Unique":"LrCuM6WfMbChSvBUlmH0Eg-1","X-Mimecast-MFC-AGG-ID":"LrCuM6WfMbChSvBUlmH0Eg_1777898518","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777898518; x=1778503318;\n h=content-transfer-encoding:in-reply-to:autocrypt:from\n :content-language:references:cc:to:subject:user-agent:mime-version\n :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=K9QBWp5H+ydDasr/z4vN8DMthPHp9zsLZhsnXeEOO6s=;\n b=lwvDUbJVTwT53H+vOI6tolqoprza2+xLzF2jL3oznvxKveTW1JstAgjLS95vEhz+Sx\n 5oSVDQHsmIqYB/vOpe8rpCZxcxZvU7DJWihtoSc6x4YXedn/KbikHuzaU2vsmJuXwLJr\n mw4iNTosKXMwphtxh+kp9OF5lCjD0nRAec6ptLiiGS4r7M4vJIjz0lJxYctIr9dlijPS\n HSDuQcBFtTxb1/GwKsmwpGafgmjNqUvmadu1N8FAYtHEScMkuUAi5w0kPI3YSbrsxPkH\n fysIfMVY1DqbDSjrFXtRNpJ9m6ZjO3nnVnAP1yLalKvWiNjAIagfexjqD94xjfs7s+ng\n dtuQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/07Na74u/gE20GFWw9zID3wFOJt/gNpK0D8DgJu7h0DHyvZWbkh87K/pvSUgtLuT/dF2lArpTYmOH/@nongnu.org","X-Gm-Message-State":"AOJu0YyeHGgS8aLg30QIYj7Nm5cHp/QIY5ly6ESJRk4T2qOHDZ2yVd7W\n TK+NxG1w+2DjsAHMwSV9lbKGVyfobpAG+4pNRnuaAzJngIbpDGPmL5aAagaRp0jPLMHgiLt1t/M\n /3jK8ceJPQuLDg+H4COvJoMh+oSwFdo2MIpiQwC13c47w3bp9e42cxAZJ","X-Gm-Gg":"AeBDieve3T/kqu4dlITiAoLW5MKnbo4z8OTrqbT4+sNLYMCPxjHpxS3FUOj3uWx5BRL\n u7mE2S1JlW1VRhCOLVw7rAP7KI5fxpeVpyXdiaK96UweZil/wPuEN7StUDVC0gHTY9OOv2yM1cl\n nqGhA1NkVAPmHHjJ8P2K5EP+8AHSEQ8MWHMHmuNpCbYtLX4pTIGbj6fruCRkB9BA0grKI+EEb2J\n FuLyNOVdJtACh8eq8xHQsuQ0aqmYKt41xSZS/QJUdyDebwJUQYW6cN4GbXP+o07CwbVjzQIE2zv\n sQtFfEFeMBKswu7Ia8DNR2J7EMKF4JNcFefGntGNO9DYXuxDk+cp2qQlrfysQyf75IdjJ1yFi0t\n 49eq62tntLS8/JUfGwGVnrSvqW5wNAJY+eib5e4LNtAxBKimd/H5mVJZ2ig9BhyqGhp7zZSA=","X-Received":["by 2002:a05:600c:3e07:b0:489:201c:dc46 with SMTP id\n 5b1f17b1804b1-48a98640536mr153644625e9.12.1777898518392;\n Mon, 04 May 2026 05:41:58 -0700 (PDT)","by 2002:a05:600c:3e07:b0:489:201c:dc46 with SMTP id\n 5b1f17b1804b1-48a98640536mr153644295e9.12.1777898517999;\n Mon, 04 May 2026 05:41:57 -0700 (PDT)"],"Message-ID":"<619bc62d-49c4-4c86-bb12-7412cad1ff65@redhat.com>","Date":"Mon, 4 May 2026 14:41:56 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 34/46] hw/fsi: move OPBus qbus_init() to instance_init","To":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n qemu-devel@nongnu.org","Cc":"armbru@redhat.com","References":"<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>\n <20260504-qom-tests-v2-34-ef7e3dc94f7a@redhat.com>","Content-Language":"en-US, fr","From":"=?utf-8?q?C=C3=A9dric_Le_Goater?= ","Autocrypt":"addr=clg@redhat.com; keydata=\n xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo\n 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t\n yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj\n 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0\n ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV\n RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+\n gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia\n 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS\n Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS\n tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSJDw6lkcmljIExl\n IEdvYXRlciA8Y2xnQHJlZGhhdC5jb20+wsGRBBMBCAA7FiEEoPZlSPBIlev+awtgUaNDx8/7\n 7KEFAmTLlVECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQUaNDx8/77KG0eg//\n S0zIzTcxkrwJ/9XgdcvVTnXLVF9V4/tZPfB7sCp8rpDCEseU6O0TkOVFoGWM39sEMiQBSvyY\n lHrP7p7E/JYQNNLh441MfaX8RJ5Ul3btluLapm8oHp/vbHKV2IhLcpNCfAqaQKdfk8yazYhh\n EdxTBlzxPcu+78uE5fF4wusmtutK0JG0sAgq0mHFZX7qKG6LIbdLdaQalZ8CCFMKUhLptW71\n xe+aNrn7hScBoOj2kTDRgf9CE7svmjGToJzUxgeh9mIkxAxTu7XU+8lmL28j2L5uNuDOq9vl\n hM30OT+pfHmyPLtLK8+GXfFDxjea5hZLF+2yolE/ATQFt9AmOmXC+YayrcO2ZvdnKExZS1o8\n VUKpZgRnkwMUUReaF/mTauRQGLuS4lDcI4DrARPyLGNbvYlpmJWnGRWCDguQ/LBPpbG7djoy\n k3NlvoeA757c4DgCzggViqLm0Bae320qEc6z9o0X0ePqSU2f7vcuWN49Uhox5kM5L86DzjEQ\n RHXndoJkeL8LmHx8DM+kx4aZt0zVfCHwmKTkSTQoAQakLpLte7tWXIio9ZKhUGPv/eHxXEoS\n 0rOOAZ6np1U/xNR82QbF9qr9TrTVI3GtVe7Vxmff+qoSAxJiZQCo5kt0YlWwti2fFI4xvkOi\n V7lyhOA3+/3oRKpZYQ86Frlo61HU3r6d9wzOwU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhW\n pOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNLSoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZ\n KXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVUcP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwp\n bV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6\n TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFU\n CSLB2AE4wXQkJbApye48qnZ09zc929df5gU6hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iS\n YBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616dtb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6g\n LxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7\n JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1cOY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0Sdu\n jWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/Jx\n IqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k\n 8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoXywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjK\n yKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9j\n hQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Tad2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yop\n s302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it+OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/p\n LHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1nHzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBU\n wYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVISl73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lU\n XOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfA\n HQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4PlsZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQ\n izDiU6iOrUzBThaMhZO3i927SG2DwWDVzZltKrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gD\n uVKe8BVz4atMOoktmt0GWTOC8P4=","In-Reply-To":"<20260504-qom-tests-v2-34-ef7e3dc94f7a@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=clg@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-24","X-Spam_score":"-2.5","X-Spam_bar":"--","X-Spam_report":"(-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]