[{"id":3685670,"web_url":"http://patchwork.ozlabs.org/comment/3685670/","msgid":"<20260504115549.3990-1-linuxtestproject.agent@gmail.com>","list_archive_url":null,"date":"2026-05-04T11:55:49","subject":"Re: [LTP] high_freq_hwp_cap_cppc.c: new test","submitter":{"id":93132,"url":"http://patchwork.ozlabs.org/api/people/93132/","name":null,"email":"linuxtestproject.agent@gmail.com"},"content":"Hi Piotr,\n\nOn Mon, 4 May 2026 12:17:36 +0200, Piotr Kubaj wrote:\n> high_freq_hwp_cap_cppc.c: new test\n>\n> Verify for all online logical CPUs that their highest performance value are\n> the same for HWP Capability MSR 0x771 and CPPC sysfs file.\n\nThe body describes what the test does but not why it is needed. Please\nadd at least one sentence explaining the motivation — e.g. a known\ninconsistency, a kernel regression, or a new interface being validated.\n\n[...]\n\n> +\t\tsnprintf(path, sizeof(path), \"/dev/cpu/%d/msr\", i);\n> +\t\tint fd = SAFE_OPEN(path, O_RDONLY);\n> +\n> +\t\tSAFE_PREAD(1, fd, &msr_highest_perf, sizeof(msr_highest_perf), MSR_HWP_CAPABILITIES);\n> +\t\tSAFE_CLOSE(fd);\n\nIf SAFE_PREAD aborts via tst_brk(), cleanup() is called but fd is never\nclosed because it is a loop-local variable with no cleanup handler.\nPromote fd to a static (initialized to -1) and add a cleanup() that\nguards with `if (fd != -1) SAFE_CLOSE(fd);`.\n\n---\nNote:\n\nOur agent completed the review of the patch. The full review can be\nfound at: https://github.com/linux-test-project/ltp-agent/actions/runs/25317225258\n\nThe agent can sometimes produce false positives although often its\nfindings are genuine. If you find issues with the review, please\ncomment this email or ignore the suggestions.\n\nRegards,\nLTP AI Reviewer","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=JsWJu7Fa;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8Kq23fb5z1y04\n\tfor ; Mon, 04 May 2026 21:55:58 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 6E6053E6200\n\tfor ; Mon, 4 May 2026 13:55:56 +0200 (CEST)","from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [217.194.8.7])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id C926C3C22A5\n for ; Mon, 4 May 2026 13:55:52 +0200 (CEST)","from mail-qk1-x743.google.com (mail-qk1-x743.google.com\n [IPv6:2607:f8b0:4864:20::743])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-7.smtp.seeweb.it (Postfix) with ESMTPS id 738B0200770\n for ; Mon, 4 May 2026 13:55:51 +0200 (CEST)","by mail-qk1-x743.google.com with SMTP id\n af79cd13be357-8eae9229110so698504285a.1\n for ; Mon, 04 May 2026 04:55:51 -0700 (PDT)","from\n runnervmeorf1.2xrq0wyeyqxelezmophrvlasqb.bx.internal.cloudapp.net\n ([172.172.157.3]) by smtp.gmail.com with ESMTPSA id\n af79cd13be357-8fc293816e8sm996080185a.8.2026.05.04.04.55.49\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 04 May 2026 04:55:49 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777895750; x=1778500550; darn=lists.linux.it;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=8ouZdnFHmhbn8WCJS5RTP7B8jCIzhnjCNWidVraL428=;\n b=JsWJu7FaHsEOvILWgzbsiR/4erDjSszmsXHPU0bOsalV8hXPULIM98j3u5tCVv8qsy\n 0d2+cAl/PSXwyQ7p1Cl5tjuVbKvWdCnVlmGwVnGAlL1Xq/fNnFkWeuhfFRWoVRUV/jts\n VZOgcn6R69fQ8MBgC+khw/NF6rzmYI0mhFaCKQHOMJHUPNdCVML3//ETtaGxARQtY2XO\n y/gJo8AZQ3r44oGVKZ+bjURNsEYx7EB/gLtt23P+XMXQz+dz56madSX4xnt6XpGHsP4U\n kFH0tuAJb03beifdNt/HuJnNSVmITmKM/PzWOFkoROfkC4PTxN9Y+qnBKGIWKjIY13vi\n C33Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777895750; x=1778500550;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=8ouZdnFHmhbn8WCJS5RTP7B8jCIzhnjCNWidVraL428=;\n b=Pc2yFug+i9zxkGokNPI9P0PAt5GunoZARSmDT+7/Me+rP8veCiXa45hL0suegzp8By\n ODu5Wft3Fv81+INMY+sQbUT+4fPAmNcr3v5BAYWy5azhmd8pUuDgb0IoXWdN6TXDhXyI\n TyRmbOz2obLtLQ5OzHI9feBxw8uDEMBe2njqS322Rj6clq/tGli1eTnFjbIilm3SzUHd\n PGpRiE5WfdUg6u3hCmXfo9tatah9yjUWJqyiepQZUXHk7/EPX3Cink0ZRXqCUlZ4AXOD\n tdQHyG4do5LFcasHJ5gbSrv7N53ecINGd486BwOOkWzhzy6lpEZOMnM5i9B8d+nzklAm\n 6Oqg==","X-Gm-Message-State":"AOJu0YyV8/2/BElhnxtUf6Yu/eYZ8wxb0PAzoTzO+h/gWgaaMJ2mv/z9\n 1YAZoeEFCSmG0MEY83GsVKRqhoQzAJMzlV+/0WjFqhPHKfCo/wV3hxZB","X-Gm-Gg":"AeBDiev8IKMrySyJZZx5DOKOkViPo9knZxUB8duZeFc4qwS3zZ/9jd9JtoT3IFKexZj\n 7BtJ7mj/PnBHin1jYvO7vWIvujQx9M1MULlnZdeO6iQpf8MQR1YU7V/xmxQpn6U+JD9oBGcx3s0\n BxACL1uPS/dEaetIIObrmTVzIyqJywt4+EEQNEtDPviU16CiDqL1NNEAn9cEYKZEOWPPvyTTwsA\n PjSdow6vTf2qN/SZSMnZST5edk75Eyd3Z/4iRy+1Dg6Ua6+BZ666343CoUaiPUX9ZJrP/oA89EM\n IivSmxR/5W2WVrTP/F2lZLAlEAOvMYme/LmjemvYT5+21pdSvmWJzJbhIt4o27wcLBsZsr5bC5F\n ZJq+divLMzTEzWyCoN9zzrtNyzzpeasBuslojtdhuoCUB/UlAA6TewMdE5FJJ2RaJn9JZFmk/2u\n WlQOj9JG5VhU/7bJQdgdXxtCZpViKxkLqhIMubSkzHVgpoeVL4v4Sqti/LfiD4wdhucbWvgxyxE\n cxp0ZMiEqR+vEmPdAil3qahx2IoqAgVymUvBfysAMp1mBRw8w==","X-Received":"by 2002:a05:620a:489a:b0:8ea:addd:8942 with SMTP id\n af79cd13be357-8fd18a2986dmr1503328485a.58.1777895750194;\n Mon, 04 May 2026 04:55:50 -0700 (PDT)","From":"linuxtestproject.agent@gmail.com","To":"Piotr Kubaj ","Date":"Mon, 4 May 2026 11:55:49 +0000","Message-ID":"<20260504115549.3990-1-linuxtestproject.agent@gmail.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260504101736.26544-2-piotr.kubaj@intel.com>","References":"<20260504101736.26544-2-piotr.kubaj@intel.com>","MIME-Version":"1.0","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE,SPF_PASS\n shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-7.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-7.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] high_freq_hwp_cap_cppc.c: new test","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}}]