[{"id":3685668,"web_url":"http://patchwork.ozlabs.org/comment/3685668/","msgid":"<20260504115424.3993-1-linuxtestproject.agent@gmail.com>","list_archive_url":null,"date":"2026-05-04T11:54:24","subject":"Re: [LTP] cpufreq.c: add new test for cpufreq sysfs interface\n validation","submitter":{"id":93132,"url":"http://patchwork.ozlabs.org/api/people/93132/","name":null,"email":"linuxtestproject.agent@gmail.com"},"content":"Hi Piotr,\n\nOn Mon, 4 May 2026 12:08:42 +0200, Piotr Kubaj wrote:\n> cpufreq.c: add new test for cpufreq sysfs interface validation\n\n> +\t\tsnprintf(path, sizeof(path), \"/sys/devices/system/cpu/cpu%d/cpufreq/scaling_governor\", i);\n> +\t\t...\n> +\t\tSAFE_FILE_PRINTF(path, \"powersave\");\n\nscaling_governor is modified for every online CPU (in both the active-mode\nand passive-mode loops) but is never saved in setup() nor restored in\ncleanup(). After the test exits each CPU is left with scaling_governor set\nto \"schedutil\". Please save the original value per CPU in setup() alongside\nprevious_scaling_max_freq and restore it in cleanup().\n\n[...]\n\n---\nNote:\n\nOur agent completed the review of the patch. The full review can be\nfound at: https://github.com/linux-test-project/ltp-agent/actions/runs/25317225931\n\nThe agent can sometimes produce false positives although often its\nfindings are genuine. If you find issues with the review, please\ncomment this email or ignore the suggestions.\n\nRegards,\nLTP AI Reviewer","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=cIYV8W8t;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8KnQ4vHPz1yJ9\n\tfor ; Mon, 04 May 2026 21:54:34 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 5CF623E6207\n\tfor ; Mon, 4 May 2026 13:54:32 +0200 (CEST)","from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 651143C22A5\n for ; Mon, 4 May 2026 13:54:28 +0200 (CEST)","from mail-pf1-x442.google.com (mail-pf1-x442.google.com\n [IPv6:2607:f8b0:4864:20::442])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-4.smtp.seeweb.it (Postfix) with ESMTPS id AAB281000489\n for ; Mon, 4 May 2026 13:54:27 +0200 (CEST)","by mail-pf1-x442.google.com with SMTP id\n d2e1a72fcca58-82fb2d0c5d1so3107201b3a.0\n for ; Mon, 04 May 2026 04:54:27 -0700 (PDT)","from\n runnervmeorf1.atih1j5idlnuzf0a0ifstqup0a.xx.internal.cloudapp.net\n ([4.155.99.35]) by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-835446b1b0asm6124545b3a.8.2026.05.04.04.54.25\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 04 May 2026 04:54:25 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777895666; x=1778500466; darn=lists.linux.it;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=FdktCNVIq9DlDkLZr1oC3lpNxpOQPCqF1Yjukhp/2Ws=;\n b=cIYV8W8tL/T0Sw9AaFkLb0a6wgkl3ejUdzeVJIwOwz0V3NBUIcoqes09PENF8BV9HJ\n SnpaTAC778cvwKao9bLMMiFmXhh86fDJqE41Nu7tZIrDLMI/Mu4tB0o1FWMmtEqR0rkM\n 3Aimohyc8zEqPIml/4ZOfmPRD6xCHNg/TG//g3erDg21O6not0eEYcJTC8oS3gURC9ad\n j+Cz2bMqu2PZSOCF3yxBRXQUh8qdZn8WP2b00o7/6/HgE4lTBZuAyPhvItbRnXqccSjb\n cerqaq3BS4VYrqUUIOMwt17B4p1tQHEogqJugqx+/6NECz4H4W5SwhjNMO4u6R/Sf4rC\n M2Dw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777895666; x=1778500466;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=FdktCNVIq9DlDkLZr1oC3lpNxpOQPCqF1Yjukhp/2Ws=;\n b=cvSZTTf1IZeX87IVMXh2/ZgNklmdIcv7jLN97CaB2cgTlVstmmtbT7MB2RcNeKxTVC\n l2yLfl8dmDmhbhMJRG5gkOVWpDf6PoKP8pYmk9u1uE9Z//KW1b4HvZ1JVe7GR5DqFp09\n 0dew0pibEU5zMOHEXTAZ3sy5+E0v/nvdobbhOWGpGqhEu/ZQQCJ5ZOZsPmxzBfh4mE8Z\n Ay1WqpHQ5BkxhA3ZVm7TavUpfgH14RmSzq7F7piGLdVrUlqkyVIpN+WvRRg0HLuwqPHZ\n AImkzvk+2OugfBo99xmvzFyWlP60Hrd9OHxhS4uqYALb5OakraIJaR7YpQe/3yfdkRRn\n DsHQ==","X-Gm-Message-State":"AOJu0Yyv2Hj00tbjrN62PIVdp3BXHikqh7aUoBtLUBiXBDhdrFXIvjKm\n lyhYCt3IXb19WOyDZXJzBbBSLHSAC1C146tQq3V9Fk/mvAGxIAEsQ4Ewzm9VoqZadb2puA==","X-Gm-Gg":"AeBDiesdyum0NodrVdeu0feIzKyzIyl0k9Ag1oPvvNwRy2LNlgP8UI8Di8cvAu1nckj\n j6CVtmInPnlGPx+eZxmOCdFBIBQAiN6iAI5YmGX/vPxaJU5+TZlrOkXE12/5vfuvVOtYSiKLIYq\n 5r/wAoUq7NAUlz+7yl6KxOFqP/um1I/Z7upd2P+LgIauksjGW9yl5rE1/eEHkCZDW4gv7v6+H5V\n IRD7K3tUz4j2WndjYNx2BziPsyZZG9+9rXgh2OAZz6I+D+KiK0YbS5H9hD5jx8ko9xPzTLcFRXz\n HsbyeY6bG7bzw/DyPWv3Z3ngGt1y0c2+LqavFobt3m63B4RZXRCuQc4UcRB8VMGukkFHR4nUlj6\n PJkUxIbdP3og5Polz8if4WY5aCd/LjHNHaF6xQ+07eBksGb7Jx2RAVqJgUcN3f52/Ts8iD6UUfN\n 08QrtS2ZReP3PzMtUMTNlN08BlKkriLnn5QQu2X4cAQPfpEMmWPk4AARsNqsbqWr9LMx1PVILu5\n kR0vzKM1T37KX5nSdCjtNgr5vUma1u9o9vo2esl2hdiZ/k=","X-Received":"by 2002:a05:6a00:9284:b0:834:e24c:3f9c with SMTP id\n d2e1a72fcca58-8350000ec86mr14570747b3a.22.1777895666106;\n Mon, 04 May 2026 04:54:26 -0700 (PDT)","From":"linuxtestproject.agent@gmail.com","To":"Piotr Kubaj ","Date":"Mon, 4 May 2026 11:54:24 +0000","Message-ID":"<20260504115424.3993-1-linuxtestproject.agent@gmail.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260504100841.20737-2-piotr.kubaj@intel.com>","References":"<20260504100841.20737-2-piotr.kubaj@intel.com>","MIME-Version":"1.0","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE,SPF_PASS\n shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-4.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-4.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] cpufreq.c: add new test for cpufreq sysfs interface\n validation","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}}]