[{"id":3686105,"web_url":"http://patchwork.ozlabs.org/comment/3686105/","msgid":"","list_archive_url":null,"date":"2026-05-05T01:33:32","subject":"Re: [PATCH v3] ASoC: tegra: Add per-stream Mixer Fade controls","submitter":{"id":24878,"url":"http://patchwork.ozlabs.org/api/people/24878/","name":"Mark Brown","email":"broonie@kernel.org"},"content":"On Mon, May 04, 2026 at 10:00:51AM +0000, Sheetal wrote:\n\n> +static int tegra210_mixer_put_fade_duration(struct snd_kcontrol *kcontrol,\n> +\t\t\t\t\t struct snd_ctl_elem_value *ucontrol)\n> +{\n> +\tstruct soc_mixer_control *mc =\n> +\t\t(struct soc_mixer_control *)kcontrol->private_value;\n> +\tstruct snd_soc_component *cmpnt = snd_kcontrol_chip(kcontrol);\n> +\tstruct tegra210_mixer *mixer = snd_soc_component_get_drvdata(cmpnt);\n> +\tunsigned int id = mc->reg;\n> +\tu32 duration = ucontrol->value.integer.value[0];\n> +\n> +\tif (duration == 0)\n> +\t\treturn -EINVAL;\n> +\n> +\tif (mixer->duration[id] == duration)\n> +\t\treturn 0;\n> +\n> +\tmixer->duration[id] = duration;\n> +\tmixer->fade_pending[id] = true;\n> +\n> +\treturn 1;\n\nWe're not validating against TEGRA210_MIXER_FADE_DURATION_MAX here,\nsimilarly for the gain.\n\n\n> +static int tegra210_mixer_get_fade_status(struct snd_kcontrol *kcontrol,\n> +\t\t\t\t\t struct snd_ctl_elem_value *ucontrol)\n> +{\n\n> +\t\tif (count >= mixer->duration[id]) {\n> +\t\t\tucontrol->value.integer.value[id] = TEGRA210_MIXER_FADE_IDLE;\n> +\t\t\tmixer->in_fade[id] = false;\n\nThis doesn't disable the sample counting so subsequent enables will be\nnoops (due to use of _update_bits()).","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=TcrBL9Qj;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=104.64.211.4; helo=sin.lore.kernel.org;\n envelope-from=linux-tegra+bounces-14167-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"TcrBL9Qj\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org [104.64.211.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8gyW1krPz1y04\n\tfor ; Tue, 05 May 2026 11:33:39 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 1833A3008602\n\tfor ; Tue, 5 May 2026 01:33:37 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 06E56293C4E;\n\tTue, 5 May 2026 01:33:35 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id BAB8E78F4A;\n\tTue, 5 May 2026 01:33:34 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 32159C2BCB8;\n\tTue, 5 May 2026 01:33:34 +0000 (UTC)","by finisterre.sirena.org.uk (Postfix, from userid 1000)\n\tid 111451AC586C; Tue, 05 May 2026 02:33:32 +0100 (BST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777944814; cv=none;\n b=a6yzqqGX35GYVIGvEq2JSqm2/jPpMfGkZzBHGpXZ5oQxUOnfoHD8ZgkCNz0ztrDpaj6PKIUlYTMY8Fk6lh2jigwemD5oufW6/cz1KfjyrmW3f+4Tp8oZoaP4y5SizznDc5tm5R3w9WcTF3nUjgw6ZaDWXxBy+d8OHZn2NXkaZkk=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777944814; c=relaxed/simple;\n\tbh=531U/ura2lGclcMT9muQeinmIdsS8LIUdVAX3tvAsy4=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=S1xpPcGzpL57hm5PS03MNHs/ojsjMQ8arrDeFnJ9CcT0dZ2E7BDDjno0E5QLFDySH0wU3crbTJ9wv/vk3tp9Q82gln3iBQNWjlltrAtNM167iGAn0+vsuL0mgbh7iMxiwtgnOT9HG3JhNeGNNT6E4t+m6a0r1GJqoY/+f9QeeCs=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=TcrBL9Qj; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1777944814;\n\tbh=531U/ura2lGclcMT9muQeinmIdsS8LIUdVAX3tvAsy4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=TcrBL9QjrDAsDwjWv4afTcgoMhSpWEzKqwdxnXCqQTmMCDoCocmu5yXSpINQGaMfz\n\t R5haR4luO2MvOD7MLoyS5/JSPETHcO3zggS0kjzzEJZ927vQlEbu0glUYx1WsuEvOz\n\t HbCG1fm5XsqUMMCzjg29hK16b/L+xGaXXFlUw4836Hqg/uMxDBlht6N73XyGiaGgkf\n\t Omfdvw1FBkjLZcMlN0W543l6OfQEJhl8vZhzA/NUlZONlIc0hM1LO1kXYRNjYHPN4g\n\t VH4xMlzJP6yo5eKRswJ18OzledVeZFeiy3Tkf6b6kD2W8toJJaxPm/u0lZ0PAmm9bR\n\t EIxDsOoYi/s7A==","Date":"Tue, 5 May 2026 10:33:32 +0900","From":"Mark Brown ","To":"Sheetal ","Cc":"Liam Girdwood , Jaroslav Kysela ,\n\tTakashi Iwai ,\n\tThierry Reding ,\n\tJonathan Hunter ,\n\tSameer Pujar , Mohan Kumar ,\n\tKuninori Morimoto ,\n\tlinux-sound@vger.kernel.org, linux-tegra@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH v3] ASoC: tegra: Add per-stream Mixer Fade controls","Message-ID":"","References":"<20260504100051.3820808-1-sheetal@nvidia.com>","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n\tprotocol=\"application/pgp-signature\"; boundary=\"TwBU4RHH5eeFXzaY\"","Content-Disposition":"inline","In-Reply-To":"<20260504100051.3820808-1-sheetal@nvidia.com>","X-Cookie":"Alex Haley was adopted!"}}]