[{"id":3685649,"web_url":"http://patchwork.ozlabs.org/comment/3685649/","msgid":"","list_archive_url":null,"date":"2026-05-04T11:17:37","subject":"Re: [LTP] [PATCH v3 1/2] lib: Add SAFE_SPLICE() macro","submitter":{"id":8530,"url":"http://patchwork.ozlabs.org/api/people/8530/","name":"Cyril Hrubis","email":"chrubis@suse.cz"},"content":"Hi!\n> Add new SAFE_SPLIT() in lapi/splice.h.\n> \n> Signed-off-by: Andrea Cervesato \n> ---\n> include/lapi/splice.h | 28 ++++++++++++++++++++++++++++\n> 1 file changed, 28 insertions(+)\n> \n> diff --git a/include/lapi/splice.h b/include/lapi/splice.h\n> index 191b22d2d6397d1efad5e2025be5a2c4370724dc..e346e5cca9f44bd8421c6b99f84cd4646269ac1f 100644\n> --- a/include/lapi/splice.h\n> +++ b/include/lapi/splice.h\n> @@ -7,6 +7,13 @@\n> #ifndef LAPI_SPLICE_H__\n> #define LAPI_SPLICE_H__\n> \n> +#ifndef _GNU_SOURCE\n> +# define _GNU_SOURCE\n> +#endif\n> +\n> +#include \n> +#include \n> +\n> #include \"config.h\"\n> #include \"lapi/syscalls.h\"\n> \n> @@ -19,4 +26,25 @@ static inline ssize_t splice(int fd_in, loff_t *off_in, int fd_out,\n> }\n> #endif\n> \n> +static inline ssize_t safe_splice(const char *file, const int lineno,\n> +\t\t\t\t int fd_in, loff_t *off_in,\n> +\t\t\t\t int fd_out, loff_t *off_out,\n> +\t\t\t\t size_t len, unsigned int flags)\n> +{\n> +\tssize_t ret;\n> +\n> +\tret = splice(fd_in, off_in, fd_out, off_out, len, flags);\n> +\n> +\tif (ret < 0) {\n> +\t\ttst_brk_(file, lineno, TBROK | TERRNO,\n> +\t\t\t\"splice(%d, %d, %zu) failed\", fd_in, fd_out, len);\n\nWhy don't we print the offsets?\n\n\nOtherwise:\n\nReviewed-by: Cyril Hrubis \n\n> +\t}\n> +\n> +\treturn ret;\n> +}\n> +\n> +#define SAFE_SPLICE(fd_in, off_in, fd_out, off_out, len, flags) \\\n> +\tsafe_splice(__FILE__, __LINE__, (fd_in), (off_in), (fd_out), \\\n> +\t\t (off_out), (len), (flags))\n> +\n> #endif /* LAPI_SPLICE_H__ */\n> \n> -- \n> 2.51.0\n> \n> \n> -- \n> Mailing list info: https://lists.linux.it/listinfo/ltp","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=1iTnaEks;\n\tdkim=fail reason=\"signature verification failed\" header.d=suse.cz\n header.i=@suse.cz header.a=ed25519-sha256 header.s=susede2_ed25519\n header.b=xeef6lsS;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256 header.s=susede2_rsa\n header.b=1iTnaEks;\n\tdkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=xeef6lsS;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)","smtp-out1.suse.de;\n\tnone"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8Jz222QYz1yJV\n\tfor ; Mon, 04 May 2026 21:17:50 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 122353E61FF\n\tfor ; Mon, 4 May 2026 13:17:48 +0200 (CEST)","from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::3])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id A70663E49A8\n for ; Mon, 4 May 2026 13:17:43 +0200 (CEST)","from smtp-out1.suse.de (smtp-out1.suse.de\n [IPv6:2a07:de40:b251:101:10:150:64:1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 7CC9B1A00153\n for ; Mon, 4 May 2026 13:17:41 +0200 (CEST)","from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id BC0916AADE;\n Mon, 4 May 2026 11:17:35 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A5286593A3;\n Mon, 4 May 2026 11:17:35 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id livbJk+A+GnBEQAAD6G6ig\n (envelope-from ); Mon, 04 May 2026 11:17:35 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1777893455;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=jUMR7OPHn8nED9HWOYBOyav0uXDQrvS/xqvKfOOIeCU=;\n b=1iTnaEksyn8XKU2bOhpEg7XvX73i1CsQeuCXU+Q7zsiV8oYdQ6LDXto+tcAffYkRqezQcH\n 3qLlGm3Ha/DtS8Nq59ib3rLgvK8nFT6si2A3HrZHAmc+hIlkyH2QERf42kEwPLCaQfU2on\n k6hHK06bC8t1LVIgMPtVQ2QHcdjwEOU=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1777893455;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=jUMR7OPHn8nED9HWOYBOyav0uXDQrvS/xqvKfOOIeCU=;\n b=xeef6lsSV1+19cM3HAAAls42VVY5ttA40LIVj/8fMl1OJcGt0ti3VtW1nSCV6xSGwe28QF\n 6OG63iqeaCJiOtCw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1777893455;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=jUMR7OPHn8nED9HWOYBOyav0uXDQrvS/xqvKfOOIeCU=;\n b=1iTnaEksyn8XKU2bOhpEg7XvX73i1CsQeuCXU+Q7zsiV8oYdQ6LDXto+tcAffYkRqezQcH\n 3qLlGm3Ha/DtS8Nq59ib3rLgvK8nFT6si2A3HrZHAmc+hIlkyH2QERf42kEwPLCaQfU2on\n k6hHK06bC8t1LVIgMPtVQ2QHcdjwEOU=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1777893455;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=jUMR7OPHn8nED9HWOYBOyav0uXDQrvS/xqvKfOOIeCU=;\n b=xeef6lsSV1+19cM3HAAAls42VVY5ttA40LIVj/8fMl1OJcGt0ti3VtW1nSCV6xSGwe28QF\n 6OG63iqeaCJiOtCw=="],"Date":"Mon, 4 May 2026 13:17:37 +0200","From":"Cyril Hrubis ","To":"Andrea Cervesato ","Message-ID":"","References":"<20260504-safe_splice-v3-0-e5acf4c9193b@suse.com>\n <20260504-safe_splice-v3-1-e5acf4c9193b@suse.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20260504-safe_splice-v3-1-e5acf4c9193b@suse.com>","X-Spam-Score":"-8.30","X-Spam-Level":"","X-Spamd-Result":"default: False [-8.30 / 50.00]; REPLY(-4.00)[];\n BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n RCPT_COUNT_TWO(0.00)[2]; FUZZY_RATELIMITED(0.00)[rspamd.com];\n MISSING_XM_UA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[];\n ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[];\n DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n TO_DN_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+];\n FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2];\n TO_MATCH_ENVRCPT_ALL(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, suse.com:email,\n linux.it:url, suse.cz:email, yuki.lan:mid]","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-3.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-3.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] [PATCH v3 1/2] lib: Add SAFE_SPLICE() macro","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Linux Test Project ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}},{"id":3685657,"web_url":"http://patchwork.ozlabs.org/comment/3685657/","msgid":"<69f882d3.050a0220.1640ac.969f@mx.google.com>","list_archive_url":null,"date":"2026-05-04T11:28:18","subject":"Re: [LTP] [PATCH v3 1/2] lib: Add SAFE_SPLICE() macro","submitter":{"id":82886,"url":"http://patchwork.ozlabs.org/api/people/82886/","name":"Andrea Cervesato","email":"andrea.cervesato@suse.com"},"content":"> Why don't we print the offsets?\n\nwill fix before merge. thanks\n\nRegards,\n\n--\nAndrea Cervesato\nSUSE QE Automation Engineer Linux\nandrea.cervesato@suse.com","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=lists.linux.it header.i=@lists.linux.it\n header.a=rsa-sha256 header.s=picard header.b=NQmU4C0J;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256\n header.s=google header.b=fbAJfInz;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=213.254.12.146; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [213.254.12.146])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8KCJ22Nvz1y04\n\tfor ; Mon, 04 May 2026 21:28:28 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id DE5E13E6200\n\tfor ; Mon, 4 May 2026 13:28:25 +0200 (CEST)","from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::7])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id A83F43E1869\n for ; Mon, 4 May 2026 13:28:20 +0200 (CEST)","from mail-wm1-x332.google.com (mail-wm1-x332.google.com\n [IPv6:2a00:1450:4864:20::332])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-7.smtp.seeweb.it (Postfix) with ESMTPS id 1594A200763\n for ; Mon, 4 May 2026 13:28:20 +0200 (CEST)","by mail-wm1-x332.google.com with SMTP id\n 5b1f17b1804b1-48334ee0aeaso28272835e9.1\n for ; Mon, 04 May 2026 04:28:20 -0700 (PDT)","from localhost.localdomain ([88.128.90.106])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a8fe93166sm76201675e9.7.2026.05.04.04.28.18\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 04 May 2026 04:28:19 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=lists.linux.it;\n i=@lists.linux.it; q=dns/txt; s=picard; t=1777894105; h=message-id :\n to : in-reply-to : date : subject : list-id : list-unsubscribe :\n list-archive : list-post : list-help : list-subscribe : from :\n reply-to : cc : mime-version : content-type :\n content-transfer-encoding : sender : from;\n bh=P2MNuLxQh1SDfkgdFkeAdLeZmQeQdNEP0HwkJFZ8YEQ=;\n b=NQmU4C0JPPBnkep2+bkyySPdlREWIipGRb8/2k5RIHOXR1AXVr6S5OSGKd31IQh3CmBLU\n EGL3W7HNmDS0DBUrXMS/ink74tcr5nsgC7YiCnxKJqxDZiSCShU+1caOP1osLnqKzw/p+Xi\n HPbcepY1wwkN48rpmuWIv4z+zg8OjVw=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=suse.com; s=google; t=1777894099; x=1778498899; darn=lists.linux.it;\n h=date:content-transfer-encoding:subject:in-reply-to:cc:to:from\n :message-id:from:to:cc:subject:date:message-id:reply-to;\n bh=AUES7k/2vEJ1tMjbnwzpJGSKnbkvx2acsfbnhEE6UZU=;\n b=fbAJfInz8PUb8mIq33QoVz1QmGDfD3diNBkQv1zw+n/A/9yVJIjye8y/HflBS6NMrV\n 19R4Yh5lb4ZByYU4uMgvjNGQVu2OLxQH7mBkcv07VhTs3yjS8YVb1XKFEQdiVZkKB4Ao\n 5tU478lLdMTE8hsTtAWmrBz3WBKTfthrnfUDxbJf3pzxKy/22b1n0zJeuDmhjOCN0fTd\n u3LjwsKsIBPuSkSMZj/1q0mF81wkyMpB0Yo3rw1iQNrJy8vmCBl/8B+LmL6A7Ol+dNoT\n yME3fc/IDq4ip95SLXVey730bLGcSE+3XO0mnCi+pIhKti2xvVZJdRzHq0MLJ7lSTYAh\n 996Q=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777894099; x=1778498899;\n h=date:content-transfer-encoding:subject:in-reply-to:cc:to:from\n :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=AUES7k/2vEJ1tMjbnwzpJGSKnbkvx2acsfbnhEE6UZU=;\n b=m0HSFTjSH8M0JM0EqTLBbR/5fXOzfA0108f0mRghukCF6pLMMs+VPiO/lzJVdpbTS8\n yN0FQnXsaYyF14N2wwXYaIvPjpaeTKrMfHQe7RARExcnLIVKXwTbysUgS4MDADMmOyEY\n V8jj/uYAuethsz03Df8gJxQC+Pf/hln7SdMRHbCNeYDFheAvYakfgJRE5LscEVpAmdSh\n bmf0eAY9mW4V5p7LSXhNzBELiRqsKqdn045ycdoTAkz6dLpTEIMOBIG0GhoZzWhm3+4w\n slbd6hoYVoix/vGvUPenybjA4VFY31siCgddt0Ua01kQgN+YCKs7pz6lQyouQ3GzfPEb\n thtg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9fEHakDYSgXYNEaSzLnZBR7BgmGwNR+JUoKirRZMv7gWpCYbR6PPcEnf66wUKWdmRIgho=@lists.linux.it","X-Gm-Message-State":"AOJu0Yw57BGAq3lpTwzMxtE2VTOikbAoXUUX9X9Jo/xWVWYQbHSzb8Wm\n MAljUwDgEaDRmJ21IDUtFIgdxEzXQLVj4porqcaEsYMVhTNV+Po0+WVR/orUhtbSU1o=","X-Gm-Gg":"AeBDievCBTyyNxASKP7eSTD6Cd3YJe2/Y6r6Jv0M3m/6v8OSUGmkSTV0lXH9I+tao0d\n SFKQQVyNIkp1LJKXV4H0UZiNtCaryhNlcpDiRYaKSgktPFgi0NdQQpq/CVEA9JNZqwnARQFRGU6\n oLdJk3lDsT4LeS6UnVdAjbiMibepdWzpjsoCTl57WDHXsZgSPROzeE9Jl6revBE+ux7fJq3W0O+\n NdyGaKEbx75YL3WJGTuc6gQuKzdh1HN780RaU9BuX7vkyzoMivlrsnxjUThth+/5g+aIi734Hfq\n 285uoC8czf/EvuKGCPqnCpz8yTQoYb1Z40EGTbUTbnVYp9iNCz5ncrKvFgo8gn7q0ASjMHPPLUh\n eygUhVBtEod8uyM+iE6K0SkhGKbdvdBznH/QIqF8RwfyEMwe3HSBYNCTZiN6p4SdfL+0KtrtdkA\n 98T3SWKnjhCDiFmCQeidiHhQLhY/t//1129s5hxFWimFFV+wAJDcSy","X-Received":"by 2002:a05:600c:5290:b0:480:69b6:dfed with SMTP id\n 5b1f17b1804b1-48a988c0fd9mr171700425e9.24.1777894099463;\n Mon, 04 May 2026 04:28:19 -0700 (PDT)","Message-ID":"<69f882d3.050a0220.1640ac.969f@mx.google.com>","To":"\"Cyril Hrubis\" ","In-Reply-To":"","Date":"Mon, 04 May 2026 11:28:18 +0000","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-7.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-7.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] [PATCH v3 1/2] lib: Add SAFE_SPLICE() macro","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Andrea Cervesato via ltp ","Reply-To":"Andrea Cervesato ","Cc":"Linux Test Project ","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}}]