[{"id":3685606,"web_url":"http://patchwork.ozlabs.org/comment/3685606/","msgid":"<20260504092805.4070-1-linuxtestproject.agent@gmail.com>","list_archive_url":null,"date":"2026-05-04T09:28:05","subject":"Re: [LTP] lib: Add SAFE_SPLICE() macro","submitter":{"id":93132,"url":"http://patchwork.ozlabs.org/api/people/93132/","name":null,"email":"linuxtestproject.agent@gmail.com"},"content":"Hi Andrea,\n\n--- [PATCH 1/2] ---\n\nOn Mon, 4 May 2026, Andrea Cervesato wrote:\n> lib: Add SAFE_SPLICE() macro\n>\n> Add new SAFE_SPLIT() in lapi/splice.h.\n\n\"SAFE_SPLIT()\" -> \"SAFE_SPLICE()\".\n\n> -#include \"lapi/splice.h\"\n> ...\n> +\tSAFE_SPLICE(file_fd, &off_in, pipefd[1], NULL, OVERWRITE_SIZE, 0);\n\nAfter this commit, SAFE_SPLICE() is called in af_alg08.c, tee01.c, and\nvmsplice01.c but all three no longer include — the tree\ndoes not compile. The include removal and the SAFE_SPLICE() conversion\nmust not be split across commits.\n\nThis patch also mixes \"add library macro\" with \"convert test files\";\nsplit them: patch 1 touches only lapi/splice.h, patch 2 adds the\ninclude and converts the splice() calls in all three test files.\n\n--- [PATCH 2/2] ---\n\nOn Mon, 4 May 2026, Andrea Cervesato wrote:\n> tee01, vmsplice01, af_alg08: Use SAFE_SPLICE()\n>\n> Replace raw splice() calls with SAFE_SPLICE() in tests where splice is\n> utility plumbing, not the subject of testing.\n\nThis patch only adds three \"#include lapi/splice.h\" lines; the actual\nsplice()-to-SAFE_SPLICE() conversion is in patch 1/2. Subject and body\nmust describe what this patch actually does, or better: restructure\nthe series so the conversion and its include live in the same commit.\n\n---\nNote:\n\nOur agent completed the review of the patch.\n\nThe agent can sometimes produce false positives although often its\nfindings are genuine. If you find issues with the review, please\ncomment this email or ignore the suggestions.\n\nRegards,\nLTP AI Reviewer","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=cfSl6ZXm;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8GXb3Tqpz1y04\n\tfor ; Mon, 04 May 2026 19:28:15 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 4312D3E499A\n\tfor ; Mon, 4 May 2026 11:28:13 +0200 (CEST)","from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::3])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 6FBEA3E1A82\n for ; Mon, 4 May 2026 11:28:10 +0200 (CEST)","from mail-dy1-x1342.google.com (mail-dy1-x1342.google.com\n [IPv6:2607:f8b0:4864:20::1342])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 1D3031A00606\n for ; Mon, 4 May 2026 11:28:09 +0200 (CEST)","by mail-dy1-x1342.google.com with SMTP id\n 5a478bee46e88-2ecf9e398f4so8786647eec.1\n for ; Mon, 04 May 2026 02:28:09 -0700 (PDT)","from\n runnervmeorf1.c5dam0qjnfsefkc3bjzldlum2d.dx.internal.cloudapp.net\n ([52.159.247.179]) by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2f194556795sm5074862eec.2.2026.05.04.02.28.06\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 04 May 2026 02:28:07 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777886887; x=1778491687; darn=lists.linux.it;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=3aJoJjlj0Et1HWr527QkpKBNaAa2uKrGT4FK/KVwo7w=;\n b=cfSl6ZXmVievXYQKlKFrsavlIUwwsLNDIJXKPz9imWU90Llv2vfKjoKNODvcLzm6UW\n LS8b1J4MY36APmiij4nOha/NEWJUSM+t6dwVFDEw6851B5WaQJoOJa+yfZV8qVK8cEHQ\n vpYfzT7FW8gPsc6qljkxgtuociAnjFoErTWY9ytBqn5AXjFCfesTyBIipgmrGjqat6a5\n cdKx6UcMSa8m2rAP/AsqiepWPDoLjsit8YqQZJ7A1PYq80QcBvFVrSurBZk3n3K4R7Z7\n m8tN+JhmB2bAq7hSFYVCFM08+SIk9w1MrS2FVdAFlOLO/tylyMI/4Mq/8tnCtmWIKsc9\n jx7w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777886887; x=1778491687;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=3aJoJjlj0Et1HWr527QkpKBNaAa2uKrGT4FK/KVwo7w=;\n b=BiCUIlDPD7zKhSv/dcNre7QPieiKYHiAFUHMjSnP2mYHEekgdvSReyWDDm9e9OQNzX\n Ly3TlJn4Ai56u0czBQN5inpbq4CIsOt7GS8BqD6LPMjZbzspjLT/088Mwxzqyk2PjS5B\n C9gUzOME4yR7PGScA/72XznsapMLsT880nR6WEaqjUIoYX3epS4sqaU1bFsfzXw6zqHN\n rARAXkSgnyXcqzubDhSF0BUlf4mGVZp6h2BV1RBxylX6aaHqaS+hV/TiwjaDQmBsV6Z3\n 8i1FXTHq7FXT+ytBgLEdoj9T6ipMDosqcFpVAW+qrICGsNQDudMiUYgz/zmGfJZAH1Pq\n rWAA==","X-Gm-Message-State":"AOJu0Yy+5YGAVzpeiWQKiLwCGtcXkG2ejxZ7ZW1UMPKZj+9WrhhLEtwi\n ChP27OLzrhiVJX3DMniztZ43Ycx3urr/93f5S3sSMlKsOjzvEjauz1oM1o76zJDNnbc=","X-Gm-Gg":"AeBDiesjPPyqqUS7FIKgi2YyZyu2Z5OUFxODspDQrn4gDkg/smv/m3unPin40qfHNMI\n 7iFNJ2MKPaFTGFXxa+nVGlnn2qbdIempujk+w9U5Z4cmSG8rRcvfWSXFvEN0/z+mA0fkwBfUwYE\n 9x9Z2zkPxa4HYt3XVjw7SExrW4dzkRDNJ5UYAywF80vn0nw8J+9FpDcggs4TS3KNgRaKtFmbp3R\n FU/czCD3MVvkoUxaQucMsQh8OcMxrqTAG3isMOCVd5kMwOw6gjHCOeB7GrJwi+I9C3ne9/rRe4J\n cFGXrC26qdrjsu57b7GhwBg6UqfMGQzuydhslnVlkNUhoqys+3FO7otNOcpzlJo/EMInFAD8vI0\n ExNT89w3GIPqGiTVcxo4wGEmKdzuxv90BxKS2q4r0DuTx88k8YjECChz4CLSdmJG8Rpux6drdzn\n z48JWhrUBlPL2gIGw8n9g5SSre8nq2z2+gSV9SYtCex+Ml4SwvNG9no7ZAEV7GDRfVKkcnubP9u\n MAKdxOMY319NP/tw/5ZJ1JSf2TvVd1G9G/UKIWb5P0T6DvsSzo=","X-Received":"by 2002:a05:7300:7490:b0:2ea:5057:a304 with SMTP id\n 5a478bee46e88-2efb7ad84f4mr3433318eec.2.1777886887352;\n Mon, 04 May 2026 02:28:07 -0700 (PDT)","From":"linuxtestproject.agent@gmail.com","To":"Andrea Cervesato ","Date":"Mon, 4 May 2026 09:28:05 +0000","Message-ID":"<20260504092805.4070-1-linuxtestproject.agent@gmail.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260504-safe_splice-v2-1-aa7eaa6b5ed7@suse.com>","References":"<20260504-safe_splice-v2-1-aa7eaa6b5ed7@suse.com>","MIME-Version":"1.0","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE,SPF_PASS\n shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-3.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-3.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] lib: Add SAFE_SPLICE() macro","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}}]