[{"id":3685534,"web_url":"http://patchwork.ozlabs.org/comment/3685534/","msgid":"","list_archive_url":null,"date":"2026-05-04T07:34:35","subject":"Re: [PATCH 2/2] arm64: dts: mediatek: mt8188-geralt: enable Wi-Fi\n card","submitter":{"id":81844,"url":"http://patchwork.ozlabs.org/api/people/81844/","name":"Chen-Yu Tsai","email":"wenst@chromium.org"},"content":"Hi,\n\nOn Mon, May 4, 2026 at 3:28 PM Icenowy Zheng wrote:\n>\n> The mainline pcie-mediatek-gen3 driver does not have code managing\n> downstream device power / reset.\n>\n> As the Wi-Fi card on ciri is a fixed device, set the related regulator\n> to always-on and use GPIO hog to set the status of its reset pin.\n\nThe plan now is to model it as an M.2 E-key slot (even though the chip\nis actually soldered on the main board).\n\nI have some of the patches ready, but I'm still working out the USB\nside of it.\n\n\nChenYu\n\n> Signed-off-by: Icenowy Zheng \n> ---\n> arch/arm64/boot/dts/mediatek/mt8188-geralt.dtsi | 11 +++++++++++\n> 1 file changed, 11 insertions(+)\n>\n> diff --git a/arch/arm64/boot/dts/mediatek/mt8188-geralt.dtsi b/arch/arm64/boot/dts/mediatek/mt8188-geralt.dtsi\n> index 8e423504ec052..c25780098103b 100644\n> --- a/arch/arm64/boot/dts/mediatek/mt8188-geralt.dtsi\n> +++ b/arch/arm64/boot/dts/mediatek/mt8188-geralt.dtsi\n> @@ -544,6 +544,11 @@ &mt6359codec {\n> mediatek,mic-type-2 = <2>; /* DMIC */\n> };\n>\n> +&mt6359_vcn18_ldo_reg {\n> + /* Used by WLAN */\n> + regulator-always-on;\n> +};\n> +\n> &mt6359_vcore_buck_reg {\n> regulator-always-on;\n> };\n> @@ -1145,6 +1150,12 @@ pins-en-pp3300-wlan {\n> output-low;\n> };\n> };\n> +\n> + wlan-reset-hog {\n> + gpio-hog;\n> + gpios = <145 GPIO_ACTIVE_HIGH>;\n> + output-high;\n> + };\n> };\n>\n> &pmic {\n> --\n> 2.52.0\n>\n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=gVbAOi/w;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-gpio+bounces-36012-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org\n header.b=\"gVbAOi/w\"","smtp.subspace.kernel.org;\n arc=pass smtp.client-ip=209.85.167.52","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=chromium.org","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=chromium.org"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8D3m4ChQz1y04\n\tfor ; Mon, 04 May 2026 17:36:36 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 00C9C30136AF\n\tfor ; Mon, 4 May 2026 07:34:51 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 8EB562E62A4;\n\tMon, 4 May 2026 07:34:50 +0000 (UTC)","from mail-lf1-f52.google.com (mail-lf1-f52.google.com\n [209.85.167.52])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id CEBF71D63F3\n\tfor ; Mon, 4 May 2026 07:34:48 +0000 (UTC)","by mail-lf1-f52.google.com with SMTP id\n 2adb3069b0e04-59dea72099eso3841666e87.0\n for ;\n Mon, 04 May 2026 00:34:48 -0700 (PDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777880090; cv=pass;\n b=pl9Ubui9y10lyqrS3X7K/Ihv04D7KpuyhNr6YBoTgG732A31CogCFbvNlFDPFL6A27B3WN8+PZK9EphSaIxF+4R4FcBxa89EVdAWQBjggqEg3s819E7gBAG92707COIeN5oNon0vI7TJSKtrRl5AARYeA9ww/PN0RNMKemtuHJo=","i=1; a=rsa-sha256; t=1777880087; cv=none;\n d=google.com; s=arc-20240605;\n b=J29VR0un2zwLqInk2QhWSEGjNqsA3g9h4ozBaB+Efm30njaPH9HI3VYD+kH81Yedbd\n j8CqD79mtmJgeVmv7CuWizJLwYsBLJm4kOOpnZpi4xciEoewSJZuUiNu/8JwPO/pXi61\n 7WNqtm0hpA1cg5DEkUbXeJNZD1AcqFZbN2JzRu80EQLA0iYXwHhUBVV2OFGVZ59W/bAm\n tIvHm8O+lOiN/ZQU3XcwSOmsbNgVJS4V07ylemsSLq1L2T2jb8UfN6jwO0XJ/EhuMOvC\n Og1zqVpNGKR1l0KMP8yz/y300USO7BFkBktSzD1jLMrXUPAxr7cstX8PnhXEWdwtjb1g\n P5Rg=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777880090; c=relaxed/simple;\n\tbh=mImTrtDwrEXC7X93ncElFhdb+XQUNNI1BSOw9cTkKyU=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=W36uAXoSmaYhq31/H9CLxn9Uq/yQG1cHrhcCPfAN9vzmkZMgtTrD7FZU+vQUg6OskCWy1wusVExrbP15k/ZEKFUaytLKxF28f6bPuySeNoBwOrcqnB92DW/sbkwELzXHwQX2V+cagRGe0Pkb3CGKhHDmAGJ2uJMNy5Ib/zFALrU=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=zmqoE5sH6WuPce4B+/6WncWE7pwXnMFKOobdKhulk1E=;\n fh=SbApjUznTQgKLRYVcink9hSfCKYetz9SCgUb+RQHjAE=;\n b=d2HC9tqYdYPL1ay5QwXd4rYNbmoAYW5RYzVuueLzLpNYYdK3I4Tnyh5Ph5l6fHqxQn\n Zrd2CPW2aL57JQJ8k2rmM+dNxnpnrCh7FS5Z493Up8PcQTYETneUJXRiuczD16SFEraA\n oMzNl9vwFkndrS/atXcUBQQItA+yKyp48A1+BrOoh2BsJ0hbBB8BVleKxR/SQSK8923p\n X0ZpdAlXIF45bWT70Oa0ck7NHBlj3lzKVuaINXqZ2emRmkZ8zPYU/1/SImFLOAYkb9NC\n hNMFqy1rDmWzG3gWm4GOZ2hGxukuzSY6cEx236GOnaTjtEQoguBhMuL7FyPBhE3n05Lg\n i5Fw==;\n darn=vger.kernel.org"],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=chromium.org;\n spf=pass smtp.mailfrom=chromium.org;\n dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org\n header.b=gVbAOi/w; arc=pass smtp.client-ip=209.85.167.52","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1777880087; x=1778484887;\n darn=vger.kernel.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=zmqoE5sH6WuPce4B+/6WncWE7pwXnMFKOobdKhulk1E=;\n b=gVbAOi/wwclWQqbPw7DlfjZ+9+9Tsd+A6szBIUo4DdnMXM9Bmu0V049sNNDEmeLhU4\n BrqiEaiihyBmc53ZTEv3IhU4ZoP3GOEUapLUYY6mkBqTLjohaIhLIFgZuA6LxV9HgevN\n zl4k0Kj9D2qHcJVMmHL2TkRf0O3rQBur/yrQ0=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777880087; x=1778484887;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=zmqoE5sH6WuPce4B+/6WncWE7pwXnMFKOobdKhulk1E=;\n b=M4BHmQN5oN6L1MIzIPwnK9UEMRaumEDR8/0h7bnRcV+2R3lpKwn0VT9XsSdPjwXQvL\n 7tZ4X8KLSXcDVygaKepuujUkKoxJWDRwVhQqwS7S3veWtPt2TB6YmEMiS0rvMpR5o018\n iMyjM9wSVYcILfGZibXiRnUCXAmH121DoZjiru8XDvE/tXtJk021wZO2pU9P4IAJG9hf\n hIDMJ47SHzednWbCEQg5cFB1iuw5VCMi3JuOcKV0O87LC58rQwTHbvy4ajg+Jd74EH7a\n Z84XK5/GQv5EZzI5L7d8PmGfoLHYQNGqRzukORettHif0E3DUoFV2yBDQagw7XKKBqsA\n KoAw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8e8a+sJrQqMWMggh8XOpXEqd5YM/yoTj7Mfrwf+UUAhq7knVNpvPjvv1uQrbdVwaWKpIfnopkHMT1S@vger.kernel.org","X-Gm-Message-State":"AOJu0YzBPeqb8nyT2biu85nSGSAx6Lwnp2cMK801M61IyccXff7HuA22\n\toj91SEMX3zIj92p0JqFOtP1dx+Nsn1/muAy/e6JPwc/+CSs4BJ44JHSNBkPPV+O4FvcH7Ox1VfQ\n\tb/ZJX7kSAc8Zrur3iQr+tYieoJKgp5JhU9gnAOCbH","X-Gm-Gg":"AeBDieuqDa5Bbp4gjxMR9ZgxE2PEcNcMZSav7+H1bJMVsgAgpfVib1ZVIkbQfx7/2Te\n\tQ9DssIF6+led27HYzaXLpICQ5twCdO+CZkuxQOcEI3cZRbBQK8zOzRmYKEkI0pTvHfqAj+LDc5m\n\tXzWwcIlDypmsvOz2SrjOyWAmCM5o7I7J2WX9ObrwmwVMVCniHetfjZ7nSoQruVggJK6K6tujVUw\n\tnzhy9jduHFj4Kqy6GfuhOnzvckOtzzKO3+XjvC2DVNXykL28T2ECqLQtk1Ej5DejA2ylJTPBfuB\n\tNElXZ5i4mQ5XXfqaF1OPm7B4Z3PnJ3VV/7HWDibqZFoWYsHc","X-Received":"by 2002:a05:6512:3b84:b0:5a2:a3dc:51e3 with SMTP id\n 2adb3069b0e04-5a862ec11b8mr2434888e87.12.1777880087115; Mon, 04 May 2026\n 00:34:47 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260504072748.2580172-1-zhengxingda@iscas.ac.cn>\n <20260504072748.2580172-2-zhengxingda@iscas.ac.cn>","In-Reply-To":"<20260504072748.2580172-2-zhengxingda@iscas.ac.cn>","From":"Chen-Yu Tsai ","Date":"Mon, 4 May 2026 15:34:35 +0800","X-Gm-Features":"AVHnY4IuKDBbAkS85uOVR5vEB6IDbpI4Sjzup8SfiFFfaDlz9Xmq5t63cjYsvnU","Message-ID":"\n ","Subject":"Re: [PATCH 2/2] arm64: dts: mediatek: mt8188-geralt: enable Wi-Fi\n card","To":"Icenowy Zheng ","Cc":"Linus Walleij , Rob Herring ,\n\tKrzysztof Kozlowski , Conor Dooley ,\n\tMatthias Brugger ,\n\tAngeloGioacchino Del Regno ,\n Hui Liu ,\n\tlinux-gpio@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tlinux-mediatek@lists.infradead.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}}]