[{"id":3685651,"web_url":"http://patchwork.ozlabs.org/comment/3685651/","msgid":"<5346becd-5178-4a63-a049-b4fab4f5eba4@linaro.org>","list_archive_url":null,"date":"2026-05-04T11:19:17","subject":"Re: [PATCH v6 09/11] hw/arm/aspeed_ast27x0: Set EHCI\n ctrldssegment-default","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 4/5/26 04:53, Jamin Lin wrote:\n> On AST2700 platforms, system DRAM is mapped above 4GB with a base\n> address at 0x400000000.\n> \n> The Linux EHCI driver programs the segment register to zero when\n> 64-bit addressing is supported. As a result, descriptor addresses\n> derived from the EHCI registers do not include the DRAM base\n> address.\n> \n> Descriptor memory is allocated through the DMA API with a 64-bit\n> DMA mask, allowing descriptors to reside in DRAM above 4GB. On\n> AST2700, EHCI queue heads (QH) and queue element transfer\n> descriptors (qTD) are therefore placed at addresses starting from\n> 0x400000000.\n> \n> Set the ctrldssegment-default property to \"sc->memmap[ASPEED_DEV_SDRAM] >> 32\"\n> so the upper 32 bits of descriptor addresses are adjusted accordingly. This\n> allows the emulated EHCI controller to construct correct system\n> addresses when accessing descriptors in DRAM above 4GB.\n> \n> Signed-off-by: Jamin Lin \n> Reviewed-by: Cédric Le Goater \n> ---\n> hw/arm/aspeed_ast27x0.c | 3 +++\n> 1 file changed, 3 insertions(+)\n\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=t6N7qwfr;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8K1N6pVZz1yJV\n\tfor ; Mon, 04 May 2026 21:19:51 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wJrKd-0003r3-RT; Mon, 04 May 2026 07:19:23 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wJrKc-0003qY-M2\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:19:22 -0400","from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wJrKb-0004GB-4u\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:19:22 -0400","by mail-wr1-x42e.google.com with SMTP id\n ffacd0b85a97d-441209fb77eso2250836f8f.1\n for ; Mon, 04 May 2026 04:19:20 -0700 (PDT)","from [192.168.69.210] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-44a8ea7cfd2sm23691611f8f.2.2026.05.04.04.19.18\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Mon, 04 May 2026 04:19:18 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777893559; x=1778498359; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=UDMHwGyW7502QhopCExMsRazAqKSVL5/HQleasGK5Ms=;\n b=t6N7qwfrLaoaQGAJpwCkGHbCMMdRM3XMH8zow8HaiR71VN09//KQHJbCemKsV1POfo\n wXDjYcqkcZAYwgFWxJOLNMU/a6SgQQNBU4nA5kg9+hAAIP56yMPfMqJNPDMLsUekaxR+\n 5ndCKmM0F2zU1COJxGHEU6d6i6wiXNtvBOQanuqudZgydXELI3GWrSp8C+tCRZ2675F5\n OWE1ajl7lL4jzmkaTqayC7PtLq8CEr+oAqDyfNCtfQ4R0G7lniDsyNxO7uapqSKMtPiH\n M/5T0bAGzerjNMmhuLtgMKFjUrcqv4Qco8Yx98bx9eHJroK3cyWCsujkfADsx5gBQLHI\n S0vQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777893559; x=1778498359;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=UDMHwGyW7502QhopCExMsRazAqKSVL5/HQleasGK5Ms=;\n b=maz1Jeo8UjRz2AZG+HDQkT8ILoLCSANtDYI2ayk9rvRSFQIjvROu13IrTSMpqgW6Yk\n eiuLJMn2PfM7Vb9KJgo1dywiBboiHS+dBUs31onx+g6Smi23gnEr/lLIE6MqNG4jSuhx\n KX/wn/7R/c9nFrpuv2C4lb56AyvkqnPFBNtv6CN82BrJXERWG2GFPF5FawdAlsqwPePV\n 7HftyzsdKu+Hw4HRY943ToSEozk/WEtGtnL6fAO0dzH00VblSaa8raN+o7IbmIykLGEq\n 6nvGpSh8Xpv04tvanaenURxM9aT2XB1Ttopl5fUqKN6N/jvjWg/gfwqpWv30CUbMp0T/\n LQ0w==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9NHOWeJgouX+t4y/pfS6/hzXRsmth0wdI3DSYrliqkVhpsGQ0zNq3drJxZMXKphecKKmqm5r0xqNFj@nongnu.org","X-Gm-Message-State":"AOJu0Yw9hE5LXAl2kMr+Uy4WRdv+9FTblO/4kHxrkNfpzvdBRFoKG9kg\n m9/OTYQRn4VsGsjYnQyqOnTmUQz4j3R9q81hhSU/vINN7My3JtELKMVpAL45eJEcKvU=","X-Gm-Gg":"AeBDietAKhFd8ZSLoY3/PyNQNAkFr8szl5aPUx/vym9ChOIoSuZ/nvPXjJL70HwfsEg\n 8rLln8b+qBWj04AadMEuINYmycP4p34RK+BVmRz87P7fvA8aIy42h+NLUgXn/dSwdHq8dNHWBW4\n jGiLZpKqNVkCeZgn0jh1ylugna1vhKP8DIgTWZu0VlV++L7AW2nDRcFOBpVgud7vD/LpHcpuROS\n msVYe4AN6oCi+uvjY0rTIVGQZOJYqzBSq8iLEHzhdFLTnzBZSL3hSQNhjs8Jc5w7FQI8v6nKZ0R\n wrSv/jgz0C7aqeyGGu/Xf3wTr/AoMkffWLcP+x8HOqBRlz36fY1BSW+jYpZHEOBeULHZSmu7mPF\n 7vAMG/ZxDce2gwTG4nvc0pCpy4MvgmV/g5/sCEFDECqXfqx48Jh64G4lMa2+P33o05wPte0I4dj\n DnSraLWB6ndKWbOcb5fzl18m7vc9z4KOtnvY11bWORFwjRLUPnF2/LQnM2dln/CVZuiQxvG843g\n egpMz/EiW7fKY8=","X-Received":"by 2002:a05:6000:2103:b0:43e:ab40:28d with SMTP id\n ffacd0b85a97d-4494dc52adbmr17441943f8f.2.1777893559517;\n Mon, 04 May 2026 04:19:19 -0700 (PDT)","Message-ID":"<5346becd-5178-4a63-a049-b4fab4f5eba4@linaro.org>","Date":"Mon, 4 May 2026 13:19:17 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v6 09/11] hw/arm/aspeed_ast27x0: Set EHCI\n ctrldssegment-default","Content-Language":"en-US","To":"Jamin Lin ,\n \"peterx@redhat.com\" ,\n =?utf-8?q?C=C3=A9dric_Le_Goater?= ,\n Peter Maydell ,\n Steven Lee , Troy Lee ,\n Kane Chen ,\n Andrew Jeffery , Joel Stanley ,\n Zhao Liu ,\n \"open list:ASPEED BMCs\" ,\n \"open list:All patches CC here\" ","Cc":"Troy Lee , \"farosas@suse.de\" ,\n \"flwu@google.com\" ,\n \"nabihestefan@google.com\" , =?utf-8?q?C=C3=A9dric_?=\n\t=?utf-8?q?Le_Goater?= ","References":"<20260504025342.1452605-1-jamin_lin@aspeedtech.com>\n <20260504025342.1452605-10-jamin_lin@aspeedtech.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260504025342.1452605-10-jamin_lin@aspeedtech.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::42e;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x42e.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]