[{"id":3685426,"web_url":"http://patchwork.ozlabs.org/comment/3685426/","msgid":"","list_archive_url":null,"date":"2026-05-03T18:36:50","subject":"Re: [PATCH v2 2/2] drm/tegra: gr2d/gr3d: Contain PM in the\n gr*d_probe/gr*d_remove","submitter":{"id":84146,"url":"http://patchwork.ozlabs.org/api/people/84146/","name":"Svyatoslav Ryhel","email":"clamor95@gmail.com"},"content":"нд, 3 трав. 2026 р. о 19:38 Svyatoslav Ryhel пише:\n>\n> From: Ion Agorria \n>\n> The current power management configuration causes GR2G/GR3D to malfunction\n> after resume. Reconfigure all PM actions to be handled within the GR*D\n> probe and remove operations to address this.\n>\n> Fixes: 62fa0a985e2c (\"drm/tegra: Enable runtime PM during probe\")\n> Acked-by: Mikko Perttunen \n> Signed-off-by: Ion Agorria \n> Signed-off-by: Svyatoslav Ryhel \n> ---\n> drivers/gpu/drm/tegra/gr2d.c | 11 ++++-------\n> drivers/gpu/drm/tegra/gr3d.c | 11 ++++-------\n> 2 files changed, 8 insertions(+), 14 deletions(-)\n>\n> diff --git a/drivers/gpu/drm/tegra/gr2d.c b/drivers/gpu/drm/tegra/gr2d.c\n> index e4148b034af7..ffcd076b5831 100644\n> --- a/drivers/gpu/drm/tegra/gr2d.c\n> +++ b/drivers/gpu/drm/tegra/gr2d.c\n> @@ -100,9 +100,6 @@ static int gr2d_exit(struct host1x_client *client)\n> if (err < 0)\n> return err;\n>\n> - pm_runtime_dont_use_autosuspend(client->dev);\n> - pm_runtime_force_suspend(client->dev);\n> -\n> host1x_client_iommu_detach(client);\n> host1x_syncpt_put(client->syncpts[0]);\n> host1x_channel_put(gr2d->channel);\n> @@ -286,6 +283,10 @@ static int gr2d_probe(struct platform_device *pdev)\n> return err;\n> }\n>\n> + pm_runtime_enable(dev);\n> + pm_runtime_use_autosuspend(dev);\n> + pm_runtime_set_autosuspend_delay(dev, 500);\n> +\n\nHello Mikko!\n\nI have used same setup as in VIC. May you please take a look to sashiko's check\nhttps://sashiko.dev/#/patchset/20260502124055.22475-1-clamor95%40gmail.com\n\nI do agree with statement that pm_runtime_enable should be before\nhost1x_client_register since this same approach is widely used in the\nmedia subsystem too.\n\nBut I am more interested in your thoughts regarding sashiko's\ngr2d_exit situation reasoning.\n\nThank you!\n\n> return 0;\n> }\n>\n> @@ -367,10 +368,6 @@ static int __maybe_unused gr2d_runtime_resume(struct device *dev)\n> goto disable_clk;\n> }\n>\n> - pm_runtime_enable(dev);\n> - pm_runtime_use_autosuspend(dev);\n> - pm_runtime_set_autosuspend_delay(dev, 500);\n> -\n> return 0;\n>\n> disable_clk:\n> diff --git a/drivers/gpu/drm/tegra/gr3d.c b/drivers/gpu/drm/tegra/gr3d.c\n> index 47b0c6c56bfd..cd5554e2117f 100644\n> --- a/drivers/gpu/drm/tegra/gr3d.c\n> +++ b/drivers/gpu/drm/tegra/gr3d.c\n> @@ -109,9 +109,6 @@ static int gr3d_exit(struct host1x_client *client)\n> if (err < 0)\n> return err;\n>\n> - pm_runtime_dont_use_autosuspend(client->dev);\n> - pm_runtime_force_suspend(client->dev);\n> -\n> host1x_client_iommu_detach(client);\n> host1x_syncpt_put(client->syncpts[0]);\n> host1x_channel_put(gr3d->channel);\n> @@ -517,6 +514,10 @@ static int gr3d_probe(struct platform_device *pdev)\n> return err;\n> }\n>\n> + pm_runtime_enable(&pdev->dev);\n> + pm_runtime_use_autosuspend(&pdev->dev);\n> + pm_runtime_set_autosuspend_delay(&pdev->dev, 500);\n> +\n> return 0;\n> }\n>\n> @@ -578,10 +579,6 @@ static int __maybe_unused gr3d_runtime_resume(struct device *dev)\n> goto disable_clk;\n> }\n>\n> - pm_runtime_enable(dev);\n> - pm_runtime_use_autosuspend(dev);\n> - pm_runtime_set_autosuspend_delay(dev, 500);\n> -\n> return 0;\n>\n> disable_clk:\n> --\n> 2.51.0\n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=HXsBrjzX;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-tegra+bounces-14149-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"HXsBrjzX\"","smtp.subspace.kernel.org;\n arc=pass smtp.client-ip=74.125.82.176","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g7tmN6jJgz1yJV\n\tfor ; Mon, 04 May 2026 04:37:08 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 67349300342B\n\tfor ; Sun, 3 May 2026 18:37:06 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 9F11F36D9F6;\n\tSun, 3 May 2026 18:37:04 +0000 (UTC)","from mail-dy1-f176.google.com (mail-dy1-f176.google.com\n [74.125.82.176])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 22AE13358C6\n\tfor ; Sun, 3 May 2026 18:37:03 +0000 (UTC)","by mail-dy1-f176.google.com with SMTP id\n 5a478bee46e88-2f00a567cfaso488203eec.0\n for ;\n Sun, 03 May 2026 11:37:03 -0700 (PDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777833424; cv=pass;\n b=uGYfzkDsAtA+YnDs4Br67gMRMYDJGLTtgoqE2+OD6RIdMaWqVgpdrm251S+GMsFb6H4UU95vDeQ0XDlpMJTjFN2/O0cj80NTnjC6eo4ckpmyWf2aH9N83FfEfCSeFiBqpCnC1Rq68KKkpNY/acSVC0C5f+O6/A8FdP346jIYKhM=","i=1; a=rsa-sha256; t=1777833422; cv=none;\n d=google.com; s=arc-20240605;\n b=C/b4ZtzJWbWn+ZS1PynQTUdmPNgUWg0sfkGdZf1xXuglyUo7lNoJmsezlCqOFfGv+Z\n 9EYU4JwaTN3Suy+rr6ZAZmdUeSxJdrWXl1RfBe12PPlGXqo6riRWNl6//DL5PFz7I3DX\n oZfSNXQCKnHnz12ilxUwa9F1rvGXOgMB56gg+2HnhLrUxE04rJDdtzZA1Xh6eYfXdeDq\n 4P8Gzwt/CDJuunoVC9hNrvi/RlJc3nUTxooqbF4lLCmZYtoU3k7L2VRmuD3l07UNPkUt\n YOJcYSx2oBwJ9rvsh2AMw1SXDy70Bju9ixNa025+iZc+0iazFK3L+7OjLMFoT8UuOqUB\n akzg=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777833424; c=relaxed/simple;\n\tbh=kf1aH6Oxw1VzpdkMu8DDLYL2Zj6chjXwll1Pl2BIftw=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=cZ7oajc/kSMSi3SRv6xFNhuJFVUjfea67VxNEydK4zW7zHDgFm8ceZEkpLrZJQPXRBgx6MFJa82M6Pip7FIDFQ7ocOgIygqeWGJn04kOEXKesLEU8g3LoTjhOMEXV2q0MQxgsbAnxKlkAQXV77620uNM5Y6Hz3A+/sjx6EypqeM=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=Z8DagsZ0dzvLRGip3yJmsVrNVksXrv0ekQfgv6AKROE=;\n fh=2RaNxfCG/MjdEv5vNcY1Z5fN8OTFzujJcZOFd1WgaqM=;\n b=ka1qwVWST1gjbsNTACULprp8J5U1+sF/Yk1AgVnp83+m8RToefXy9IXB82hYvUE3T6\n 5O0xJrNj0L5Co6g2y89KvKFLgtRXwSdV9/7axcDxKTssIf+dTLhDiSy/KdU5GlOiLf9M\n mol92Jv8/eOc/py0Rr+AP5J5F+8Cs2T2n6sdJIB9Xd1C7rs5fzRiWPgPc8wgVVh65SDx\n TkLkEwhNv4l9pqJQ69lK2IgVEfZ8DSyVaCB9xK2Dez5a3jo6eYj/eU8cDEbhGlwuPJVt\n oPgQPVB9P/F6HoNgPb5wpTDW3OC6wRZp7W9RrsclidqDSzyNjSZspig1VgZ5wJeMo/zd\n RwfQ==;\n darn=vger.kernel.org"],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=HXsBrjzX; arc=pass smtp.client-ip=74.125.82.176","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777833422; x=1778438222;\n darn=vger.kernel.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Z8DagsZ0dzvLRGip3yJmsVrNVksXrv0ekQfgv6AKROE=;\n b=HXsBrjzXGEXLpp3hlQyF7PrKdfWcb4oXvCXl8KVsm9TPo9rrbg67a5hKwQOGbe4vP0\n L3qbccNxsgtuGDHciznC5Tn+Wp5/hN2rAzJpq2ByGEAmmzmU8siSThSp9E0GbprKzzDt\n 6SOcs2pXVomgvrijkNv61+u+v0uJE/16nXhBnJVo4Fao1JnXq3AipfEu44c1/+z3o9EX\n Tt8WqwEF1U3t3A885dmHF/7ek2mJYlFXY7XQoEtAIvS7hLcAINnPDfiu1Pss7e260Udc\n 9XFiGBtJfrJFrq/Eogsxy0t0aSqEDbTgjBmuz9Zr6y9i3CwNOnMKPHhD2cFPA11C6QkH\n sUbA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777833422; x=1778438222;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=Z8DagsZ0dzvLRGip3yJmsVrNVksXrv0ekQfgv6AKROE=;\n b=pp5rS42PVLN1dnS298Lavw9VdvUGM9WT4M95vE1eGaG8uyZ9BtSncPOlfxGIQDa95A\n gEJIsDYNRy0OCIJ6m3nNSUZgv6XZIpEuKZiaqfIyvll361rQzzrC7sMoQ97bC+Ody8bP\n klyYuLx+660W/xgwg/pct3Sr6LqGvzrRk0SYpARzcV2tWCuqIpPQFII85Eh1Ufe1npwm\n Gz9R934zm9rnILdl+/V1SVmdauaItMjvE4sPcc8Aas+px/QbWFCqUNPjA/QqHP7cqp0o\n XBu6nxtEbQ4Obvs8+IS/O9REMxs24oQ2a52ixe6fPTX3NJvEbU8eZLZgUoGp8BVUrujX\n bLsA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+42BnJwL5+zlZkSFB0362nScFZ0sq7NGl8hQAtYkFfkjlDhGRwFvsm2H6GVAqwoqKmL+BRntmvV/CKPQ==@vger.kernel.org","X-Gm-Message-State":"AOJu0YzdTvSigHn0pRK1NnQonKGDrIp2xQW73pmenOayRm4KsNy78vcc\n\tAw4kGWLcsvOdOVwczOSsPhVV1aOB6lU5WTSiTaEFsDRljMh4bG4pTUCXHjozE4obdthWuiYkM+Y\n\taG12vJodKEQ2tc9XoJGU3hIg2wBe25QA=","X-Gm-Gg":"AeBDietGRNPHIfW3SiebKSDdgerSi6LOzlzzaJHcynNjkCJBL7H7XZdyaNr3B8NWEtL\n\tNph1oyyC9k3KdmYj+4PWS05MD3Ij/zgHbC2BbAB2bBfdYdJN7Dyj1y6PhFrV/UBksa20nFwj+i1\n\tR2pewCCCfbD9lDFgG23Bb0jObZOSO6JOSuVlasFkU7+lL6wFp2GGxy786vP23a2gi+Gbniw/C4C\n\tgHPsuaPIU0BGQ+cwWuiycxFru643U3JPp/QbYv4FIiSRERznrSgE+gfNmiywTEvf+PzDmPyzdR7\n\t0yXn5uYN6+08EcimYzE=","X-Received":"by 2002:a05:7301:2f8f:b0:2c9:ee15:a0ee with SMTP id\n 5a478bee46e88-2efb1ea49b4mr2558521eec.12.1777833422205; Sun, 03 May 2026\n 11:37:02 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260503163842.213489-1-clamor95@gmail.com>\n <20260503163842.213489-3-clamor95@gmail.com>","In-Reply-To":"<20260503163842.213489-3-clamor95@gmail.com>","From":"Svyatoslav Ryhel ","Date":"Sun, 3 May 2026 21:36:50 +0300","X-Gm-Features":"AVHnY4IxuDT5wqlWTthor6a-YxW_u6JTlPuE1JJHX5m6jXfJ3pVQZVYx5UnP4ak","Message-ID":"\n ","Subject":"Re: [PATCH v2 2/2] drm/tegra: gr2d/gr3d: Contain PM in the\n gr*d_probe/gr*d_remove","To":"Mikko Perttunen ,\n Svyatoslav Ryhel ","Cc":"David Airlie , Simona Vetter ,\n\tJonathan Hunter , Ion Agorria ,\n\tThierry Reding , dri-devel@lists.freedesktop.org,\n\tlinux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}}]