[{"id":3685514,"web_url":"http://patchwork.ozlabs.org/comment/3685514/","msgid":"<e36f1d1b-89db-443b-aa48-6247831a8247@linaro.org>","list_archive_url":null,"date":"2026-05-04T06:49:08","subject":"Re: [PATCH] hvf: arm: override HV_SYS_REG_MDCR_EL2","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 2/5/26 01:13, Mohamed Mediouni wrote:\n> In older SDKs, MDCR_EL2 was defined incorrectly.\n> \n> As such, override it with a #define if compiling with an older macOS\n> SDK.\n> \n> This is a workaround because the macOS CI setup we currently rely on\n> has not been kept up to date, to be able to land nested virtualization\n> support.\n> \n> Once CI is updated, the SME stubs can be removed and this\n> commit can be reverted.\n> \n> Signed-off-by: Mohamed Mediouni <mohamed@unpredictable.fr>\n> ---\n>   target/arm/hvf/hvf.c | 9 +++++++++\n>   1 file changed, 9 insertions(+)\n> \n> diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c\n> index 4f0f7ffba1..79209bc8e9 100644\n> --- a/target/arm/hvf/hvf.c\n> +++ b/target/arm/hvf/hvf.c\n> @@ -468,6 +468,15 @@ static const struct hvf_reg_match hvf_sme2_preg_match[] = {\n>   #define HVF_TO_KVMID(HVF)  \\\n>       (CP_REG_ARM64 | CP_REG_SIZE_U64 | CP_REG_ARM64_SYSREG | (HVF))\n>   \n> +/*\n> + * In older SDKs, MDCR_EL2 was defined incorrectly.\n> + * As such, override it with a #define if compiling with an older macOS SDK.\n> + * https://lore.kernel.org/qemu-devel/BCCED674-EAEF-4755-9BE1-116FB36FB5C9@apple.com/\n> + */\n> +#if !defined(MAC_OS_VERSION_26_0)\n\nNot sure about this check, i.e. wouldn't it clash with 26.1 release?\nI'd expect a check such:\n\n    #if MAC_OS_X_VERSION_MAX_ALLOWED < 260000\n\n> +#define HV_SYS_REG_MDCR_EL2 0xe089\n> +#endif\n> +\n>   /*\n>    * Verify this at compile-time.\n>    *","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=P8Tq5pvq;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8C211wqTz1yJ9\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 04 May 2026 16:49:59 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wJn7I-0002sM-EE; Mon, 04 May 2026 02:49:20 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wJn7B-0002qf-It\n for qemu-devel@nongnu.org; Mon, 04 May 2026 02:49:13 -0400","from mail-wm1-x329.google.com ([2a00:1450:4864:20::329])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wJn79-00009E-Rf\n for qemu-devel@nongnu.org; Mon, 04 May 2026 02:49:13 -0400","by mail-wm1-x329.google.com with SMTP id\n 5b1f17b1804b1-4838c15e3cbso28273335e9.3\n for <qemu-devel@nongnu.org>; Sun, 03 May 2026 23:49:11 -0700 (PDT)","from [192.168.69.210] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a9919fc3asm83929775e9.0.2026.05.03.23.49.08\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Sun, 03 May 2026 23:49:09 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777877350; x=1778482150; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=1k45xLpLHb0qdPbiKWgQOPZfUPhlvLzAYHcCXM1ad1g=;\n b=P8Tq5pvqewwxxDY5EO8HRD7m8i5XZkF+Xtg1w3Md9j5+TaY9Y3U4yFWNelGY99jtrE\n bFiuan21mnuWyjE0REKQ45ZXrRzCBsA77+AJp5N3Z62/OWEJPzJXLt7J7s1k3bX2wWj0\n XMH2+ywDFCBDz9JhVK8TpADdG3+ebJ9hR/coQtKAUyRD1AK3P5bmVl6Qe5HjgHSuM+MC\n x/GOer0ZmYGCokn9wqVA6NgJO1apQapiO+hQt5DcJc4FK4Ixcb2+y4FHa6d6FhRMt70V\n tHgCS8sHb/8b7KW9fnPOTvvvlS5v9LFsK6ekeDgR+g8Hqz7Hal0QABQMtJKtzr1bLw7w\n 9xBQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777877350; x=1778482150;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=1k45xLpLHb0qdPbiKWgQOPZfUPhlvLzAYHcCXM1ad1g=;\n b=CXa3TjKqCDBee1sCrxgvMRGNYXgxg6TDmNAFgdNnqkuXdC+oxL/JXG4IkdLZa9cQa8\n aK7HIPp/6HTa8A616gq/v8G5DaeAF1xXrx/X8qQvhfthAvQt22N0jiuYoWJ2dgyEdWt7\n x4aHbVJKmD8TEHaL7kmj3m/HlQ56hz8N2aPTqlY1l+1LVnGQthQX+nSe8FxC5xvLfZa5\n tx4Y1u7riF9xsnTAg6ntM/tY1Xpk9IapiC0qrH93PesNsfPLC6e7YfyiYwopW7+A4k0f\n 4lRSuHuEZnBsAI/SF6eATKp2YjP+BB+D8SwIlGEK2i/+mczk7WO77Idxi+nOGtSf6da1\n hWhA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9SQVcngOx7FhseZhY881SzZczy7PvzONfp55pPLe7ggpuVrgGnFA5ZkH6mVlytbMU0Hoy47EFLKh4Z@nongnu.org","X-Gm-Message-State":"AOJu0YzXG4IhowvIkRIz2JtVk56TL9c2U0Rl9QLvfm9yKjsQVsh0xr9n\n /yHwKxV/rQIDTC3NuNEf4qCQfC0bIyhHuz1N6GgHecR0UM381b3n+HuCRirUv2qNq34=","X-Gm-Gg":"AeBDiesMH+I2n/z/wdvGDek6piiWaiKNFHNJxPsgiw8U71iCa1GrKoxDFzjRDBJDZAt\n zc3psjlZxwIWyIKtJcjzQXxgCN6zVJnL3Hp/ja9VBplBCzqNFAXKxffplCo3j2r01am65/G1HTf\n n37fgpBDy67/5fIKvbsuze+qhfiK9zWx5k7pCUB9NXODz8muSCNh+RjjhphM+ojwK6LX7r5atr+\n Pm4TYnO3h4dFuP5Y1+CaNxSa2TUNaHuSwtCCzDNkvpnFNXdq4GR3OHz4SlPfiJIv15Upm0ZoiF4\n g7u/HCuAzBnZvlzswwCF2PZx5yCcyrku7k2DSa1zOqTkOWnFI18bUr/DOx3y7tG4Vfn7Dp6TdvX\n ylBxjIsE5x2XVTmH/Ay/rWMIKQwnWbknurTh85WSpVw2gBs5a08FAqKAPWPtR/V/C34n4qzhsQw\n 2A4oi7mUCQFodGICXkQYsRPuBsxlCr8vuFiGCFc3HVH1BKiA+SGRG80Yi26M/xMUqRE9womKnAP\n At4","X-Received":"by 2002:a05:600c:3e05:b0:489:1ff1:74df with SMTP id\n 5b1f17b1804b1-48a9852fbcfmr139519015e9.1.1777877349778;\n Sun, 03 May 2026 23:49:09 -0700 (PDT)","Message-ID":"<e36f1d1b-89db-443b-aa48-6247831a8247@linaro.org>","Date":"Mon, 4 May 2026 08:49:08 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] hvf: arm: override HV_SYS_REG_MDCR_EL2","Content-Language":"en-US","To":"Mohamed Mediouni <mohamed@unpredictable.fr>, qemu-devel@nongnu.org","Cc":"Alexander Graf <agraf@csgraf.de>, qemu-arm@nongnu.org,\n Peter Maydell <peter.maydell@linaro.org>,\n Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>,\n Manos Pitsidianakis <manos.pitsidianakis@linaro.org>","References":"<20260501231353.63184-1-mohamed@unpredictable.fr>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>","In-Reply-To":"<20260501231353.63184-1-mohamed@unpredictable.fr>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::329;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3685517,"web_url":"http://patchwork.ozlabs.org/comment/3685517/","msgid":"<D84A47B8-1555-4ED6-9BC5-C4C433D5D7AD@unpredictable.fr>","list_archive_url":null,"date":"2026-05-04T06:59:15","subject":"Re: [PATCH] hvf: arm: override HV_SYS_REG_MDCR_EL2","submitter":{"id":91318,"url":"http://patchwork.ozlabs.org/api/people/91318/","name":"Mohamed Mediouni","email":"mohamed@unpredictable.fr"},"content":"> On 4. May 2026, at 08:49, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:\n> \n> On 2/5/26 01:13, Mohamed Mediouni wrote:\n>> In older SDKs, MDCR_EL2 was defined incorrectly.\n>> As such, override it with a #define if compiling with an older macOS\n>> SDK.\n>> This is a workaround because the macOS CI setup we currently rely on\n>> has not been kept up to date, to be able to land nested virtualization\n>> support.\n>> Once CI is updated, the SME stubs can be removed and this\n>> commit can be reverted.\n>> Signed-off-by: Mohamed Mediouni <mohamed@unpredictable.fr>\n>> ---\n>>  target/arm/hvf/hvf.c | 9 +++++++++\n>>  1 file changed, 9 insertions(+)\n>> diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c\n>> index 4f0f7ffba1..79209bc8e9 100644\n>> --- a/target/arm/hvf/hvf.c\n>> +++ b/target/arm/hvf/hvf.c\n>> @@ -468,6 +468,15 @@ static const struct hvf_reg_match hvf_sme2_preg_match[] = {\n>>  #define HVF_TO_KVMID(HVF)  \\\n>>      (CP_REG_ARM64 | CP_REG_SIZE_U64 | CP_REG_ARM64_SYSREG | (HVF))\n>>  +/*\n>> + * In older SDKs, MDCR_EL2 was defined incorrectly.\n>> + * As such, override it with a #define if compiling with an older macOS SDK.\n>> + * https://lore.kernel.org/qemu-devel/BCCED674-EAEF-4755-9BE1-116FB36FB5C9@apple.com/\n>> + */\n>> +#if !defined(MAC_OS_VERSION_26_0)\n> \n> Not sure about this check, i.e. wouldn't it clash with 26.1 release?\n> I'd expect a check such:\n> \n>   #if MAC_OS_X_VERSION_MAX_ALLOWED < 260000\n\nHi,\n\nMAC_OS_VERSION_26_0 will be defined in all future SDKs.\n\nSee AvailabilityVersions.h in the macOS SDK, has all of them since 10.0\n> \n>> +#define HV_SYS_REG_MDCR_EL2 0xe089\n>> +#endif\n>> +\n>>  /*\n>>   * Verify this at compile-time.\n>>   *\n> \n>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=unpredictable.fr header.i=@unpredictable.fr\n header.a=rsa-sha256 header.s=sig1 header.b=dNbwqt5y;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8CFF4gRRz1yJV\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 04 May 2026 16:59:45 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wJnHF-0005hq-OY; Mon, 04 May 2026 02:59:37 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mohamed@unpredictable.fr>)\n id 1wJnHD-0005h5-Gm\n for qemu-devel@nongnu.org; Mon, 04 May 2026 02:59:35 -0400","from p-east2-cluster5-host12-snip4-2.eps.apple.com ([57.103.79.75]\n helo=outbound.st.icloud.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mohamed@unpredictable.fr>)\n id 1wJnHB-00053Y-Md\n for qemu-devel@nongnu.org; Mon, 04 May 2026 02:59:35 -0400","from outbound.st.icloud.com (unknown [127.0.0.2])\n by p00-icloudmta-asmtp-us-east-1a-100-percent-4 (Postfix) with ESMTPS id\n 3635D180012D; Mon, 04 May 2026 06:59:29 +0000 (UTC)","from smtpclient.apple (unknown [17.42.251.67])\n by p00-icloudmta-asmtp-us-east-1a-100-percent-4 (Postfix) with ESMTPSA id\n C56BD1800096; Mon, 04 May 2026 06:59:27 +0000 (UTC)"],"X-ICL-Out-Info":"\n HUtFAUMHWwJACUgBTUQeDx5WFlZNRAJCTQFIHV8DWRxBAUkdXw9LVxQEFVwFVgZXFHkNXR1FDlYZWgxSD1sOHBZLWFUJCgZdGFgVVgl3HlwASx1XBFQfUxJVHR0LRUtAEwRPEwVSB11NVg1HD1geXBQXC0dDXgheH0wcHQ5YBhIATQoONgZZBV4JVgNDBTYSFF1FRgNHGVcUUBtHDFUHV15fChMAXg8PTH1ABywDXHBIFEkGWAJGBjV9Th5UdSgHXXpMcFkEWHZFfU9yKXceXABLHVcEVB9TElUdHQtFVRIEQAhWUFQeQQRWFWwJWAZTGVc=","Dkim-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr;\n s=sig1; t=1777877970; x=1780469970;\n bh=SZZ4bD46fodlVuPnhZ5AQeC05oNsIViTKO4hoZMC2ug=;\n h=Content-Type:Mime-Version:Subject:From:Date:Message-Id:To:x-icloud-hme;\n b=dNbwqt5yQUmR0I4DBiGNPL9EK4uhtaFRXcpH3xxUk6iQYWn34itE7U3z6p1mHbekbeJwGEW4M6S5bwQQ3IpJOUVzIkrJz/8vxuycqYGeK+/cI/9agvqM4sibfIBEIuX56ZAVxvY5pAQ0JFTe223Aq09mwm829hN4nV3FgIcd15AzZuoiEyvvgNWrlNjcycW0p84xAxEkcTGh0v0sscPQQvXoXbGBe9L2fVtOjeC3JxosGe8ClrkkHGONA2fBenSu8lZxRoongBP/BoPlZXZhfcrMnvlG3S9D/I6wIqnovKxSArUOlWHK0BPZpw0owMdppwx+qjjHqnRhGtpl7CmowA==","mail-alias-created-date":"1752046281608","Content-Type":"text/plain;\n\tcharset=utf-8","Mime-Version":"1.0 (Mac OS X Mail 16.0 \\(3864.500.181\\))","Subject":"Re: [PATCH] hvf: arm: override HV_SYS_REG_MDCR_EL2","From":"Mohamed Mediouni <mohamed@unpredictable.fr>","In-Reply-To":"<e36f1d1b-89db-443b-aa48-6247831a8247@linaro.org>","Date":"Mon, 4 May 2026 08:59:15 +0200","Cc":"qemu-devel@nongnu.org, Alexander Graf <agraf@csgraf.de>,\n qemu-arm@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,\n Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>,\n Manos Pitsidianakis <manos.pitsidianakis@linaro.org>","Content-Transfer-Encoding":"quoted-printable","Message-Id":"<D84A47B8-1555-4ED6-9BC5-C4C433D5D7AD@unpredictable.fr>","References":"<20260501231353.63184-1-mohamed@unpredictable.fr>\n <e36f1d1b-89db-443b-aa48-6247831a8247@linaro.org>","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>","X-Mailer":"Apple Mail (2.3864.500.181)","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNTA0MDA3NCBTYWx0ZWRfX50j64LuHqecN\n YIcHpO62soAvTBq8MJHwgegjcVYubLFuCqJ4ZFTjNh8NwD4lXF/cijuKtzzXs3mpPBqMu6kXbTV\n +EF2CdZ2NRr3HcMgylD0/u8QU4b+BECIsi6y54Zv/DFLjeKVTZQ/A4WzJaJyUjsQbKU1WtxkU3Q\n LAHjxPNYwRT9CpYAsitmqbdjUvUc2DTsi5wTjgnqIQ8BGNV84+3XYpXgpAuiaFtrJYzwZ5D0o67\n rYoRHym1B8cjWNfuFA14nNuuVV/fAy1OAUUxC+a47urud0Nm82rXwrNC9fiAYd1nsFV4wjfGxt7\n bMD268nM8RTJF//wd7en+oaih4Kqodn3tFwKwgOI7gX/mfBUiPJenlKI9CHE8k=","X-Proofpoint-ORIG-GUID":"977kQRD9JuIrGFmTpOjcIDt4MIWGO4Ch","X-Authority-Info-Out":"v=2.4 cv=GbcaXAXL c=1 sm=1 tr=0 ts=69f843d1\n cx=c_apl:c_pps:t_out a=YrL12D//S6tul8v/L+6tKg==:117\n a=YrL12D//S6tul8v/L+6tKg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=t-IPkPogAAAA:8 a=KKAkSRfTAAAA:8\n a=uypWpLIWIABjCLFm2_QA:9 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22","X-Proofpoint-GUID":"977kQRD9JuIrGFmTpOjcIDt4MIWGO4Ch","Received-SPF":"pass client-ip=57.103.79.75;\n envelope-from=mohamed@unpredictable.fr; helo=outbound.st.icloud.com","X-Spam_score_int":"-27","X-Spam_score":"-2.8","X-Spam_bar":"--","X-Spam_report":"(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3685537,"web_url":"http://patchwork.ozlabs.org/comment/3685537/","msgid":"<77227abc-9ea3-41a3-9407-5a00555a4718@linaro.org>","list_archive_url":null,"date":"2026-05-04T07:38:02","subject":"Re: [PATCH] hvf: arm: override HV_SYS_REG_MDCR_EL2","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 4/5/26 08:59, Mohamed Mediouni wrote:\n> \n> \n>> On 4. May 2026, at 08:49, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:\n>>\n>> On 2/5/26 01:13, Mohamed Mediouni wrote:\n>>> In older SDKs, MDCR_EL2 was defined incorrectly.\n>>> As such, override it with a #define if compiling with an older macOS\n>>> SDK.\n>>> This is a workaround because the macOS CI setup we currently rely on\n>>> has not been kept up to date, to be able to land nested virtualization\n>>> support.\n>>> Once CI is updated, the SME stubs can be removed and this\n>>> commit can be reverted.\n>>> Signed-off-by: Mohamed Mediouni <mohamed@unpredictable.fr>\n>>> ---\n>>>   target/arm/hvf/hvf.c | 9 +++++++++\n>>>   1 file changed, 9 insertions(+)\n>>> diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c\n>>> index 4f0f7ffba1..79209bc8e9 100644\n>>> --- a/target/arm/hvf/hvf.c\n>>> +++ b/target/arm/hvf/hvf.c\n>>> @@ -468,6 +468,15 @@ static const struct hvf_reg_match hvf_sme2_preg_match[] = {\n>>>   #define HVF_TO_KVMID(HVF)  \\\n>>>       (CP_REG_ARM64 | CP_REG_SIZE_U64 | CP_REG_ARM64_SYSREG | (HVF))\n>>>   +/*\n>>> + * In older SDKs, MDCR_EL2 was defined incorrectly.\n>>> + * As such, override it with a #define if compiling with an older macOS SDK.\n>>> + * https://lore.kernel.org/qemu-devel/BCCED674-EAEF-4755-9BE1-116FB36FB5C9@apple.com/\n>>> + */\n>>> +#if !defined(MAC_OS_VERSION_26_0)\n>>\n>> Not sure about this check, i.e. wouldn't it clash with 26.1 release?\n>> I'd expect a check such:\n>>\n>>    #if MAC_OS_X_VERSION_MAX_ALLOWED < 260000\n> \n> Hi,\n> \n> MAC_OS_VERSION_26_0 will be defined in all future SDKs.\n> \n> See AvailabilityVersions.h in the macOS SDK, has all of them since 10.0\n\nRight.\n\nReviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n\n>>\n>>> +#define HV_SYS_REG_MDCR_EL2 0xe089\n>>> +#endif\n>>> +\n>>>   /*\n>>>    * Verify this at compile-time.\n>>>    *\n>>\n>>\n>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=XO3PIn4W;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8D661NJvz1y04\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 04 May 2026 17:38:38 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wJnsX-0005PV-7j; Mon, 04 May 2026 03:38:09 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wJnsV-0005MW-If\n for qemu-devel@nongnu.org; Mon, 04 May 2026 03:38:07 -0400","from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wJnsT-0007U0-SY\n for qemu-devel@nongnu.org; Mon, 04 May 2026 03:38:07 -0400","by mail-wm1-x32c.google.com with SMTP id\n 5b1f17b1804b1-48334ee0aeaso26108825e9.1\n for <qemu-devel@nongnu.org>; Mon, 04 May 2026 00:38:05 -0700 (PDT)","from [192.168.69.210] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a8feec1easm74216055e9.24.2026.05.04.00.38.02\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Mon, 04 May 2026 00:38:03 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777880284; x=1778485084; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=xa+CGLnrL+V4mfXhcp5ZkTFXOdRkvFFxI9x4qHtyRqU=;\n b=XO3PIn4WKHhLQ1nDVgHIhGDkAcTxxVJl5U5YIHzj/P/9MrjiHDa1f0ef5fd9x5Ggkg\n jA/xgqg2Ot0v1u+OoO5s7+5U9Hsz5+iBiU/ugfXL4ahBnezq3e1mi/LWxuYRGovZ/F4j\n pnkfC7+gxBD04lTIVGcj7eu9/u6mZdPqyoIe+MsoPIAsFl7gZLxRvdXT/0bqiCLpc0tz\n uEkqIQwMAq7dMSFQHGTHpmxTiV+l+qcx5iA6RjXAXUT3Nh+aFOQNkYo8J9DiGoJ1cC7f\n mPKOFSBG4hFAS9SVyccndLL5knaS5GlhMH4s49U/57wQZjzWlXYWsIQkq5pe1B/ZjY3T\n 2PUg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777880284; x=1778485084;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=xa+CGLnrL+V4mfXhcp5ZkTFXOdRkvFFxI9x4qHtyRqU=;\n b=Py+nVoDopcFgVguKuxA+UmgfpGerNQLIqDVeGlVs99qewJ6tO1PoqA5U24f7sybkTd\n UyEDWAb3xW/ztUe+PaTsZGWqbyri43SWaWf7h0b3fXY+ggDGR1R0cUG5lD0cnY/Q/Nhf\n R8p+NFLfQ6rLmyQBgdARAmx88RGl+DesqKey38SNrV0OoMlFNfqRBg0lmZnTGl+YpyTR\n /irkgM3uEv/PERQga6jM3E+ukh45/By3LWxOlaYRCOfTr/2vw2IIkUVmDjmRO3Dg2mtl\n vE+ANcqyQZE7XCJ0W7J1NfPg1KU60OqxsJdITJx9J8ICDaSKJNlCKNkj1VXJwoXgqD9B\n Dy9w==","X-Gm-Message-State":"AOJu0YzQma/GfK0T00z1F21sCyaSQt/vKBdLwkEz7LS7K5qNbPNFfXi3\n G26JgxXNLIoHsVQDBinRoU9oIk34x93j/D3157Tm1NQnXVfz0rTPByFjYWETyf/nDjQ=","X-Gm-Gg":"AeBDieuOIPE993oynBZd6lD5lVTJ7WSj1JijBQV2mky2PVE0WYYqKC0VqMwgkX26ntC\n 4FL22ZCUXSJt53vtoFtj/uwjNoaPfwJo+DalUKKW23+GLEkBvLxLKRFVOtREvNs17iBQT660qDX\n lGYNf+PmQlsGbOo3ZU1yotUfUdH+c93kav4c1TEFBG1zUw170F25fvHhL54rAL3HQ/6ovxlZULZ\n HEB3E+8H/AJI+6pnNOBBhObvfgU+8oez4blSDZO/o3wpkHNCQtaQKfZbd92a6d20g1W3LEbkwQ9\n HhOFgebW3x7nx5Iq8thH4AH+pCTntV5q0W/zdqBybmevUayd4H9Gz1IV9UrTj3uWAdyurgS/t0P\n 7Mi0UHgwRvFV2ZWpYwPWN1mTjf92865HyJafnclgwmRpthaiIIvzH76+RMVwcQ55QbTzVlCoij1\n J9lBQfMlcnFYTjNI2QZkwCGmhr91UxlBj3f8ERIFBSJgLkFz7g6Hnb3R/gI1z9++VNAf87f+UNX\n pTx/V8if4IvCY4=","X-Received":"by 2002:a05:600c:540e:b0:48a:5574:3a5d with SMTP id\n 5b1f17b1804b1-48a98874ab4mr125264155e9.7.1777880283870;\n Mon, 04 May 2026 00:38:03 -0700 (PDT)","Message-ID":"<77227abc-9ea3-41a3-9407-5a00555a4718@linaro.org>","Date":"Mon, 4 May 2026 09:38:02 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] hvf: arm: override HV_SYS_REG_MDCR_EL2","Content-Language":"en-US","To":"Mohamed Mediouni <mohamed@unpredictable.fr>","Cc":"qemu-devel@nongnu.org, Alexander Graf <agraf@csgraf.de>,\n qemu-arm@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,\n Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>,\n Manos Pitsidianakis <manos.pitsidianakis@linaro.org>","References":"<20260501231353.63184-1-mohamed@unpredictable.fr>\n <e36f1d1b-89db-443b-aa48-6247831a8247@linaro.org>\n <D84A47B8-1555-4ED6-9BC5-C4C433D5D7AD@unpredictable.fr>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>","In-Reply-To":"<D84A47B8-1555-4ED6-9BC5-C4C433D5D7AD@unpredictable.fr>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32c;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32c.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]