[{"id":3685238,"web_url":"http://patchwork.ozlabs.org/comment/3685238/","msgid":"","list_archive_url":null,"date":"2026-05-01T22:46:23","subject":"Re: [PATCH 1/4] i386: testsuite: disable stack protector for 5 tests","submitter":{"id":4387,"url":"http://patchwork.ozlabs.org/api/people/4387/","name":"H.J. Lu","email":"hjl.tools@gmail.com"},"content":"On Sat, May 2, 2026 at 5:32 AM Xi Ruoyao wrote:\n>\n> These tests have check_function_bodies against functions allocating\n> arrays on stack, so they fail with --enable-default-ssp. Disable stack\n> protector explicitly to fix them.\n>\n> gcc/testsuite/\n>\n> * g++.target/i386/memset-pr108585-1a.C (dg-options): Add\n> -fno-stack-protector.\n> * g++.target/i386/memset-pr108585-1b.C (dg-options): Likewise.\n> * gcc.target/i386/auto-init-padding-9.c (dg-options): Likewise.\n> * gcc.target/i386/memset-pr70308-1a.c (dg-options): Likewise.\n> * gcc.target/i386/memset-pr70308-1b.c (dg-options): Likewise.\n\nOK.\n\nThanks.\n\n> ---\n> gcc/testsuite/g++.target/i386/memset-pr108585-1a.C | 2 +-\n> gcc/testsuite/g++.target/i386/memset-pr108585-1b.C | 2 +-\n> gcc/testsuite/gcc.target/i386/auto-init-padding-9.c | 2 +-\n> gcc/testsuite/gcc.target/i386/memset-pr70308-1a.c | 2 +-\n> gcc/testsuite/gcc.target/i386/memset-pr70308-1b.c | 2 +-\n> 5 files changed, 5 insertions(+), 5 deletions(-)\n>\n> diff --git a/gcc/testsuite/g++.target/i386/memset-pr108585-1a.C b/gcc/testsuite/g++.target/i386/memset-pr108585-1a.C\n> index 80603241722..9f6dbff9d2b 100644\n> --- a/gcc/testsuite/g++.target/i386/memset-pr108585-1a.C\n> +++ b/gcc/testsuite/g++.target/i386/memset-pr108585-1a.C\n> @@ -1,5 +1,5 @@\n> /* { dg-do compile } */\n> -/* { dg-options \"-O3 -march=x86-64 -std=c++20 -mno-stackrealign -fomit-frame-pointer -DUSE_CHAR\" } */\n> +/* { dg-options \"-O3 -march=x86-64 -std=c++20 -mno-stackrealign -fomit-frame-pointer -DUSE_CHAR -fno-stack-protector\" } */\n> /* { dg-add-options check_function_bodies } */\n> /* Keep labels and directives ('.cfi_startproc', '.cfi_endproc'). */\n> /* { dg-final { check-function-bodies \"**\" \"\" \"\" { target lp64 } {^\\t?\\.} } } */\n> diff --git a/gcc/testsuite/g++.target/i386/memset-pr108585-1b.C b/gcc/testsuite/g++.target/i386/memset-pr108585-1b.C\n> index 0e79265e59b..a94b29df868 100644\n> --- a/gcc/testsuite/g++.target/i386/memset-pr108585-1b.C\n> +++ b/gcc/testsuite/g++.target/i386/memset-pr108585-1b.C\n> @@ -1,5 +1,5 @@\n> /* { dg-do compile } */\n> -/* { dg-options \"-O3 -march=x86-64 -std=c++20 -mno-stackrealign -fomit-frame-pointer\" } */\n> +/* { dg-options \"-O3 -march=x86-64 -std=c++20 -mno-stackrealign -fomit-frame-pointer -fno-stack-protector\" } */\n> /* { dg-add-options check_function_bodies } */\n> /* Keep labels and directives ('.cfi_startproc', '.cfi_endproc'). */\n> /* { dg-final { check-function-bodies \"**\" \"\" \"\" { target lp64 } {^\\t?\\.} } } */\n> diff --git a/gcc/testsuite/gcc.target/i386/auto-init-padding-9.c b/gcc/testsuite/gcc.target/i386/auto-init-padding-9.c\n> index 4f26aa47802..8cbf67a902d 100644\n> --- a/gcc/testsuite/gcc.target/i386/auto-init-padding-9.c\n> +++ b/gcc/testsuite/gcc.target/i386/auto-init-padding-9.c\n> @@ -1,7 +1,7 @@\n> /* Verify zero initialization for array type with structure element with\n> padding. */\n> /* { dg-do compile } */\n> -/* { dg-options \"-ftrivial-auto-var-init=zero -march=x86-64\" } */\n> +/* { dg-options \"-ftrivial-auto-var-init=zero -march=x86-64 -fno-stack-protector\" } */\n> /* Keep labels and directives ('.cfi_startproc', '.cfi_endproc'). */\n> /* { dg-final { check-function-bodies \"**\" \"\" \"\" { target lp64 } {^\\t?\\.} } } */\n>\n> diff --git a/gcc/testsuite/gcc.target/i386/memset-pr70308-1a.c b/gcc/testsuite/gcc.target/i386/memset-pr70308-1a.c\n> index 4cba4745700..06a2665f4d4 100644\n> --- a/gcc/testsuite/gcc.target/i386/memset-pr70308-1a.c\n> +++ b/gcc/testsuite/gcc.target/i386/memset-pr70308-1a.c\n> @@ -1,5 +1,5 @@\n> /* { dg-do compile } */\n> -/* { dg-options \"-O2 -march=x86-64\" } */\n> +/* { dg-options \"-O2 -march=x86-64 -fno-stack-protector\" } */\n> /* { dg-add-options check_function_bodies } */\n> /* Keep labels and directives ('.cfi_startproc', '.cfi_endproc'). */\n> /* { dg-final { check-function-bodies \"**\" \"\" \"\" { target lp64 } {^\\t?\\.} } } */\n> diff --git a/gcc/testsuite/gcc.target/i386/memset-pr70308-1b.c b/gcc/testsuite/gcc.target/i386/memset-pr70308-1b.c\n> index 425a1232f27..bd53f246069 100644\n> --- a/gcc/testsuite/gcc.target/i386/memset-pr70308-1b.c\n> +++ b/gcc/testsuite/gcc.target/i386/memset-pr70308-1b.c\n> @@ -1,5 +1,5 @@\n> /* { dg-do compile } */\n> -/* { dg-options \"-O2 -march=x86-64 -fomit-frame-pointer -DUSE_SCANF\" } */\n> +/* { dg-options \"-O2 -march=x86-64 -fomit-frame-pointer -DUSE_SCANF -fno-stack-protector\" } */\n> /* { dg-add-options check_function_bodies } */\n> /* Keep labels and directives ('.cfi_startproc', '.cfi_endproc'). */\n> /* { dg-final { check-function-bodies \"**\" \"\" \"\" { target lp64 } {^\\t?\\.} } } */\n> --\n> 2.54.0\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=DBDLXTdM;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=DBDLXTdM","sourceware.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","sourceware.org; spf=pass smtp.mailfrom=gmail.com","server2.sourceware.org;\n arc=pass smtp.remote-ip=2607:f8b0:4864:20::102a"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6mQB4JbRz1yHZ\n\tfor ; Sat, 02 May 2026 08:47:30 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id BB83F436A05B\n\tfor ; Fri, 1 May 2026 22:47:28 +0000 (GMT)","from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com\n [IPv6:2607:f8b0:4864:20::102a])\n by sourceware.org (Postfix) with ESMTPS id F325B44115D4\n for ; Fri, 1 May 2026 22:47:00 +0000 (GMT)","by mail-pj1-x102a.google.com with SMTP id\n 98e67ed59e1d1-364eef1891dso668252a91.1\n for ; Fri, 01 May 2026 15:47:00 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org BB83F436A05B","OpenDKIM Filter v2.11.0 sourceware.org F325B44115D4"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org F325B44115D4","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org F325B44115D4","ARC-Seal":["i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1777675621; cv=pass;\n b=pqZW27bTyoyPtcAtKivfjTTTi4Lij121z+JHHxqVFO0tAb1PyQ3lip2o1Q+UNHPEEm52TlSNjswhEtVIoTLnysNK7I+O0CEdVm2EL1NvVgmm8hEABr01sZWGHJlLRRM6VtIt+Zk3aFem6GFRtJZRT/pW60COnFIh19MYgz7C1DU=","i=1; a=rsa-sha256; t=1777675620; cv=none;\n d=google.com; s=arc-20240605;\n b=SK96eUPs0e8++Mzpx0rF6ipcYHJ23BcZsiQnNyWZojrz860MpSGITne9Ccc46a5wo7\n O5/1RvCsAnDigz54+5kXkcPzd3UjCqCqMx146zlehJJWNHnFp5yc3kks0DXHN07pfHFW\n MwsUdIw4wUBroxFnQSCzu8zM/xVB/zS+bYv7sOUq3b+VXROgFlIH7tiWZnpSCW1n9ULb\n qdqNeYj8A8RBBmQSt8w35SZR6k09sjiHed/9byh+uHCElDi16N8zWuvdHW5uC7r1dGoz\n X+ZD3k0J1RS7yGxfIT7oSysgVMBDtR6TaDqtJFZ+Tw96gTv2y4pukb+WzuU8B7/H5gc9\n q/Vg=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=sourceware.org; s=key;\n t=1777675621; c=relaxed/simple;\n bh=zLBAd0fRm3yOsRV5UAzlLBhJXBd99Yx0zc5ltHOTZJA=;\n h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To;\n b=pel2E7hip0BjzImVjYICJ7qBJkU6wjF1aFz7YS3pNXxYVlyNvG56SRTx7Oh4C8a5SRr1TT5e0JzhvuXn+SZ3UpARvR0UgPqR1UyJARaKXXBJzQrJOpG5XuB73MS2fOTLIsQhKMI83RIvdlY3f405TD+970BQ6c0LEjR3wv8lXng=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=cKgvlSLfgDDOdICRU7EqoE+Eooi5Owookn9iy18h7h4=;\n fh=fLOj8RPJ9nROtesax1vZzx0gjWOqD4xidnpd5d2OsBM=;\n b=ZnSMeV+NNhbTIafoUwWfY3Y9LUPcAdceSPCwp+tBk93xZPS7JlMiD7D5josKAxbSHm\n DVe76MoUc/bgZ1MPon3ufHrb2T3eYRH7JQNEKksV+QSI65ld/wmfjJVOPjT/Z+DoyLiu\n EG6TuPrqC4kRCVb31Mc1TOQhAMfTAN2Ou00bqWswTIgj4niDxP/KEYfLufSX6bJis6/P\n fFq3ZyuQ5CEgX1NRgmL0eg21LHATgT+71JVY119l+2I9JnflxzYMiJdW/wtIO+Jji/l5\n M8SdN99HYGd7Abu45Df3PWOIyV6avtbfKCwD2EWVwSyiG1DVD6fNv+9qoABecWSnIei+\n KKwA==; darn=gcc.gnu.org"],"ARC-Authentication-Results":["i=2; server2.sourceware.org","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777675620; x=1778280420; darn=gcc.gnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=cKgvlSLfgDDOdICRU7EqoE+Eooi5Owookn9iy18h7h4=;\n b=DBDLXTdMxOprTqG1bjVOLbFbBVWEIB31OqGM2quF4CuoILAAwyon7UzpmuFnEzlb89\n GlY+O+TI1zupO8beIQnRIkMCPnCJUxWHA5Is2jBO3/SwxFsuch+CRfGAdpJtixRI84bB\n FucgokasSli8UqwxhhOUMJLj/6YGKklLMo6EuclXUTUZLgKllv42PqWniM04rKXj2jKr\n pw/5yrYBb+tE9Nd//5sBr6B3UdHpGONR7PmiMwgN9RVOIzHBqScCF9A1oVGe9dsZ7YIV\n tTPQtSyw4evx2A+nChYu6A1Yex6t8zsRvb5YNdEuQYreRFhmw6JQ78leTb10miW5yddK\n A+2A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777675620; x=1778280420;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=cKgvlSLfgDDOdICRU7EqoE+Eooi5Owookn9iy18h7h4=;\n b=YSc0NZqRLfPdzB8Ozfw3p8nL91UmBffPsibNUwxXfdAz85lg7+0hP6JWskmrkUya/e\n Q3GM8g6NH9I0N+jLOmV+sAEfwtPJUYmZA8EE0S9jv9I1mNGWh8fVK3kCcl7RS6FSwVJb\n NZh8M6RcElabyXYJHf49IAMiO2VWZdlTBtdcTNwkATgs2g0EDkK5rR+ZWR/huM7+ttVG\n 8p9vnED/+SxFq18Cy+8xWm7zGyFI7CNq2GBQ5uI9mMiRE/HKLLsnjgCv2JzZ0C1V9mlE\n GN/US5ExfWsgqUv2kJJxAJPZpCcO4iTx/MrD46iYhWxbFCuoIzsdJAjDdpBVDuwzOilh\n XaBQ==","X-Gm-Message-State":"AOJu0YyJmebl5ShFCQx+Qi7jLaq39mHkBB/eEkXWvOhFf0YkYRQGK4wc\n D1yde0e2N/Cnx3CI1SKiYZOgl6w7MrdqUqjLtdmtnrGa/949z0nIqhk7W55W6sm0SPiQB8XtvDi\n 3DIT0UZt2CaORvDssEXknAS5qi5VQ9xk=","X-Gm-Gg":"AeBDievaoCyCZkibeAESaOb2YTRPyS6iCqkLetLsTCyABiYFsRfX2qgdotsgBVrp3P9\n dK7hRiLK9ZyYqI79bhDYDCq1w3aEGI+W+w4w4B7s0C147QrlVRMzpBGvLT0quojKqTuahOyAyju\n 8vL2jCtMmvg4OM++FncuH0jLJaH6gMfmUsDtRofPRklG8vqP4OSJNd9qQCJG/oEb8jvYg2nDrEr\n GHT8R/zIcEwvfE6kxPZTjHdvOTcoWG/f3VjHxkVc6TzZUxGLqPlOeYRj9FmgDtcc+2bcq/lhHLz\n 5fUjXW6scG8pa4eP","X-Received":"by 2002:a05:6a20:7290:b0:3a2:f7bd:a9a5 with SMTP id\n adf61e73a8af0-3a7f1c51726mr899584637.38.1777675619901; Fri, 01 May 2026\n 15:46:59 -0700 (PDT)","MIME-Version":"1.0","References":"<20260501213120.324542-1-xry111@xry111.site>\n <20260501213120.324542-2-xry111@xry111.site>","In-Reply-To":"<20260501213120.324542-2-xry111@xry111.site>","From":"\"H.J. Lu\" ","Date":"Sat, 2 May 2026 06:46:23 +0800","X-Gm-Features":"AVHnY4J3DnRURQJUTs2ye0aKBOy7N1SIHC8Zl0WiIPRcBwgD9XepZ7YfDlfM5sc","Message-ID":"\n ","Subject":"Re: [PATCH 1/4] i386: testsuite: disable stack protector for 5 tests","To":"Xi Ruoyao ","Cc":"gcc-patches@gcc.gnu.org, Richard Sandiford ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}}]