[{"id":3685233,"web_url":"http://patchwork.ozlabs.org/comment/3685233/","msgid":"<20260501220359.GA522578@bhelgaas>","list_archive_url":null,"date":"2026-05-01T22:03:59","subject":"Re: [PATCH] PCI: brcmstb: Assign pcie->gen from pcie_get_link_speed()","submitter":{"id":67298,"url":"http://patchwork.ozlabs.org/api/people/67298/","name":"Bjorn Helgaas","email":"helgaas@kernel.org"},"content":"On Fri, May 01, 2026 at 01:24:38PM -0700, Florian Fainelli wrote:\n> After commit 03f920936977 (\"PCI: controller: Validate max-link-speed\"),\n> pcie->gen stopped being assigned and as a result the established PCIe\n> link would stop supporting Gen3 speeds on 2712 since pcie->gen is used\n> to populate LnkCntl2 and LnkCap in brcm_pcie_set_gen().\n> \n> Link: https://github.com/raspberrypi/linux/issues/7343\n> Reported-by: Dom Cobley \n> Reported-by: Phil Elwell \n> Fixes: 03f920936977 (\"PCI: controller: Validate max-link-speed\")\n> Signed-off-by: Florian Fainelli \n\nApplied to pci/for-linus for v7.1, thanks, and sorry for the breakage.\n\n> ---\n> drivers/pci/controller/pcie-brcmstb.c | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c\n> index 714bcab97b60..6138fc4bc064 100644\n> --- a/drivers/pci/controller/pcie-brcmstb.c\n> +++ b/drivers/pci/controller/pcie-brcmstb.c\n> @@ -2072,8 +2072,7 @@ static int brcm_pcie_probe(struct platform_device *pdev)\n> \t\treturn PTR_ERR(pcie->clk);\n> \n> \tret = of_pci_get_max_link_speed(np);\n> -\tif (pcie_get_link_speed(ret) == PCI_SPEED_UNKNOWN)\n> -\t\tpcie->gen = 0;\n> +\tpcie->gen = pcie_get_link_speed(ret);\n> \n> \tpcie->ssc = of_property_read_bool(np, \"brcm,enable-ssc\");\n> \n> -- \n> 2.43.0\n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=NCGJRs/c;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.232.135.74; helo=sto.lore.kernel.org;\n envelope-from=linux-pci+bounces-53609-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"NCGJRs/c\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org [172.232.135.74])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6lS84tsxz1yHZ\n\tfor ; Sat, 02 May 2026 08:04:08 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 27D3C30059AB\n\tfor ; Fri, 1 May 2026 22:04:05 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id A8CAC2FB965;\n\tFri, 1 May 2026 22:04:01 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 865102D9ECD;\n\tFri, 1 May 2026 22:04:01 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id D3BC8C2BCB4;\n\tFri, 1 May 2026 22:04:00 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777673041; cv=none;\n b=GlhDUIm2c8DNK06ap1mmxYqnV7KEL8PaD6uF78wGXWhGTvqStwQ2mg141+pVqS/1Qavc0dK28ewobjNwNYFs0qB0F9WA2cwAkReZP+xUPCsYM53++nl1boQpAzFK/2t3A5zmh2TUpjIRUChJLEkSlqqCwUPeMTHWlkIR26iQ8AI=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777673041; c=relaxed/simple;\n\tbh=HKVDY3YeNH8AZP6qEwAmEqYoxJ5WPVlsvJuzoKf9Vk0=;\n\th=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type:\n\t Content-Disposition:In-Reply-To;\n b=EJ8Ymcna28LyBU68AT3SAQhsURetp2P62j5o3AYWVuvF0Z6KrIMBH/E18AT9I4QtYFseccnH7qDSozcT2ZmFySuBONGPrEqbDUO7t65JN/JsSebZADCZk+nTMEs4+oOTK07OR+quaRMEpXQLCa5Rk+IkosUZ1uNfx9MGi5E1YgY=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=NCGJRs/c; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1777673041;\n\tbh=HKVDY3YeNH8AZP6qEwAmEqYoxJ5WPVlsvJuzoKf9Vk0=;\n\th=Date:From:To:Cc:Subject:In-Reply-To:From;\n\tb=NCGJRs/cGzIKN9rsmSBDs5PTJvhYXE+WvOWqUlR0bsfZSjtxPYIfYfT62C8ZHNWYq\n\t ClSRidEbvJjyXtUehEm70BKzW/Bt1I4X3L877ewRPNrT0I/nI5NJ+/lQ/U8AEM+t2L\n\t Xsf7mHGvQIOFBfJCuN6JrmWi70PUs9eL1O3y58ZxBpT84+BckUcjQcSYin9fkseApi\n\t qObiWeXe9yLhxklJROn+Swl7u30/xNtszmgNiWn/gjYJYVvlVj3B4JXXzuwvZ5vSpi\n\t DHND5usVcsaa67o0/RYNdejkiYwC9rIfXlpOyOuhqrts0iRerRAslhxpH5S4ZwWA40\n\t CsIM1jxQ4r/9A==","Date":"Fri, 1 May 2026 17:03:59 -0500","From":"Bjorn Helgaas ","To":"Florian Fainelli ","Cc":"linux-pci@vger.kernel.org, Dom Cobley ,\n Phil Elwell , Jim Quinlan ,\n Broadcom internal kernel review list ,\n Lorenzo Pieralisi , Krzysztof =?utf-8?q?Wilczy=C5=84?=\n\t=?utf-8?q?ski?= ,\n Manivannan Sadhasivam , Rob Herring ,\n Bjorn Helgaas , Hans Zhang <18255117159@163.com>,\n \"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE\"\n ,\n \"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE\"\n ,\n open list ","Subject":"Re: [PATCH] PCI: brcmstb: Assign pcie->gen from pcie_get_link_speed()","Message-ID":"<20260501220359.GA522578@bhelgaas>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260501202438.376033-1-florian.fainelli@broadcom.com>"}},{"id":3685234,"web_url":"http://patchwork.ozlabs.org/comment/3685234/","msgid":"","list_archive_url":null,"date":"2026-05-01T22:05:02","subject":"Re: [PATCH] PCI: brcmstb: Assign pcie->gen from pcie_get_link_speed()","submitter":{"id":68940,"url":"http://patchwork.ozlabs.org/api/people/68940/","name":"Florian Fainelli","email":"florian.fainelli@broadcom.com"},"content":"On 5/1/26 15:03, Bjorn Helgaas wrote:\n> On Fri, May 01, 2026 at 01:24:38PM -0700, Florian Fainelli wrote:\n>> After commit 03f920936977 (\"PCI: controller: Validate max-link-speed\"),\n>> pcie->gen stopped being assigned and as a result the established PCIe\n>> link would stop supporting Gen3 speeds on 2712 since pcie->gen is used\n>> to populate LnkCntl2 and LnkCap in brcm_pcie_set_gen().\n>>\n>> Link: https://github.com/raspberrypi/linux/issues/7343\n>> Reported-by: Dom Cobley \n>> Reported-by: Phil Elwell \n>> Fixes: 03f920936977 (\"PCI: controller: Validate max-link-speed\")\n>> Signed-off-by: Florian Fainelli \n> \n> Applied to pci/for-linus for v7.1, thanks, and sorry for the breakage.\n\nI reviewed the original change and completely missed that, so no \nworries, the fault is mine to have missed it in the first place. Thanks \nfor fast tracking this!","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=broadcom.com header.i=@broadcom.com header.a=rsa-sha256\n header.s=google header.b=WFay63yA;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-53610-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com\n header.b=\"WFay63yA\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=74.125.82.97","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=broadcom.com","smtp.subspace.kernel.org;\n spf=fail smtp.mailfrom=broadcom.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6lTV1FLRz1xvV\n\tfor ; Sat, 02 May 2026 08:05:18 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 807C930107CB\n\tfor ; Fri, 1 May 2026 22:05:11 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id A0583319847;\n\tFri, 1 May 2026 22:05:10 +0000 (UTC)","from mail-dl1-f97.google.com (mail-dl1-f97.google.com\n [74.125.82.97])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 357AE287503\n\tfor ; Fri, 1 May 2026 22:05:09 +0000 (UTC)","by mail-dl1-f97.google.com with SMTP id\n a92af1059eb24-12dcdcd54adso3602601c88.1\n for ; Fri, 01 May 2026 15:05:09 -0700 (PDT)","from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com\n (address-144-49-247-121.dlp.protect.broadcom.com. [144.49.247.121])\n by smtp-relay.gmail.com with ESMTPS id\n a92af1059eb24-12df843d895sm260939c88.8.2026.05.01.15.05.07\n for \n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Fri, 01 May 2026 15:05:07 -0700 (PDT)","by mail-qt1-f197.google.com with SMTP id\n d75a77b69052e-50d5d1c2289so56423711cf.2\n for ; Fri, 01 May 2026 15:05:06 -0700 (PDT)","from [10.67.48.245] ([192.19.223.252])\n by smtp.gmail.com with ESMTPSA id\n d75a77b69052e-51040b5e8b4sm29282711cf.23.2026.05.01.15.05.03\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 01 May 2026 15:05:04 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777673110; cv=none;\n b=mdcVY1iiiZ6hDVb6eKW32LQnLduINW2rkveQ63NxcGrFawpUh8gfpGnHMoaekWZShAG+XiQJZuR/lvO0CoalMXS37zGl+fAE7TKgJRKgp14RwJ9UlQF3bUp1N3EuQgQF5TB1rUbhDvhzN2mmvmoLWgarFyIon+SkhaV9oxlwDnI=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777673110; c=relaxed/simple;\n\tbh=0qSOFdNT6dR0KSqAHacMYC+aznjSOX25Xn2HUv4F0p0=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=g814ZStPVV7NIKBymR8I4hgBF0gk3a1QcuV4wXyd15xjTaSaEBGAU5RCaEzqe08QElViMnw/RKJrBtmB0mv+F443eKaFxyUuN6ZrUWsmmNppABJ8jK5r2pjQB6nlndrbf54kPtMi28u0n6PF8OyzDI+hK4gBO0HFYMV1lRAZSFI=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=broadcom.com;\n spf=fail smtp.mailfrom=broadcom.com;\n dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com\n header.b=WFay63yA; arc=none smtp.client-ip=74.125.82.97","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777673108; x=1778277908;\n h=content-transfer-encoding:in-reply-to:autocrypt:from\n :content-language:references:cc:to:subject:user-agent:mime-version\n :date:message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=0JiJdMx+KJquXdLD9tyzm4VKNrHA4z52kt6wPCreDaY=;\n b=Ry7gQM2z9sngIcDhHcDr3S6oLByT+A32deo9bUWXNRoc32JYe5FSa8X+fTHvJAB8F8\n Jia5/SpP0VDLFdOFQNHF24Ybf1/S45rlFBwIetAOJaMQiMfKenYPvMegRaVKzAwd2PJb\n FgECCTzCbodVJtwPPRnpBUom1vS2tJAR7hYOJnN5t0cCQlzCM+OHG9NEDiuwOKRuUbgp\n oAFZWS6ltz+WgDUBYLF+8RQxPWw0m7ntB5aM6UTxNCYjHCFQPEKqN1dqGMQB0sdHWaZJ\n LjBPFJUtrWi2/UlRMpkFL2cmc+q1Ww4D2kZxK8Pc4Cbfltyq+EzUxJDzUiXTHKFrDUsF\n mXvg==","X-Gm-Message-State":"AOJu0YyMMu6TcoZhTCPO+RCRSfN4NONlZTObSwTpQXNe77pCvjQo+7UU\n\tewhmpHiD6etEvgGMDAUdXZsOcWNWINbo/DMfmvVdDtkIFQvQCPUJE5YHIYyA57eykKb80Nb2QR7\n\txIIksbppsMzWrlSrwp1mMjuvnRbHVVga+TOEAw/1HTxdQQ/F/VWu8RXBV+dFP/UUQrDWsTiSJ5x\n\ttA6Cyxy1KvdbJG8ltoBrFm676QugxtN7QHTBdLXeEchxiHkpbnyGoYfFh5vAEBhY/cjUTxE3zU6\n\tFqYhhtlu04kC+Kr8wkH","X-Gm-Gg":"AeBDieunHwAN9nLiCfvqYy86JGi/A4+3wJRJFsygfxZGOIchfHbmicZPImeJJB0UApI\n\tlyo1Bo9ds/Av+WTnXPPJhDZ9Y0qDo7eWuNwqdWZ7eskiv13mitD+YcpOfGVg2Mz4P+3WLc5MTbA\n\tSqBbeIymRliQFZKuBGmDFohERziM9ojtqHyeYK7cByBs6WkrTVDXWyvLjnRjNjjtW8cFqaCmcie\n\tH+PLHZfP9IE/QbiFh+jKAE7CODQjMbiIkvgLShURh/n1F9oNOvtu6MnfrhRKlnZb+/rB8QUmT9E\n\tp+sknMIoKJiDXJzwl6jWXM/CQLZ70lK8KZ/NI9iECzvv+0gZ7ui+0FUxSQIxaO8Nh2Eymy4+Cy/\n\tdjXltWA88aEAg/7IQfvPBdrf4tqWAMYPHwBRDVwzkIHWxdwfDkf0DiWXy1CdKydW6lwCdLyj1eG\n\tT2fFZmaqiYPkJ8xfAIHZKtZq09e47vM3U0QJ9osN8S7Hb3L4Wub4csbJBUDqJ7QajVRIO1IQpo3\n\t8A=","X-Received":["by 2002:a05:7022:4391:b0:12a:713b:8958 with SMTP id\n a92af1059eb24-12dfd7bbc2dmr474444c88.10.1777673107954;\n Fri, 01 May 2026 15:05:07 -0700 (PDT)","by 2002:ac8:57c9:0:b0:50f:b17d:7e53 with SMTP id\n d75a77b69052e-5104bf6baeamr15609351cf.47.1777673106367;\n Fri, 01 May 2026 15:05:06 -0700 (PDT)","by 2002:ac8:57c9:0:b0:50f:b17d:7e53 with SMTP id\n d75a77b69052e-5104bf6baeamr15608871cf.47.1777673105862;\n Fri, 01 May 2026 15:05:05 -0700 (PDT)"],"X-Relaying-Domain":"broadcom.com","X-CFilter-Loop":"Reflected","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=broadcom.com; s=google; t=1777673106; x=1778277906;\n darn=vger.kernel.org;\n h=content-transfer-encoding:in-reply-to:autocrypt:from\n :content-language:references:cc:to:subject:user-agent:mime-version\n :date:message-id:from:to:cc:subject:date:message-id:reply-to;\n bh=0JiJdMx+KJquXdLD9tyzm4VKNrHA4z52kt6wPCreDaY=;\n b=WFay63yAPRoQkcnSe97zBV6MZynaDpVMMcKII1G3vL+y2qh/pxRHDMiEZrfC7xwYqJ\n x9A/KEwr37otSGJlJjI8KB329N4SvBHwtHS4slbO2XFe3tyYMafQ5ul6boQRcP5Pb8ZU\n 12pC7HQuflku/R0f688EJH2P4jMCjjPkS7C98=","Message-ID":"","Date":"Fri, 1 May 2026 15:05:02 -0700","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] PCI: brcmstb: Assign pcie->gen from pcie_get_link_speed()","To":"Bjorn Helgaas ","Cc":"linux-pci@vger.kernel.org, Dom Cobley ,\n Phil Elwell , Jim Quinlan ,\n Broadcom internal kernel review list ,\n Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?=\n\t=?utf-8?q?ski?= ,\n Manivannan Sadhasivam , Rob Herring ,\n Bjorn Helgaas , Hans Zhang <18255117159@163.com>,\n \"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE\"\n ,\n \"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE\"\n ,\n open list ","References":"<20260501220359.GA522578@bhelgaas>","Content-Language":"en-US, fr-FR","From":"Florian Fainelli ","Autocrypt":"addr=florian.fainelli@broadcom.com; keydata=\n xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT\n M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs\n JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ\n PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ\n KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB\n AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB\n IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr\n ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp\n bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t\n Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx\n tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z\n TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA\n zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61\n WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2\n IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E\n U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k\n 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU\n pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs\n MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh\n IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB\n gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+\n obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P\n N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s\n CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm\n C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5\n wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5\n EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb\n fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc\n MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC\n 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww\n 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us=","In-Reply-To":"<20260501220359.GA522578@bhelgaas>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-DetectorID-Processed":"b00c1d49-9d2e-4205-b15f-d015386d3d5e"}},{"id":3685275,"web_url":"http://patchwork.ozlabs.org/comment/3685275/","msgid":"<20260502114019.GA551304@bhelgaas>","list_archive_url":null,"date":"2026-05-02T11:40:19","subject":"Re: [PATCH] PCI: brcmstb: Assign pcie->gen from pcie_get_link_speed()","submitter":{"id":67298,"url":"http://patchwork.ozlabs.org/api/people/67298/","name":"Bjorn Helgaas","email":"helgaas@kernel.org"},"content":"On Fri, May 01, 2026 at 01:24:38PM -0700, Florian Fainelli wrote:\n> After commit 03f920936977 (\"PCI: controller: Validate max-link-speed\"),\n> pcie->gen stopped being assigned and as a result the established PCIe\n> link would stop supporting Gen3 speeds on 2712 since pcie->gen is used\n> to populate LnkCntl2 and LnkCap in brcm_pcie_set_gen().\n> \n> Link: https://github.com/raspberrypi/linux/issues/7343\n> Reported-by: Dom Cobley \n> Reported-by: Phil Elwell \n> Fixes: 03f920936977 (\"PCI: controller: Validate max-link-speed\")\n> Signed-off-by: Florian Fainelli \n> ---\n> drivers/pci/controller/pcie-brcmstb.c | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c\n> index 714bcab97b60..6138fc4bc064 100644\n> --- a/drivers/pci/controller/pcie-brcmstb.c\n> +++ b/drivers/pci/controller/pcie-brcmstb.c\n> @@ -2072,8 +2072,7 @@ static int brcm_pcie_probe(struct platform_device *pdev)\n> \t\treturn PTR_ERR(pcie->clk);\n> \n> \tret = of_pci_get_max_link_speed(np);\n> -\tif (pcie_get_link_speed(ret) == PCI_SPEED_UNKNOWN)\n> -\t\tpcie->gen = 0;\n> +\tpcie->gen = pcie_get_link_speed(ret);\n\nTake a look at https://sashiko.dev/#/patchset/20260501202438.376033-1-florian.fainelli%40broadcom.com\n\nThe notes at https://github.com/raspberrypi/linux/issues/7343 assumed\nPCI_SPEED_UNKNOWN was 0, but in fact it is 0xff, which means you might\nwant the more defensive patch instead.\n\nI'll be happy to replace what's on pci/for-linus if so.\n\n> \tpcie->ssc = of_property_read_bool(np, \"brcm,enable-ssc\");\n> \n> -- \n> 2.43.0\n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=UvN+ekgw;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-pci+bounces-53624-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"UvN+ekgw\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g75Z60Hsmz1yJ0\n\tfor ; Sat, 02 May 2026 21:40:29 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 442F33004D26\n\tfor ; Sat, 2 May 2026 11:40:23 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 61C3032B9BB;\n\tSat, 2 May 2026 11:40:21 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EBFF3101CD;\n\tSat, 2 May 2026 11:40:20 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 9CE86C19425;\n\tSat, 2 May 2026 11:40:20 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777722021; cv=none;\n b=r5mnYeQ0e0fXF8b9Io8ByaNQjgfkAfanYRdhtXbMKHglPGoU4kDssan5NqZDRUbGquJ7ZBh12s0MDLjCvMqQIYuwbF7UNPzvWYh1d2kCLUJNoW2DY2QHOeP6/Svqws5rRqfDtswpCSs3dJvmUwWQpScHptHoWB8Yc3Xh580lqxY=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777722021; c=relaxed/simple;\n\tbh=Ba1wqX2SN8Flrod7t3UMQ92yqgaLJRZILMs4KGu8JaY=;\n\th=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type:\n\t Content-Disposition:In-Reply-To;\n b=pZS+w4wRilBYexw4eFgOgTWS/fpu0YcPcIFqfdQNR0OIIno/bn489mCtwO1GPYo3hsk841zzYYguZboHKIxizDIMmslpIulavd9HK1IidZsYvYBPdjJH4bmyXDEadzqHsJaOuSvRsB2For3SqEqPlQuk0ijvpuMydfGo3kKHPJg=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=UvN+ekgw; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1777722020;\n\tbh=Ba1wqX2SN8Flrod7t3UMQ92yqgaLJRZILMs4KGu8JaY=;\n\th=Date:From:To:Cc:Subject:In-Reply-To:From;\n\tb=UvN+ekgwd8BBWJbXT5QkMKUdTwzEYPmQV8Tt0MSw65R2LjEfKccGzIwXqIU6oPC8Z\n\t m6W5N1A3NE2WurVH3eQOX3EnBf33MxsYsE/X6erNCChhShy3oX5rAmA9ewQvl5a7TI\n\t DfiaUl87B+rIOvviedQ0uG4n17Lc3/DXrqdD5SZPrBNSwqb4r2qX5W2mhsoZ0a1EEr\n\t 2ABXYDWxmLLZUhuWxo33Bb7bIJGAZnl2Xet65XNqcNUokSWw6ey/f9y2UOj5y/w1OC\n\t Eca1fVzlOAG0AnMMxBs862CJOQ2Gg20OOVnPQXU9U5gO95VSylI25bJzyJ7eAdozs9\n\t BO6KYoiyee5qw==","Date":"Sat, 2 May 2026 06:40:19 -0500","From":"Bjorn Helgaas ","To":"Florian Fainelli ","Cc":"linux-pci@vger.kernel.org, Dom Cobley ,\n Phil Elwell , Jim Quinlan ,\n Broadcom internal kernel review list ,\n Lorenzo Pieralisi , Krzysztof =?utf-8?q?Wilczy=C5=84?=\n\t=?utf-8?q?ski?= ,\n Manivannan Sadhasivam , Rob Herring ,\n Bjorn Helgaas , Hans Zhang <18255117159@163.com>,\n \"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE\"\n ,\n \"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE\"\n ,\n open list ","Subject":"Re: [PATCH] PCI: brcmstb: Assign pcie->gen from pcie_get_link_speed()","Message-ID":"<20260502114019.GA551304@bhelgaas>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260501202438.376033-1-florian.fainelli@broadcom.com>"}}]